test(a2a): add regression tests to verify zero acp references after module rename #10668
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!10668
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "test/v3.6.0/a2a-rename-regression-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
This PR adds comprehensive regression tests to verify that zero ACP references remain after the module rename from ACP to A2A. These tests ensure the migration is complete and all symbols follow the standardized A2A naming convention, preventing any regressions during the ongoing module rename initiative.
Changes
Test Scenarios Added
Behave Scenarios (Import Verification)
Robot Framework Tests (CLI Verification)
Test Coverage
Testing
The following test suites were added and executed:
Issue Reference
Closes #7578
Automated by CleverAgents Bot
Agent: pr-creator
Implementation Attempt — Tier 1: haiku — Success
Fixed the A2A regression test expectations to match the actual module exports. The original test file was expecting symbols like
A2AFacade,ClientFactory,A2AMessage, andEventEmitter, but the actual a2a module exportsA2aLocalFacade,ServerClient,A2aRequest, andA2aEventQueue.Changes made:
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
This PR cannot be approved because critical CI checks are failing:
Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved and merged. Please fix the failing tests and linting issues.
Note: The PR title indicates this is adding regression tests for zero ACP references after module rename. Ensure these tests are passing and that no new linting violations were introduced.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #10668 adds regression tests (Behave + Robot Framework) to verify zero ACP references after the ACP → A2A module rename. No other open PR combines testing for post-rename verification with identical issue closure (#7578). Related PRs (#10664, #11165) perform the actual rename implementation, not regression testing. The anchor's unique scope (regression test suite + verification focus) distinguishes it from all 397 open PRs.
📋 Estimate: tier 1.
Pure test addition (2 files, +424 LOC) with two active CI failures. Lint gate fails due to ruff format on the new step definitions file (trivial one-command fix). Unit test gate shows 2 Behave scenarios failing with 26 step errors — the "traceback outside scenario" pattern indicates a setup/teardown error in the new Behave environment, requiring debugging of the step definitions and/or environment hooks. Fixing both issues is standard implementer work: apply formatting, then diagnose and correct the Behave context setup problem in the new test code. Multi-file test debugging with framework-specific knowledge needed → tier 1.
15d4757dd7395724e0fb(attempt #3, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
395724e.395724e0fb79513af899(attempt #4, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
79513af.79513af899baf8c3103b(attempt #5, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
baf8c31.(attempt #6, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
750df90.Files touched:
features/steps/a2a_naming_regression_steps.py.750df909201bda260320(attempt #7, tier 2)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
1bda260.1bda2603206e5172338b(attempt #8, tier 2)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
6e51723.(attempt #9, tier 2)
🔧 Implementer attempt —
blocked.Blockers:
e81d1d09fbbut dispatch base was6e5172338b. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #10668 adds regression tests to verify zero ACP references after the ACP→A2A module rename. Topically overlaps with #11165 (which implements the rename), but these are complementary: #11165 executes the rename, #10668 tests that it succeeded. Scanned all 357 open PRs; no other PR tests for the same "zero ACP references" regression condition. Unique testing contribution.
📋 Estimate: tier 1.
Pure test-additive PR: 2 new files (Behave feature file + Robot Framework suite), 452 LOC. Exceeds tier-0 on both the file-count and LOC dimensions, and calibration data shows test-additive work consistently regresses at tier 0. The implementer must write valid Behave step definitions and Robot Framework keywords that actually scan the codebase for ACP references, requiring cross-module awareness of the A2A rename. CI passes, task definition is clear. Standard tier-1 engineering work.
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #10668 adds regression tests for ACP→A2A module rename verification. While PR #11165 implements the actual rename, these are complementary not duplicate: #10668 tests the rename's completeness and prevents future regressions, whereas #11165 executes the rename itself. No other open PR targets the same regression test coverage.
📋 Estimate: tier 1.
Purely additive test code: 2 new files, +452/-0 lines covering Behave feature scenarios and Robot Framework test suites. No production code changes. CI passes clean (12/12). However, test-additive work in this codebase has a 0/4 historical hit rate at tier 0 — Behave .feature syntax and Robot Framework format-sensitive content require project-convention awareness (97% coverage threshold, src/test layout, feature file structure) that consistently demands tier-1 capability. Scope is isolated to test files for the ACP→A2A module rename verification; reasoning complexity is low but format and convention correctness push the work above tier 0.
e81d1d09fbfef91165f4🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #10668 adds regression tests for the ACP → A2A module rename, verifying zero deprecated ACP references via Behave and Robot Framework test suites. Scanned all 236 open PRs for topical overlap: no other PR addresses A2A rename verification or regression tests for this specific refactor. PR #10992 mentions @a2a tags but concerns BDD tagging enforcement, not rename tests. Conclusion: unique scope, no duplicate.
📋 Estimate: tier 1.
Test-only PR (2 files, +452 LOC) adding Behave and Robot Framework regression tests for ACP→A2A module rename. CI fails on a newly added scenario (
a2a_module_imports_audit.feature:126 Verify test coverage for A2A module imports). Fixing requires reading the new feature file, understanding what the failing step asserts vs. actual codebase state post-rename, and correcting the scenario logic. Cross-file context needed (test file + A2A module structure). Calibration data explicitly flags test-additive work as consistently escalating from tier 0; tier 1 is correct.fef91165f40153633b65✅ Approved
Reviewed at commit
0153633.Confidence: high.
Claimed by
merge_drive.py(pid 2202036) until2026-06-17T01:47:33.819565+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
0153633b6518b4d80627Released by
merge_drive.py(pid 2202036). terminal_state=ci-fail-on-rebased-sha, op_label=auto/needs-implementer(attempt #30, tier 1)
🔧 Implementer attempt —
blocked.Blockers:
b3048f128abut dispatch base was18b4d80627. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.(attempt #31, tier 2)
🔧 Implementer attempt —
ci-not-ready.✅ Approved
Reviewed at commit
b3048f1.Confidence: high.
Claimed by
merge_drive.py(pid 2202036) until2026-06-17T03:01:23.158307+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Approved by the controller reviewer stage (workflow 293).