Fixes a resource leak where the LSP server subprocess was not cleaned up if an
exception occurred after the process was spawned but before start() returned
normally. This could happen if any post-Popen initialization step (e.g., logging)
raised an exception.

The fix wraps all post-Popen initialization code in a try/except block that:
1. Terminates the subprocess on exception
2. Waits for graceful shutdown with timeout
3. Resets self._process to None
4. Re-raises the original exception without suppression

This ensures the subprocess is never left running as a zombie, and the transport
state remains consistent (is_alive returns False, stop() is a no-op).

Closes #7044

@@ -0,0 +42,4 @@
+        "A2aError": A2aError,
+        "A2aErrorDetail": A2aErrorDetail,
+        "A2aEvent": A2aEvent,
+        "A2aEventQueue": A2aEventQueue,

@@ -0,0 +203,4 @@
+    assert hasattr(context.request, "params")
+
+
+@then("it should have an id field")

@@ -515,0 +565,4 @@
+
+@then("ltcov the mock process should have been waited on")
+def step_ltcov_process_waited(context: Context) -> None:
+    context.ltcov_mock_process.wait.assert_called()

@@ -515,0 +565,4 @@
+
+@then("ltcov the mock process should have been waited on")
+def step_ltcov_process_waited(context: Context) -> None:
+    context.ltcov_mock_process.wait.assert_called()

@@ -515,0 +565,4 @@
+
+@then("ltcov the mock process should have been waited on")
+def step_ltcov_process_waited(context: Context) -> None:
+    context.ltcov_mock_process.wait.assert_called()

@@ -0,0 +8,4 @@
+        Given a temporary directory for workspace files
+        And no environment variable ``CLEVERAGENTS_LSP_COMMAND`` set
+
+    @tdd_issue @tdd_issue_10597

@@ -0,0 +15,4 @@
+        Then an LspError is raised describing the missing command
+        And no subprocess was leaked (no orphan processes exist)
+
+    @tdd_issue @tdd_issue_10597

@@ -0,0 +8,4 @@
+        Given a temporary directory for workspace files
+        And no environment variable ``CLEVERAGENTS_LSP_COMMAND`` set
+
+    @tdd_issue @tdd_issue_10597

@@ -515,0 +565,4 @@
+
+@then("ltcov the mock process should have been waited on")
+def step_ltcov_process_waited(context: Context) -> None:
+    context.ltcov_mock_process.wait.assert_called()

@@ -0,0 +4,4 @@
+
+import os
+import shutil
+import subprocess as _subproc  # noqa: N812

@@ -0,0 +141,4 @@
+
+
+@then("the subprocess was terminated before re-raising")
+def step_subprocess_terminated(context):  # noqa: ANN201

@@ -32,5 +35,7 @@ Below are some of the specific details of various contributions.
 * HAL 9000 has contributed comprehensive milestone documentation for v3.6.0 (Advanced Concepts & Deferred Features) and v3.7.0 (TUI Implementation) (PR #9903): split into sub-documents covering context strategies, LLM backends, resource types, A2A rename, container tool execution, scope chain resolution, cost/safety budgets, E2E workflow tests, code review examples, plugin architecture, TUI layout, persona system, reference/command input, session management, configuration, and TuiMaterializer integration.
 * HAL 9000 has contributed the LLMTraceRepository data-integrity fix (PR #8185 / issue #7505): replaced the unconditional `session.commit()` in `LLMTraceRepository.save()` with a dual-path implementation that respects the UnitOfWork pattern — flushing only when an external session is provided, and flushing + committing + closing when operating standalone. This eliminates premature transaction commits, loss of rollback capability, and a docstring/implementation mismatch.
 * HAL 9000 has contributed the ACMS Index Data Model and File Traversal Engine (PR #9664 / issue #9579): foundational data structures for indexed context entries with hot/warm/cold/archive storage tier classification, tag system, and a timeout-safe chunked file traversal engine for large projects with 10,000+ files.
+<<<<<<< HEAD

@@ -0,0 +8,4 @@
+        Given a temporary directory for workspace files
+        And no environment variable ``CLEVERAGENTS_LSP_COMMAND`` set
+
+    @tdd_issue @tdd_issue_10597

@@ -515,0 +565,4 @@
+
+@then("ltcov the mock process should have been waited on")
+def step_ltcov_process_waited(context: Context) -> None:
+    context.ltcov_mock_process.wait.assert_called()

@@ -0,0 +4,4 @@
+
+import os
+import shutil
+import subprocess as _subproc  # noqa: N812

@@ -0,0 +141,4 @@
+
+
+@then("the subprocess was terminated before re-raising")
+def step_subprocess_terminated(context):  # noqa: ANN201

@@ -11,1 +11,4 @@
 # Details
+* HAL 9000 has contributed the LSP ``StdioTransport`` subprocess cleanup fix (PR #10597): added OS-error handling in ``start()`` that terminates and clears a half-created subprocess before re-raising, preventing orphan language-server processes on failed initialisation.
+
+* HAL 9000 has contributed spec clarifications for layer boundary DI exception, ULID scope, ACMS pipeline contracts, and TUI component interfaces (PR #10451): documented architectural invariants including the DI container exception, clarified ULID identifier scope distinguishing domain entities from internal implementation details, added per-stage protocol contracts for all 10 ACMS pipeline stages with storage tier definitions, budget enforcement protocol, and context assembly output format, and defined public interfaces with verifiable checks for 8 TUI components.

@@ -131,17 +129,9 @@ def step_ltcov_writable_stdin(context: Context) -> None:
     mock_stdin = MagicMock()
     mock_stdin.write = MagicMock()
     mock_stdin.flush = MagicMock()

@@ -0,0 +25,4 @@
+# Decorated @given moved to lsp_transport_coverage_steps.py for primary step registry.
+
+
+def step_ltcov_popen_success(context: Context) -> None:  # pylint: disable=unused-argument

@@ -0,0 +81,4 @@
+# ---------------------------------------------------------------------------
+
+
+@given("ltcov the error should be a RuntimeError")

@@ -0,0 +88,4 @@
+
+
+@then("ltcov the mock process was terminated by stop()")
+def step_ltcov_process_terminated(context: Context) -> None:  # pylint: disable=unused-argument

@@ -0,0 +95,4 @@
+
+
+@then("ltcov the mock process was waited on by stop()")
+def step_ltcov_process_waited(context: Context) -> None:  # pylint: disable=unused-argument

@@ -1,514 +1,979 @@
 """Step definitions for LSP StdioTransport coverage tests.

@@ -0,0 +36,4 @@
+    context.ltcov_mock_process = mock_proc
+
+
+@given('ltcov logger.info is mocked to raise RuntimeError on second call')

@@ -1,514 +1,979 @@
 """Step definitions for LSP StdioTransport coverage tests.

@@ -0,0 +36,4 @@
+    context.ltcov_mock_process = mock_proc
+
+
+@given('ltcov logger.info is mocked to raise RuntimeError on second call')

@@ -107,6 +107,10 @@ def _make_assembler(
         repo.get_context_policy.return_value = policy
     else:
         repo.get_context_policy.return_value = ProjectContextPolicy()
+    # Default: project context config with hot_max_tokens=None (falls back to constructor).

@@ -166,6 +168,47 @@ class ACMSExecutePhaseContextAssembler(ExecutePhaseContextAssembler):
             return False
         return not (exclude and _matches_any(exclude))
 
+    def _resolve_effective_hot_max_tokens(

@@ -3149,0 +3153,4 @@
+        Unlike :meth:`get_context_policy` which returns a
+        ``ProjectContextPolicy``, this method returns the full
+        ``ContextConfig`` containing memory-tier settings such as
+        hot_max_tokens, warm/cold tier limits, and more.

@@ -107,6 +107,10 @@ def _make_assembler(
         repo.get_context_policy.return_value = policy
     else:
         repo.get_context_policy.return_value = ProjectContextPolicy()
+    # Default: project context config with hot_max_tokens=None (falls back to constructor).

@@ -169,0 +207,4 @@
+            return self._fallback_hot_max_tokens
+
+        # Absolute safety-net.
+        return 4096

@@ -3149,0 +3195,4 @@
+            ) from exc
+        finally:
+            session.close()
+