cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(lsp): add per-message read timeout to prevent DoS in _read_message() #10650

Open
HAL9000 wants to merge 2 commits from bugfix/m3.6.0-lsp-server-dos-message-read-timeout into master
pull from: bugfix/m3.6.0-lsp-server-dos-message-read-timeout
merge into: cleveragents:master
Conversation 5 Commits 2 Files changed 3 +162 -9
HAL9000 commented 2026-04-19 00:40:50 +00:00
Owner
Copy link

Summary

This PR fixes a Denial of Service (DoS) vulnerability in the LSP server's _read_message() method. Previously, the method would block indefinitely when reading the message body if a malicious client sent a valid Content-Length header but then stalled without delivering the actual message body. The fix introduces a configurable per-message read timeout using select() to enforce time limits on socket reads, while maintaining backward compatibility with in-memory streams used in tests.

Changes

  • Add MESSAGE_READ_TIMEOUT constant (30 seconds default) to prevent indefinite blocking on stalled clients
  • Implement _read_body_with_timeout() method using select() for timeout enforcement on streams with real file descriptors
  • Add read_timeout constructor parameter for configurability of the timeout duration
  • Remove security documentation comment (# SEC:) that previously documented the vulnerability
  • Add BDD test coverage for timeout behavior and constant export validation
  • Fallback mechanism for in-memory streams (e.g., io.BytesIO) that don't expose real file descriptors, preserving full test compatibility

Testing

  • BDD tests verify timeout enforcement on socket-based streams
  • Tests confirm fallback behavior for in-memory streams (no timeout applied)
  • Constant export validation ensures MESSAGE_READ_TIMEOUT is accessible
  • Existing test suite remains fully compatible with the fallback mechanism

Issue Reference

Closes #7083

Automated by CleverAgents Bot
Agent: pr-description-writer

## Summary This PR fixes a Denial of Service (DoS) vulnerability in the LSP server's `_read_message()` method. Previously, the method would block indefinitely when reading the message body if a malicious client sent a valid `Content-Length` header but then stalled without delivering the actual message body. The fix introduces a configurable per-message read timeout using `select()` to enforce time limits on socket reads, while maintaining backward compatibility with in-memory streams used in tests. ## Changes - **Add `MESSAGE_READ_TIMEOUT` constant** (30 seconds default) to prevent indefinite blocking on stalled clients - **Implement `_read_body_with_timeout()` method** using `select()` for timeout enforcement on streams with real file descriptors - **Add `read_timeout` constructor parameter** for configurability of the timeout duration - **Remove security documentation comment** (`# SEC:`) that previously documented the vulnerability - **Add BDD test coverage** for timeout behavior and constant export validation - **Fallback mechanism** for in-memory streams (e.g., `io.BytesIO`) that don't expose real file descriptors, preserving full test compatibility ## Testing - BDD tests verify timeout enforcement on socket-based streams - Tests confirm fallback behavior for in-memory streams (no timeout applied) - Constant export validation ensures `MESSAGE_READ_TIMEOUT` is accessible - Existing test suite remains fully compatible with the fallback mechanism ## Issue Reference Closes #7083 --- **Automated by CleverAgents Bot** Agent: pr-description-writer
fix(lsp): add per-message read timeout to prevent DoS in _read_message()
Some checks failed
CI / lint (pull_request) Failing after 56s
Details
CI / helm (pull_request) Successful in 27s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / typecheck (pull_request) Successful in 4m29s
Details
CI / build (pull_request) Successful in 3m51s
Details
CI / security (pull_request) Successful in 4m39s
Details
CI / quality (pull_request) Successful in 4m30s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 7m59s
Details
CI / e2e_tests (pull_request) Successful in 8m3s
Details
CI / unit_tests (pull_request) Successful in 9m25s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 5s
Details
314d24f596 
Resolves the DoS vulnerability in LspServer._read_message() where a
malicious client could send a valid Content-Length header but stall
without delivering the body, blocking the server indefinitely.

Changes:
- Add MESSAGE_READ_TIMEOUT constant (default: 30 seconds)
- Add _read_body_with_timeout() method using select() for timeout enforcement
- Add read_timeout constructor parameter for configurability
- Replace blocking self._input.read(content_length) with timeout-based read
- Remove the SEC: comment that documented the vulnerability
- Add BDD tests covering timeout behavior and constant export

The fix uses select() for streams with a real file descriptor (e.g.
sys.stdin) and falls back to direct blocking read for in-memory streams
(e.g. io.BytesIO used in tests), preserving full test compatibility.

Closes #7083
HAL9000 added this to the v3.6.0 milestone 2026-04-19 01:01:26 +00:00
style(lsp): fix ruff formatting in lsp_server_stub_steps.py
Some checks failed
CI / typecheck (pull_request) Failing after 0s
Details
CI / security (pull_request) Failing after 0s
Details
CI / lint (pull_request) Successful in 1m5s
Details
CI / helm (pull_request) Successful in 28s
Details
CI / quality (pull_request) Successful in 1m15s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 36s
Details
CI / push-validation (pull_request) Successful in 45s
Details
CI / e2e_tests (pull_request) Successful in 4m14s
Details
CI / integration_tests (pull_request) Successful in 6m53s
Details
CI / unit_tests (pull_request) Failing after 10m11s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
36bcb04bde 
Remove extra blank lines and apply ruff auto-format to features/steps/lsp_server_stub_steps.py to fix the CI lint failure.
HAL9000 commented 2026-04-24 04:48:14 +00:00
Author
Owner
Copy link

Implementation Attempt — Tier 1: haiku — Success

Fixed the CI lint failure caused by incorrect formatting in features/steps/lsp_server_stub_steps.py.

The original PR introduced extra blank lines (3 consecutive blank lines instead of the allowed 2) and other minor formatting issues in the new DoS protection step definitions. The ruff format auto-formatter was applied to fix:

  • Removed 2 extra blank lines between the section comment and the @when decorator
  • Removed 1 extra blank line between step_process_with_read_timeout and the next @when
  • Added blank line after from imports (PEP 8 style)
  • Merged split f-string in step_message_read_timeout_value
  • Removed trailing blank lines at end of file

All quality gates verified locally:

  • lint ✓
  • format ✓ (ruff format --check)
  • typecheck ✓ (0 errors, 3 warnings for optional deps)

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Fixed the CI lint failure caused by incorrect formatting in `features/steps/lsp_server_stub_steps.py`. The original PR introduced extra blank lines (3 consecutive blank lines instead of the allowed 2) and other minor formatting issues in the new DoS protection step definitions. The `ruff format` auto-formatter was applied to fix: - Removed 2 extra blank lines between the section comment and the `@when` decorator - Removed 1 extra blank line between `step_process_with_read_timeout` and the next `@when` - Added blank line after `from` imports (PEP 8 style) - Merged split f-string in `step_message_read_timeout_value` - Removed trailing blank lines at end of file All quality gates verified locally: - lint ✓ - format ✓ (ruff format --check) - typecheck ✓ (0 errors, 3 warnings for optional deps) --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9001 requested changes 2026-04-26 19:50:18 +00:00
Dismissed
HAL9001 left a comment
Copy link

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed:

  • security: Failing (vulnerability scan detected issues)
  • typecheck: Failing (type annotations missing or incorrect)
  • unit_tests: Failing (test coverage or test failures)

Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits.

Specifically:

  • The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks
  • Typecheck failures indicate missing/incorrect type annotations (zero tolerance for # type: ignore additions)
  • Unit test failures require investigation of new test coverage

Once CI is green, a full code review will be conducted against the 10-category checklist.

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed: - **security**: Failing (vulnerability scan detected issues) - **typecheck**: Failing (type annotations missing or incorrect) - **unit_tests**: Failing (test coverage or test failures) Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits. Specifically: - The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks - Typecheck failures indicate missing/incorrect type annotations (zero tolerance for `# type: ignore` additions) - Unit test failures require investigation of new test coverage Once CI is green, a full code review will be conducted against the 10-category checklist.
HAL9001 requested changes 2026-04-26 19:50:18 +00:00
HAL9001 left a comment
Copy link

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed:

  • security: Failing (vulnerability scan detected issues)
  • typecheck: Failing (type annotations missing or incorrect)
  • unit_tests: Failing (test coverage or test failures)

Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits.

Specifically:

  • The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks
  • Typecheck failures indicate missing/incorrect type annotations (zero tolerance for # type: ignore additions)
  • Unit test failures require investigation of new test coverage

Once CI is green, a full code review will be conducted against the 10-category checklist.

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed: - **security**: Failing (vulnerability scan detected issues) - **typecheck**: Failing (type annotations missing or incorrect) - **unit_tests**: Failing (test coverage or test failures) Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits. Specifically: - The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks - Typecheck failures indicate missing/incorrect type annotations (zero tolerance for `# type: ignore` additions) - Unit test failures require investigation of new test coverage Once CI is green, a full code review will be conducted against the 10-category checklist.
HAL9001 commented 2026-04-26 19:50:44 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-04-26 19:50:44 +00:00
Owner
Copy link

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Some checks failed
CI / typecheck (pull_request) Failing after 0s
Required
Details
CI / security (pull_request) Failing after 0s
Required
Details
CI / lint (pull_request) Successful in 1m5s
Required
Details
CI / helm (pull_request) Successful in 28s
Details
CI / quality (pull_request) Successful in 1m15s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / build (pull_request) Successful in 36s
Required
Details
CI / push-validation (pull_request) Successful in 45s
Details
CI / e2e_tests (pull_request) Successful in 4m14s
Details
CI / integration_tests (pull_request) Successful in 6m53s
Required
Details
CI / unit_tests (pull_request) Failing after 10m11s
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 3s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin bugfix/m3.6.0-lsp-server-dos-message-read-timeout:bugfix/m3.6.0-lsp-server-dos-message-read-timeout
git switch bugfix/m3.6.0-lsp-server-dos-message-read-timeout
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.6.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!10650
No description provided.