fix(lsp): add per-message read timeout to prevent DoS in _read_message() #10650

Merged

HAL9000 merged 5 commits from bugfix/m3.6.0-lsp-server-dos-message-read-timeout into master 2026-06-05 22:08:32 +00:00

Conversation 20 Commits 5 Files Changed 3

+244 -9

HAL9000 commented 2026-04-19 00:40:50 +00:00

Owner

Copy Link

Copy Source

Summary

This PR fixes a Denial of Service (DoS) vulnerability in the LSP server's _read_message() method. Previously, the method would block indefinitely when reading the message body if a malicious client sent a valid Content-Length header but then stalled without delivering the actual message body. The fix introduces a configurable per-message read timeout using select() to enforce time limits on socket reads, while maintaining backward compatibility with in-memory streams used in tests.

Changes

• Add MESSAGE_READ_TIMEOUT constant (30 seconds default) to prevent indefinite blocking on stalled clients
• Implement _read_body_with_timeout() method using select() for timeout enforcement on streams with real file descriptors
• Add read_timeout constructor parameter for configurability of the timeout duration
• Remove security documentation comment (# SEC:) that previously documented the vulnerability
• Add BDD test coverage for timeout behavior and constant export validation
• Fallback mechanism for in-memory streams (e.g., io.BytesIO) that don't expose real file descriptors, preserving full test compatibility

Testing

• BDD tests verify timeout enforcement on socket-based streams
• Tests confirm fallback behavior for in-memory streams (no timeout applied)
• Constant export validation ensures MESSAGE_READ_TIMEOUT is accessible
• Existing test suite remains fully compatible with the fallback mechanism

Issue Reference

Closes #7083

---

Automated by CleverAgents Bot
Agent: pr-description-writer

## Summary This PR fixes a Denial of Service (DoS) vulnerability in the LSP server's `_read_message()` method. Previously, the method would block indefinitely when reading the message body if a malicious client sent a valid `Content-Length` header but then stalled without delivering the actual message body. The fix introduces a configurable per-message read timeout using `select()` to enforce time limits on socket reads, while maintaining backward compatibility with in-memory streams used in tests. ## Changes - **Add `MESSAGE_READ_TIMEOUT` constant** (30 seconds default) to prevent indefinite blocking on stalled clients - **Implement `_read_body_with_timeout()` method** using `select()` for timeout enforcement on streams with real file descriptors - **Add `read_timeout` constructor parameter** for configurability of the timeout duration - **Remove security documentation comment** (`# SEC:`) that previously documented the vulnerability - **Add BDD test coverage** for timeout behavior and constant export validation - **Fallback mechanism** for in-memory streams (e.g., `io.BytesIO`) that don't expose real file descriptors, preserving full test compatibility ## Testing - BDD tests verify timeout enforcement on socket-based streams - Tests confirm fallback behavior for in-memory streams (no timeout applied) - Constant export validation ensures `MESSAGE_READ_TIMEOUT` is accessible - Existing test suite remains fully compatible with the fallback mechanism ## Issue Reference Closes #7083 --- **Automated by CleverAgents Bot** Agent: pr-description-writer

HAL9000 added 1 commit 2026-04-19 00:40:51 +00:00

fix(lsp): add per-message read timeout to prevent DoS in _read_message() ... 314d24f596

Resolves the DoS vulnerability in LspServer._read_message() where a
malicious client could send a valid Content-Length header but stall
without delivering the body, blocking the server indefinitely.

Changes:
- Add MESSAGE_READ_TIMEOUT constant (default: 30 seconds)
- Add _read_body_with_timeout() method using select() for timeout enforcement
- Add read_timeout constructor parameter for configurability
- Replace blocking self._input.read(content_length) with timeout-based read
- Remove the SEC: comment that documented the vulnerability
- Add BDD tests covering timeout behavior and constant export

The fix uses select() for streams with a real file descriptor (e.g.
sys.stdin) and falls back to direct blocking read for in-memory streams
(e.g. io.BytesIO used in tests), preserving full test compatibility.

Closes #7083

HAL9000 added the

Type

Bug

label 2026-04-19 00:45:13 +00:00

HAL9000 referenced this pull request 2026-04-19 01:01:26 +00:00

BUG-HUNT: [security] DoS vulnerability in LSP server message reading #7083

HAL9000 added this to the v3.6.0 milestone 2026-04-19 01:01:26 +00:00

HAL9000 referenced this pull request 2026-04-19 01:08:16 +00:00

Implementation Pool Supervisor - Cycle 44 Status #10652

HAL9000 referenced this pull request 2026-04-19 01:41:12 +00:00

Implementation Pool Supervisor - Cycle 49 Status #10659

HAL9000 referenced this pull request 2026-04-19 02:19:27 +00:00

Implementation Pool Supervisor - Cycle 54 Status #10667

HAL9000 referenced this pull request 2026-04-19 02:51:46 +00:00

Implementation Pool Supervisor - Cycle 59 Status #10677

HAL9000 added 1 commit 2026-04-24 04:47:05 +00:00

style(lsp): fix ruff formatting in lsp_server_stub_steps.py ... 36bcb04bde

Remove extra blank lines and apply ruff auto-format to features/steps/lsp_server_stub_steps.py to fix the CI lint failure.

HAL9000 commented 2026-04-24 04:48:14 +00:00

Author

Owner

Copy Link

Copy Source

Implementation Attempt — Tier 1: haiku — Success

Fixed the CI lint failure caused by incorrect formatting in features/steps/lsp_server_stub_steps.py.

The original PR introduced extra blank lines (3 consecutive blank lines instead of the allowed 2) and other minor formatting issues in the new DoS protection step definitions. The ruff format auto-formatter was applied to fix:

• Removed 2 extra blank lines between the section comment and the @when decorator
• Removed 1 extra blank line between step_process_with_read_timeout and the next @when
• Added blank line after from imports (PEP 8 style)
• Merged split f-string in step_message_read_timeout_value
• Removed trailing blank lines at end of file

All quality gates verified locally:

• lint ✓
• format ✓ (ruff format --check)
• typecheck ✓ (0 errors, 3 warnings for optional deps)

---

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Fixed the CI lint failure caused by incorrect formatting in `features/steps/lsp_server_stub_steps.py`. The original PR introduced extra blank lines (3 consecutive blank lines instead of the allowed 2) and other minor formatting issues in the new DoS protection step definitions. The `ruff format` auto-formatter was applied to fix: - Removed 2 extra blank lines between the section comment and the `@when` decorator - Removed 1 extra blank line between `step_process_with_read_timeout` and the next `@when` - Added blank line after `from` imports (PEP 8 style) - Merged split f-string in `step_message_read_timeout_value` - Removed trailing blank lines at end of file All quality gates verified locally: - lint ✓ - format ✓ (ruff format --check) - typecheck ✓ (0 errors, 3 warnings for optional deps) --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker

HAL9001 requested changes 2026-04-26 19:50:18 +00:00

Dismissed

HAL9001 left a comment

Owner

Copy Link

Copy Source

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed:

• security: Failing (vulnerability scan detected issues)
• typecheck: Failing (type annotations missing or incorrect)
• unit_tests: Failing (test coverage or test failures)

Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits.

Specifically:

• The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks
• Typecheck failures indicate missing/incorrect type annotations (zero tolerance for # type: ignore additions)
• Unit test failures require investigation of new test coverage

Once CI is green, a full code review will be conducted against the 10-category checklist.

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed: - **security**: Failing (vulnerability scan detected issues) - **typecheck**: Failing (type annotations missing or incorrect) - **unit_tests**: Failing (test coverage or test failures) Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits. Specifically: - The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks - Typecheck failures indicate missing/incorrect type annotations (zero tolerance for `# type: ignore` additions) - Unit test failures require investigation of new test coverage Once CI is green, a full code review will be conducted against the 10-category checklist.

HAL9001 requested changes 2026-04-26 19:50:18 +00:00

HAL9001 left a comment

Owner

Copy Link

Copy Source

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed:

• security: Failing (vulnerability scan detected issues)
• typecheck: Failing (type annotations missing or incorrect)
• unit_tests: Failing (test coverage or test failures)

Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits.

Specifically:

• The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks
• Typecheck failures indicate missing/incorrect type annotations (zero tolerance for # type: ignore additions)
• Unit test failures require investigation of new test coverage

Once CI is green, a full code review will be conducted against the 10-category checklist.

This PR cannot be approved because CI checks are failing. The following critical gates must pass before review can proceed: - **security**: Failing (vulnerability scan detected issues) - **typecheck**: Failing (type annotations missing or incorrect) - **unit_tests**: Failing (test coverage or test failures) Per company policy, all CI gates (lint, typecheck, security, unit_tests, coverage) must pass before a PR can be approved. Please fix these failures and push new commits. Specifically: - The security failure suggests the DoS vulnerability fix may not fully address the issue or introduced new risks - Typecheck failures indicate missing/incorrect type annotations (zero tolerance for `# type: ignore` additions) - Unit test failures require investigation of new test coverage Once CI is green, a full code review will be conducted against the 10-category checklist.

HAL9001 commented 2026-04-26 19:50:44 +00:00

Owner

Copy Link

Copy Source

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9001 commented 2026-04-26 19:50:44 +00:00

Owner

Copy Link

Copy Source

---

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

--- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker

HAL9000 referenced this pull request 2026-06-04 20:04:56 +00:00

fix(lsp): sanitize environment variables in LSP server process creation #10625

HAL9000 referenced this pull request 2026-06-04 20:08:27 +00:00

fix(lsp): prevent resource exhaustion DoS in language discovery directory traversal #10632

HAL9000 added the controller-managed label 2026-06-04 21:02:25 +00:00

HAL9000 added the

MoSCoW

Must have

Priority

Critical

labels 2026-06-04 21:05:37 +00:00

HAL9000 commented 2026-06-04 21:29:41 +00:00

Author

Owner

Copy Link

Copy Source

🌱 Grooming: proceed — PR cleared for processing.

(check no_duplicates, category no_duplicates)

PR #10650 fixes a specific DoS vulnerability in the LSP server's _read_message() method by adding a per-message read timeout using select(). While multiple open LSP PRs address other security issues (subprocess cleanup on initialization failure, header injection in ASCII decoding, path traversal in file reading), none of them target the indefinite blocking vulnerability in the message body reading logic. This is a distinct, focused security fix with no topical overlap or duplicate among the open PRs.

**🌱 Grooming: proceed** — PR cleared for processing. (check `no_duplicates`, category `no_duplicates`) PR #10650 fixes a specific DoS vulnerability in the LSP server's _read_message() method by adding a per-message read timeout using select(). While multiple open LSP PRs address other security issues (subprocess cleanup on initialization failure, header injection in ASCII decoding, path traversal in file reading), none of them target the indefinite blocking vulnerability in the message body reading logic. This is a distinct, focused security fix with no topical overlap or duplicate among the open PRs. <!-- controller:fingerprint:8c8f248bf1a10f6b -->

HAL9000 commented 2026-06-04 21:42:50 +00:00

Author

Owner

Copy Link

Copy Source

📋 Estimate: tier 1.

3-file change (+162/-9) adding a DoS fix to the LSP server: new select()-based timeout logic, a fallback path for in-memory streams, a new constructor parameter, and BDD test coverage. Multi-file scope with new logic branches (select fd check, fallback, configurable timeout) puts this firmly above tier 0. The typecheck and security CI failures are Docker pull-rate-limit infrastructure noise, not code defects. The unit_tests gate shows 2 genuine scenario failures out of 15241, indicating real implementation work remains. Task is well-defined and bounded — no architectural sprawl — so tier 2 is not warranted.

**📋 Estimate: tier 1.** 3-file change (+162/-9) adding a DoS fix to the LSP server: new `select()`-based timeout logic, a fallback path for in-memory streams, a new constructor parameter, and BDD test coverage. Multi-file scope with new logic branches (select fd check, fallback, configurable timeout) puts this firmly above tier 0. The typecheck and security CI failures are Docker pull-rate-limit infrastructure noise, not code defects. The unit_tests gate shows 2 genuine scenario failures out of 15241, indicating real implementation work remains. Task is well-defined and bounded — no architectural sprawl — so tier 2 is not warranted. <!-- controller:fingerprint:8c44b98b96ed02ce -->

HAL9000 force-pushed bugfix/m3.6.0-lsp-server-dos-message-read-timeout from 36bcb04bde to e2c658918b 2026-06-04 21:52:32 +00:00 Compare

HAL9000 commented 2026-06-04 21:52:57 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #3, tier 1)

🔧 Implementer attempt — rebased.

Pushed 1 commit: e2c6589.

_(attempt #3, tier 1)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `e2c6589`. <!-- controller:fingerprint:5c673f78e5ece124 -->

HAL9000 force-pushed bugfix/m3.6.0-lsp-server-dos-message-read-timeout from e2c658918b to 7a0baf30fd 2026-06-04 22:22:32 +00:00 Compare

HAL9000 commented 2026-06-04 22:23:46 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #4, tier 1)

🔧 Implementer attempt — rebased.

Pushed 1 commit: 7a0baf3.

_(attempt #4, tier 1)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `7a0baf3`. <!-- controller:fingerprint:01119cccdc661893 -->

HAL9000 force-pushed bugfix/m3.6.0-lsp-server-dos-message-read-timeout from 7a0baf30fd to 32b728f7a3 2026-06-04 22:47:01 +00:00 Compare

HAL9000 commented 2026-06-04 22:48:53 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #5, tier 1)

🔧 Implementer attempt — rebased.

Pushed 1 commit: 32b728f.

_(attempt #5, tier 1)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `32b728f`. <!-- controller:fingerprint:bc18dcf56ab689f1 -->

HAL9000 added 1 commit 2026-06-04 23:57:24 +00:00

chore: re-trigger CI [controller] 737dbebb73

HAL9000 commented 2026-06-04 23:57:48 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #6, tier 1)

🔧 Implementer attempt — blocked.

Blockers:

• agent-side push detected: remote bugfix/m3.6.0-lsp-server-dos-message-read-timeout is at 737dbebb73 but dispatch base was 32b728f7a3. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.

_(attempt #6, tier 1)_ **🔧 Implementer attempt — `blocked`.** Blockers: - agent-side push detected: remote bugfix/m3.6.0-lsp-server-dos-message-read-timeout is at 737dbebb73df but dispatch base was 32b728f7a38c. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head. <!-- controller:fingerprint:e43e4625e5ad8f1f -->

HAL9000 force-pushed bugfix/m3.6.0-lsp-server-dos-message-read-timeout from 737dbebb73 to c03498d71a 2026-06-05 00:33:06 +00:00 Compare

HAL9000 commented 2026-06-05 00:33:54 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #7, tier 2)

🔧 Implementer attempt — rebased.

Pushed 1 commit: c03498d.

_(attempt #7, tier 2)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `c03498d`. <!-- controller:fingerprint:ad8c224ed35cc5e7 -->

HAL9000 commented 2026-06-05 00:55:08 +00:00

Author

Owner

Copy Link

Copy Source

🌱 Grooming: proceed — PR cleared for processing.

(check no_duplicates, category no_duplicates)

PR #10650 adds a configurable per-message read timeout to LSP's _read_message() method using select() to prevent indefinite blocking on stalled clients. While six other LSP security fixes are open (#10597, #10608, #10632, #10644, #10625, etc.), each addresses a distinct vulnerability (subprocess cleanup, header injection, directory traversal, path traversal, env injection). None modifies message-reading loop timeout handling or closes #7083. No topical overlap or duplicated scope detected.

**🌱 Grooming: proceed** — PR cleared for processing. (check `no_duplicates`, category `no_duplicates`) PR #10650 adds a configurable per-message read timeout to LSP's _read_message() method using select() to prevent indefinite blocking on stalled clients. While six other LSP security fixes are open (#10597, #10608, #10632, #10644, #10625, etc.), each addresses a distinct vulnerability (subprocess cleanup, header injection, directory traversal, path traversal, env injection). None modifies message-reading loop timeout handling or closes #7083. No topical overlap or duplicated scope detected. <!-- controller:fingerprint:5065a6527bc86494 -->

HAL9000 commented 2026-06-05 00:57:40 +00:00

Author

Owner

Copy Link

Copy Source

📋 Estimate: tier 1.

3-file security fix adding select()-based per-message read timeout to LSP _read_message(). New logic includes _read_body_with_timeout() with fd detection, fallback for in-memory streams (BytesIO), and a new constructor parameter. New BDD test coverage for timeout enforcement and fallback behavior. Socket/file-descriptor semantics and backward-compatibility reasoning required. CI failures are all infrastructure network errors (forgejo-http unreachable), not code failures — integration_tests logs show "OK" before artifact upload failure. Solidly tier 1: cross-file, new logic branches, new tests.

**📋 Estimate: tier 1.** 3-file security fix adding select()-based per-message read timeout to LSP _read_message(). New logic includes _read_body_with_timeout() with fd detection, fallback for in-memory streams (BytesIO), and a new constructor parameter. New BDD test coverage for timeout enforcement and fallback behavior. Socket/file-descriptor semantics and backward-compatibility reasoning required. CI failures are all infrastructure network errors (forgejo-http unreachable), not code failures — integration_tests logs show "OK" before artifact upload failure. Solidly tier 1: cross-file, new logic branches, new tests. <!-- controller:fingerprint:251cf624fb336cdd -->

HAL9000 added 1 commit 2026-06-05 00:58:49 +00:00

chore: re-trigger CI [controller] fab8c64ba5

HAL9000 commented 2026-06-05 01:00:11 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #10, tier 1)

🔧 Implementer attempt — blocked.

Blockers:

• agent-side push detected: remote bugfix/m3.6.0-lsp-server-dos-message-read-timeout is at fab8c64ba5 but dispatch base was c03498d71a. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.

_(attempt #10, tier 1)_ **🔧 Implementer attempt — `blocked`.** Blockers: - agent-side push detected: remote bugfix/m3.6.0-lsp-server-dos-message-read-timeout is at fab8c64ba523 but dispatch base was c03498d71ac6. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head. <!-- controller:fingerprint:24a1400d62728be1 -->

HAL9000 force-pushed bugfix/m3.6.0-lsp-server-dos-message-read-timeout from fab8c64ba5 to c3de4921bb 2026-06-05 01:00:12 +00:00 Compare

HAL9000 commented 2026-06-05 01:01:17 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #11, tier 2)

🔧 Implementer attempt — rebased.

Pushed 1 commit: c3de492.

_(attempt #11, tier 2)_ **🔧 Implementer attempt — `rebased`.** Pushed 1 commit: `c3de492`. <!-- controller:fingerprint:98a93a1a6ac41836 -->

HAL9000 added 1 commit 2026-06-05 21:29:30 +00:00

test(lsp): cover the select-based read-body timeout branch via os.pipe() ... 22c3cddf08

The DoS mitigation added in db389a730 wraps each message-body read in
``select()`` so a stalled client cannot pin the server forever. The
existing transport tests route through MockLspTransport, whose
``BytesIO`` raises ``UnsupportedOperation`` on ``fileno()`` -- so
``_read_body_with_timeout`` always falls through the BytesIO fast
path and the actual ``select()``-based mitigation code (the part
that runs in production) is never executed. That left ~19 new lines
uncovered, dragging total coverage below the 96.5% floor and
failing the coverage gate.

Two new scenarios drive the helper through an ``os.pipe()`` whose
read fd satisfies ``fileno()``, so ``use_select`` is True and the
real DoS-protection path runs:

* ``timeout=0.0`` makes the deadline already past on the first
  iteration, exercising the ``if timeout <= 0:`` early-exit warning.
* ``timeout=0.05`` lets ``select.select()`` run and time out with no
  ready descriptors, exercising the ``if not ready:`` warning.

Both paths log ``lsp.transport.read_timeout`` and return ``None``,
matching the production behaviour the helper was added to provide.

ISSUES CLOSED: #5566

HAL9000 commented 2026-06-05 21:30:40 +00:00

Author

Owner

Copy Link

Copy Source

(attempt #12, tier 2)

🔧 Implementer attempt — resolved.

Pushed 1 commit: 22c3cdd.

Files touched: features/lsp_server_stub.feature, features/steps/lsp_server_stub_steps.py.

_(attempt #12, tier 2)_ **🔧 Implementer attempt — `resolved`.** Pushed 1 commit: `22c3cdd`. Files touched: `features/lsp_server_stub.feature`, `features/steps/lsp_server_stub_steps.py`. <!-- controller:fingerprint:03f90f3b7fe778a4 -->

HAL9000 referenced this pull request 2026-06-05 21:30:41 +00:00

fix(lsp): prevent resource exhaustion DoS in language discovery directory traversal #10632

HAL9001 approved these changes 2026-06-05 22:04:24 +00:00

HAL9001 left a comment

Owner

Copy Link

Copy Source

✅ Approved

Reviewed at commit 22c3cdd.

Confidence: high.

**✅ Approved** Reviewed at commit `22c3cdd`. Confidence: high. <!-- controller:fingerprint:33247fd56f35e968 -->

HAL9000 added the auto/claimed-merge label 2026-06-05 22:08:23 +00:00

HAL9000 commented 2026-06-05 22:08:24 +00:00

Author

Owner

Copy Link

Copy Source

Claimed by merge_drive.py (pid 1627962) until 2026-06-05T23:38:24.119281+00:00.

This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.

<!-- merge_drive.py: claim --> Claimed by `merge_drive.py` (pid 1627962) until `2026-06-05T23:38:24.119281+00:00`. This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.

HAL9001 approved these changes 2026-06-05 22:08:28 +00:00

HAL9001 left a comment

Owner

Copy Link

Copy Source

Approved by the controller reviewer stage (workflow 280).

Approved by the controller reviewer stage (workflow 280).

HAL9000 merged commit f173e381a6 into master 2026-06-05 22:08:32 +00:00

HAL9000 removed the auto/claimed-merge label 2026-06-05 22:08:33 +00:00

HAL9000 referenced this issue from a commit 2026-06-05 22:08:35 +00:00

Merge pull request 'fix(lsp): add per-message read timeout to prevent DoS in _read_message()' (#10650) from bugfix/m3.6.0-lsp-server-dos-message-read-timeout into master

Sign in to join this conversation.

Reviewers

No Reviewers

HAL9001

Labels

Clear labels

auto/needs-reevaluation

Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

controller-managed

Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

overdue

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

auto/claimed-implementer

Currently being processed by an implementer worker.

auto/claimed-merge

Currently being processed by the merge driver.

auto/claimed-reviewer

Currently being processed by a reviewer worker.

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

auto/needs-implementer

Failing CI needs implementer attention.

auto/postmortem

Documenting a driver incident or rollback.

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

Points

1

1 man-hours worth of work for an expert with no learning curve.

Points

13

13 man-hours worth of work for an expert with no learning curve.

Points

2

2 man-hours worth of work for an expert with no learning curve.

Points

21

21 man-hours worth of work for an expert with no learning curve.

Points

3

3 man-hours worth of work for an expert with no learning curve.

Points

34

34 man-hours worth of work for an expert with no learning curve.

Points

5

5 man-hours worth of work for an expert with no learning curve.

Points

55

55 man-hours worth of work for an expert with no learning curve.

Points

8

8 man-hours worth of work for an expert with no learning curve.

Points

88

88 man-hours worth of work for an expert with no learning curve.

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

State

Duplicate

A ticket that represents the same content as an existing ticket.

State

In Progress

A ticket that is actively being developed.

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

Type

Automation

Any edits or discussion about the AI automated coding system.

Type

Bug

Something that doesnt work as intended.

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

Type

Documentation

An error or improvement needed in the documentation.

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

Type

Feature

Some new functionality not present.

Type

Legendary

A type of Epic which will contain other Epics.

Type

Refactor

A code change that restructures existing code without changing its external behavior.

Type

Support

Someone needs help using the project.

Type

Task

A generic task that doesnt fit into the other type categories.

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No Label controller-managed

MoSCoW

Must have

Priority

Critical

Type

Bug

Milestone

No items

No Milestone v3.6.0

Projects

Clear projects

No project

Assignees

Clear assignees

aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10650