2411 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	35a5c57cca	fix(plan): add CHANGELOG.md and CONTRIBUTORS.md compliance updates for PR #9407 ... - Add changelog entry under Changed section referencing the structured alternatives output fix (#9166) per Keep a Changelog format. - Add HAL 9000 contributor entry for PR #9407 documenting the plan explain structured alternatives implementation in CONTRIBUTORS.md details section. ISSUES CLOSED: #9166	2026-05-08 17:26:29 +00:00
HAL9000	8b7f7edb19	fix(plan): update robot helper to assert alternatives key in explain output ... The robot/helper_plan_explain.py integration test helper was still asserting the old field name alternatives_considered in the explain dict output. Since _build_explain_dict() now outputs alternatives (structured objects with index/description/chosen fields per spec), the assertion was failing the CI integration_tests job. Updated the assertion to check for alternatives and also verify it is a list, matching the new structured output format.	2026-05-08 15:29:52 +00:00
HAL9000	b39834a766	fix(plan): use structured alternatives objects in plan explain output per spec ... Convert alternatives_considered list of strings to structured objects with index (1-based), description, and chosen fields in _build_explain_dict(). Rename output field from alternatives_considered to alternatives. Update BDD tests in plan_explain.feature, plan_explain_cli_coverage.feature, and plan_explain_steps.py to validate the new structured format. Closes #9166	2026-05-08 15:29:52 +00:00
HAL9000	e8996d66d7	test(core): fix ASV benchmark timing methodology and remove unused imports ... - Remove unused `from typing import Any` import from core_retry_patterns_bench.py - Refactor CircuitBreakerStateTransitionBench into three separate benchmark classes (CircuitBreakerClosedToOpenTransitionBench, CircuitBreakerOpenToHalfOpenTransitionBench, CircuitBreakerHalfOpenToClosedTransitionBench), each with a proper setup() method that pre-creates the CircuitBreaker in the correct initial state so only the transition itself is measured - Move open-state CircuitBreaker creation for async fast-fail benchmark into setup() in CircuitBreakerAsyncBench, eliminating instance creation overhead from the timed method Addresses reviewer feedback on PR #10961.	2026-05-08 14:21:41 +00:00
HAL9000	9aa966cdaa	fix(bench): correct API usage and formatting in core ASV benchmark files ... - Fix get_retry_decorator() calls to use category string instead of keyword arguments (max_attempts, base_delay, etc.) - Fix retry_on_result() calls to pass required predicate argument - Fix retry_service_operation() to use circuit_breaker= (CircuitBreaker instance) instead of use_circuit_breaker= (bool), and backoff_strategy= instead of wait_strategy= - Fix is_read_only_plan_operation() calls to pass dict instead of string - Fix RetryContext() to use operation_name= instead of service_name=, remove non-existent use_circuit_breaker and attempt_count constructor params - Fix retry_auto_debug() to use max_debug_attempts= instead of service_name=/operation_name= (which are not valid parameters) - Remove unused Any import from core_circuit_breaker_bench.py - Apply ruff format to all three benchmark files to fix CI format check	2026-05-08 14:21:41 +00:00
HAL9000	ffd83e8712	test(core): add ASV performance benchmarks for core module ... Added three new ASV benchmark suites for the core module: 1. core_circuit_breaker_bench.py - Benchmarks for CircuitBreaker class: - Closed state call overhead - Open state fast-fail latency - State transition overhead (closed→open, open→half-open, half-open→closed) - Async operations - Initialization overhead 2. core_retry_patterns_bench.py - Benchmarks for retry decorators: - Decorator construction overhead for exponential backoff, jitter, timeout, and result-based retry - Happy-path invocation overhead - Async decorator operations - Decorator usage with function arguments - Factory function performance - Various configuration scenarios 3. core_retry_service_patterns_bench.py - Benchmarks for service-level retry: - retry_service_operation decorator construction and invocation - retry_auto_debug decorator performance - RetryContext operations - is_read_only_plan_operation utility - Different wait strategies (exponential, linear, fixed, jitter) These benchmarks ensure latency regressions in core resilience primitives are caught early. ISSUES CLOSED: #1921	2026-05-08 14:21:41 +00:00
HAL9000	3f8f8eb0bf	docs(agents): add State/In Review and Priority labels to pr-creator ... ISSUES CLOSED: #8520	2026-05-08 13:22:11 +00:00
hamza.khyari	a79d22642a	docs(tui): document MULTILINE limitation and spec reference in _PromptSymbolMixin ... The spec (§29257) refers to 'PromptTextArea' implying a multi-line TextArea widget, but TextArea.__init__() dropped the placeholder kwarg in textual >=1.0. This implementation uses Input (single-line) as a workaround. MULTILINE mode detection works via content inspection but the widget cannot display multiple lines. Document this gap and reference the spec sections for future migration.	2026-05-08 11:15:36 +00:00
HAL9000	b588de18d6	fix(tui): rebase onto master and add CHANGELOG entry for prompt symbol fix (#6431) ... Rebases the TUI prompt symbol fix onto the latest master, resolving conflicts with the TextArea→Input refactor and the dollar-prefix shell mode addition. Adds the missing CHANGELOG.md entry for #6431 and removes the now-obsolete tui_prompt_textarea feature/steps that tested the old TextArea-based implementation. ISSUES CLOSED: #6431	2026-05-08 11:15:36 +00:00
HAL9000	a130d63357	docs(timeline): update schedule adherence Day 101 (2026-04-12) (#7858)	2026-05-08 10:21:23 +00:00
HAL9000	a15b77f6a6	fix(acms): normalize context path matching for absolute paths in _path_matches ... Fixes issue #10972 where _path_matches() used PurePath.full_match()/match() which requires the entire path to match. Since fragment metadata stores absolute paths (e.g. /app/.opencode/skills/SKILL.md) while project context --exclude-path/--include-path settings produce relative globs (.opencode/*, docs/*), include/exclude filters were silently ineffective. Added _matches_any() static helper in execute_phase_context_assembler.py that: - Tries full_match(pattern) as-is for relative paths and anchored patterns - Auto-prefixes relative patterns with **/ so they match absolute paths Updated _matches_pattern() in context_phase_analysis.py with same logic plus zero-depth compatibility shim. Added 7 new BDD regression scenarios with @tdd_issue tags: - 5 in execute_phase_context_assembler_coverage.feature (absolute path matching) - 1 extra trailing ** glob exclusion test - 1 in project_context_phase_analysis.feature (phase analysis exclusion) ISSUES CLOSED: #10972	2026-05-08 09:57:18 +00:00
HAL9000	5b6224daa8	fix(plugins): prevent arbitrary code execution in PluginLoader.validate_protocol() ... - Add guard in TypeError fallback path: raise ProtocolMismatchError when issubclass raises TypeError and protocol has no inspectable members, preventing silent True return for unverifiable protocols - Update test scenario descriptions to accurately reflect the new implementation (no instantiation occurs at any point) - Update step definition comments to remove references to old instantiation-based code paths ISSUES CLOSED: #7418	2026-05-08 09:32:29 +00:00
HAL9000	c58ceb7918	fix(plugins): strengthen validate_protocol structural check and satisfy linter	2026-05-08 09:32:29 +00:00
freemo	c84ae3bb96	fix(plugins): prevent arbitrary code execution in PluginLoader.validate_protocol() ... Fixes #7418 - Security vulnerability where PluginLoader.validate_protocol() instantiated arbitrary plugin classes with no-arg constructor, allowing arbitrary code execution during validation. Changes: - Reversed validation order: use issubclass() first (safe, no instantiation) - Only instantiate if structural check is insufficient - Prevents constructor code execution from untrusted plugins - Maintains protocol validation functionality This prevents RCE attacks via malicious plugin constructors during the validation phase.	2026-05-08 09:32:29 +00:00
HAL9000	883ec872e2	fix(CI): resolve remaining lint/format violations in PR #8722 ... - Apply ruff format to features/steps/strategize_decision_recording_steps.py: expanded single-line set literal to multi-line canonical form (PEP 87) This was the sole remaining CI lint blocker per review cycle 14. - Remove unused imports from tests/actor/test_registry_builtin_yaml.py: removed 'Settings' and 'ProviderRegistry' to fix F401 errors. These were pre-existing violations caught by ruff check. ISSUES CLOSED: #8522 Closes: #8722	2026-05-08 06:24:23 +00:00
HAL9000	e7fb7168b4	feat(decisions): implement decision recording hook in Strategize phase ... Implement the StrategizeDecisionHook class for recording decisions during the Strategize phase. The hook captures every decision point with question, chosen_option, alternatives_considered, confidence_score, rationale, and full context_snapshot (hot_context_hash, actor_state_ref, relevant_resources). Supports four decision types: strategy_choice, resource_selection, subplan_spawn, and invariant_enforced. Includes a DecisionRecorder protocol port for decoupled persistence and capture_context_snapshot utility function. Comprehensive BDD test suite with 40+ scenarios covering all decision types, context snapshot validation, error handling, and tree structure tracking. ISSUES CLOSED: #8522	2026-05-08 06:24:23 +00:00
HAL9000	85473d894d	ci: retrigger CI after docker infrastructure recovery	2026-05-08 06:09:11 +00:00
HAL9000	253768f886	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... Pass connect_args={'check_same_thread': False} when creating the SQLite engine in get_current_revision(), consistent with init_or_upgrade() which already does this for all SQLite engines. Without this flag, calling get_current_revision() from a thread other than the one that created the engine raises a ProgrammingError. Add a Behave scenario to verify the connect_args are passed correctly. ISSUES CLOSED: #10952	2026-05-08 06:09:11 +00:00
HAL9000	241c2602b0	fix(quality-gates): resolve ruff formatting and missing type annotations ... Fix two lint blockers identified in PR review: 1. Collapsible list comprehension format (ruff RUF015): Collapse the "projects" list comprehension in _build_strategize_context_snapshot() from 3 lines to a single line within the 88-character limit. 2. Missing type annotations on 13 new BDD step functions: All existing step functions use explicit `context: Context` and `-> None` return type annotations per project style. The 13 new step functions added for issue #9056 were missing these declarations, causing lint warning RUF012 (missing type annotations on function arguments). Verified: - nox -s lint passes (ruff check + ruff format --check) - nox -s typecheck passes (pyright 0 errors) - Pre-existing unit_tests/CI timeouts are infrastructure-related ISSUES CLOSED: #9056	2026-05-08 05:14:03 +00:00
HAL9000	8ed8c25652	fix(plan-lifecycle): record full context snapshots in Strategize phase ... The Strategize phase was recording decisions with minimal context snapshots (only a hash of question+chosen_option), violating the v3.2.0 acceptance criterion that decisions must include full context snapshots sufficient to replay the decision. Changes: - Add _build_strategize_context_snapshot() helper that builds a full ContextSnapshot from plan metadata (description, action_name, strategy_actor, project_links) - Update _try_record_decision() to accept an optional context_snapshot parameter and forward it to DecisionService - Update start_strategize() to build and pass a full context snapshot - Add 3 BDD scenarios in decision_recording.feature verifying that hot_context_hash, hot_context_ref, actor_state_ref, and relevant_resources are all populated for Strategize-phase decisions ISSUES CLOSED: #9056	2026-05-08 05:11:47 +00:00
HAL9000	0ce2e14f2d	style: fix ruff format violations in devcontainer_autodiscovery_wiring_steps.py ... Apply ruff auto-format to resolve CI lint failure: long lines in subprocess.run() calls and list comprehensions were not wrapped to the project's line-length limit.	2026-05-07 23:49:20 +00:00
HAL9000	3d7afb4378	fix(resource): wire discover_devcontainers() into git-checkout and fs-directory handlers ... GitCheckoutHandler.discover_children() and FsDirectoryHandler.discover_children() now call discover_devcontainers() after scanning for fs-directory children. Any .devcontainer/devcontainer.json or root-level .devcontainer.json found at the resource location is registered as a devcontainer-instance child resource with provisioning_state: discovered. Named configurations are also discovered and carry the configuration name in the config_name property. This wires the previously-isolated discover_devcontainers() function into the production code path, enabling the spec's zero-configuration devcontainer experience. ISSUES CLOSED: #4740	2026-05-07 23:49:20 +00:00
Luis Mendes	15e72b8407	fix(events): log full exception details in ReactiveEventBus.emit() error handler ... Add exc_info=True to the _logger.warning() call in the per-handler exception block of ReactiveEventBus.emit(). The handler already logged error=str(exc) (the exception message text), but omitted the traceback. With exc_info=True structlog now forwards the full traceback to the configured log output, giving developers the diagnostic detail needed to debug subscriber failures in production. Remove the @tdd_expected_fail tag from the traceback scenario in features/tdd_event_bus_exception_swallow.feature so that both TDD scenarios (#988) run as normal regression guards. Fix TDD tags in robot/tdd_e2e_implicit_init.robot: replace incorrect tdd_bug/tdd_bug_1023 tags with the canonical tdd_issue/tdd_issue_1023/ tdd_expected_fail tags so the tdd_expected_fail_listener properly inverts results while bug #1023 remains open. ISSUES CLOSED: #988	2026-05-07 23:39:08 +01:00
Dev User	23e9848f95	fix(cli): make actor NAME argument optional, derive from YAML config ... Implement NAME argument as optional with derivation from config file when not provided. Changes: - actor.py: NAME argument changed from required 'str' to optional 'str | None = None' - Added help text explaining NAME can be omitted and derived from config - Added logic to derive name from config_blob.get('name') when name arg is None - Raises BadParameter if neither name argument nor config 'name' field is provided - Updated docstring signature to reflect optional NAME: 'agents actor add [--config|-c <FILE>] [<NAME>]' - Updated examples to show config-only usage ISSUES CLOSED: #4186	2026-05-07 20:05:33 +00:00
CoreRasurae	d47d560a2e	test(behave): Fix failing tests after rebase on master	2026-05-07 20:05:33 +00:00
CoreRasurae	ac84f314ff	test(behave): Fix concurrent BDD tests failures	2026-05-07 20:05:33 +00:00
CoreRasurae	272821028f	test(behave): Remove tdd_expected fail for issue #2609 ... Issue is already implemented in master via commits b6959aeff and 491781714	2026-05-07 20:05:33 +00:00
Dev User	6b5568af1d	fix(tests): update PlanModel step texts to match renamed base step ... The base step 'I create a plan in strategize phase' was renamed to 'I create a PlanModel in strategize phase' to avoid AmbiguousStep collision. This commit updates compound step definitions that use the base step: - 'I create a plan in strategize phase with errored state' - 'I create a plan in strategize phase with processing state' - 'I create a plan in strategize phase with cancelled state'	2026-05-07 20:05:33 +00:00
Dev User	a3ba3c3eaf	fix(tests): resolve pre-existing AmbiguousStep collisions in step definitions ... Rename step texts to avoid case-sensitive conflicts between different step modules: - edge_case_plan_steps.py: 'a Pydantic validation error' -> 'an Edge Case Pydantic validation error' - plan_executor_coverage_boost_steps.py: 'the rollback result should be False' -> 'the executor rollback result should be False' - plan_explain_steps.py: 'the json output should be valid json' -> 'the plan explain json output should be valid' - plan_model_steps.py: 'I create a plan in strategize phase' -> 'I create a PlanModel in strategize phase' - project_repository_steps.py: 'the remove result should be False' -> 'the project repo remove result should be False' - service_retry_wiring_steps.py: 'I create a ServiceRetryWiring from those Settings' -> 'I create a ServiceRetryWiring from those retry Settings' - session_model_steps.py: 'I get the session CLI dict' -> 'I get the session model CLI dict' These pre-existing bugs prevented all behave tests from loading.	2026-05-07 20:05:33 +00:00
HAL9000	d4ebb482e1	style(tests): fix ruff format violation in TDD step file ... Collapse multi-line @then decorator onto a single line in tdd_session_create_suppress_exception_steps.py to satisfy ruff format --check (the CI lint job runs both ruff check and ruff format --check).	2026-05-07 19:14:53 +00:00
HAL9000	08422b4ded	fix(cli): log suppressed facade dispatch exceptions in session create ... Replace __import__("datetime") with proper top-level import per project Python import rules. This resolves the CI lint failure blocking PR #10898. Closes #10433 Refs: #10414 #10898	2026-05-07 19:14:53 +00:00
HAL9000	2d519182ca	fix(cli): log suppressed facade dispatch exceptions in session create ... Replace the silent contextlib.suppress(Exception) block in the session create command with a try/except that logs at WARNING level with exc_info. Previously, any exception raised by _facade_dispatch() during session creation was silently discarded with no logging, making it impossible to diagnose failures in the facade layer (e.g. A2A bootstrap unavailable, programming errors, infrastructure issues). The fix keeps session creation non-fatal (the session is already persisted before the facade call) while ensuring the exception is visible in logs: try: _facade_dispatch(session.create, {...}) except Exception as _exc: _log.warning( session_create_facade_dispatch_failed, extra={"session_id": ..., "error": str(_exc)}, exc_info=True, ) Also includes the TDD regression test from issue #10414 (PR #10749) with @tdd_expected_fail removed, since the fix is now applied. The test verifies that a WARNING log entry is emitted when _facade_dispatch() raises and that session creation still exits 0. ISSUES CLOSED: #10433	2026-05-07 19:14:53 +00:00
HAL9000	94dd77fbcd	fix(application): Complete PR #9247 compliance — add CHANGELOG and CONTRIBUTORS entries ... - Add CHANGELOG.md entry under [Unreleased] Fixed section for error suppression removal (issue #9060) - Update CONTRIBUTORS.md with HAL 9000 contribution note for this fix - Branch: bugfix/m-error-suppression-reactive-registry-adapter-v2 ISSUES CLOSED: #9060	2026-05-07 14:51:35 +00:00
HAL9000	2778bde95a	fix(repositories): derive PlanResult.success from result_success column instead of error_message ... ISSUES CLOSED: #7501	2026-05-07 14:22:57 +00:00
hurui200320	bef7f3175b	fix(tests): resolve integration test failures in behave parallel log filtering ... Fix the integration test helper so that it can load scripts/run_behave_parallel.py outside of nox sessions. The helper imports the runner module via importlib, which triggers the top-level from behave_pass_suppress_formatter import PassSuppressFormatter. When invoked from integration tests (or any non-nox context), neither behave_pass_suppress_formatter nor the behave_parallel package (created by noxfile.py for unit_tests) is on sys.path, causing a ModuleNotFoundError and all 6 Robot tests to fail with exit code 1. The fix adds scripts/ to sys.path before loading the runner module so that from behave_pass_suppress_formatter import PassSuppressFormatter resolves correctly. This mirrors the approach already used in noxfile.py's unit_tests session for the behave-parallel package. Also addresses review feedback: - Removes one blank line from scripts/run_behave_parallel.py to bring it to 499 lines, satisfying the project's <500-line code style rule. - Moves in-function behave imports (Configuration, StreamOpener) in features/steps/behave_parallel_log_filtering_steps.py to the top-level import block alongside the existing behave imports, complying with the project's rule that all imports must be at the top of the file. Refs: #10987	2026-05-07 18:09:26 +08:00
hurui200320	4fe87d9eec	fix(tests): resolve pre-existing unit test failures in 5 feature files ... Fix five pre-existing BDD test failures that were present on master before PR #10988 was opened: 1. **architecture.feature** — Converted `IndexEntry` from `@dataclass` to Pydantic `BaseModel` and `ACMSIndex` to a plain class so the "all dataclasses should use Pydantic models" check passes. 2. **pr_compliance_checklist.feature** — Fixed `PROJECT_ROOT` path resolution from `parents[3]` to `parents[2]` so the agent definition file at `.opencode/agents/implementation-supervisor.md` is located correctly within the `/app` workspace. 3. **acms/index_data_model_and_traversal.feature** — Added missing Gherkin table header rows (`| key | value |` and `| filter | value |`) to the "Create an index entry" and "Combined query with multiple filters" scenarios so behave correctly resolves column references. 4. **cli_init_yes_flag.feature** — Added a `getattr` guard around `context.temp_dir` in `_restore_cwd()` so cleanup does not crash with a `TypeError` when `temp_dir` was never assigned. 5. **security_audit.feature** — Renamed the ACMS step from "the count should be {count:d}" to "the ACMS entry count should be {count:d}" to resolve a step ambiguity where ACMS's `step_check_entry_count_value` shadowed security_audit's `step_count_is`, causing `AttributeError` on `context.entry_count` for audit scenarios. These failures are pre-existing on master and are independent of the PassSuppressFormatter feature in the preceding commit. They are fixed in a separate commit to maintain commit atomicity — the feature commit remains solely about the output suppression change. Refs: #10987	2026-05-07 18:09:25 +08:00
hurui200320	49f1cfcdb6	chore(tests): suppress passing scenario output by default in behave-parallel unit test runner ... Implemented PassSuppressFormatter, a custom Behave formatter that buffers per-scenario output and only flushes it to stdout when the scenario failed or errored. Passing scenarios produce no output, keeping an all-passing suite at ~5-10 lines (the _print_overall_summary block only). Key design decisions: - PassSuppressFormatter (in scripts/behave_pass_suppress_formatter.py) inherits from behave's Formatter base class so it can be registered via behave.formatter._registry.register_as(), which enforces issubclass(cls, Formatter). - _SUPPRESS_STATUSES = {'passed', 'skipped'} determines which terminal statuses are silently discarded; all others (failed, undefined, etc.) trigger a buffer flush so no failure is hidden. - _make_runner() in run_behave_parallel.py registers the formatter and sets it as the default format whenever config.format is None (no explicit -f/--format flag). Coverage mode (BEHAVE_PARALLEL_COVERAGE=1) bypasses the formatter and falls back to config.default_format so slipcover can instrument a single process. - The formatter lives in a separate file to keep both scripts under the 500-line limit. _install_behave_parallel() in noxfile.py copies both files into the behave_parallel package. A try/except import handles both the direct-script path (tests via importlib) and the installed- package path (nox CI). - Three new BDD scenarios in behave_parallel_log_filtering.feature cover: (1) passing scenario -> no output, (2) failing scenario -> full output, (3) mixed run -> only failing scenario visible. All 20 scenarios pass. ISSUES CLOSED: #10987	2026-05-07 07:08:52 +00:00
HAL9000	f2d1f4efe7	docs: fix quickstart plan/apply command signatures ... Update docs/quickstart.md to use correct CLI command signatures: - Replace 'cleveragents plan --project' with 'cleveragents plan use <action> --project' - Replace 'cleveragents apply --project' with 'cleveragents plan list' + 'cleveragents plan apply <plan-id>' Addresses reviewer non-blocking suggestion to verify CLI commands match actual signatures before merging.	2026-05-06 04:29:40 +00:00
HAL9000	54fef4768c	docs: add quick start guide (PR #9245) ... Add docs/quickstart.md with end-to-end quick start guide covering prerequisites, installation, project creation, resource registration, plan/apply workflow, and troubleshooting. Update mkdocs.yml navigation to include Quick Start page and rename ADR-028 title to Skill/Tool Abstraction Definition. Update CHANGELOG.md with quick start guide entry. Closes #9245	2026-05-06 04:29:40 +00:00
HAL9000	0461f8e51f	fix(actor): remove type: ignore from subgraph cycle detection steps ... Remove # type: ignore[import-untyped] suppression comments from features/steps/actor_subgraph_cycle_detection_steps.py per CONTRIBUTING.md zero-tolerance policy on inline type suppressions. Pyright does not check the features/ directory so these suppressions were unnecessary and violated project policy.	2026-05-06 04:08:25 +00:00
HAL9000	5db663cb63	fix(actor): read actor_ref from NodeDefinition field in _detect_subgraph_cycles ... Fix cross-actor subgraph cycle detection in the actor compiler by reading actor_ref from the top-level NodeDefinition field instead of the config dict. The _detect_subgraph_cycles(), _map_node(), and compile_actor() functions were all reading node.config.get("actor_ref", "") instead of node.actor_ref. Because actor_ref is a typed, validated Pydantic field on NodeDefinition (not a key inside the untyped config dict), the old code always returned an empty string, causing cross-actor cycle detection to silently fail and leaving the system vulnerable to infinite recursion at runtime. Changes: - Fix all three call sites in src/cleveragents/actor/compiler.py - Add Behave regression tests (features/actor_subgraph_cycle_detection.feature) with @tdd_issue and @tdd_issue_1431 tags on all scenarios - Add Robot Framework integration test (robot/actor_compiler.robot) - Fix existing test helpers to use actor_ref as top-level field - Add CHANGELOG entry ISSUES CLOSED: #1431	2026-05-06 04:08:25 +00:00
HAL9000	ad31e75af6	fix(cli): address reviewer feedback on actor remove --format option ... - Validate --format argument before any side effects; raise typer.BadParameter with a clear message for unsupported format values (fail-fast principle) - Pass normalised fmt_value (lowercased) to format_output instead of raw fmt to ensure consistent behaviour regardless of input casing - Rewrite robot/helper_actor_remove_cli.py to exercise the real CLI end-to-end via subprocess (no mocking); seeds a test actor via agents actor add, then removes it with --format json and validates the JSON envelope ISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	8384f53e28	test(cli): cover actor remove format regression (#6491) ... Add Robot regression coverage for `actor remove --format json`, document the flag in the CLI synopsis, and record the fix in the changelog.\n\nISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	defa04d56d	fix(cli): add --format option to actor remove command (#6491) ... ISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	50d7b02850	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... - Fix extra blank line in step file causing lint failure (ruff E302) - Consolidate duplicate step_when_capture_engine_args and step_when_verify_thread_safe_args into a shared _run_get_current_revision_and_capture_kwargs() helper - Remove duplicate Scenario 3 (identical assertion to Scenario 1, different step impl) - Unify context attribute name to engine_creation_kwargs across all steps - Add explicit type annotations to all step function signatures	2026-05-05 17:48:39 +00:00
HAL9000	89a6817e95	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... MigrationRunner.get_current_revision() was creating a SQLAlchemy engine with create_engine(self.database_url) without passing connect_args={"check_same_thread": False} for SQLite databases. When called from a background thread (e.g. async startup flows), SQLite raised ProgrammingError: SQLite objects created in a thread can only be used in that same thread. The sibling method init_or_upgrade() already passes check_same_thread=False for SQLite, making this an inconsistency in the same class. Because get_pending_migrations() and check_migrations_needed() both delegate to get_current_revision(), the threading bug propagated to all three methods. This fix adds connect_args={"check_same_thread": False} to the create_engine() call in get_current_revision() when the database URL starts with "sqlite", consistent with the existing pattern in init_or_upgrade(). ISSUES CLOSED: #10507	2026-05-05 17:48:39 +00:00
HAL9000	741186cbfb	docs: add ACMS Index Data Model contribution to CONTRIBUTORS.md	2026-05-05 17:48:37 +00:00
HAL9000	b846ab5cd7	fix(acms): rebase ACMS index data model onto master to fix unit test failures ... Rebases the ACMS index data model and file traversal engine implementation onto the current master branch to resolve merge conflicts and fix unit test failures caused by the PR branch being 321 commits behind master. All ACMS-specific changes are preserved: - src/cleveragents/acms/index.py: ACMS index data model with hot/warm/cold/archive tiers - src/cleveragents/acms/__init__.py: Updated exports - features/acms/index_data_model_and_traversal.feature: BDD feature file - features/steps/acms_index_data_model_traversal_steps.py: Step definitions - features/environment.py: Added temp_dir cleanup hook - CHANGELOG.md: ACMS entry preserved ISSUES CLOSED: #9579	2026-05-05 17:48:37 +00:00
HAL9000	1a7cead619	Merge pull request 'fix(agents): add mandatory PR compliance checklist to implementation-pool-supervisor' (#10071) from bugfix/m3-evlv-implementation-pool-compliance-checklist into master	2026-05-05 17:48:32 +00:00
HAL9000	44f9abe5d1	style(test): use PROJECT_ROOT constant for clearer path resolution in pr_compliance_checklist_steps ... Applies reviewer suggestion from PR #10071 review #7500 (comment #249234): replace chained .parent calls with a named PROJECT_ROOT constant for improved readability and maintainability. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00