fix(quality-gates): resolve ruff formatting and missing type annotations

Fix two lint blockers identified in PR review:

1. Collapsible list comprehension format (ruff RUF015): Collapse the
   "projects" list comprehension in _build_strategize_context_snapshot()
   from 3 lines to a single line within the 88-character limit.

2. Missing type annotations on 13 new BDD step functions: All existing
   step functions use explicit `context: Context` and `-> None` return
   type annotations per project style. The 13 new step functions added
   for issue #9056 were missing these declarations, causing lint
   warning RUF012 (missing type annotations on function arguments).

Verified:
- nox -s lint passes (ruff check + ruff format --check)
- nox -s typecheck passes (pyright 0 errors)
- Pre-existing unit_tests/CI timeouts are infrastructure-related

ISSUES CLOSED: #9056

features/steps/decision_recording_steps.py

@@ -1113,7 +1113,7 @@ def step_duplicate_error_raised(context: Context) -> None:
 
 
 @given("a plan lifecycle service with decision service wired")
-def step_lifecycle_with_decision_service(context):
+def step_lifecycle_with_decision_service(context: Context) -> None:
     """Create a PlanLifecycleService with a real DecisionService wired in."""
     from cleveragents.application.services.decision_service import DecisionService
     from cleveragents.application.services.plan_lifecycle_service import (
@@ -1134,7 +1134,7 @@ def step_lifecycle_with_decision_service(context):
 
 
 @given('an action "{action_name}" for strategize snapshot test')
-def step_create_action_for_snapshot_test(context, action_name):
+def step_create_action_for_snapshot_test(context: Context, action_name: str) -> None:
     """Create an action for the strategize snapshot test."""
     context.snapshot_action_name = action_name
     context.snapshot_lifecycle_service.create_action(
@@ -1147,7 +1147,9 @@ def step_create_action_for_snapshot_test(context, action_name):
 
 
 @given('a plan created from "{action_name}" with project "{project_name}"')
-def step_create_plan_with_project(context, action_name, project_name):
+def step_create_plan_with_project(
+    context: Context, action_name: str, project_name: str
+) -> None:
     """Create a plan from the given action with a project link."""
     from cleveragents.domain.models.core.plan import ProjectLink
 
@@ -1158,7 +1160,7 @@ def step_create_plan_with_project(context, action_name, project_name):
 
 
 @given('a plan created from "{action_name}" without projects')
-def step_create_plan_without_projects(context, action_name):
+def step_create_plan_without_projects(context: Context, action_name: str) -> None:
     """Create a plan from the given action without any project links."""
     context.snapshot_plan = context.snapshot_lifecycle_service.use_action(
         action_name=action_name,
@@ -1167,7 +1169,7 @@ def step_create_plan_without_projects(context, action_name):
 
 
 @when("I start strategize for the snapshot test plan")
-def step_start_strategize_snapshot_test(context):
+def step_start_strategize_snapshot_test(context: Context) -> None:
     """Start strategize and capture the recorded decision."""
     plan_id = context.snapshot_plan.identity.plan_id
     context.snapshot_lifecycle_service.start_strategize(plan_id)
@@ -1182,21 +1184,21 @@ def step_start_strategize_snapshot_test(context):
 
 
 @then("the strategize decision should have a non-empty hot_context_hash")
-def step_check_snapshot_hash_not_empty(context):
+def step_check_snapshot_hash_not_empty(context: Context) -> None:
     """Verify the context snapshot hash is not empty."""
     snapshot = context.snapshot_decision.context_snapshot
     assert snapshot.hot_context_hash, "hot_context_hash should not be empty"
 
 
 @then("the strategize decision should have a non-empty hot_context_ref")
-def step_check_snapshot_ref_not_empty(context):
+def step_check_snapshot_ref_not_empty(context: Context) -> None:
     """Verify the context snapshot ref is not empty."""
     snapshot = context.snapshot_decision.context_snapshot
     assert snapshot.hot_context_ref, "hot_context_ref should not be empty"
 
 
 @then('the strategize decision hot_context_ref should start with "{prefix}"')
-def step_check_snapshot_ref_prefix(context, prefix):
+def step_check_snapshot_ref_prefix(context: Context, prefix: str) -> None:
     """Verify the context snapshot ref starts with the expected prefix."""
     snapshot = context.snapshot_decision.context_snapshot
     assert snapshot.hot_context_ref.startswith(prefix), (
@@ -1205,21 +1207,23 @@ def step_check_snapshot_ref_prefix(context, prefix):
 
 
 @then("the strategize decision should have a non-empty actor_state_ref")
-def step_check_snapshot_actor_ref_not_empty(context):
+def step_check_snapshot_actor_ref_not_empty(context: Context) -> None:
     """Verify the actor_state_ref is not empty."""
     snapshot = context.snapshot_decision.context_snapshot
     assert snapshot.actor_state_ref, "actor_state_ref should not be empty"
 
 
 @then("the strategize decision should have relevant_resources populated")
-def step_check_snapshot_resources_populated(context):
+def step_check_snapshot_resources_populated(context: Context) -> None:
     """Verify relevant_resources is not empty."""
     snapshot = context.snapshot_decision.context_snapshot
-    assert len(snapshot.relevant_resources) > 0, "relevant_resources should not be empty"
+    assert len(snapshot.relevant_resources) > 0, (
+        "relevant_resources should not be empty"
+    )
 
 
 @then('the strategize decision hot_context_hash should start with "{prefix}"')
-def step_check_snapshot_hash_prefix(context, prefix):
+def step_check_snapshot_hash_prefix(context: Context, prefix: str) -> None:
     """Verify the context snapshot hash starts with the expected prefix."""
     snapshot = context.snapshot_decision.context_snapshot
     assert snapshot.hot_context_hash.startswith(prefix), (
@@ -1228,7 +1232,7 @@ def step_check_snapshot_hash_prefix(context, prefix):
 
 
 @then("the strategize decision hot_context_hash should be {length:d} characters long")
-def step_check_snapshot_hash_length(context, length):
+def step_check_snapshot_hash_length(context: Context, length: int) -> None:
     """Verify the context snapshot hash has the expected length."""
     snapshot = context.snapshot_decision.context_snapshot
     actual_length = len(snapshot.hot_context_hash)
@@ -1238,7 +1242,7 @@ def step_check_snapshot_hash_length(context, length):
 
 
 @then("the strategize decision should have empty relevant_resources")
-def step_check_snapshot_resources_empty(context):
+def step_check_snapshot_resources_empty(context: Context) -> None:
     """Verify relevant_resources is empty."""
     snapshot = context.snapshot_decision.context_snapshot
     assert len(snapshot.relevant_resources) == 0, (

src/cleveragents/application/services/plan_lifecycle_service.py

@@ -1459,10 +1459,7 @@ class PlanLifecycleService:
             "action_name": plan.action_name,
             "description": plan.description or "",
             "strategy_actor": plan.strategy_actor or "",
-            "projects": [
-                pl.project_name
-                for pl in plan.project_links
-            ],
+            "projects": [pl.project_name for pl in plan.project_links],
         }
         context_json = json.dumps(hot_context, sort_keys=True)
         context_hash = hashlib.sha256(context_json.encode()).hexdigest()