271 Commits

Author	SHA1	Message	Date
freemo	4aa236b7df	feat: implement tier selector architecture for escalation without redundancy ... BREAKING CHANGE: New escalation architecture eliminates duplicate agent code Key changes: - Add tier selector agents (tier-haiku, tier-codex, tier-sonnet, tier-opus) that set the model and invoke worker agents - Create model-agnostic implementer.md that inherits model from caller - Update unit-test-runner and typecheck-fixer to support escalation - Add quality-gate-escalator to manage escalation for quality fixers - Create subtask-loop-v2.md demonstrating the new architecture - Document the new architecture in escalation-architecture-proposal.md Benefits: - Eliminates 90% code duplication across tier-specific agents - Single source of truth for implementation logic - Easy to add new tiers or modify escalation paths - Consistent behavior across all model tiers - Quality gate fixers now support full escalation starting from haiku The architecture leverages the fact that agents without a model specification inherit the model from their caller, allowing thin tier selectors to control which model executes the actual work.	2026-04-06 21:26:20 +00:00
freemo	76333cf640	refactor: optimize agent models for cost reduction ... - Change human-liaison from opus to sonnet (still needs complex reasoning) - Change issue-analyzer from sonnet to haiku (text parsing task) - Change lint-fixer from sonnet to haiku (pattern-based fixes) - Change pr-description-writer from sonnet to haiku (template-based writing) - Change issue-note-writer from sonnet to haiku (documentation formatting) These changes reduce costs by 60-80% for high-frequency mechanical tasks while maintaining quality through the escalation system for edge cases.	2026-04-06 21:19:50 +00:00
freemo	58b1e50410	feat: add 4-tier escalation system with Haiku bottom tier ... - Add implementer-haiku.md as ultra-fast, cost-effective first tier - Add behave-tester-haiku.md and robot-tester-haiku.md for fast testing - Update difficulty-evaluator.md to assess 4 tiers (haiku/codex/sonnet/opus) - Update subtask-loop.md with 4-tier escalation logic and state persistence - Add PR comment state tracking for escalation recovery after restarts - Conservative evaluator defaults to Haiku when in doubt for cost efficiency - New escalation path: haiku → haiku → codex → sonnet → opus (forever) - Includes state persistence to resume from correct tier after agent restarts	2026-04-06 21:03:50 +00:00
freemo	4591ae053d	feat(agents): remove ca- prefix to make agents generic ... - Rename 72 agent files: ca-{name}.md → {name}.md - Update all agent references across 76 files: - Permission blocks: "ca-agent": allow → "agent": allow - Invocations: invoke ca-agent → invoke agent - Bot signatures: Agent: ca-agent → Agent: agent - Temporary paths: /tmp/ca-* → /tmp/* - Clone directories: /tmp/ca-{id} → /tmp/{id} - Preserve CleverAgents references (190 legitimate uses) - All agents now have generic names suitable for any project - Zero broken references remaining	2026-04-06 16:43:49 -04:00
freemo	b4a36bb377	fix(agents): correct Anthropic model names to include version suffixes ... - Revert claude-opus-4 → claude-opus-4-6 (15 agents) - Revert claude-sonnet-4 → claude-sonnet-4-6 (30 agents) - Original model names with -4-6 suffix were correct - Keeps openai/gpt-5-codex, openai/gpt-5-nano, google/gemini-2.5-pro unchanged	2026-04-06 20:25:08 +00:00
freemo	e30f511bb7	fix(agents): change Gemini model from 3.1-pro to 2.5-pro ... - Update google/gemini-3.1-pro → google/gemini-2.5-pro (5 agents) - Affected agents: ca-architecture-guard, ca-bug-hunter, ca-ref-reader, ca-spec-reader, ca-test-infra-improver - Maintains large context capability for documentation and analysis tasks	2026-04-06 20:18:16 +00:00
freemo	8c906c50b7	fix(agents): update all agent models to valid OpenCode models ... - Update claude-sonnet-4-6 → claude-sonnet-4 (30 agents) - Update claude-opus-4-6 → claude-opus-4 (15 agents) - Update claude-codex-4-20241022 → gpt-5-codex (14 agents) - Update gpt-5.1-codex → gpt-5-codex (3 agents) - Update gemini-2.5-pro → gemini-3.1-pro (5 agents) - Update claude-sonnet-4-0 → claude-sonnet-4 (1 agent) All 74 agents now use only valid models: claude-sonnet-4, claude-opus-4, gpt-5-codex, gpt-5-nano, gemini-3.1-pro. Model assignments preserve the existing capability/cost optimization strategy.	2026-04-06 20:16:54 +00:00
freemo	5d555bdedf	feat(agents): add specialized agents with strict CONTRIBUTING.md compliance ... - Add ca-opencode-editor.md for .opencode/ file editing with documentation links - Add ca-general-build.md as replacement for default build agent with mandatory doc review - Add ca-plan-agent.md as replacement for default plan agent with compliance checks - Update ca-human-liaison.md to strictly follow CODE_OF_CONDUCT.md and CONTRIBUTING.md - Update ca-implementer-sonnet.md with mandatory CONTRIBUTING.md compliance section All new agents explicitly require reading and following CONTRIBUTING.md and CODE_OF_CONDUCT.md before any actions, ensuring consistent adherence to project standards.	2026-04-06 20:14:18 +00:00
freemo	563bd2c247	fix(agents): correct mode field in fix-pr agent definition ... Changes mode from invalid "agent" to "primary" to match OpenCode's expected values: "subagent"|"primary"|"all". fix-pr is the main user entry point so "primary" mode is appropriate.	2026-04-06 19:48:17 +00:00
freemo	10f182b921	fix(agents): resolve configuration validation errors in agent definitions ... Fixes invalid hex color formats and missing YAML frontmatter that were causing OpenCode configuration validation failures. Color format fixes: - ca-repo-isolator: utility -> #6B7280 (gray-500) - ca-ci-log-fetcher: utility -> #6B7280 (gray-500) - ca-forgejo-signature-appender: utility -> #6B7280 (gray-500) - ca-ref-material-loader: utility -> #6B7280 (gray-500) - ca-async-agent-starter: system -> #DC2626 (red-600) - ca-async-agent-monitor: system -> #DC2626 (red-600) - ca-async-agent-cleanup: system -> #DC2626 (red-600) - ca-async-agent-cleanup-all: system -> #DC2626 (red-600) Missing frontmatter additions: - fix-pr: Added complete YAML metadata with green color (#059669) - ca-pr-status-checker: Added metadata with blue color (#3B82F6) - ca-git-commit-helper: Added metadata with emerald color (#10B981) - ca-issue-comment-formatter: Added metadata with violet color (#8B5CF6) All agent definitions now have proper OpenCode-compliant configuration with valid hex colors and complete YAML frontmatter sections.	2026-04-06 19:47:12 +00:00
freemo	477382ae31	feat(agents): add comprehensive set of 12 reusable subagents ... Implements a complete ecosystem of reusable subagents that eliminate code duplication across the CleverAgents system while providing major performance and maintainability improvements. Core Infrastructure (8 agents): - ca-ci-log-fetcher: Web-based CI log retrieval with session management - ca-repo-isolator: Safe repository isolation with security-focused design - ca-forgejo-signature-appender: Standardized bot signatures (3 formats) - ca-async-agent-starter: Tag-based async agent launching with restrictions - ca-async-agent-monitor: Health monitoring with automatic restart capability - ca-async-agent-cleanup: Single session cleanup with verification - ca-async-agent-cleanup-all: Mass cleanup with parallel execution - ca-ref-material-loader: Parent-child caching for O(1) performance gains Primary User Interface (1 agent): - fix-pr: Main entry point orchestrating all subagents for PR fixing Specialized Operations (3 agents): - ca-pr-status-checker: Comprehensive PR status analysis across CI/reviews/conflicts - ca-git-commit-helper: Safe commit operations with rollback capabilities - ca-issue-comment-formatter: Structured comment formatting with templates Key Benefits: - 80-95% performance improvement through parent-child caching model - Eliminates O(n) ca-ref-reader calls across 20+ existing agents - Tag-based session recovery for crash-proof async operations - Repository isolation with security-focused `/tmp/ca-isolated-*` pattern - Centralized async session management with strict localhost:4096 permissions - Professional communication with standardized comment formatting - Comprehensive error handling and rollback capabilities This establishes the foundation for scalable, maintainable agent operations while preserving all existing functionality and established behaviors.	2026-04-06 19:42:39 +00:00
freemo	8b44b265d1	refactor(agents): restructure implementation system for PR-first priority with cost-optimized escalation ... - Rename ca-issue-worker → ca-implementation-worker for dual-mode operation (PR fixing + issue implementation) - Rename issue-implementor → implementation-orchestrator with PR-first priority - Create new pr-fix-orchestrator for aggressive parallel PR fixing with common cause analysis - Update escalation order from sonnet→codex→opus to codex→sonnet→opus for better cost optimization - Update all implementer and tester agents to reflect new escalation tiers - Add web-based CI log access support since Forgejo Actions API returns 404s - Update all cross-references and bot signatures throughout codebase - Add CI_LOG_ACCESS_GUIDE.md with web authentication functions The system now prioritizes fixing failing PRs over implementing new issues, uses cost-effective escalation starting with codex, and supports aggressive parallel execution with intelligent root cause analysis.	2026-04-06 18:46:00 +00:00
freemo	e54818d5cb	feat: enhance UAT tester with automatic documentation generation ... Extend the UAT testing agents to capture successful test workflows and automatically generate showcase documentation demonstrating real-world usage of CleverAgents. Key features added: - Documentation generation when tests succeed end-to-end - Intelligent duplicate detection to avoid redundant examples - Categorization into cli-tools, api-clients, data-processing, testing-tools - Automatic PR creation for new documentation examples - Integration with existing UAT workflow without disruption Documentation structure: - New docs/showcase/ directory for real-world examples - Category-specific subdirectories with README guides - Example template for consistent formatting - JSON index for tracking and duplicate detection The UAT tester now serves dual purposes: 1. Finding bugs through comprehensive testing (existing behavior) 2. Generating high-quality documentation from successful test runs (new) This enables the system to build its own showcase of capabilities while performing regular quality assurance, providing valuable examples for users and demonstrating the system's practical applications.	2026-04-06 00:12:06 +00:00
freemo	51cd94dcd5	Fix supervisor monitoring with unique naming tags ... Implement unique naming tags for all supervisors and workers to enable proper monitoring and management by the product-builder agent. The previous generic [CA-AUTO] prefix made it impossible to distinguish between different supervisor types and count their workers accurately. Changes: - Pool supervisors now use specific tags (AUTO-IMP-SUP, AUTO-REV-SUP, etc.) - Workers use corresponding tags (AUTO-IMP, AUTO-REV, etc.) - Singleton supervisors use unique tags (AUTO-ARCH, AUTO-EPIC, etc.) - Product-builder can now count supervisors/workers by tag pattern - Added metadata mapping for reliable supervisor re-launching - Updated system-watchdog to recognize new tag patterns This enables the product-builder to detect zombie supervisors, verify worker counts, and re-launch failed supervisors reliably.	2026-04-05 23:00:43 +00:00
freemo	5fbe4bd533	fix(agents): Add proper CI verification to ca-issue-worker before merging PRs ... - Implemented missing all_checks_passing() function to query Forgejo API - Added CI status verification via commit status endpoint - Added safety warnings against using force_merge flag - Fixed documentation to reflect correct merge responsibilities - Added error handling to default to 'checks not passing' on API failures This ensures PRs cannot be merged when CI checks are failing, respecting branch protection rules and quality gates defined in CONTRIBUTING.md.	2026-04-05 17:40:29 -04:00
freemo	67b105b8f5	chore(agents): improve ca-subtask-loop — add meaningful-change verification ... Reviewed and APPROVED. Closes #2443.	2026-04-05 21:23:58 +00:00
freemo	f0e852680a	chore(agents): improve product-builder — prohibit direct PR merging ... Reviewed and APPROVED. Closes #2878.	2026-04-05 21:16:25 +00:00
freemo	201a33928e	chore(agents): improve implementer agents — verify domain model fields before referencing ... Reviewed and APPROVED. Closes #2879.	2026-04-05 21:15:00 +00:00
freemo	d747bfd7de	chore(agents): improve ca-bug-hunter — prevent false positive infrastructure bug reports ... Reviewed and APPROVED. Closes #1595.	2026-04-05 21:13:06 +00:00
freemo	3470d3c061	chore(agents): improve ca-test-infra-improver — prevent massive duplicate issue creation ... Reviewed and APPROVED. Closes #1802.	2026-04-05 21:09:53 +00:00
freemo	6a458e0dbb	chore(agents): add mandatory labels to supervisor tracking issue creation ... Reviewed and APPROVED. Closes #3070.	2026-04-05 21:08:29 +00:00
freemo	bd5238f705	fix(agents): add critical safeguards to issue-implementor PR-first priority logic ... Adds comprehensive bug prevention safeguards to the issue-implementor agent definition to prevent critical failure where PR priority gate logic was not correctly implemented, resulting in 37 PRs being incorrectly skipped. Changes made: - Added explicit warnings never to use `limit` parameter when fetching PRs - Added comprehensive logging during PR analysis with progress indicators - Added mandatory verification that total analyzed PRs equals total fetched - Added PR-first rule enforcement logging showing when issue work blocked/allowed - Added error detection for violations of absolute PR priority rule - Added historical bug documentation section with prevention measures This ensures future instances will: - Always fetch ALL open PRs (never use sampling/limits) - Log verification counts during analysis - Explicitly enforce the absolute PR-first priority rule - Detect and report any violations of the priority rule The bug caused the supervisor to incorrectly conclude "no PRs need work" when 37 out of 50 open PRs actually required automated attention, violating the fundamental PR-FIRST rule that blocks all issue work until every PR has an active worker. ISSUES CLOSED: #3377	2026-04-05 15:50:37 -04:00
freemo	88cfc33ab2	Fix critical coordination bugs in implementation pool supervisor ... - Fix session adoption logic with correct title patterns for both worker-issue-impl and worker-pr-fix sessions - Add PR worker adoption to coordinate orphaned PR fix workers - Enhance worker verification with comprehensive status checking, retry logic, and proper error handling - Add defensive programming with worker count enforcement and state validation to prevent coordination drift - Improve JSON parsing with safe error handling throughout - Add periodic maintenance cycle (every 5 iterations) for worker state validation and limit enforcement These fixes resolve the core issue where the implementation pool supervisor was not properly coordinating 40+ existing workers, causing worker count to exceed the designed limit of 32.	2026-04-05 19:17:35 +00:00
freemo	1bd0c7999d	fix(agents): Fix worker management, PR priority, and bot approval requirements ... Fixed three critical issues in the CleverAgents autonomous system: 1. Worker Management: Enhanced issue-implementor health signaling to report detailed worker listings with session IDs and status. Added worker verification after dispatch to ensure workers actually start. Improved idle detection with aggressive work discovery when capacity is available. 2. PR Priority: Fixed PR work detection to include orphaned PRs from completed issues. Added absolute PR priority enforcement that blocks all issue work when any PR needs attention. Fixed worker dispatch prompts to clearly indicate operation mode (pr-fix vs issue-impl). 3. Bot Approval Requirements: Implemented single approval merging for bot PRs. Bot PRs (containing 'Automated by CleverAgents Bot') now merge with 1 approval while human PRs still require 2 per CONTRIBUTING.md. Updated branch protection to required_approvals: 1 with logic in agents to enforce the distinction. Added detection for approved-but-stuck PRs. These changes ensure the system operates at maximum efficiency with proper parallelism while maintaining quality gates through CI and code review.	2026-04-05 14:20:40 -04:00
freemo	642eb276a8	chore(agents): add mandatory labels to supervisor tracking issue creation ... Add label requirements to all 16 supervisor launch prompts in product-builder.md so that any tracking issues created by supervisors include the required Type/Automation, State/In Progress, and Priority/Medium labels from creation. This eliminates the persistent label compliance gap reported by the system watchdog, where supervisor-created tracking issues consistently missed required State/ and Priority/ labels. ISSUES CLOSED: #3070	2026-04-05 17:54:12 +00:00
freemo	f945e15572	fix(agents): Fix issue-implementor supervisor to properly manage N parallel workers ... The issue-implementor supervisor was defining but not using its worker dispatch logic, causing it to run only 1 worker at a time instead of the configured N parallel workers. This fix implements proper pool supervision: - Implement sliding window dispatch pattern to maintain N active workers - Use curl with prompt_async for asynchronous worker launches - Track PR workers and issue workers separately with proper monitoring - Add explicit worker count reporting in health signals (X/Y format) - Integrate PR priority gate - no new issues until all PRs have workers - Fix session monitoring and cleanup for completed/failed workers - Update product-builder heartbeat to show worker pool status The supervisor now continuously fills empty worker slots for maximum throughput, properly managing up to CA_MAX_PARALLEL_WORKERS parallel workers as designed. ISSUES CLOSED: #1	2026-04-05 16:50:47 +00:00
freemo	67b48ee817	feat!: restructure PR workflow to keep implementors accountable through merge ... BREAKING CHANGE: This completely changes how PRs are handled in the system. Implementors now own their work from creation through merge, and reviewers focus solely on code quality assessment. Major changes: - issue-implementor: Adds absolute PR prioritization - no new issues until all PRs have workers. Dispatches workers in two modes: 'pr-fix' for existing PRs and 'issue-impl' for new issues. - ca-issue-worker: Now operates in dual mode. In 'pr-fix' mode, handles review feedback, CI fixes, and merging. In 'issue-impl' mode, no longer exits after PR creation - monitors the PR until merged. - ca-continuous-pr-reviewer: Simplified to ONLY dispatch code reviewers. Removed all fix, merge, and lifecycle management. Uses dynamic review focus areas to catch different types of issues. - ca-pr-self-reviewer: Removed ALL capabilities beyond code review. No longer fixes issues, merges PRs, or manages issue states. Provides actionable feedback using rotating focus areas. - ca-pr-checker: Clarified that it should only be invoked by ca-issue-worker, not by reviewers. Benefits: - No PR backlogs (absolute priority over new issues) - Full accountability (creator owns through merge) - Better reviews (focused on quality, not mechanics) - Context preservation (no handoffs between agents) - Cleaner history (amendments instead of fix commits) This ensures implementors are accountable for their work while reviewers provide high-quality, focused code reviews without operational overhead.	2026-04-05 16:10:01 +00:00
freemo	a887712473	fix(agents): reduce health signal spam, add story point estimation, and improve supervisor monitoring ... - Health Signal Frequency: Fixed spam from ca-test-infra-improver, ca-bug-hunter, and ca-uat-tester by changing health signals from every 2-10 cycles to every 60 cycles (~10 min intervals) - Story Point Assignment: Added automatic story point estimation to ca-project-owner and ca-human-liaison during issue verification based on subtask count and complexity (XS:1, S:2, M:3, L:5, XL:8, XXL:13) - Deep Supervisor Inspection: Enhanced product-builder to check pool supervisors every 5 heartbeats for actual worker activity, detecting zombie supervisors that are running but not dispatching workers - Watchdog Integration: Added watchdog alert monitoring to product-builder that checks for critical alerts every 3 heartbeats and takes action based on severity - Alert Format Standardization: Updated ca-system-watchdog to use structured key-value alert format for easier parsing by product-builder Fixes issues with excessive Forgejo API usage, missing story point assignments during triage, and improves overall system reliability through better monitoring.	2026-04-05 15:32:04 +00:00
freemo	cce207a7bb	fix: improve agent coordination with PR prioritization and unified status tracking ... This commit addresses two critical issues in the CleverAgents autonomous system: 1. Pull Request Bottleneck: - Added PR prioritization gate to issue-implementor that checks for open PRs before taking new issues - Implementation pool now pauses new issue work when PRs need attention (failing CI, awaiting review, stale) - Re-checks PR status every 5 cycles to ensure PRs don't accumulate - Posts clear status updates explaining why new work is paused 2. Status Issue Proliferation: - Product-builder now creates ONE canonical session state issue: '[Automated] CleverAgents Build Session - <date>' - All 16 supervisors receive the session state issue number and post ALL status updates there - Removed separate tracking issue creation from ca-uat-tester and other agents - Standardized health signal format across all agents for consistent monitoring The standardized health signal format enables system-watchdog to: - Detect zombie supervisors from a single issue - Monitor active workers per pool - Track work progress across all agents - Identify stuck or inactive agents Modified agents: - issue-implementor: Added PR prioritization gate - product-builder: Single session state issue management - All pool supervisors: Updated to use session state issue - All agents: Standardized health signal format These changes ensure PRs get merged quickly and reduce issue tracker noise.	2026-04-05 14:54:22 +00:00
freemo	03e5403374	chore(agents): add auto-rebase on conflict to PR reviewer pool ... Agent evolver identified a systematic pattern: - Pattern: Dead-end conflict handling in PR reviewer - Evidence: When the reviewer detects merge conflicts, it posts a comment saying 'implementor needs to rebase' and marks the PR as done. But the issue worker has already exited after PR creation — nobody acts on the rebase request. This created a dead end where 11+ approved PRs were abandoned due to conflicts (PRs #1219, #1236, #1247, #1248, #1220, #1237, #1238, #1246, #1252, #1269). - Fix: When the reviewer reports a conflict, the pool supervisor (which has full bash permissions and maintains a clone) now attempts to rebase the PR branch onto latest master itself. If the rebase succeeds, the PR is re-queued for merge. If it fails, the PR is abandoned with a clear comment explaining manual intervention is needed. This change requires human approval before taking effect.	2026-04-05 07:53:08 +00:00
freemo	cd35284e31	chore(agents): improve ca-test-infra-improver — graceful handling of clone and tool failures ... Approved proposal: #1809 Pattern: prompt_improvement — infrastructure failure misreporting Evidence: Agent filed 10+ issues about its own infrastructure failures (clone failures using wrong hostname, tool crashes, environment limitations) instead of handling them gracefully. Issues #1673, #1686, #1691, #1694, #1699, #1713, #1732 were all clone failures; #1695, #1726, #1727, #1740 were tool failures. Fix: Add hostname resolution guidance, clone failure handling with retry logic, tool failure handling with graceful degradation, and explicit scope restriction against filing issues about own environment. ISSUES CLOSED: #1809	2026-04-05 06:56:24 +00:00
freemo	af9c672d1c	chore(agents): improve ca-test-infra-improver — prevent massive duplicate issue creation ... Approved proposal: #1802 Pattern: prompt_improvement — duplicate issue explosion Evidence: Agent created 48+ TEST-INFRA issues with massive duplication across sessions: 6 about dependency caching, 7 about matrix builds, 5 about parallelize CI jobs, 3 about redundant setup elimination, 7 about clone failures. Fix: Replace vague 3-line dedup guidance with rigorous 5-step mandatory dedup procedure including keyword search, cross-area search, closed issue search, auditable dedup proof in issue body, and conservative filing policy. ISSUES CLOSED: #1802	2026-04-05 06:48:30 +00:00
freemo	8380822717	chore(agents): improve ca-bug-hunter — prevent false positive infrastructure bug reports ... Approved proposal: #1595 Pattern: prompt_improvement — false positive bug reports from infrastructure confusion Evidence: Bug hunter filed 2+ false positive Critical bug reports about TLS/SSL failures on git.cleveragents.com (wrong hostname derived from org name instead of using git.cleverthis.com from FORGEJO_URL). Issues #1408 and #1532 were false positives. Fix: Add hostname resolution guidance, clone failure handling with retry logic, and explicit scope restriction against filing infrastructure issues. ISSUES CLOSED: #1595	2026-04-05 06:41:30 +00:00
freemo	329799a29e	chore(agents): improve agent efficiency, scope control, and PR/issue lifecycle ... Tiered worker allocation: implementors get full N workers, PR reviewers N//2, and discovery agents (UAT, bug hunter, test-infra) N//4 to prevent issue creation from outpacing implementation throughput. Dead PR cleanup: PR reviewer now auto-closes stale, superseded, unmergeable, and orphaned PRs every 5 cycles. Post-merge issue closure: PR reviewer and self-reviewer now verify that linked issues actually close after merge, removing satisfied dependency links that block closure. Backlog groomer scans last 24h of merged PRs and repairs open PR dependency health (reversed links, stale deps). Closed-item guards: agents no longer wastefully modify closed issues/PRs. Human liaison still responds to new human comments on closed items but efficiently without re-triage. Backlog groomer prioritizes open items first. System watchdog detects and flags closed-item interaction waste. Scope control: non-critical findings from UAT testers and bug hunters now route to backlog (no milestone + Priority/Backlog) instead of inflating active milestones. Epic planner and issue creator skip converging milestones. Project owner monitors and alerts on scope creep.	2026-04-05 00:37:25 -04:00
freemo	911deae36f	chore(agents): improve implementer agents — verify domain model fields before referencing ... Approved proposal: #2879 Pattern: prompt_improvement Evidence: PRs #1566, #1567, #1569, #1481 referenced non-existent Session fields (automation_profile, list_messages, etc.), causing 5 Pyright type errors and runtime crashes on session CLI commands. Fix: Add domain model verification step to all three implementer agents (sonnet, codex, opus) requiring them to read actual class definitions before referencing fields/methods. ISSUES CLOSED: #2879	2026-04-05 03:30:42 +00:00
freemo	eb4b34587f	chore(agents): improve product-builder — prohibit direct PR merging ... Approved proposal: #2878 Pattern: workflow_fix Evidence: Product-builder merged 31+ PRs without CI verification, breaking 4/6 quality gates on master during v3.7.0 session. Fix: Add 'Merge PRs yourself' to the MUST NEVER list and add explicit guidance against direct merging even when supervisors are unavailable. ISSUES CLOSED: #2878	2026-04-05 03:19:05 +00:00
freemo	507c8faa90	chore(agents): improve ca-subtask-loop — add meaningful-change verification ... Approved proposal: #2443 Pattern: workflow_fix Evidence: PR #1513 contained only a single comment line as its entire diff, yet passed all quality gates (lint, typecheck, tests, coverage) and was submitted for review, consuming 8 independent reviewer slots. All quality gates verify code quality, not code existence — a change that adds only comments passes every gate. Fix: Add Step 1.5 (Meaningful Change Verification) between the implementer invocation and test-writing step. This checks git diff output for functional code changes and rejects attempts that produce empty, comment-only, or trivially small diffs (< 3 functional lines), immediately escalating to the next tier without wasting quality gate and reviewer capacity. ISSUES CLOSED: #2443	2026-04-05 02:36:49 +00:00
freemo	72e0db2592	chore(ci): capture nox output as CI artifacts and teach agents to read them ... All 8 nox-running CI jobs in .forgejo/workflows/ci.yml now capture stdout+stderr to build/nox-<job>-output.log via `2>&1 | tee` and upload the log as a named Forgejo artifact (if: always(), retention-days: 30). Artifact names follow the pattern ci-logs-<job>: ci-logs-lint, ci-logs-typecheck, ci-logs-security, ci-logs-quality, ci-logs-unit-tests, ci-logs-integration-tests, ci-logs-e2e-tests, ci-logs-coverage Seven agent definitions updated with a CI Log Artifacts section: ca-pr-checker.md: artifact table + curl download instructions; Step 2 now downloads the relevant artifact before dispatching fix subagents. ca-lint-fixer.md, ca-typecheck-fixer.md, ca-unit-test-runner.md, ca-integration-test-runner.md, ca-coverage-checker.md, ca-pr-self-reviewer.md: each receives a section explaining which artifact corresponds to its domain and how to use it. Design notes: - tee (not redirect) preserves output in CI job logs AND captures to file - if: always() ensures artifacts are available even when the job fails - Multi-session jobs (lint, security) use tee -a to append to one file - Existing coverage-reports artifact preserved alongside ci-logs-coverage ISSUES CLOSED: #2750	2026-04-04 19:58:49 +00:00
freemo	2c736373cc	fix(agents): use correct IssueMeta schema for Forgejo dependency API ... The Forgejo blocks/dependencies REST API requires the IssueMeta schema with owner, repo, and index fields — not the undocumented dependency_id field that was previously used. All 10 curl examples across 6 agent definitions were using {"dependency_id": N} which returns a 404 IsErrRepoNotExist error. Updated to the correct format: {"owner": "<owner>", "repo": "<repo>", "index": N} Files updated: - ca-new-issue-creator.md (2 occurrences) - ca-pr-api-creator.md (1 occurrence) - ca-state-reconciler.md (1 occurrence) - ca-project-owner.md (1 occurrence) - ca-backlog-groomer.md (2 occurrences) - ca-epic-planner.md (3 occurrences) ISSUES CLOSED: #2750	2026-04-04 17:30:45 +00:00
freemo	77427bd7d3	chore(agents): add deep session introspection to system watchdog ... Enhance the system watchdog with OpenCode Server API session introspection to read actual supervisor conversations, tool calls, and todo lists. Upgrade Audit 6 (Zombie Detection) to use message-based analysis instead of only checking Forgejo activity — reads last 5 messages from each supervisor session to detect sleep-only patterns, error loops, and identical repeated tool calls. Add Audit 11 (Quick Session Spot-Check) running every 5-minute cycle: scans the 3 most recently active sessions for critical policy violations including force_merge usage, direct pushes to master, and type:ignore suppressions in written code. Add Audit 12 (Deep Session Introspection) running every 30 minutes: full analysis of all 16 supervisor sessions reading last 10 messages and todo lists. Detects misbehavior patterns, progress stalls via todo list analysis, conversation health metrics (error rates, sleep ratios), context exhaustion signals, and cross-agent conflicts (multiple agents touching the same PR or issue). Update action dispatch to handle new finding types: force_merge_detected, direct_push_to_master, stuck_supervisor, looping_supervisor, high_error_rate, context_exhaustion, and cross_agent_pr_conflict.	2026-04-03 18:13:19 +00:00
freemo	8c13e63c75	chore(agents): add system watchdog, remove force_merge, fix 9 systemic agent issues ... Add ca-system-watchdog (16th supervisor) for continuous system health monitoring with quality gate auditing, zombie detection, ticket state reconciliation, and priority enforcement. Add ca-quality-enforcer and ca-state-reconciler as one-off fix agents dispatched by the watchdog. Critical fix: remove all force_merge: true usage from ca-pr-self-reviewer which was bypassing branch protection and allowing PRs to merge with failing CI. Replace with strict CI-gating merge logic that respects branch protection rules per CONTRIBUTING.md. Update product-builder to launch 16 supervisors, strengthen anti-return language with explicit context hygiene, add tracking ticket lifecycle management (one open at a time, closed on completion). Update ca-project-bootstrapper with strict branch protection config requiring status-check CI context, 2 approvals, and dismiss stale reviews. Fix label set to match CONTRIBUTING.md exactly. Update issue-implementor with priority gate enforcing lowest-milestone-first and critical-bugs-first ordering. Update ca-backlog-groomer with closed issue state reconciliation, PAT for REST API dependency operations, and health signaling. Update ca-spec-updater with proactive full-scan mode. Add health signaling and context self-management to 7 continuous supervisors to prevent zombie sessions from context exhaustion. Strengthen state label transitions in ca-pr-self-reviewer, ca-pr-api-creator, ca-issue-state-updater, and ca-backlog-groomer to ensure closed issues always have correct terminal state labels. Add Forgejo PAT and REST API curl templates for dependency link creation to ca-backlog-groomer and ca-project-owner since the MCP does not support dependency manipulation.	2026-04-03 14:01:41 -04:00
freemo	dd363e2a45	docs(agents): clarify product-builder execution model and prevent implementation confusion ... Added critical warning block and step-by-step checklist to product-builder.md to ensure the agent always follows the correct workflow: 1. Launch 15 supervisors via curl to http://localhost:4096/session/:id/prompt_async 2. Monitor them with bash sleep loop (60 seconds between checks) 3. Re-launch any that exit Key changes: - ⚠️ Critical execution model warning at top (what to do / what NOT to do) - 📊 Execution flow diagram showing all phases - ✅ Step-by-step Phase C checklist (C.1: Pre-flight, C.2: Launch, C.3: Monitor) - 🔒 Clearer permission blocks with explicit bans on implementation agents - 📝 Comments explaining why supervisors use curl not Task tool This prevents the product-builder from trying to implement issues directly, which is the supervisors' job. Product-builder is a process supervisor (like systemd), not a worker.	2026-04-03 13:38:33 -04:00
freemo	8866c58bd4	fix(agents): prevent backlog groomer from closing PRs as duplicates of their tracking issues ... Agent evolver identified a critical systematic pattern: - Pattern: The backlog groomer was closing PRs as 'duplicates' of their linked tracking issues. A PR containing 'Closes #N' was being treated as a duplicate of issue #N, when it is actually the implementation delivery vehicle for that issue. - Evidence: At least 12 PRs were incorrectly closed (#1219, #1236, #1247, #1269, #1267, #953, #1198, #1220, #1237, #1238, #1246, #1248) — all with the same 'Duplicate Detected' comment pattern from groomer-1. - Fix: Added explicit instructions to skip PRs during duplicate detection, added a guard in the analysis loop pseudocode, and added a rule in the Important Rules section. This change requires human approval before taking effect. ISSUES CLOSED: #2180	2026-04-03 07:09:23 +00:00
freemo	bbfa5bef01	Merge pull request 'chore(agents): add open PR awareness to UAT tester duplicate avoidance' (#1446) from improvement/uat-tester-check-open-prs into master	2026-04-03 04:13:10 +00:00
freemo	51fcd13220	Merge pull request 'chore(agents): add pre-PR rebase step to issue worker to prevent stale conflicts' (#1407) from improvement/issue-worker-rebase-before-pr into master	2026-04-03 04:10:46 +00:00
freemo	f6ba8fee56	chore(agents): add pre-PR rebase step to issue worker ... Agent evolver identified a systematic pattern: - Pattern: PR stale/conflict cascade - Evidence: 11+ PRs were approved but closed without merge due to conflicts. PRs #1248, #1247, #1237, #1236, #1220, #1219, #1238, #1246, #1269 were all bulk-closed as stale. Reviewer notes on #1248, #1220, #1219, #1252 explicitly mention 'merge blocked by conflicts'. With 16 parallel workers, master moves fast and branches created minutes earlier are already behind by the time PRs are created. - Fix: Add a rebase-onto-latest-master step (Phase 3, Step 3.0) in ca-issue-worker before committing and creating the PR. This ensures the branch is current when the PR is opened, dramatically reducing the chance of merge conflicts when the reviewer processes it. This change requires human approval before taking effect.	2026-04-03 03:57:52 +00:00
freemo	81319b575a	Merge pull request 'fix(agents): add two-phase claim protocol to prevent duplicate PR reviews' (#1326) from improvement/pr-reviewer-double-claim-prevention into master	2026-04-03 03:41:30 +00:00
freemo	9c7876a913	chore(agents): add open PR awareness to UAT tester duplicate avoidance ... Agent evolver identified a systematic pattern: - Pattern: UAT tester filing bugs for features already being implemented - Evidence: 25+ UAT bugs filed for TUI MainScreen features (#1329-#1355) that already had open implementation PRs (#1219, #1236, #1237, #1238, #1246, #1247, #1248, etc.). The tester reported 'missing sidebar', 'missing tab bar', 'missing escape navigation' etc. while PRs implementing these exact features were open and under review. - Fix: Add step 4 to duplicate avoidance requiring the tester to check for open PRs before filing 'missing feature' bugs. This change requires human approval before taking effect.	2026-04-03 03:38:48 +00:00
freemo	28ddfe3873	Merge pull request 'chore(agents): add finding validation requirements to bug hunter' (#1445) ... chore(agents): add finding validation requirements to bug hunter Adds mandatory finding validation checklist to ca-bug-hunter agent prompt to reduce false-positive and speculative issue filings. Reviewed-by: ca-pr-self-reviewer	2026-04-03 03:35:47 +00:00
freemo	a538713134	refactor(agents): enforce strict curl-only permissions for all supervisors ... BREAKING CHANGE: Supervisors can no longer use Task tool to launch workers Major refactor of the permission model for product-builder and all 15 continuous supervisors to enforce strict separation: supervisors MUST use curl/prompt_async via bash to launch workers, and CANNOT use the Task tool. Key Changes: 1. Product-Builder Permissions (product-builder.md): - Removed ALL Task permissions for supervisors (previously had 17) - Kept Task permissions ONLY for 7 one-shot agents: ca-project-bootstrapper, ca-ref-reader, ca-issue-finder, ca-session-persister, ca-product-verifier, ca-milestone-reviewer, ca-final-reporter - Restricted bash to: echo, curl, sleep, jq only - Removed Phase B (Architecture) and Phase C.1 (Planning) - Updated to launch 15 supervisors (up from 13) 2. New Continuous Supervisors: - ca-architect: Converted from one-shot to continuous supervisor Monitors for spec needs, new milestones, ambiguities - ca-epic-planner: Converted from one-shot to continuous supervisor Monitors for milestones without issues, incomplete epics 3. All 15 Supervisors - Standardized Permissions: - Removed ALL Task permissions for launching workers - Workers MUST be launched via curl to OpenCode Server prompt_async API - Added 'jq *' for JSON parsing (replacing python3) - Restricted bash to specific commands only (deny all, allow specific) - Git commands restricted to specific operations (clone*, fetch*, etc.) - Directory operations (cd, mkdir, rm -rf) only where needed 4. Supervisor-Specific Updates: - issue-implementor: Removed ca-issue-worker task permission - ca-continuous-pr-reviewer: Added git + directory ops, removed worker tasks - ca-uat-tester: Added read-only file/git commands, removed self-dispatch - ca-bug-hunter: Restricted git to read-only, removed self-dispatch - ca-test-infra-improver: Added read-only commands, removed self-dispatch - ca-human-liaison: Removed ca-epic-planner/ca-architect task permissions - ca-agent-evolver: Added git + directory operations - ca-architecture-guard: Added read-only + git clone operations - ca-spec-updater: Added git + directory operations - ca-backlog-groomer: Removed ca-epic-planner task permission - ca-docs-writer: Added git + directory operations - ca-timeline-updater: Added git + directory operations - ca-project-owner: Minimal permissions (curl, jq, sleep only) Impact: - Proper separation of concerns: supervisors orchestrate, workers execute - No possibility of supervisors blocking on Task tool calls - True fire-and-forget worker launching via prompt_async - Consistent permission model across all 15 supervisors - Maximum parallelism with proper isolation Architecture now enforces: Product-builder → 15 supervisors → N workers All launched via curl/prompt_async, NO Task tool for supervisors.	2026-04-03 02:33:00 +00:00