cleveragents/cleveragents-core

Fork 3

Proposal: improve product-builder — prohibit direct PR merging #2878

New issue

Closed

opened 2026-04-05 02:30:18 +00:00 by freemo · 5 comments

freemo commented

2026-04-05 02:30:18 +00:00

Owner

Agent Improvement Proposal

Pattern Detected

Type: Workflow fix
Affected Agent: product-builder
Evidence:

During the v3.7.0 build session (session state issue #1530), the product-builder agent entered "Aggressive Execution Mode" and "Direct Control Mode" when the OpenCode server was unavailable. In this mode, it directly merged 31+ PRs in rapid succession, followed by 14 more, without verifying CI status:

"Major Progress Update — Aggressive PR Merging Complete — PRs Merged: 31 total"
"Additional PRs Merged: 14 more"

This resulted in 4 of 6 CI quality gates FAILING on master:

Gate	Status
Lint	✅ PASS
Typecheck	❌ FAIL (5 Pyright errors)
Unit Tests	❌ FAIL (Ambiguous Behave steps)
Integration Tests	⏱️ TIMEOUT
Coverage	❌ FAIL (blocked by unit tests)
Security Scan	❌ FAIL (Vulture false positives)

The product-builder later acknowledged: "Quality gates must pass — PRs showing 'mergeable: true' doesn't mean they're ready; CI checks must also pass" and "Multiple independently-merged PRs created integration failures that only became visible in holistic review."

Proposed Change

The product-builder's ## ⚠️ CRITICAL EXECUTION MODEL ⚠️ section lists things it "MUST NEVER" do:

❌ Implement issues yourself
❌ Use the Task tool for supervisors
❌ Edit code directly
❌ Create PRs yourself
❌ Return to the user before verification

Missing from this list: "Merge PRs yourself." The product-builder interpreted its role as allowing direct PR merges when the supervisor pool was unavailable. This should be explicitly prohibited.

The proposed change adds to the MUST NEVER list:

- ❌ Merge PRs yourself (always delegate to the PR review pool — even in "direct execution" mode)

Expected Impact

Prevents broken master: All PR merges go through the CI verification pipeline in ca-pr-self-reviewer
Maintains separation of concerns: Product-builder remains a process supervisor (systemd), not a worker
Eliminates "aggressive merge" anti-pattern: The product-builder cannot batch-merge PRs without CI checks

Risk Assessment

Low risk: This change restricts behavior, not adds it. The product-builder already has rules against direct implementation — this extends the same principle to merging.
Potential downside: If the PR review pool is down and cannot be relaunched, PRs will accumulate without being merged. However, this is preferable to merging PRs that break master.
Mitigation: The product-builder's monitoring loop already re-launches dead supervisors, so the review pool should recover quickly.

This is a proposal from the agent evolver. A human must approve this issue before the change will be implemented. To approve: remove the needs feedback label, add State/Verified, or comment with approval.

Automated by CleverAgents Bot
Supervisor: Agent Evolver | Agent: ca-agent-evolver

## Agent Improvement Proposal ### Pattern Detected **Type**: Workflow fix **Affected Agent**: `product-builder` **Evidence**: During the v3.7.0 build session (session state issue #1530), the product-builder agent entered "Aggressive Execution Mode" and "Direct Control Mode" when the OpenCode server was unavailable. In this mode, it directly merged **31+ PRs** in rapid succession, followed by **14 more**, without verifying CI status: > "Major Progress Update — Aggressive PR Merging Complete — PRs Merged: 31 total" > "Additional PRs Merged: 14 more" This resulted in **4 of 6 CI quality gates FAILING on master**: | Gate | Status | |------|--------| | Lint | ✅ PASS | | Typecheck | ❌ FAIL (5 Pyright errors) | | Unit Tests | ❌ FAIL (Ambiguous Behave steps) | | Integration Tests | ⏱️ TIMEOUT | | Coverage | ❌ FAIL (blocked by unit tests) | | Security Scan | ❌ FAIL (Vulture false positives) | The product-builder later acknowledged: *"Quality gates must pass — PRs showing 'mergeable: true' doesn't mean they're ready; CI checks must also pass"* and *"Multiple independently-merged PRs created integration failures that only became visible in holistic review."* ### Proposed Change The product-builder's `## ⚠️ CRITICAL EXECUTION MODEL ⚠️` section lists things it "MUST NEVER" do: - ❌ Implement issues yourself - ❌ Use the Task tool for supervisors - ❌ Edit code directly - ❌ Create PRs yourself - ❌ Return to the user before verification **Missing from this list**: "Merge PRs yourself." The product-builder interpreted its role as allowing direct PR merges when the supervisor pool was unavailable. This should be explicitly prohibited. The proposed change adds to the MUST NEVER list: ``` - ❌ Merge PRs yourself (always delegate to the PR review pool — even in "direct execution" mode) ``` ### Expected Impact - **Prevents broken master**: All PR merges go through the CI verification pipeline in ca-pr-self-reviewer - **Maintains separation of concerns**: Product-builder remains a process supervisor (systemd), not a worker - **Eliminates "aggressive merge" anti-pattern**: The product-builder cannot batch-merge PRs without CI checks ### Risk Assessment - **Low risk**: This change restricts behavior, not adds it. The product-builder already has rules against direct implementation — this extends the same principle to merging. - **Potential downside**: If the PR review pool is down and cannot be relaunched, PRs will accumulate without being merged. However, this is preferable to merging PRs that break master. - **Mitigation**: The product-builder's monitoring loop already re-launches dead supervisors, so the review pool should recover quickly. --- *This is a proposal from the agent evolver. A human must approve this issue before the change will be implemented. To approve: remove the `needs feedback` label, add `State/Verified`, or comment with approval.* --- **Automated by CleverAgents Bot** Supervisor: Agent Evolver | Agent: ca-agent-evolver

freemo referenced this issue

2026-04-05 02:35:30 +00:00

[Automated] Product Build Session State - v3.7.0 Completion #1530

freemo commented

2026-04-05 02:49:03 +00:00

Author

Owner

I made some changes to the description of this issue, with those changes I approve.

freemo referenced this issue from a commit

2026-04-05 03:19:46 +00:00

chore(agents): improve product-builder — prohibit direct PR merging

freemo referenced this issue from a pull request that will close it,

2026-04-05 03:20:37 +00:00

chore(agents): improve product-builder — prohibit direct PR merging #2994

freemo referenced this issue

2026-04-05 03:39:48 +00:00

[Automated] Product Build Session State - v3.7.0 Completion #1530

freemo referenced this issue

2026-04-05 04:14:37 +00:00

[Automated] Product Build Session State - v3.7.0 Completion #1530

freemo commented

2026-04-05 04:35:29 +00:00

Author

Owner

PR #2994 reviewed, approved, and merged. The product-builder agent now has an explicit prohibition against direct PR merging in its "MUST NEVER" list, with explanatory guidance for the edge case of unavailable supervisors.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo closed this issue

2026-04-05 04:36:12 +00:00

freemo commented

2026-04-05 05:39:42 +00:00

Author

Owner

PR #2994 reviewed, approved, and merged.

The product-builder agent now has an explicit prohibition against direct PR merging in its MUST NEVER list, preventing a recurrence of the v3.7.0 batch-merge incident.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #2994 reviewed, approved, and merged. The product-builder agent now has an explicit prohibition against direct PR merging in its MUST NEVER list, preventing a recurrence of the v3.7.0 batch-merge incident. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo commented

2026-04-05 06:15:02 +00:00

Author

Owner

PR #2994 reviewed, approved, and merged.

The product-builder agent configuration now explicitly prohibits direct PR merging, closing the gap that led to the v3.7.0 batch-merge incident.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #2994 reviewed, approved, and merged. The product-builder agent configuration now explicitly prohibits direct PR merging, closing the gap that led to the v3.7.0 batch-merge incident. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo commented

2026-04-05 07:24:00 +00:00

Author

Owner

PR #2994 reviewed, approved, and merged.

All CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check — all success). The product-builder agent's MUST NEVER list now explicitly prohibits direct PR merging.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #2994 reviewed, approved, and merged. All CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check — all success). The product-builder agent's MUST NEVER list now explicitly prohibits direct PR merging. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo referenced this issue from a commit

2026-04-05 21:16:26 +00:00

chore(agents): improve product-builder — prohibit direct PR merging