1117 Commits

Author	SHA1	Message	Date
freemo	4c419d48f5	fix(Python 3.13): replace deprecated asyncio.get_event_loop() and datetime.utcnow() calls ... - Replace all src/ loop = asyncio.get_event_loop() with get_running_loop() + exception-safe fallback pattern - Replace source-level asyncio.get_event_loop().run_until_complete( with context-managed event loop creation and proper cleanup - Replace route_bridge.py asyncio.get_event_loop().time() call with time.time() import to avoid creating event loops just for timestamp access - Add loop.close() in langgraph_bridge_steps tests to prevent resource leak from unclosed event loops (reviewed feedback #7) - Move Python 3.13 changelog entry from ### Added to ### Fixed section per CONTRIBUTING.md style guidelines (review feedback #6) Files modified: src/cleveragents/agents/base.py - replace get_event_loop().run_until_complete() src/cleveragents/langgraph/bridge.py - replace loop = get_event_loop() src/cleveragents/langgraph/nodes.py - replace both get_event_loop() calls src/cleveragents/reactive/route_bridge.py - replace with time.time(), remove unused asyncio import features/steps/langgraph_bridge_steps.py - add loop.close() for resource cleanup features/steps/reactive_application_coverage_steps.py - fix event loop patterns, add import time features/steps/route_bridge_coverage_steps.py - fix multiple get_event_loop/run_until_complete patterns, proper import ordering CHANGELOG.md - move Python 3.13 entry to ### Fixed ISSUES CLOSED: #11134	2026-05-13 04:42:53 +00:00
freemo	daee737934	fix(Python 3.13): replace deprecated asyncio.get_event_loop() and datetime.utcnow() calls ... - Replace all asyncio.get_event_loop() with get_running_loop() + safe fallback - Replace datetime.utcnow() with datetime.now(timezone.utc) - Add PYTHONWARNINGS safety net in nox session for remaining deprecations - Fix 7 failing BDD test scenarios under Python 3.13 ISSUES CLOSED: #11134	2026-05-12 12:04:30 +00:00
hurui200320	b4a514e0f4	fix(cli): add spec-required --data-dir, --config-path, and -v global options to main_callback ... Implements ADR-021 §Global CLI Flags and ADR-024 §Resolution Chain. All three global options were missing from main_callback(), causing any invocation with these flags to crash with 'No such option'. Changes: - src/cleveragents/cli/main.py * Add _VERBOSITY_LOG_LEVELS tuple mapping verbose count to log levels (0=CRITICAL/silent, 1=ERROR, 2=WARNING, 3=INFO, 4=DEBUG, 5+=DEBUG) * Add --data-dir PATH option: validates path is a directory if it exists, sets CLEVERAGENTS_DATA_DIR env var, resets Settings singleton * Add --config-path PATH option: validates file exists and is a file, sets CLEVERAGENTS_CONFIG_PATH env var for ConfigService to pick up * Add -v (count=True) option: wires verbose count to configure_structlog * Store all three values in ctx.obj for subcommand access * Update _print_basic_help() to include the three new global options so 'cleveragents --help' (fast path) also lists them * In the catch-all Exception handler, print the original exception type+message directly to err_console so actionable details remain visible even when log level is CRITICAL (e.g. 'No such option') - src/cleveragents/application/services/config_service.py * ConfigService.__init__ now checks CLEVERAGENTS_CONFIG_PATH env var when no explicit config_path is passed, completing the resolution chain for --config-path CLI override Tests (all passing): - features/cli_global_options.feature (21 Behave scenarios) - features/steps/cli_global_options_steps.py - robot/cli_global_options.robot (8 Robot Framework integration tests) - robot/helper_cli_global_options.py Quality gates: lint ✓ typecheck ✓ unit_tests ✓ integration_tests ✓ Coverage: 96.52% (threshold 96.5% ✓) ISSUES CLOSED: #6785	2026-05-12 01:05:10 +00:00
CoreRasurae	e8d2f76466	feat(ci): implement TDD bug tag quality gate for bug fix PRs ... Add an automated quality gate that enforces TDD bug fix workflow rules on pull requests. The gate parses PR descriptions for bug-closing keywords (Closes/Fixes/Resolves #N, ISSUES CLOSED: #N), searches the codebase for corresponding TDD tests tagged @tdd_bug_N, and verifies that @tdd_expected_fail tags have been removed. Key components: - scripts/tdd_quality_gate.py: Main quality gate script with PR description parsing, TDD test discovery, and tag removal verification. All public functions validate arguments fail-fast and are statically typed. - noxfile.py: New tdd_quality_gate session that reads PR_DESCRIPTION from the environment and runs the quality gate script. - .forgejo/workflows/ci.yml: New tdd_quality_gate CI job that runs only on pull_request events, passing the PR body as PR_DESCRIPTION. - features/tdd_quality_gate.feature: 46 Behave scenarios covering PR parsing, TDD test search, tag removal verification, full gate logic, robot diff handling, edge cases, argument validation, bool guards, co-located bug false-positive guard, and main() CLI entry point. - features/steps/tdd_quality_gate_steps.py: Step definitions for all Behave scenarios using temporary directories for isolation. - robot/tdd_quality_gate.robot: 15 Robot Framework integration tests exercising the gate end-to-end via a helper subprocess. - robot/helper_tdd_quality_gate.py: Helper script for Robot tests with sentinel-based sub-commands. Review-round fixes applied: - check_expected_fail_removed now uses _contains_tag_token for word-boundary matching (avoids false positives on partial tag names) - Diff expected-fail removal detection tracks flags at file level instead of per-hunk (fixes false negatives when tags span hunks) - parse_bug_refs filters out issue number zero - Redundant double error reporting eliminated (file-level check short-circuits the diff-level check) - run_quality_gate returns (errors, bug_refs) tuple to avoid redundant re-parsing in main() - Regex compilation cached via functools.lru_cache - Nox session no longer installs the full project (stdlib only) - CI checkout uses fetch-depth: 0 for reliable merge-base resolution Review-round 2 fixes applied: - _diff_has_expected_fail_removal_for_bug now requires the removed line to contain both the expected-fail tag and the specific bug tag (fixes false positives when two bugs share the same test file) - check_expected_fail_removed error messages use the correct tag prefix per file type (@tdd_bug_N for .feature, tdd_bug_N for .robot) - bool values rejected by bug-number validation guards in find_tdd_tests, check_expected_fail_removed, and _diff_has_expected_fail_removal_for_bug - File-read error handling catches UnicodeDecodeError alongside OSError (root-safe unreadable-file handling via invalid-UTF-8 test fixture) - Temp directory cleanup added to after_scenario hook in environment.py - 8 new Behave scenarios: bool type guards (2), co-located bug false-positive regression (1), run_quality_gate argument validation (3), and main() CLI entry point exit codes (2) Review-round 3 fixes applied: - Synthetic PR diff helper (_default_pr_diff_for_bug_refs) now auto-detects .robot vs .feature file type from the temp search tree and generates the matching diff format (fixes under-tested robot-format diff code path in multi-bug integration scenarios) - check_expected_fail_removed test step now filters files by bug tag via find_tdd_tests before checking (matches production path in run_quality_gate) - after_scenario temp directory cleanup no longer sets context.temp_dir = None (fixes cleanup conflict with cli_init_yes_flag_steps.py cleanup functions that run after hooks) - 2 new Behave scenarios: multi-line PR description parsing, and non-string pr_diff type guard for run_quality_gate ISSUES CLOSED: #629	2026-05-12 00:22:49 +01:00
HAL9000	b692894c88	fix(tests): remove AmbiguousStep conflict in security_pyyaml_dependency_steps ... Duplicate step definitions for 'the pyproject.toml file exists at', 'I read the project dependencies from pyproject.toml', 'I attempt to import the module', and 'the import should succeed without errors' were present in both security_pyyaml_dependency_steps.py and tdd_a2a_sdk_dependency_steps.py, causing a behave.AmbiguousStep error that failed the unit_tests CI gate. Removed the 4 duplicate step definitions from security_pyyaml_dependency_steps.py, keeping only the 3 PyYAML-specific step definitions. The shared steps are now exclusively provided by tdd_a2a_sdk_dependency_steps.py. Also resolved merge conflicts from master in CONTRIBUTORS.md: preserved all master additions (database resource types entry) alongside the existing PyYAML upgrade entry. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	2f01e7d625	fix(tests): resolve lint format failure and harden pyyaml BDD step path resolution ... - Move _flatten_toml_dict to module level: eliminates nested function definition that ruff format reformats unexpectedly; makes the helper independently testable and clearly documented. - Rename helper to _flatten_toml_dict (was _flatten) for unambiguous module-level identity and improved readability. - Add _PROJECT_ROOT constant computed from __file__ so pyproject.toml is always resolved via an absolute path regardless of the process working directory — fixes brittle relative-path lookup that fails when behave-parallel forks workers whose cwd differs from the repo root. - Fix ruff format violations: wrap long assert message, normalise decorator quote style, ensure trailing newline, fix import ordering (behave imports before packaging). - All quality gates pass: lint, format --check, security_scan, dead_code. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	63746b4d30	fix(pyyaml): address CI review feedback from PR #11012 ... - Fix ruff lint F541 error: remove unnecessary f-string prefix - Remove dead step_uv_lock_specifier step (never called by BDD scenarios) - Update CONTRIBUTORS.md to reference correct PR number (#11012 not #9244) ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	05acc26c40	chore(deps): upgrade PyYAML to address known security vulnerability ... - Added `pyyaml>=6.0.3` dependency constraint to pyproject.toml after aiohttp to prevent installation of vulnerable older versions with known YAML parsing security issues. - Updated uv.lock package dependencies and requires-dist to include pyyaml entry with specifier '>=6.0.3'. - Added changelog Security section entry under [Unreleased] documenting the upgrade for issue #9055. - Updated CONTRIBUTORS.md with contribution note (PR #9244). - Added BDD test scenario verifying PyYAML security dependency constraint. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
hurui200320	87a7ce35d7	feat(session): implement real LLM actor invocation in session tell ... Replace the M3 stub in `agents session tell` with real orchestrator actor invocation via `SessionWorkflow.tell()`. The stub echoed a canned `Acknowledged: ...` response without calling any LLM or actor; this commit wires up the full pipeline: Architecture: - New `SessionWorkflow` (Application layer) orchestrates LLM invocation for session tell. Accepts a `ProviderRegistry` and `ToolRegistry`; falls back to `FakeListLLM` when no provider is configured. - `LangChainSessionCaller` implements the `LLMCaller` protocol, building history-aware LangChain message lists from the session conversation and invoking the LLM via `ToolCallingRuntime.run_tool_loop()`. - `TellResult` (Pydantic BaseModel) carries the assistant response plus token usage (input_tokens, output_tokens, cost_usd, duration_ms). Domain / service layer: - `SessionActorNotConfiguredError` added to the session domain model; raised when tell is invoked with no actor on the session and no `--actor` override. Clear message; CLI exits with code 1. - `SessionService.get_messages()` abstract method added (+ implementation in `PersistentSessionService`) to load ordered message history. A2A facade: - `A2aLocalFacade` gains `message/send` and `message/stream` standard A2A operation handlers that route to `SessionWorkflow.tell()`. Total supported operations count: 42 → 44. CLI: - `session tell` command delegates to `_build_session_workflow()` (patchable factory) instead of directly calling `SessionService`. - Non-streaming: `SessionWorkflow.tell()` returns `TellResult`; output includes a Usage panel (Rich/Plain) or a `usage` object (JSON/YAML). - Streaming: `SessionWorkflow.tell_stream()` yields tokens; CLI prints them via `console.print` (not raw `sys.stdout.write`). - Token usage recorded via `SessionService.update_token_usage()` in both paths. Tests: - New Behave feature `session_tell_llm.feature` (4 scenarios): real LLM response persisted; streaming yields tokens; no-actor exits code 1; `--actor` override resolves correctly. - New Robot suite `session_tell_llm.robot` (4 tests): end-to-end with stub LLM injected via monkey-patching `_resolve_llm`. - Updated all existing `session tell` test steps to patch `_build_session_workflow` returning a mock `TellResult` so tests remain isolated from the LLM layer. - Updated operation-count assertions (42 → 44) in `a2a_cli_facade_integration`, `consolidated_misc`, `m6_autonomy_acceptance` feature files and steps. Cycle 7 (Review ID 8088) fixes: - Blocker 4: Split `session_workflow.py` (was 801 lines) into two files: `session_workflow.py` (467 lines) and `session_caller.py` (318 lines). Extracted: `LangChainSessionCaller`, `extract_content`, `extract_token_usage`, `estimate_cost`, `estimate_tokens`, `history_to_langchain_messages`, and stub classes. - Blocker 5: Route CLI streaming path through `_facade_dispatch("message/stream", ...)` instead of directly calling `workflow.tell_stream()`. The facade's `_handle_message_stream` falls back to non-streaming with `streamed: false` (acceptable for this milestone per the spec). - Updated streaming test assertion to validate full response presence (no longer checks token-by-token word positions, since the facade fallback returns a complete message). ISSUES CLOSED: #5784	2026-05-11 04:39:29 +00:00
CoreRasurae	78be08870c	fix(cli): validate actor provider field at correct config nesting level ... - Actor configuration in V3 is now obtained from the nested configuration parameter, according to the specification. - Removed the legacy V2 fallback support and the tests affected by that removal. Mocked existing steps to allow remaining V2 features to be covered/tested. - Fix add() to pass unsafe flag to add_v3() for proper unsafe actor handling - Add _extract_nested_v3_config() to extract provider/model from nested actors.<name>.config block before v3 schema validation - Remove v2 extraction test scenarios from consolidated_actor.feature that call removed _extract_v2_actor() and _extract_v2_options() methods - Update test YAML in actor_registry_spec_yaml_steps.py to exercise nested type detection (no top-level type field) - Add @tdd_issue_4300 regression test tag to existing spec-compliant actors map scenario ISSUES CLOSED: #4300	2026-05-09 23:13:33 +01:00
HAL9000	5ee08ea946	fix(plan): remove TDD expected fail tag and fix format violations ... - Remove @tdd_expected_fail from Tree with json format scenario in plan_explain.feature (bug is now fixed by the envelope implementation) - Update scenario assertions to verify new spec-required envelope format instead of old bare-array format - Add step_tree_json_valid_envelope step definition in plan_explain_steps.py - Fix ruff format violation in plan_explain_cli_coverage_steps.py ISSUES CLOSED: #9163	2026-05-09 12:23:24 +00:00
HAL9000	6e1646d565	fix(plan): wrap plan tree JSON/YAML output in spec-required command envelope.\n\nISSUES CLOSED: #9163 ... # Conflicts: # CONTRIBUTORS.md	2026-05-09 12:23:24 +00:00
HAL9000	af6e54f0b2	fix(tests): reformat pr_compliance_pool_supervisor_steps.py and fix pre-existing lint errors ... - ruff format: multiline AGENT_DEF_PATH assignment, compress all() comprehension, add blank line before decorator block — fixes CI / unit_tests lint failure - ruff --fix: remove unused imports from tests/actor/test_registry_builtin_yaml.py (pre-existing F401 errors on master) ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	addbc51dc4	fix(tests): fix lint violation UP035 and match feature file step text to Pool: prefixes ... - B5 (lint): changed 'from typing import Any, Callable' to 'from collections.abc import Callable' per ruff UP035 rule - B7 (step mismatch): added 'Pool: ' prefix to all Then/And steps in pr_compliance_pool_supervisor.feature to match step definition decorators ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	96670720f0	fix(tests): resolve Behave AmbiguousStep conflict in pool-supervisor steps ... The pr_compliance_pool_supervisor_steps.py file defined @then step texts identical to those in the pre-existing pr_compliance_checklist_steps.py, causing Behave's ambiguous-step detection to reject the test run. Fix: prefix all pool-supervisor @then decorators with 'Pool:' so they're uniquely identifiable by Behave while reusing the same validator logic. Also fix PROJECT_ROOT from parents[3] -> parents[2] for correct repo root resolution in step files located at features/steps/. ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	fbe6308200	feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor ... Add a new implementation-pool-supervisor agent definition with an embedded 8-item PR Compliance Checklist. Workers dispatched by the pool supervisor must complete all 8 items before creating any PR: CHANGELOG.md update, CONTRIBUTORS.md update, commit footer (ISSUES CLOSED: #N), CI verification, BDD tests, Epic reference, label application via forgejo-label-manager, and milestone assignment. Includes concrete markdown examples for each subsection and compliance verification pseudocode. Also adds BDD test coverage (pr_compliance_pool_supervisor.feature + steps) to verify the pool supervisor agent definition contains all 8 checklist items. Parent Epic: #9779 ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	b588de18d6	fix(tui): rebase onto master and add CHANGELOG entry for prompt symbol fix (#6431) ... Rebases the TUI prompt symbol fix onto the latest master, resolving conflicts with the TextArea→Input refactor and the dollar-prefix shell mode addition. Adds the missing CHANGELOG.md entry for #6431 and removes the now-obsolete tui_prompt_textarea feature/steps that tested the old TextArea-based implementation. ISSUES CLOSED: #6431	2026-05-08 11:15:36 +00:00
HAL9000	a15b77f6a6	fix(acms): normalize context path matching for absolute paths in _path_matches ... Fixes issue #10972 where _path_matches() used PurePath.full_match()/match() which requires the entire path to match. Since fragment metadata stores absolute paths (e.g. /app/.opencode/skills/SKILL.md) while project context --exclude-path/--include-path settings produce relative globs (.opencode/*, docs/*), include/exclude filters were silently ineffective. Added _matches_any() static helper in execute_phase_context_assembler.py that: - Tries full_match(pattern) as-is for relative paths and anchored patterns - Auto-prefixes relative patterns with **/ so they match absolute paths Updated _matches_pattern() in context_phase_analysis.py with same logic plus zero-depth compatibility shim. Added 7 new BDD regression scenarios with @tdd_issue tags: - 5 in execute_phase_context_assembler_coverage.feature (absolute path matching) - 1 extra trailing ** glob exclusion test - 1 in project_context_phase_analysis.feature (phase analysis exclusion) ISSUES CLOSED: #10972	2026-05-08 09:57:18 +00:00
HAL9000	5b6224daa8	fix(plugins): prevent arbitrary code execution in PluginLoader.validate_protocol() ... - Add guard in TypeError fallback path: raise ProtocolMismatchError when issubclass raises TypeError and protocol has no inspectable members, preventing silent True return for unverifiable protocols - Update test scenario descriptions to accurately reflect the new implementation (no instantiation occurs at any point) - Update step definition comments to remove references to old instantiation-based code paths ISSUES CLOSED: #7418	2026-05-08 09:32:29 +00:00
HAL9000	883ec872e2	fix(CI): resolve remaining lint/format violations in PR #8722 ... - Apply ruff format to features/steps/strategize_decision_recording_steps.py: expanded single-line set literal to multi-line canonical form (PEP 87) This was the sole remaining CI lint blocker per review cycle 14. - Remove unused imports from tests/actor/test_registry_builtin_yaml.py: removed 'Settings' and 'ProviderRegistry' to fix F401 errors. These were pre-existing violations caught by ruff check. ISSUES CLOSED: #8522 Closes: #8722	2026-05-08 06:24:23 +00:00
HAL9000	e7fb7168b4	feat(decisions): implement decision recording hook in Strategize phase ... Implement the StrategizeDecisionHook class for recording decisions during the Strategize phase. The hook captures every decision point with question, chosen_option, alternatives_considered, confidence_score, rationale, and full context_snapshot (hot_context_hash, actor_state_ref, relevant_resources). Supports four decision types: strategy_choice, resource_selection, subplan_spawn, and invariant_enforced. Includes a DecisionRecorder protocol port for decoupled persistence and capture_context_snapshot utility function. Comprehensive BDD test suite with 40+ scenarios covering all decision types, context snapshot validation, error handling, and tree structure tracking. ISSUES CLOSED: #8522	2026-05-08 06:24:23 +00:00
HAL9000	241c2602b0	fix(quality-gates): resolve ruff formatting and missing type annotations ... Fix two lint blockers identified in PR review: 1. Collapsible list comprehension format (ruff RUF015): Collapse the "projects" list comprehension in _build_strategize_context_snapshot() from 3 lines to a single line within the 88-character limit. 2. Missing type annotations on 13 new BDD step functions: All existing step functions use explicit `context: Context` and `-> None` return type annotations per project style. The 13 new step functions added for issue #9056 were missing these declarations, causing lint warning RUF012 (missing type annotations on function arguments). Verified: - nox -s lint passes (ruff check + ruff format --check) - nox -s typecheck passes (pyright 0 errors) - Pre-existing unit_tests/CI timeouts are infrastructure-related ISSUES CLOSED: #9056	2026-05-08 05:14:03 +00:00
HAL9000	8ed8c25652	fix(plan-lifecycle): record full context snapshots in Strategize phase ... The Strategize phase was recording decisions with minimal context snapshots (only a hash of question+chosen_option), violating the v3.2.0 acceptance criterion that decisions must include full context snapshots sufficient to replay the decision. Changes: - Add _build_strategize_context_snapshot() helper that builds a full ContextSnapshot from plan metadata (description, action_name, strategy_actor, project_links) - Update _try_record_decision() to accept an optional context_snapshot parameter and forward it to DecisionService - Update start_strategize() to build and pass a full context snapshot - Add 3 BDD scenarios in decision_recording.feature verifying that hot_context_hash, hot_context_ref, actor_state_ref, and relevant_resources are all populated for Strategize-phase decisions ISSUES CLOSED: #9056	2026-05-08 05:11:47 +00:00
HAL9000	0ce2e14f2d	style: fix ruff format violations in devcontainer_autodiscovery_wiring_steps.py ... Apply ruff auto-format to resolve CI lint failure: long lines in subprocess.run() calls and list comprehensions were not wrapped to the project's line-length limit.	2026-05-07 23:49:20 +00:00
HAL9000	3d7afb4378	fix(resource): wire discover_devcontainers() into git-checkout and fs-directory handlers ... GitCheckoutHandler.discover_children() and FsDirectoryHandler.discover_children() now call discover_devcontainers() after scanning for fs-directory children. Any .devcontainer/devcontainer.json or root-level .devcontainer.json found at the resource location is registered as a devcontainer-instance child resource with provisioning_state: discovered. Named configurations are also discovered and carry the configuration name in the config_name property. This wires the previously-isolated discover_devcontainers() function into the production code path, enabling the spec's zero-configuration devcontainer experience. ISSUES CLOSED: #4740	2026-05-07 23:49:20 +00:00
Luis Mendes	15e72b8407	fix(events): log full exception details in ReactiveEventBus.emit() error handler ... Add exc_info=True to the _logger.warning() call in the per-handler exception block of ReactiveEventBus.emit(). The handler already logged error=str(exc) (the exception message text), but omitted the traceback. With exc_info=True structlog now forwards the full traceback to the configured log output, giving developers the diagnostic detail needed to debug subscriber failures in production. Remove the @tdd_expected_fail tag from the traceback scenario in features/tdd_event_bus_exception_swallow.feature so that both TDD scenarios (#988) run as normal regression guards. Fix TDD tags in robot/tdd_e2e_implicit_init.robot: replace incorrect tdd_bug/tdd_bug_1023 tags with the canonical tdd_issue/tdd_issue_1023/ tdd_expected_fail tags so the tdd_expected_fail_listener properly inverts results while bug #1023 remains open. ISSUES CLOSED: #988	2026-05-07 23:39:08 +01:00
Dev User	23e9848f95	fix(cli): make actor NAME argument optional, derive from YAML config ... Implement NAME argument as optional with derivation from config file when not provided. Changes: - actor.py: NAME argument changed from required 'str' to optional 'str | None = None' - Added help text explaining NAME can be omitted and derived from config - Added logic to derive name from config_blob.get('name') when name arg is None - Raises BadParameter if neither name argument nor config 'name' field is provided - Updated docstring signature to reflect optional NAME: 'agents actor add [--config|-c <FILE>] [<NAME>]' - Updated examples to show config-only usage ISSUES CLOSED: #4186	2026-05-07 20:05:33 +00:00
CoreRasurae	d47d560a2e	test(behave): Fix failing tests after rebase on master	2026-05-07 20:05:33 +00:00
CoreRasurae	ac84f314ff	test(behave): Fix concurrent BDD tests failures	2026-05-07 20:05:33 +00:00
CoreRasurae	272821028f	test(behave): Remove tdd_expected fail for issue #2609 ... Issue is already implemented in master via commits b6959aeff and 491781714	2026-05-07 20:05:33 +00:00
Dev User	6b5568af1d	fix(tests): update PlanModel step texts to match renamed base step ... The base step 'I create a plan in strategize phase' was renamed to 'I create a PlanModel in strategize phase' to avoid AmbiguousStep collision. This commit updates compound step definitions that use the base step: - 'I create a plan in strategize phase with errored state' - 'I create a plan in strategize phase with processing state' - 'I create a plan in strategize phase with cancelled state'	2026-05-07 20:05:33 +00:00
Dev User	a3ba3c3eaf	fix(tests): resolve pre-existing AmbiguousStep collisions in step definitions ... Rename step texts to avoid case-sensitive conflicts between different step modules: - edge_case_plan_steps.py: 'a Pydantic validation error' -> 'an Edge Case Pydantic validation error' - plan_executor_coverage_boost_steps.py: 'the rollback result should be False' -> 'the executor rollback result should be False' - plan_explain_steps.py: 'the json output should be valid json' -> 'the plan explain json output should be valid' - plan_model_steps.py: 'I create a plan in strategize phase' -> 'I create a PlanModel in strategize phase' - project_repository_steps.py: 'the remove result should be False' -> 'the project repo remove result should be False' - service_retry_wiring_steps.py: 'I create a ServiceRetryWiring from those Settings' -> 'I create a ServiceRetryWiring from those retry Settings' - session_model_steps.py: 'I get the session CLI dict' -> 'I get the session model CLI dict' These pre-existing bugs prevented all behave tests from loading.	2026-05-07 20:05:33 +00:00
HAL9000	d4ebb482e1	style(tests): fix ruff format violation in TDD step file ... Collapse multi-line @then decorator onto a single line in tdd_session_create_suppress_exception_steps.py to satisfy ruff format --check (the CI lint job runs both ruff check and ruff format --check).	2026-05-07 19:14:53 +00:00
HAL9000	08422b4ded	fix(cli): log suppressed facade dispatch exceptions in session create ... Replace __import__("datetime") with proper top-level import per project Python import rules. This resolves the CI lint failure blocking PR #10898. Closes #10433 Refs: #10414 #10898	2026-05-07 19:14:53 +00:00
HAL9000	2d519182ca	fix(cli): log suppressed facade dispatch exceptions in session create ... Replace the silent contextlib.suppress(Exception) block in the session create command with a try/except that logs at WARNING level with exc_info. Previously, any exception raised by _facade_dispatch() during session creation was silently discarded with no logging, making it impossible to diagnose failures in the facade layer (e.g. A2A bootstrap unavailable, programming errors, infrastructure issues). The fix keeps session creation non-fatal (the session is already persisted before the facade call) while ensuring the exception is visible in logs: try: _facade_dispatch(session.create, {...}) except Exception as _exc: _log.warning( session_create_facade_dispatch_failed, extra={"session_id": ..., "error": str(_exc)}, exc_info=True, ) Also includes the TDD regression test from issue #10414 (PR #10749) with @tdd_expected_fail removed, since the fix is now applied. The test verifies that a WARNING log entry is emitted when _facade_dispatch() raises and that session creation still exits 0. ISSUES CLOSED: #10433	2026-05-07 19:14:53 +00:00
HAL9000	2778bde95a	fix(repositories): derive PlanResult.success from result_success column instead of error_message ... ISSUES CLOSED: #7501	2026-05-07 14:22:57 +00:00
hurui200320	bef7f3175b	fix(tests): resolve integration test failures in behave parallel log filtering ... Fix the integration test helper so that it can load scripts/run_behave_parallel.py outside of nox sessions. The helper imports the runner module via importlib, which triggers the top-level from behave_pass_suppress_formatter import PassSuppressFormatter. When invoked from integration tests (or any non-nox context), neither behave_pass_suppress_formatter nor the behave_parallel package (created by noxfile.py for unit_tests) is on sys.path, causing a ModuleNotFoundError and all 6 Robot tests to fail with exit code 1. The fix adds scripts/ to sys.path before loading the runner module so that from behave_pass_suppress_formatter import PassSuppressFormatter resolves correctly. This mirrors the approach already used in noxfile.py's unit_tests session for the behave-parallel package. Also addresses review feedback: - Removes one blank line from scripts/run_behave_parallel.py to bring it to 499 lines, satisfying the project's <500-line code style rule. - Moves in-function behave imports (Configuration, StreamOpener) in features/steps/behave_parallel_log_filtering_steps.py to the top-level import block alongside the existing behave imports, complying with the project's rule that all imports must be at the top of the file. Refs: #10987	2026-05-07 18:09:26 +08:00
hurui200320	4fe87d9eec	fix(tests): resolve pre-existing unit test failures in 5 feature files ... Fix five pre-existing BDD test failures that were present on master before PR #10988 was opened: 1. **architecture.feature** — Converted `IndexEntry` from `@dataclass` to Pydantic `BaseModel` and `ACMSIndex` to a plain class so the "all dataclasses should use Pydantic models" check passes. 2. **pr_compliance_checklist.feature** — Fixed `PROJECT_ROOT` path resolution from `parents[3]` to `parents[2]` so the agent definition file at `.opencode/agents/implementation-supervisor.md` is located correctly within the `/app` workspace. 3. **acms/index_data_model_and_traversal.feature** — Added missing Gherkin table header rows (`| key | value |` and `| filter | value |`) to the "Create an index entry" and "Combined query with multiple filters" scenarios so behave correctly resolves column references. 4. **cli_init_yes_flag.feature** — Added a `getattr` guard around `context.temp_dir` in `_restore_cwd()` so cleanup does not crash with a `TypeError` when `temp_dir` was never assigned. 5. **security_audit.feature** — Renamed the ACMS step from "the count should be {count:d}" to "the ACMS entry count should be {count:d}" to resolve a step ambiguity where ACMS's `step_check_entry_count_value` shadowed security_audit's `step_count_is`, causing `AttributeError` on `context.entry_count` for audit scenarios. These failures are pre-existing on master and are independent of the PassSuppressFormatter feature in the preceding commit. They are fixed in a separate commit to maintain commit atomicity — the feature commit remains solely about the output suppression change. Refs: #10987	2026-05-07 18:09:25 +08:00
hurui200320	49f1cfcdb6	chore(tests): suppress passing scenario output by default in behave-parallel unit test runner ... Implemented PassSuppressFormatter, a custom Behave formatter that buffers per-scenario output and only flushes it to stdout when the scenario failed or errored. Passing scenarios produce no output, keeping an all-passing suite at ~5-10 lines (the _print_overall_summary block only). Key design decisions: - PassSuppressFormatter (in scripts/behave_pass_suppress_formatter.py) inherits from behave's Formatter base class so it can be registered via behave.formatter._registry.register_as(), which enforces issubclass(cls, Formatter). - _SUPPRESS_STATUSES = {'passed', 'skipped'} determines which terminal statuses are silently discarded; all others (failed, undefined, etc.) trigger a buffer flush so no failure is hidden. - _make_runner() in run_behave_parallel.py registers the formatter and sets it as the default format whenever config.format is None (no explicit -f/--format flag). Coverage mode (BEHAVE_PARALLEL_COVERAGE=1) bypasses the formatter and falls back to config.default_format so slipcover can instrument a single process. - The formatter lives in a separate file to keep both scripts under the 500-line limit. _install_behave_parallel() in noxfile.py copies both files into the behave_parallel package. A try/except import handles both the direct-script path (tests via importlib) and the installed- package path (nox CI). - Three new BDD scenarios in behave_parallel_log_filtering.feature cover: (1) passing scenario -> no output, (2) failing scenario -> full output, (3) mixed run -> only failing scenario visible. All 20 scenarios pass. ISSUES CLOSED: #10987	2026-05-07 07:08:52 +00:00
HAL9000	0461f8e51f	fix(actor): remove type: ignore from subgraph cycle detection steps ... Remove # type: ignore[import-untyped] suppression comments from features/steps/actor_subgraph_cycle_detection_steps.py per CONTRIBUTING.md zero-tolerance policy on inline type suppressions. Pyright does not check the features/ directory so these suppressions were unnecessary and violated project policy.	2026-05-06 04:08:25 +00:00
HAL9000	5db663cb63	fix(actor): read actor_ref from NodeDefinition field in _detect_subgraph_cycles ... Fix cross-actor subgraph cycle detection in the actor compiler by reading actor_ref from the top-level NodeDefinition field instead of the config dict. The _detect_subgraph_cycles(), _map_node(), and compile_actor() functions were all reading node.config.get("actor_ref", "") instead of node.actor_ref. Because actor_ref is a typed, validated Pydantic field on NodeDefinition (not a key inside the untyped config dict), the old code always returned an empty string, causing cross-actor cycle detection to silently fail and leaving the system vulnerable to infinite recursion at runtime. Changes: - Fix all three call sites in src/cleveragents/actor/compiler.py - Add Behave regression tests (features/actor_subgraph_cycle_detection.feature) with @tdd_issue and @tdd_issue_1431 tags on all scenarios - Add Robot Framework integration test (robot/actor_compiler.robot) - Fix existing test helpers to use actor_ref as top-level field - Add CHANGELOG entry ISSUES CLOSED: #1431	2026-05-06 04:08:25 +00:00
HAL9000	defa04d56d	fix(cli): add --format option to actor remove command (#6491) ... ISSUES CLOSED: #6491	2026-05-06 01:07:15 +00:00
HAL9000	50d7b02850	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... - Fix extra blank line in step file causing lint failure (ruff E302) - Consolidate duplicate step_when_capture_engine_args and step_when_verify_thread_safe_args into a shared _run_get_current_revision_and_capture_kwargs() helper - Remove duplicate Scenario 3 (identical assertion to Scenario 1, different step impl) - Unify context attribute name to engine_creation_kwargs across all steps - Add explicit type annotations to all step function signatures	2026-05-05 17:48:39 +00:00
HAL9000	89a6817e95	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... MigrationRunner.get_current_revision() was creating a SQLAlchemy engine with create_engine(self.database_url) without passing connect_args={"check_same_thread": False} for SQLite databases. When called from a background thread (e.g. async startup flows), SQLite raised ProgrammingError: SQLite objects created in a thread can only be used in that same thread. The sibling method init_or_upgrade() already passes check_same_thread=False for SQLite, making this an inconsistency in the same class. Because get_pending_migrations() and check_migrations_needed() both delegate to get_current_revision(), the threading bug propagated to all three methods. This fix adds connect_args={"check_same_thread": False} to the create_engine() call in get_current_revision() when the database URL starts with "sqlite", consistent with the existing pattern in init_or_upgrade(). ISSUES CLOSED: #10507	2026-05-05 17:48:39 +00:00
HAL9000	b846ab5cd7	fix(acms): rebase ACMS index data model onto master to fix unit test failures ... Rebases the ACMS index data model and file traversal engine implementation onto the current master branch to resolve merge conflicts and fix unit test failures caused by the PR branch being 321 commits behind master. All ACMS-specific changes are preserved: - src/cleveragents/acms/index.py: ACMS index data model with hot/warm/cold/archive tiers - src/cleveragents/acms/__init__.py: Updated exports - features/acms/index_data_model_and_traversal.feature: BDD feature file - features/steps/acms_index_data_model_traversal_steps.py: Step definitions - features/environment.py: Added temp_dir cleanup hook - CHANGELOG.md: ACMS entry preserved ISSUES CLOSED: #9579	2026-05-05 17:48:37 +00:00
HAL9000	44f9abe5d1	style(test): use PROJECT_ROOT constant for clearer path resolution in pr_compliance_checklist_steps ... Applies reviewer suggestion from PR #10071 review #7500 (comment #249234): replace chained .parent calls with a named PROJECT_ROOT constant for improved readability and maintainability. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00
HAL9000	3fb49f16e4	fix(tests): restore @tdd_expected_fail on PlanContextInheritance scenario ... Bug #4198 (PlanContextInheritance prioritises fragments near the child focus) is NOT yet fixed. The previous commit incorrectly removed the @tdd_expected_fail tag, causing the unit_tests CI gate to fail with "Expected 2 skeleton fragments, got 1". Re-add @tdd_expected_fail to the scenario so CI correctly inverts the failing assertion back to a pass, per the TDD bug-fix workflow. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00
HAL9000	c8e713e50b	style(test): fix ruff format in pr_compliance_checklist_steps.py ... Collapse multi-line assert into single line to satisfy ruff format check. The CI lint job runs both ruff check and ruff format --check; the format check was failing because the assert statement used unnecessary parentheses across three lines. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00
HAL9000	63241f1859	fix(agents): add mandatory PR compliance checklist to implementation-supervisor ... Workers were systematically omitting CHANGELOG.md, CONTRIBUTORS.md, and commit footer (ISSUES CLOSED: #N), causing all PRs to be blocked from merge. Added a mandatory 8-item PR Compliance Checklist to the worker prompt body in implementation-supervisor.md that supervisors must pass to every worker. The checklist covers: 1. CHANGELOG.md update under [Unreleased] 2. CONTRIBUTORS.md update 3. Commit footer with ISSUES CLOSED: #N 4. CI verification (all quality gates green) 5. BDD/Behave test coverage 6. Epic reference in PR description 7. Labels applied via forgejo-label-manager 8. Milestone assignment Also removed @tdd_expected_fail tag from PlanContextInheritance test in depth_breadth_projection.feature (bug #4198 is fixed). Added BDD tests in features/pr_compliance_checklist.feature with 10 scenarios covering all 8 checklist items. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00
HAL9000	6fc294b24b	fix(database/migration_runner): add check_same_thread=False to get_current_revision() SQLite engine ... MigrationRunner.get_current_revision() was creating a SQLite engine without connect_args={'check_same_thread': False}, causing ProgrammingError when called from a different thread than the one that created the engine. This is now consistent with init_or_upgrade() which correctly passes check_same_thread=False for all SQLite engines. Added a Behave scenario to verify that get_current_revision() passes check_same_thread=False when creating a SQLite engine. ISSUES CLOSED: #10952	2026-05-05 11:05:07 +00:00