748 Commits

Author	SHA1	Message	Date
brent.edwards	0588495007	fix(cli): fix broken merge state in session command per spec #1451 ... The PR 1482 merge of master into bugfix/session-export-format-flag left multiple broken states: 1. delete(): Orphaned else block without matching if/elif — removed the orphaned structure that references deleted fmt/message_count vars. 2. export_session(): Multiple unbound variable references (json_data instead of data, fmt instead of output_format) and a call to deleted _render_export_panels function — fixed all references and removed the Rich panel rendering block since CLI export is JSON-only per spec §1986. 3. import_session(): References to deleted schema_version and actor_name variables in structured output envelope — replaced with data.get() calls. 4. _facade_dispatch(): Changed A2aRequest constructor from operation= to method= (matching the actual model field name) and response attributes from .status/.data to .error/.result (matching A2aResponse model). 5. Added --format flag to export_session() that explicitly rejects non-JSON data format values (md, xml, etc.) since CLI export is JSON-only per spec. Use TUI /session:export --format md for Markdown export instead. 6. Updated robot integration tests (helper_session_cli.py, session_cli.robot) to expect JSON output instead of Rich panels for file and stdout export.	2026-06-10 00:21:47 +00:00
HAL9000	79d84c1d12	fix(robot): fix PureGraph Robot Framework tests and lint violations ... - Remove unused `import ast` and fix `set_function_registry` to store callable values directly instead of calling eval() on a function object - Replace try/except/pass with contextlib.suppress (SIM105) - Add strict=False to zip() call (B905) - Wrap long line in execute_graph (E501) - Use list unpacking in assert_topo_order_equals (RUF005) - Fix keyword name: Remove hyphen from 'Non-Functional' (Python method has no hyphen so Robot generates 'Non Functional') - Rewrite Set Double And Increment Registry to evaluate lambdas directly rather than iterating a list of tuples (which paired whole tuples as loop variables instead of unpacking them) - Pass node/function name lists via Robot list variables instead of space-delimited positional args ISSUES CLOSED: #9531	2026-06-03 14:30:16 -04:00
HAL9000	3488dff9f9	fix(PureGraph): Resolve all review blockers from PR feedback ... - Remove features/pure_graph_coverage.feature to resolve duplicate BDD scenarios conflict with existing consolidated_langgraph.feature (lines 440-474) that was introduced by prior consolidation commit 60887308. Duplicate scenario execution causes unit_tests CI failure. - Replace Robot Framework stub tests in robot/langraph/pure_graph.robot with real PureGraph integration tests: * Topological order verifies start/end boundaries and node sequence * Function execution validates sequential transformation (double=1->2, increment=2->3) * Missing function test confirms graceful skip behavior without exceptions * Non-functional nodes verify pass-through semantics - Create pure_graph_lib.py Robot Framework library module with proper keywords for graph construction, topo order computation, and execution under test. ISSUES CLOSED: #9531	2026-06-03 14:30:16 -04:00
HAL9000	2837ad04a6	test(langgraph): Add missing PureGraph BDD and integration coverage ... Add comprehensive test coverage for PureGraph module: - Created features/pure_graph_coverage.feature with BDD scenarios for topological ordering, function execution, missing function handling, and non-functional nodes - Added robot/langgraph/pure_graph.robot with Robot Framework integration tests - Created benchmarks/pure_graph_bench.py with ASV benchmarks for execution throughput and ordering performance This addresses the test infrastructure gap identified in issue #9531 where PureGraph had orphaned step definitions but no feature file, and lacked integration and performance test coverage. ISSUES CLOSED: #9531	2026-06-03 14:30:16 -04:00
HAL9000	6d4134938d	feat(plans): implement configurable merge strategy for three-way merge ... ISSUES CLOSED: #9559	2026-06-03 12:16:30 -04:00
HAL9000	7279ce64dd	feat(plans): implement configurable merge strategy (prefer-parent, prefer-subplan, manual) ... Implemented a configurable merge strategy framework for three-way merges. - New module: src/cleveragents/domain/models/core/merge_strategy.py - MergeStrategy StrEnum with options: prefer-parent, prefer-subplan, manual - Helper methods: is_auto_resolve(), is_manual(), from_string() - New module: src/cleveragents/domain/models/core/merge_strategy_service.py - MergeConflict class with __eq__ for value equality comparison - MergeStrategyService to apply strategies and resolve conflicts - Proper type annotations (dict, Any) with no unused imports - BDD test suite: features/plan_merge_strategy.feature (8 scenarios) - Step definitions: features/steps/plan_merge_strategy_steps.py - Robot Framework integration tests: robot/merge_strategy.robot - Helper script: robot/helper_merge_strategy.py - Updated src/cleveragents/domain/models/core/__init__.py exports ISSUES CLOSED: #9559	2026-06-03 12:16:30 -04:00
HAL9000	15c4138aa3	fix(cli): add per-tier budget utilization breakdown to context show ... Extends the budget utilization summary in `context show` to display hot/warm/cold tier utilization percentages individually, satisfying the spec requirement for a per-tier breakdown. Previously only hot tier utilization was shown. - Hot tier: tokens used vs. max_tokens_hot budget - Warm tier: fragment count vs. max_decisions_warm budget - Cold tier: fragment count vs. max_decisions_cold budget Also updates Robot Framework helper to verify per-tier breakdown is present in output, and updates CHANGELOG/CONTRIBUTORS. ISSUES CLOSED: #9586	2026-06-03 11:24:21 -04:00
HAL9000	662e269485	fix(cli): resolve CI failures and reviewer feedback for ACMS context CLI commands ... - Fix integration test failure: Context Show Validates Empty View Name - typer.Exit is click.Exit (RuntimeError subclass), not SystemExit - Robot helper now catches typer.Exit using exit_code attribute - Helper path insertion now always places clone src at sys.path[0] to prevent /app/src from shadowing the PR branch source - Fix information disclosure: CleverAgentsError handler now logs exception internally via _logger.exception() and shows generic user-facing message instead of str(e) - Fix budget utilization: use actual per-tier token counts instead of hot_count * 100 (fragment count * arbitrary factor) - Fix type safety: _remove_fragments now uses _TierServiceProtocol instead of object, enabling proper static type checking - Fix overly broad except: cancellation handled with early return instead of catching typer.Exit(0) in the except block - Add broad glob pattern warning when --path matches > 50 entries - Remove duplicate HAL 9000 entry from CONTRIBUTORS.md - Fix Behave steps to catch typer.Exit in addition to SystemExit ISSUES CLOSED: #9586	2026-06-03 11:24:21 -04:00
HAL9000	ea25627051	feat(cli): wire up ACMS context sub-app to main CLI entry point ... The ACMS context CLI commands ('context show' / 'context clear') were fully implemented in 'acms_context.py' with comprehensive tests, mocks, benchmarks, and documentation — but the module was never imported or registered in 'cli/main.py'. This commit wires up the 'acms_context.app' Typer sub-app so that 'agents acms context show' and 'agents acms context clear' are actually accessible from the CLI. Changes: - Import acms_context in _register_subcommands() - Register acms_context.app as the 'acms' sub-app on the main Typer app - Add 'acms' to valid_cmds list in main() for fast-path validation - Add 'acms context' entry to _print_basic_help() output - Minor formatting cleanup applied by ruff ISSUES CLOSED: #9586 Refs: #9675	2026-06-03 11:24:21 -04:00
HAL9000	c65a0726a8	feat(cli): implement context show and context clear CLI commands for ACMS - Closes #9586 ... - Rewrote production CLI to use real ContextTierService (get_scoped_view, get_all_fragments, evict_lru) instead of non-existent ACMSService - Removed unused imports (Path, Panel, ScopedView) from production code - Fixed all lint issues: trailing whitespace, import ordering, nested with statements - Replaced typer.Abort() with typer.Exit(code=1) for error exits - Added input validation for empty/whitespace view parameter - Fixed error handling to use str(e) instead of e.message - Added guards against negative budget values in _format_budget_utilization - Added warning when clearing context with no filters (clear ALL) - Removed module-level console side effect - Moved mocks to features/mocks/acms_context_mocks.py per CONTRIBUTING.md - Fixed test assertions to capture real CLI output (not placeholder) - Fixed duplicate step definitions (AmbiguousStep errors) - Fixed feature file step mismatch for tier count parameter - Added Robot Framework integration tests in robot/acms_context_cli.robot - Added performance benchmarks in benchmarks/acms_context_cli_bench.py - Updated CHANGELOG.md with ACMS context CLI feature entry - Updated CONTRIBUTORS.md with ACMS context CLI contribution ISSUES CLOSED: #9586	2026-06-03 11:24:21 -04:00
HAL9000	afe89964df	chore(tests): remove stale tdd_expected_fail tags from tests now passing on master ... The tdd_expected_fail listener (robot/tdd_expected_fail_listener.py and features/environment.py) inverts test results: a test tagged @tdd_expected_fail that PASSES is forced to FAIL with the message "Bug appears to be fixed. Remove the tdd_expected_fail tag…". After rebasing onto master, 22 scenarios across 11 files were triggering that forced-failure path because the underlying bugs (#4199, #4201, #4202, #4203, #4205, #4206, #4243, #4252, #4301, #4303, #4304) have been fixed on master but the @tdd_expected_fail tags were never removed. This commit removes the stale tag (keeping @tdd_issue and @tdd_issue_<N> for traceability, per the master-side pattern in robot/tdd_skill_add_regression.robot:9 "tag removed after bug fix"). Files touched (lines: where the stale tag was): features/plan_cli_spec_alignment.feature (121, 128, 136) robot/a2a_facade.robot (40) robot/actor_cli_show.robot (13, 30) robot/actor_configuration.robot (8) robot/actor_context_export_import.robot (20, 71, 92) robot/cli_extensions.robot (61) robot/cli_formats.robot (14, 23, 30, 48, 57, 85) robot/cli_lifecycle_e2e.robot (77, 87) robot/config_project_scope.robot (37) robot/config_resolution.robot (13) robot/container_tool_exec.robot (137) Verified locally: targeted unit_tests run on features/plan_cli_spec_alignment.feature now passes 20/20 (was 17/20 with 3 scenarios forced-failed by the inversion). ISSUES CLOSED: #3677	2026-06-03 03:22:59 -04:00
freemo	7fb3fc76c8	fix(plan-lifecycle): add rollback_plan method to PlanLifecycleService ... - What was implemented - Added PLAN_ROLLED_BACK event type to the EventType enum at src/cleveragents/infrastructure/events/types.py to properly represent successful rollbacks in the domain model. - Implemented rollback_plan(plan_id: str, checkpoint_id: str) -> RollbackResult in PlanLifecycleService (src/cleveragents/application/services/plan_lifecycle_service.py) with: - Plan state validation: rejects rollback when the plan is in terminal APPLIED or CANCELLED states. - Delegation to CheckpointService.selective_rollback() to perform the actual rollback logic and obtain a RollbackResult. - Emission of PLAN_ROLLED_BACK as a domain event to reflect the completed rollback. - checkpoint_service is accepted as an optional constructor parameter; if not provided, a PlanError is raised to preserve backward compatibility. - Updated CLI behavior in src/cleveragents/cli/commands/plan.py so agents plan rollback routes through PlanLifecycleService.rollback_plan() rather than calling CheckpointService.selective_rollback() directly. - Updated PlanLifecycleService module docstring to include rollback_plan in the documented API. - Added Behave feature file features/plan_lifecycle_rollback.feature with 11 scenarios covering state validation, domain events, and delegation. - Added step implementations in features/steps/plan_lifecycle_rollback_steps.py to support the new scenarios. - Key design decisions - rollback_plan returns RollbackResult (the same result type produced by CheckpointService.selective_rollback) so the CLI can display rollback details consistently. - Terminal states APPLIED and CANCELLED are disallowed for rollback to prevent inconsistent or invalid state transitions. - checkpoint_service is optional in the PlanLifecycleService constructor; when omitted (None), a PlanError is raised to retain backward compatibility while signaling explicit dependency requirements. - CLI UI remains powered by CheckpointService for metadata enrichment (e.g., confirmation prompts), but the actual rollback action is performed via PlanLifecycleService to ensure proper domain workflow and event emission. - Technical implications - All rollback logic now flows through the domain service layer (PlanLifecycleService) to preserve invariants and emit domain events, rather than allowing ad-hoc UI routes to bypass service validation. - The UI can still retrieve checkpoint metadata for user confirmation, but the operation that modifies state uses the new rollback_plan pathway. - Tests and behavior coverage were expanded via the new Behave feature and step implementations to validate state handling, events, and delegation. - Affected modules/components - src/cleveragents/infrastructure/events/types.py - src/cleveragents/application/services/plan_lifecycle_service.py - src/cleveragents/cli/commands/plan.py - PlanLifecycleService module docstring - features/plan_lifecycle_rollback.feature - features/steps/plan_lifecycle_rollback_steps.py ISSUES CLOSED: #3677	2026-06-03 03:22:59 -04:00
HAL9000	fa215f86c6	fix(resource): move inline imports to top and remove redundant import ... Addresses remaining CI review feedback from HAL9001 on PR #8304: 1. Moved all cleveragents imports from inside function bodies to module-level in features/steps/container_clone_into_steps.py (5 functions fixed) 2. Moved BUILTIN_TYPES import from inside step_look_up_in_builtin_types() to module level in features/steps/devcontainer_sandbox_strategy_steps.py 3. Removed redundant inline import of EMPTY_CONTENT_HASH and BaseResourceHandler inside diff() method of devcontainer.py (already available at module level) 4. Fixed stale docstring referencing old 'detected' terminology in robot/helper_devcontainer_lifecycle.py cmd_transition_valid() All files pass ruff format and ruff check.	2026-06-02 20:37:35 -04:00
HAL9000	2ea588f395	fix(resource): align DETECTED->DISCOVERED rename and remove build artifacts ... - Remove committed build artifacts (test_reports/summary.txt, test_reports/test_results.json) and add test_reports/ to .gitignore - Fix CLI resource.py: update lifecycle state condition and warning banner from 'detected (not built)' to 'discovered (not built)' and 'Devcontainer detected' to 'Devcontainer discovered' to align with ContainerLifecycleState.DISCOVERED rename - Fix BDD feature file: update resource_list_lifecycle_state.feature scenario title and assertion from 'Devcontainer detected' to 'Devcontainer discovered' - Fix robot/helper_devcontainer_lifecycle.py: update enum value check from 'detected' to 'discovered' in cmd_enum_values() - Fix robot/helper_devcontainer_handler.py: update strategy check assertion from 'none' to 'snapshot' to match PR #8304 change - Update CONTRIBUTORS.md with HAL 9000 feature contribution entry Closes #7555 (via PR #8304) Fixes: CI unit_tests and integration_tests failures from PR #8304	2026-06-02 20:37:35 -04:00
HAL9000	02acbbf25c	style: fix ruff format violations in BDD steps and Robot helper ... Apply ruff format to features/steps/auto_debug_prompt_injection_steps.py and robot/helper_auto_debug_agent_prompt_injection.py to resolve CI lint failures (missing blank lines between top-level definitions).	2026-06-02 17:06:11 -04:00
HAL9000	807b56bc69	fix(agents): sanitize user-provided content in AutoDebugAgent prompts to prevent prompt injection ... - Add _sanitize_user_input() helper that catches PromptInjectionDetected and falls back to wrap_user_content() instead of crashing the agent - Remove dead code (_bs, _be variables) from all three agent methods - Use wrap_user_content() for error_analysis (internal LLM output) in _generate_fix() to avoid crashing on the agent's own output - Add @security @prompt-injection BDD tags to feature file and all scenarios - Add missing @then("the boundary markers should be present") step definition - Add Robot Framework integration tests (auto_debug_agent_prompt_injection.robot) - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #9110	2026-06-02 17:06:11 -04:00
HAL9000	38fd9cc839	fix(tests): align output-rendering tests with spec §26936 progress-omission and renamed TerminalCapabilities fields ... Four CI failures fixed: 1. JSON/YAML progress scenarios (features/output_rendering.feature:588 and :1584): The conflict resolver had preserved master's test assertions expecting ProgressIndicator elements in JSON/YAML data arrays, but the PR's _snapshot_to_dict correctly omits them per spec §26936 ("progress is omitted from JSON output"). Removed the assertions that contradict the spec-compliant implementation. 2. ColumnDef all-fields scenario (:1885): Test checked for "col_type" in raw JSON output, but _column_def_to_dict serialises the field under the key "type" (via Pydantic alias). Changed assertion to "width_hint" which IS a serialised key in the ColumnDef dict. 3. Rich-with-cursor scenario (:2154): Step constructed TerminalCapabilities(supports_cursor=True, term=...) using the old field names — now backward-compat properties, not Pydantic fields. Pydantic silently ignores unknown kwargs, leaving supports_cursor_movement=False and causing select_materializer("rich") to return TableMaterializer. Updated to supports_cursor_movement=True and term_program="xterm-256color". 4. Robot json-all / yaml-all helpers: Same conflict-resolution issue as #1: helper expected all 10 element types including "progress" in JSON/YAML data arrays. Removed "progress" from both expected lists to match the spec-compliant implementation.	2026-06-02 16:48:22 -04:00
freemo	4e5e0624fd	feat(cli): implement RendererRegistry and ElementRenderer architecture per spec ... Implement the three missing architectural components of the Output Rendering Framework as specified in issue #917: 1. RendererRegistry (spec §27249-27350): Central registry for format (MaterializationStrategy, ElementRenderer) pairs with register(), resolve(), available_formats(), is_registered() methods and a FormatRegistration model. Built-in formats pre-registered in default_registry. Replaces hardcoded if/elif chains for format resolution. 2. ElementRenderer Protocol (spec §26557-26654): Per-element render methods (render_panel, render_table, render_tree, etc.) plus serialize() and can_render(). Six concrete implementations: PlainElementRenderer, ColorElementRenderer, TableElementRenderer, RichElementRenderer, JsonElementRenderer, YamlElementRenderer. Each format now has a paired (Strategy, Renderer). 3. TerminalCapabilities (spec §27264-27301): Extended from 4 fields to all 11 spec-defined fields: width, height, supports_256_color, supports_truecolor, supports_unicode, supports_alternate_screen, no_color, plus renames supports_cursor → supports_cursor_movement, term → term_program. Backward-compatible properties preserved. Additional fixes: - ColumnDef serialises column type as 'type' (not 'col_type') per spec §26199, with alias for backward compatibility - YAML output uses sort_keys=True per spec §27168 - Progress elements omitted from JSON/YAML per spec §26936 - MaterializationStrategy.bind(renderer, terminal_caps) method added to protocol and all strategy implementations (SD-19 resolved) - Updated SD documentation in __init__.py ISSUES CLOSED: #917	2026-06-02 16:48:22 -04:00
HAL9000	b0ff11ccef	fix(resource): address PR review findings for AWS SDK CloudResourceHandler ... - Extract AWS-specific logic into cloud_aws.py and cloud_providers.py to keep all files under the 500-line limit (cloud.py: 490 lines, cloud_aws.py: 498 lines, cloud_providers.py: 181 lines) - Fix sandbox test regression: change cloud_resources.feature sandbox create scenario from "aws" to "gcp" provider (AWS no longer raises NotImplementedError) - Add ImportError handling to step_sandbox_create/commit/rollback in cloud_resources_steps.py - Remove all 9 type: ignore comments from production code using proper type narrowing and boto3/botocore type stubs in typings/ - Move plan_id validation before logger.info() in all three sandbox methods (fail-fast principle) - Fix exception suppression: discover_aws_resources() now propagates exceptions instead of catching bare Exception - Move deferred imports (PhysVirt, ResourceCapabilities, _derive_child_id) to module level in cloud_aws.py - Split cloud_aws_sdk_steps.py (755 lines) into focused modules: cloud_aws_helpers.py, cloud_aws_session_steps.py, cloud_aws_discover_steps.py, cloud_aws_sandbox_steps.py - Add CHANGELOG.md entry for AWS SDK integration feature - Update robot/helper_cloud_resources.py to handle ImportError/ NotImplementedError for AWS sandbox operations ISSUES CLOSED: #1021	2026-06-02 07:37:13 -04:00
HAL9000	de1fd49594	fix(plan-lifecycle): fix integration test regressions from DoD gating ... Update integration test helpers to use definition_of_done values that satisfy the new TextMatchEvaluator gate (criterion text must appear as a substring of a plan argument key or value). Also fix _evaluate_dod to merge DoD metadata into plan.validation_summary without overwriting Execute-phase validation counts, preserving the coverage/tool-validation gate used by apply_with_validation_gate. Update CONTRIBUTORS.md. Fixes: wf02, wf04, wf06, wf07 integration test suites. ISSUES CLOSED: #7927	2026-06-02 05:14:43 -04:00
drew	8119043837	fix(coverage): reconcile robot coverage-threshold test with pyproject delegation (WS5) ... integration_tests (Robot/pabot) failed on robot/coverage_threshold.robot "Noxfile Contains Coverage Threshold Constant": it asserted the literal `COVERAGE_THRESHOLD = 96.5` in noxfile.py, but the coverage_report session now delegates the constant to pyproject's single source (`COVERAGE_THRESHOLD = _read_coverage_fail_under()`). This was the last WS5 reconciliation gap (the plan enumerated behave feature steps + ci.yml + guidelines prose, but not the Robot suite). Assert the delegation plus the pyproject floor (`fail_under = 96.5`) instead of the literal, mirroring the behave step fix in b499834c0. The other assertions in the suite (--fail-under= substring, [tool.coverage.run], branch=true, source=["src"]) are unaffected; verified no other robot/behave/pytest test depends on the literal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-01 22:11:54 -04:00
HAL9000	9215894b98	fix(tests): rewrite Robot for-loop as comprehension to preserve indentation ... The Robot Framework `Catenate` keyword treats 2+ consecutive spaces as field separators and strips them, which breaks Python's mandatory indentation when a nested `assert` follows a `for` line. As a result the "TUI Help Command Groups By Namespace" test produced a script with a de-indented `assert` body, causing an IndentationError under `python -c` and the test to fail with rc=1. Rewrite the namespace-presence check as a single-line list comprehension over the expected group headers, mirroring the pattern already used by the sibling "Lists All Catalogued Commands" test in the same file. The check is semantically equivalent — both fail with the same diagnostic message when a group header is missing — but the flattened form survives Robot's argument tokenisation intact. ISSUES CLOSED: #3434	2026-05-31 23:00:02 -04:00
freemo	9131523a7f	fix(tui): make /help command list all catalogued slash commands from SLASH_COMMAND_SPECS ... Replace the hardcoded help string in TuiCommandRouter.handle() with a dynamic lookup against SLASH_COMMAND_SPECS from slash_catalog.py. Changes: - Add _help_command(), _help_list_all(), _help_for_command() methods to TuiCommandRouter - /help (no args): iterates SLASH_COMMAND_SPECS, groups commands by namespace (sorted alphabetically), renders all 70 commands with descriptions in colon-namespaced format (e.g. persona:list) - /help <command>: looks up the given command in SLASH_COMMAND_SPECS and renders its full help (group, description) - /help <unknown>: returns 'Unknown command: /<cmd>' message - /help /persona:list (with leading slash): strips the slash and resolves correctly - Import defaultdict and SLASH_COMMAND_SPECS at module level Tests: - Update tui_commands_coverage.feature: replace old exact-match scenario for help text with new dynamic-listing assertions - Add tui_commands_coverage_steps.py: new 'should contain' step definition - Add tui_help_command_full_catalog.feature: 12 BDD scenarios covering /help no-args, /help <command>, /help <unknown>, namespace grouping, colon-namespaced format, and regression against old hardcoded string - Add tui_help_command_full_catalog_steps.py: step definitions for the new feature (all-commands check, not-equal assertion) - Add robot/tui_help_command.robot: 5 Robot Framework integration tests verifying the help command via direct Python invocation and headless TUI startup Closes #3434 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker	2026-05-31 21:51:37 -04:00
HAL9000	565263ab24	fix(cli): fix project context show test mock for tier service ... Add ContextTierService mock to step_m5_invoke_project_context_show so the CLI command can call _get_context_tier_service() without failing. Also patch _load_policy_json to prevent JSON decode errors from MagicMock session objects. Update CHANGELOG.md and CONTRIBUTORS.md. ISSUES CLOSED: #6323	2026-05-31 20:45:10 -04:00
HAL9000	17ede04458	fix(cli): align project context show structured output ... ISSUES CLOSED: #6323	2026-05-31 20:45:10 -04:00
HAL9000	fcc780bf1b	fix(cli): align --url validation error message with test expectations ... The Behave test expected the error message to contain '--url is only valid for git resources' but the code was producing '--url only for git resources'. Updated the validation error message to match the test assertion. Also updated the Robot Framework integration test to expect the corrected message, ensuring consistency across both test suites. Fixes the failing Behave scenario: 'Using --url with a non-git resource type is rejected' by correcting the error message text output from the CLI. ISSUES CLOSED: #6322	2026-05-31 17:10:35 -04:00
HAL9000	ca55d565b6	test: add Robot Framework integration test for --url flag	2026-05-31 15:39:36 -04:00
HAL9000	4d04b2e4ad	test(tdd): restore tdd_plan_explain_plan_id regression tests for fixed behaviour ... The TDD regression files for bug #968 were incorrectly deleted instead of updated to assert the spec-compliant fixed behaviour from issue #6325. Per CONTRIBUTING.md the regression guard must be kept and updated — not removed — once the bug is fixed. Restore and update all three files to assert the new expected behaviour: - plan explain rejects a non-decision-id argument with rc=1 - error output contains "not found" - decision data fields are absent from output Also pair the orphaned robot/helper_tdd_plan_explain_plan_id.py with a restored robot test file and update it to verify rc=1 rejection behaviour. ISSUES CLOSED: #6325	2026-05-31 15:00:33 -04:00
HAL9000	c16d90058d	fix(cli): only accept decision_id in plan explain (Closes #6325)	2026-05-31 15:00:33 -04:00
freemo	497c78219a	fix(resources): remove unsupported executable resource type ... The executable resource type was not defined in the specification (docs/specification.md lines 10567-10575). The supported resource types are: git-checkout, git, fs-mount, fs-directory, fs-file, container-instance, and devcontainer-instance. Additionally, the agents resource list output included a Location column that is not part of the spec-defined columns (Name, ID, Type, Phys/Virt, Children, Projects per line 11051). Changes: - Remove executable type registration from _resource_registry_lsp.py - Remove executable from BUILTIN_TYPE_NAMES in _resource_type_validation.py - Update resource list table columns to match spec (Name, ID, Type, Phys/Virt, Children, Projects) removing Location and Description - Remove all executable-related test scenarios from features/resource_type_lsp.feature - Update robot/helper_resource_type_lsp.py to reflect 3 LSP types (not 4) and add assertions that executable is absent ISSUES CLOSED: #3077	2026-05-30 15:43:56 -04:00
freemo	c59a76cdb7	fix(cli): add spec-required 'Profile Removed' panel to agents automation-profile remove rich output ... The automation-profile remove command was only printing a plain checkmark message after deletion. The spec requires a Rich Panel titled 'Profile Removed' containing the profile name, followed by the success message. Changes: - Replace plain console.print checkmark with Panel render + success message - Panel displays 'Name: <profile-name>' under 'Profile Removed' title - Success message updated to '✓ OK Profile removed' per spec - Behave feature: add panel assertions to existing remove scenario - Behave feature: add new 'Remove custom profile shows Profile Removed panel' scenario - Robot Framework helper: update test_remove_profile() to assert panel presence ISSUES CLOSED: #2966	2026-05-30 13:59:48 -04:00
HAL9000	a726b96d26	fix(cli): address reviewer feedback on format_output rich/color fix ... - Move function-level imports to module top level in formatting.py: * Remove redundant OutputSession import inside _format_rich() * Remove redundant OutputSession import inside _format_color() * Move `import sys` from inside format_output() to module level - Fix robot/helper_cli_formats.py: * Remove redundant `import json as _json` inside format_output_rich(); use the top-level `json` module directly * Replace non-deterministic datetime.now() calls in _mock_action() and _mock_plan() with fixed datetime(2025, 1, 15, 10, 0, 0) - Split cli_output_formats_steps.py to comply with 500-line limit: * Extract all @then step definitions into new file features/steps/cli_output_format_validation_steps.py * Behave auto-discovers steps from any .py file in steps/ ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
freemo	6e47abbd63	fix(cli): fix format_output() to use rich and color renderers instead of JSON fallback ... The format_output() function in src/cleveragents/cli/formatting.py had two routing bugs that caused incorrect output for the 'rich' and 'color' formats: 1. The 'rich' format had no explicit dispatch branch and silently fell through to the final JSON fallback, returning raw JSON instead of styled terminal output. Since 'rich' is the default CLI format (per ADR-021), this meant all commands using format_output() (version, info, diagnostics) produced JSON by default. 2. The 'color' format was incorrectly routed to _format_plain() instead of a color-aware renderer, producing plain text with no ANSI color codes. Fix: - Added _format_rich() helper that delegates to RichMaterializer via OutputSession, producing ANSI-styled terminal output consistent with format_output_session(). - Added _format_color() helper that delegates to ColorMaterializer via OutputSession, producing ANSI-colored terminal output. - Added explicit OutputFormat.RICH dispatch in format_output() routing. - Fixed OutputFormat.COLOR dispatch to use _format_color() instead of _format_plain(). Tests: - Updated existing BDD scenario that was validating the buggy behavior (expected JSON for rich format) to now assert correct styled output. - Added new BDD scenarios: 'rich format produces styled terminal output not JSON' and 'color format produces ANSI-colored output not plain text'. - Added Robot Framework integration tests in cli_formats.robot and helper_cli_formats.py verifying end-to-end styled output for both formats. All nox sessions pass: lint, typecheck, unit_tests, security_scan. ISSUES CLOSED: #2921	2026-05-30 11:09:06 -04:00
freemo	f2232eec09	fix(acms): align SkeletonCompressorService.compress() with SkeletonCompressor protocol ... - Updated SkeletonCompressorService.compress() to accept (fragments: tuple[ContextFragment, ...], skeleton_budget: int) -> tuple[ContextFragment, ...], matching the SkeletonCompressor protocol - Removed skeleton_ratio and CompressionResult from the public API - Added @runtime_checkable to SkeletonCompressor protocol in acms_service.py - Added structural subtype assertion at module level to prevent future protocol drift - Rewrote all Behave feature scenarios and step definitions to use skeleton_budget - Updated benchmarks and robot helpers to use absolute token budgets - Removed CompressionResult export from services __init__.py and vulture_whitelist.py - The depth_breadth_projection.py call site already correctly computed and passed skeleton_budget ISSUES CLOSED: #2925	2026-05-30 08:29:22 -04:00
HAL9000	e21fc197d3	fix(skills): fix robot integration test YAML creation for skill: wrapper key test	2026-05-30 04:04:21 -04:00
HAL9000	387b640249	fix(skills): fix CI gate failures blocking PR #1506 merge ... Fix pre-existing lint, typecheck, and security failures that were blocking the PR from passing CI: - Fix E501 line-too-long in session_service.py (remove erroneous "sha256:" string prefix from dict comprehension on line 268) - Fix W293 trailing whitespace in tool.py line 249 - Fix typecheck error in session_service.py: data.get("checksum") can return None, remove invalid string concatenation - Fix typecheck error in schema.py: add explicit dict[str, Any] type annotation for wrapper variable to resolve str|None issue - Fix vulture false positive: add "destination" Protocol parameter to vulture_whitelist.py - Fix @tdd_issue/@tdd_issue_1472 tag placement in skill_schema.feature (remove blank line between tags and scenario) - Add @tdd_issue/@tdd_issue_1472 tags to all new wrapper key scenarios - Add Robot integration test for spec-compliant skill: wrapper YAML	2026-05-30 04:04:21 -04:00
HAL9000	2c2b4e8813	test(actor): add @tdd_issue_1429 regression tests for actor_ref field reading ... Add Behave feature file and Robot Framework integration tests covering the two compiler functions fixed in issue #1429: - _map_node(): SUBGRAPH node's NodeConfig.subgraph is now populated from node.actor_ref instead of config.get("actor_ref") which always returned None - compile_actor(): metadata.subgraph_refs is now populated from node_def.actor_ref instead of node_def.config.get("actor_ref", "") which always returned an empty string Three Behave scenarios tagged @tdd_issue @tdd_issue_1429 covering: 1. NodeConfig.subgraph field populated from actor_ref (_map_node fix) 2. metadata.subgraph_refs populated from actor_ref (compile_actor fix) 3. Both fields correct together with a realistic actor ref Two Robot Framework integration tests in tdd_actor_compiler_actor_ref_1429.robot with a self-contained Python helper that exercises both code paths in isolation. ISSUES CLOSED: #1429	2026-05-30 02:07:41 -04:00
HAL9000	02e51b9298	fix(actor): fix lint errors and add regression tests for lsp_binding field (#1432) ... - Remove trailing whitespace from blank lines in _extract_lsp_bindings() (W293 at lines 160, 164, 167, 172, 183, 188, 203) - Simplify over-long line 180 (E501): auto_detect=node.lsp_binding.auto - Add Behave scenario verifying NodeLspBinding typed field populates CompilationMetadata.lsp_bindings (features/actor_lsp_binding_field.feature) - Add corresponding @given step using NodeLspBinding in actor_compiler_steps.py - Add Robot Framework regression test case and lsp-binding-field helper command confirming node.lsp_binding is read by compile_actor() - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #1432	2026-05-30 00:36:20 -04:00
brent.edwards	92e2585358	fix: add missing validations/unit-tests.yaml example ... Add the missing workflow validation example and keep the #1039 TDD regression active by removing the expected-fail tag and updating scenario narrative.\n\nTo satisfy the required full quality gates, stabilize flaky integration behavior encountered during this issue run: use a shared SQLAlchemy session in resource DAG scripts, isolate RxPY validation temp paths per test run, extend transient subprocess timeouts/retry behavior, and clear stale pabot worker artifacts before integration runs so repeated nox executions are reliable.\n\nISSUES CLOSED: #1039	2026-05-30 00:09:20 -04:00
HAL9000	8ed8750160	fix(audit): forward DomainEvent.timestamp to AuditService.record() ... AuditService.record() was generating its own timestamp internally, discarding the original DomainEvent.timestamp. This means audit entries recorded when an event was audited, not when the domain event actually occurred, breaking forensic accuracy per §Audit Logging (SEC7). Changes: - Add `timestamp: datetime | None = None` keyword parameter to AuditService.record(). When provided, uses it as created_at; falls back to datetime.now(tz=UTC) for backward compatibility. Applied to both the async queue path and the synchronous DB path. - AuditEventSubscriber._handle_event() now passes timestamp=event.timestamp so the original event creation time is preserved in audit entries. - Add 3 Behave BDD scenarios covering: full pipeline timestamp preservation, direct record() with explicit timestamp, and backward compatibility (record() without timestamp auto-generates created_at). - Add preserve_event_timestamp Robot integration test and helper subcommand. - Add static source check in security_audit.robot verifying the timestamp parameter signature exists. ISSUES CLOSED: #719	2026-05-29 16:36:39 -04:00
HAL9000	6a76ea894d	test(cli): add TDD regression tests for automation_profile._get_service() DI bypass ... Three BDD scenarios and two Robot Framework integration tests verifying that _get_service() in automation_profile.py resolves AutomationProfileService through the DI container rather than manually calling create_engine or sessionmaker (bug #990). Bug #990 was fixed by PR #1181 before this TDD test PR merged; the @tdd_expected_fail tag is therefore absent and these tests serve as permanent regression guards confirming the fix remains in place. ISSUES CLOSED: #1031	2026-05-29 15:26:47 -04:00
cleveragents-auto	ee1ec2b56d	chore: worker ruff auto-fix (pre-push lint gate)	2026-05-29 07:21:08 -04:00
HAL9000	5ede1c018a	fix(server,sync): use A2aRequest.method not .operation in tests and helpers ... The new entity-sync feature introduced A2aRequest with a `method` field (JSON-RPC 2.0 wire format), but several test/helper files used the wrong field name `operation` when constructing requests or logging, and checked non-existent `.status`/`.data` attributes on A2aResponse instead of `.result`/`.error`. Fixes: - asgi_app.py: log `a2a_request.method`, not `.operation` (typecheck error) - server_lifecycle_steps.py: send `method` key in JSON-RPC payload; look up status in `result` dict, not top-level response body - server_lifecycle.feature: expect "healthy" (what the handler returns), not "ok" - entity_sync_steps.py: construct A2aRequest(method=...) not (operation=...); assert on .result/.error instead of .status/.data - robot/helper_entity_sync.py: same method= and result/error fixes across sync_pull, sync_push, sync_status, sync_facade_no_service helpers - robot/helper_server_lifecycle.py: same method= and result path fixes ISSUES CLOSED: #1125	2026-05-29 07:21:08 -04:00
freemo	ff9c6540a2	feat(server): entity sync (_cleveragents/sync/*) ... Implement entity synchronization between client and server using the _cleveragents/sync/* A2A extension methods per the specification. Sync models (src/cleveragents/a2a/sync_models.py): - Pydantic v2 models for pull/push/status requests and responses - VectorClock with increment, merge, happens-before, and concurrency detection for distributed conflict detection - SyncEntitySnapshot, SyncConflict, SyncState, SyncQueueEntry models - SyncEntityType enum: actor, skill, action, plan, session - ConflictResolution enum: last_writer_wins, manual, server_wins, client_wins SyncService (src/cleveragents/application/services/sync_service.py): - pull(): download server namespace entities to local cache with incremental sync (since timestamps) and force-overwrite option - push(): push local entity definitions to server namespace with configurable conflict resolution strategy - status(): compare local and server entity versions, detect drift, report local-ahead, server-ahead, and concurrent conflicts - resolve_conflict(): manually resolve detected conflicts with winner selection (local or server) - Offline queue: enqueue_offline() and process_offline_queue() for retry on reconnect, with max-retries enforcement - The local/ namespace is never synced per specification A2A facade (src/cleveragents/a2a/facade.py): - Replaced sync stub handlers with real _handle_sync_pull, _handle_sync_push, _handle_sync_status routing to SyncService - Added sync_service property and TYPE_CHECKING import - Facade returns stubs when no SyncService is registered Tests: - Behave BDD: features/entity_sync.feature (65 scenarios, 247 steps) covering models, vector clocks, pull/push/status, conflict resolution, offline queue, facade integration, constructor validation, edge cases - Robot Framework: robot/entity_sync.robot (8 integration tests) ISSUES CLOSED: #866	2026-05-29 07:21:08 -04:00
freemo	b5f56a6fb8	feat(server): team collaboration features ... Implemented multi-user connection handling with user identity tracking (TeamMember with owner/admin/member/viewer roles), role-based access control (TeamPermission with read/write/admin/manage_members), concurrent session support (SessionRegistry with thread-safe locking and per-user/ per-project queries), and optimistic-locking conflict resolution (VersionStamp with last-writer-wins, reject, and merge strategies). Added TeamCollaborationService as the central orchestrator for all collaboration operations: team membership management, permission enforcement, session lifecycle, and version-stamp conflict detection/ resolution. The service cleans up user sessions when members are removed. Domain models follow existing patterns: Pydantic BaseModel with ConfigDict, StrEnum enums, ULID identifiers, and an error hierarchy rooted in TeamCollaborationError. Includes 48 Behave BDD scenarios (178 steps) covering all models, service operations, and edge cases, plus 15 Robot Framework integration tests for end-to-end workflow validation. ISSUES CLOSED: #863	2026-05-29 05:08:08 -04:00
freemo	c6ccb85bb8	feat(server): ASGI endpoint via uvicorn ... Implement FastAPI-based ASGI application served by uvicorn for the CleverAgents server mode. Add health check endpoint, A2A JSON-RPC routing, configurable host:port binding, and graceful shutdown handling. Server launches via `agents server start`. - Add FastAPI ASGI app factory at infrastructure/server/asgi_app.py with /.well-known/agent.json (Agent Card), /health (liveness), and /a2a (A2A JSON-RPC 2.0 dispatch via A2aLocalFacade) - Add ServerLifecycle class at infrastructure/server/server_lifecycle.py wrapping uvicorn.Server with SIGTERM/SIGINT graceful shutdown - Add `agents server start` CLI command with --host, --port, --log-level options, resolving defaults from Settings - Add fastapi>=0.115.0 dependency to pyproject.toml (uvicorn already present) - Add Behave BDD tests (features/server_lifecycle.feature, 20 scenarios) - Add Robot Framework integration tests (robot/server_lifecycle.robot) - Update CHANGELOG.md and vulture_whitelist.py ISSUES CLOSED: #862	2026-05-29 05:08:08 -04:00
HAL9000	8dde6c81ef	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests Fixes: - Restore require_confirmation parameter to UnitOfWork.__init__ - Add argument validation to UnitOfWork.__init__ (fail-fast) - Add explicit PostgreSQL isolation_level (READ COMMITTED) - Add dispose() method and context manager support to UnitOfWork - Fix MigrationRunner.get_current_revision() to dispose engine - Fix Settings.is_postgresql() to handle ValueError gracefully ISSUES CLOSED: #878	2026-05-29 01:04:59 -04:00
freemo	6aaf69e0a4	feat(server): implement PostgreSQL storage backend for server mode ... Add PostgreSQL support as the server-mode storage backend alongside existing SQLite for local mode. Verify all ORM models are dialect- agnostic, configure connection pooling for multi-user access, add Docker Compose for local PG development, and wire database URL selection based on deployment mode. Changes: - Add psycopg2-binary dependency to pyproject.toml - Add server_mode, db_pool_size, db_max_overflow, db_pool_recycle settings to Settings with environment variable support - Add resolve_database_url() and is_postgresql() to Settings for mode-aware database URL resolution - Configure UnitOfWork engine creation with pool_size, max_overflow, pool_recycle, and pool_pre_ping for PostgreSQL connections - Update MigrationRunner to handle both SQLite and PostgreSQL backends - Add compare_type=True to Alembic env.py for dialect-aware migrations - Add docker-compose.yml with PostgreSQL 16-alpine for local development - Add Behave BDD feature (14 scenarios) covering settings, pool config, engine creation, ORM dialect compatibility, and migration runner - Add Robot Framework integration tests (12 test cases) for the abstraction layer with requires_postgresql tag for live PG tests ISSUES CLOSED: #878	2026-05-29 01:00:08 -04:00
HAL9000	2dd920078a	fix(tests): add resolve_actor_options to mock lifecycle helpers ... The PR added resolve_actor_options() to StrategyActor, LLMStrategizeActor, and LLMExecuteActor, but the three mock lifecycle SimpleNamespace objects used by tests did not include this method, causing AttributeError at runtime: - features/mocks/mock_strategy_llm.py: make_mock_lifecycle() used by robot/helper_strategy_actor.py (strategy_actor.robot llm-json test) and features/steps/strategy_actor_llm_steps.py - features/steps/llm_actors_coverage_steps.py: _make_mock_lifecycle() used by llm_actors_coverage.feature scenarios - robot/helper_m5_e2e_context.py: inline lifecycle SimpleNamespace used by m5_e2e_verification.robot Execute Phase LLM Uses ACMS Context All three now include resolve_actor_options=MagicMock(return_value=None) matching the None-return contract the actors use when no custom backend is configured. ISSUES CLOSED: #11256	2026-05-28 17:35:08 -04:00
CoreRasurae	3e13411fcf	fix(actors): distinguish namespace/name from provider/model in actor name parsing ... When action YAML references actors using namespace/name format (e.g. `strategy_actor: local/my-strategist`), `_parse_actor_name()` incorrectly treated the namespace prefix as a provider name, causing `ValueError: Unknown provider type: local`. Changes: - `_is_known_provider()`: New utility function (strategy_resolution.py) that checks whether a slash-separated first segment matches a known `ProviderType` value (openai, anthropic, etc.). Consolidated into a single implementation; llm_actors.py now imports from strategy_resolution.py. - `_parse_actor_name()`: When the first segment IS a known provider, preserves existing behaviour (provider/model). When it is NOT a known provider, treats the input as namespace/name and returns the full name as the model identifier with the default provider. Callers SHOULD pre-resolve namespace/name references via the actor registry before calling this function. Both implementations (strategy_resolution.py and llm_actors.py) updated; ProviderType import moved to top level. - `PlanLifecycleService.resolve_actor_provider_model()`: New method that resolves a namespaced actor name (e.g. local/my-strategist) to provider/model format by looking up the actor record and extracting its provider and model fields. - `LifecycleService` Protocol (strategy_resolution.py): Added `resolve_actor_provider_model` to the protocol, eliminating the need for `# type: ignore[union-attr]` at call sites. - `PlanLifecycleProtocol` (llm_actors.py): Added `resolve_actor_provider_model` to the protocol. - Caller pre-resolution: StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow._resolve_llm(), and CLI session commands now pre-resolve actor names through the lifecycle service or via injected actor_resolver callables before calling `_parse_actor_name()`, ensuring namespace/name references are correctly mapped to their underlying LLM providers. - `_build_actor_resolver()` (cli/commands/session.py) and `_build_actor_resolver_for_session_workflow()` (a2a/facade.py): Moved `_is_known_provider` imports to top level; removed redundant `except (NotFoundError, Exception)`; added warning logging for outer exception handlers. - `make_mock_lifecycle()` (mock_strategy_llm.py) and `_make_mock_lifecycle()` (llm_actors_coverage_steps.py): Added `resolve_actor_provider_model` to mock lifecycle services for test compatibility. - Added `@tdd_issue @tdd_issue_11254` tags to all new BDD scenarios related to namespace/name disambiguation in llm_actors_coverage, strategy_actor_llm, and plan_lifecycle_service_coverage_boost_r4 feature files. - Updated docs/CHANGELOG.md with the fix entry. ISSUES CLOSED: #11254	2026-05-22 20:42:25 +01:00