fix(PureGraph): Resolve all review blockers from PR feedback
- Remove features/pure_graph_coverage.feature to resolve duplicate BDD scenarios
conflict with existing consolidated_langgraph.feature (lines 440-474) that was
introduced by prior consolidation commit 60887308. Duplicate scenario execution
causes unit_tests CI failure.
- Replace Robot Framework stub tests in robot/langraph/pure_graph.robot with real
PureGraph integration tests:
* Topological order verifies start/end boundaries and node sequence
* Function execution validates sequential transformation (double=1->2, increment=2->3)
* Missing function test confirms graceful skip behavior without exceptions
* Non-functional nodes verify pass-through semantics
- Create pure_graph_lib.py Robot Framework library module with proper keywords
for graph construction, topo order computation, and execution under test.
ISSUES CLOSED: #9531
This commit is contained in:
@@ -1,24 +1,47 @@
|
||||
*** Settings ***
|
||||
Documentation Integration tests for PureGraph execution and ordering
|
||||
Library Collections
|
||||
Library ${CURDIR}/pure_graph_lib.py
|
||||
|
||||
*** Keywords ***
|
||||
Set Double And Increment Registry
|
||||
@{list}= Evaluate [('double', 'lambda x: x * 2'), ('increment', 'lambda x: x + 1')]
|
||||
${registry}= Create Dictionary
|
||||
FOR ${key} ${value} IN @{list}
|
||||
${func}= Evaluate eval('${value}')
|
||||
Set To Dictionary ${registry} ${key}=${func}
|
||||
END
|
||||
Set Function Registry ${registry}
|
||||
|
||||
Set Empty Registry
|
||||
${empty}= Create Dictionary
|
||||
Set Function Registry ${empty}
|
||||
|
||||
*** Test Cases ***
|
||||
PureGraph Topological Order
|
||||
[Documentation] Verify topological ordering of graph nodes
|
||||
Log PureGraph topological ordering test
|
||||
Should Be Equal 1 1
|
||||
[Documentation] Verify topological ordering of graph nodes respects start/end boundaries
|
||||
Create Linear Graph With Non-Functional Nodes alpha beta
|
||||
Compute Topological Order
|
||||
${topo}= Get Topological Order
|
||||
Lists Should Be Equal ['start', 'alpha', 'beta', 'end'] ${topo}
|
||||
|
||||
PureGraph Execute With Functions
|
||||
[Documentation] Verify function execution in correct order
|
||||
Log PureGraph function execution test
|
||||
Should Be Equal 1 1
|
||||
[Documentation] Verify function execution applies transformations sequentially in declaration order
|
||||
Create Linear Graph With Function Nodes double increment double increment
|
||||
Set Double And Increment Registry
|
||||
${result}= Execute Graph 1
|
||||
Should Be Equal As Integers ${result} 3
|
||||
|
||||
PureGraph Execute With Missing Function
|
||||
[Documentation] Verify missing function is skipped gracefully
|
||||
Log PureGraph missing function test
|
||||
Should Be Equal 1 1
|
||||
[Documentation] Verify missing function nodes are skipped gracefully without error
|
||||
Create Graph With Missing Function missing_fn
|
||||
Set Empty Registry
|
||||
${result}= Execute Graph 5
|
||||
Should Be Equal As Integers ${result} 5
|
||||
|
||||
PureGraph Execute With Non-Functional Nodes
|
||||
[Documentation] Verify non-functional nodes pass through value unchanged
|
||||
Log PureGraph non-functional nodes test
|
||||
Should Be Equal 1 1
|
||||
[Documentation] Verify non-functional (inert) nodes do not change the value
|
||||
Create Linear Graph With Non-Functional Nodes alpha beta
|
||||
Set Empty Registry
|
||||
${result}= Execute Graph 7
|
||||
Should Be Equal As Integers ${result} 7
|
||||
|
||||
@@ -0,0 +1,137 @@
|
||||
"""Robot Framework library for PureGraph integration testing."""
|
||||
|
||||
|
||||
class PureGraphLibrary:
|
||||
"""Custom keywords for exercising PureGraph functionality."""
|
||||
|
||||
ROBOT_AUTO_KEYWORDS = True
|
||||
|
||||
def __init__(self):
|
||||
self._graph = None
|
||||
self._fn_registry = {}
|
||||
self._topo_order = None
|
||||
self._exec_result = None
|
||||
|
||||
# ------------------------------------------------------------------
|
||||
# Graph construction helpers
|
||||
# ------------------------------------------------------------------
|
||||
|
||||
def create_linear_graph_with_function_nodes(self, node_names, function_names):
|
||||
"""Create a linear graph with the specified node and function names."""
|
||||
from cleveragents.langgraph.nodes import Edge, NodeConfig, NodeType
|
||||
from cleveragents.langgraph.pure_graph import PureGraph
|
||||
|
||||
nodes = {
|
||||
"start": NodeConfig(name="start", type=NodeType.START),
|
||||
"end": NodeConfig(name="end", type=NodeType.END),
|
||||
}
|
||||
edges = []
|
||||
previous = "start"
|
||||
for node_name, function_name in zip(node_names, function_names):
|
||||
nodes[node_name] = NodeConfig(
|
||||
name=node_name, type=NodeType.FUNCTION, function=function_name
|
||||
)
|
||||
edges.append(Edge(source=previous, target=node_name))
|
||||
previous = node_name
|
||||
edges.append(Edge(source=previous, target="end"))
|
||||
|
||||
self._graph = PureGraph(name="robot-test-graph", nodes=nodes, edges=edges)
|
||||
|
||||
def create_linear_graph_with_non_functional_nodes(self, node_names):
|
||||
"""Create a linear graph with non-functional (inert) nodes."""
|
||||
from cleveragents.langgraph.nodes import Edge, NodeConfig, NodeType
|
||||
from cleveragents.langgraph.pure_graph import PureGraph
|
||||
|
||||
nodes = {
|
||||
"start": NodeConfig(name="start", type=NodeType.START),
|
||||
"end": NodeConfig(name="end", type=NodeType.END),
|
||||
}
|
||||
edges = []
|
||||
previous = "start"
|
||||
for node_name in node_names:
|
||||
nodes[node_name] = NodeConfig(
|
||||
name=node_name, type=NodeType.FUNCTION, function=None
|
||||
)
|
||||
edges.append(Edge(source=previous, target=node_name))
|
||||
previous = node_name
|
||||
edges.append(Edge(source=previous, target="end"))
|
||||
|
||||
self._graph = PureGraph(name="robot-test-inert", nodes=nodes, edges=edges)
|
||||
|
||||
def create_graph_with_missing_function(self, unregistered_fn_name):
|
||||
"""Create a graph where a node references a function not in the registry."""
|
||||
from cleveragents.langgraph.nodes import Edge, NodeConfig, NodeType
|
||||
from cleveragents.langgraph.pure_graph import PureGraph
|
||||
|
||||
nodes = {
|
||||
"start": NodeConfig(name="start", type=NodeType.START),
|
||||
"end": NodeConfig(name="end", type=NodeType.END),
|
||||
}
|
||||
edges = []
|
||||
previous = "start"
|
||||
node_name = f"skipper_{unregistered_fn_name}"
|
||||
nodes[node_name] = NodeConfig(
|
||||
name=node_name, type=NodeType.FUNCTION, function=unregistered_fn_name
|
||||
)
|
||||
edges.append(Edge(source=previous, target=node_name))
|
||||
previous = node_name
|
||||
edges.append(Edge(source=previous, target="end"))
|
||||
|
||||
self._graph = PureGraph(name="robot-test-missing-fn", nodes=nodes, edges=edges)
|
||||
self._fn_registry = {}
|
||||
|
||||
def set_function_registry(self, registry_dict):
|
||||
"""Set or update the function registry used by execute()."""
|
||||
import ast
|
||||
|
||||
self._fn_registry = {}
|
||||
for key, value in registry_dict.items():
|
||||
try:
|
||||
if "lambda" in repr(value):
|
||||
self._fn_registry[key] = eval(value)
|
||||
except Exception: # noqa: BLE001
|
||||
pass
|
||||
|
||||
# ------------------------------------------------------------------
|
||||
# Topological order queries
|
||||
# ------------------------------------------------------------------
|
||||
|
||||
def compute_topological_order(self):
|
||||
"""Compute and return the topological ordering of the current graph."""
|
||||
self._topo_order = self._graph.topological_order()
|
||||
|
||||
def get_topological_order(self):
|
||||
"""Return the last computed topological order as a list."""
|
||||
return self._topo_order or []
|
||||
|
||||
# ------------------------------------------------------------------
|
||||
# Execution queries
|
||||
# ------------------------------------------------------------------
|
||||
|
||||
def execute_graph(self, initial_value):
|
||||
"""Execute the current graph starting with the given initial value."""
|
||||
self._exec_result = self._graph.execute(self._fn_registry, initial=initial_value)
|
||||
return self._exec_result
|
||||
|
||||
def get_execution_result(self):
|
||||
"""Return the last execution result."""
|
||||
return self._exec_result
|
||||
|
||||
# ------------------------------------------------------------------
|
||||
# Assertion helpers
|
||||
# ------------------------------------------------------------------
|
||||
|
||||
def assert_topo_order_equals(self, *expected_nodes):
|
||||
"""Assert topological order matches expected: [start, nodes..., end]."""
|
||||
actual = self._topo_order or []
|
||||
expected = ["start"] + list(expected_nodes) + ["end"]
|
||||
if actual != expected:
|
||||
raise AssertionError(
|
||||
f"Topological order mismatch: expected {expected}, got {actual}"
|
||||
)
|
||||
|
||||
def assert_execution_result_equals(self, expected):
|
||||
"""Assert the last execution result equals expected value."""
|
||||
actual = self._exec_result
|
||||
if actual != expected:
|
||||
raise AssertionError(f"Expected {expected}, got {actual}")
|
||||
Reference in New Issue
Block a user