cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test(integration): workflow example 15 — disaster recovery, rollback a failed apply (trusted profile) #951

Closed
brent.edwards wants to merge 1 commits from test/int-wf15-disaster-recovery into master
pull from: test/int-wf15-disaster-recovery
merge into: cleveragents:master
Conversation 8 Commits 1 Files Changed 3
+574
brent.edwards commented 2026-03-14 05:52:19 +00:00
Member
Copy Link
Copy Source

Summary

  • Add Robot Framework integration test (robot/wf15_disaster_recovery.robot) for Specification Workflow Example 15: Disaster Recovery — Rollback a Failed Apply
  • Add Python helper (robot/helper_wf15_disaster_recovery.py) implementing 5 test subcommands
  • Tests cover: plan status after failed apply, decision tree with ROOT CAUSE investigation, plan explain with context and reasoning, plan rollback to checkpoint, plan correct --mode revert with guidance
  • Also fixes pre-existing test failures in database integration, architecture, providers, CLI core, and scientific paper tests

Quality Gates

  • nox -s lint — PASS
  • nox -s typecheck — PASS (0 errors)
  • nox -s integration_tests — All 5 WF15 tests PASS
  • nox -s coverage_report — 98% (>= 97%)
  • Helper file: 446 lines (under 500 limit)

Closes #779

## Summary - Add Robot Framework integration test (`robot/wf15_disaster_recovery.robot`) for Specification Workflow Example 15: Disaster Recovery — Rollback a Failed Apply - Add Python helper (`robot/helper_wf15_disaster_recovery.py`) implementing 5 test subcommands - Tests cover: plan status after failed apply, decision tree with ROOT CAUSE investigation, plan explain with context and reasoning, plan rollback to checkpoint, plan correct --mode revert with guidance - Also fixes pre-existing test failures in database integration, architecture, providers, CLI core, and scientific paper tests ## Quality Gates - `nox -s lint` — PASS - `nox -s typecheck` — PASS (0 errors) - `nox -s integration_tests` — All 5 WF15 tests PASS - `nox -s coverage_report` — 98% (>= 97%) - Helper file: 446 lines (under 500 limit) Closes #779
brent.edwards added the
Type
Testing
 label 2026-03-14 05:52:29 +00:00
brent.edwards added this to the v3.2.0 milestone 2026-03-14 05:52:30 +00:00
brent.edwards reviewed 2026-03-14 19:50:53 +00:00
brent.edwards left a comment
Author
Member
Copy Link
Copy Source

Self-Review — PR #951

Reviewer: @brent.edwards (author self-review)
Review method: 4 parallel threads + 2 fresh-eyes passes

Structural Issue — Shared with PRs #949, #952, #953, #954, #955

P1:must-fix — Duplicate pre-existing fixes across 6 PRs

This PR modifies 9 files (architecture.robot, cli_core.robot, core_cli_commands.robot, database_integration.robot, scientific_paper_basic.robot, scientific_paper_e2e_test.robot, unit_of_work.py, providers/__init__.py, vulture_whitelist.py) that are identically modified in PRs #952-#955 and partially in #949. Merging the 2nd PR will produce conflicts in all shared files.

Remediation: These PRs must be merged in a defined sequence. After each merge, remaining PRs must be rebased onto updated master to drop the already-merged shared fixes.

PR-Specific Findings

P1:must-fix — Test case names missing WF15 prefix

robot/wf15_disaster_recovery.robot

All 5 test cases lack the WF15 prefix. Other helpers (WF03, WF12) use the prefix.

P1:must-fix — Missing reset_global_state() in dispatch

Same pattern issue as PRs #944 and #949.

Verdict

3 P1. Must sequence merges and fix naming before merge.

# Self-Review — PR #951 **Reviewer:** @brent.edwards (author self-review) **Review method:** 4 parallel threads + 2 fresh-eyes passes ## Structural Issue — Shared with PRs #949, #952, #953, #954, #955 ### P1:must-fix — Duplicate pre-existing fixes across 6 PRs This PR modifies 9 files (`architecture.robot`, `cli_core.robot`, `core_cli_commands.robot`, `database_integration.robot`, `scientific_paper_basic.robot`, `scientific_paper_e2e_test.robot`, `unit_of_work.py`, `providers/__init__.py`, `vulture_whitelist.py`) that are **identically modified** in PRs #952-#955 and partially in #949. Merging the 2nd PR will produce conflicts in all shared files. **Remediation:** These PRs must be merged in a defined sequence. After each merge, remaining PRs must be rebased onto updated master to drop the already-merged shared fixes. ## PR-Specific Findings ### P1:must-fix — Test case names missing `WF15` prefix `robot/wf15_disaster_recovery.robot` All 5 test cases lack the `WF15` prefix. Other helpers (WF03, WF12) use the prefix. ### P1:must-fix — Missing `reset_global_state()` in dispatch Same pattern issue as PRs #944 and #949. ## Verdict **3 P1.** Must sequence merges and fix naming before merge.
freemo reviewed 2026-03-14 22:10:11 +00:00
freemo left a comment
Owner
Copy Link
Copy Source

PM Status — Day 34 (2026-03-14)

PR is mergeable, well-structured, and passes all quality gates. WF15 (disaster recovery / rollback) is an M3 integration test — important for M3 closure.

Missing labels: This PR needs Priority/Medium, MoSCoW/Must have, and Points/3 labels added for tracking compliance.

Action: Ready for peer review. Recommend Jeff or Luis review the Robot Framework test logic. Merge priority is MEDIUM — M3 test coverage.

**PM Status — Day 34 (2026-03-14)** PR is mergeable, well-structured, and passes all quality gates. WF15 (disaster recovery / rollback) is an M3 integration test — important for M3 closure. **Missing labels:** This PR needs `Priority/Medium`, `MoSCoW/Must have`, and `Points/3` labels added for tracking compliance. **Action:** Ready for peer review. Recommend Jeff or Luis review the Robot Framework test logic. Merge priority is MEDIUM — M3 test coverage.
freemo added the
MoSCoW
Must have
Points
3
Priority
Medium
 labels 2026-03-14 22:10:24 +00:00
brent.edwards force-pushed test/int-wf15-disaster-recovery from fc14f9dddd to b1956a295d 2026-03-15 04:39:22 +00:00 Compare
brent.edwards commented 2026-03-15 19:23:05 +00:00
Author
Member
Copy Link
Copy Source

Response to Self-Review P1s

P1 — Duplicate pre-existing fixes across 6 PRs
Acknowledged. Will rebase after earlier PRs merge to drop duplicate shared fixes.

P1 — Test case names missing WF15 prefix
Will add WF15 prefix to all 5 test case names.

P1 — Missing reset_global_state() in dispatch
Will add to main dispatch.

Will fix all P1s and rebase when the merge sequence begins.

## Response to Self-Review P1s **P1 — Duplicate pre-existing fixes across 6 PRs** Acknowledged. Will rebase after earlier PRs merge to drop duplicate shared fixes. **P1 — Test case names missing `WF15` prefix** Will add `WF15` prefix to all 5 test case names. **P1 — Missing `reset_global_state()` in dispatch** Will add to main dispatch. Will fix all P1s and rebase when the merge sequence begins.
brent.edwards force-pushed test/int-wf15-disaster-recovery from b1956a295d to c2f025bf0a 2026-03-15 19:38:43 +00:00 Compare
freemo added a new dependency 2026-03-16 02:42:21 +00:00
#627 Implement @tdd_expected_fail tag handling in Behave environment
freemo added a new dependency 2026-03-16 02:42:22 +00:00
#628 Implement @tdd_expected_fail tag handling in Robot Framework
freemo commented 2026-03-16 09:21:25 +00:00
Owner
Copy Link
Copy Source

PM Status — Day 36 (2026-03-16)

@brent.edwards — Self-review P1 response acknowledged (Day 35). The plan to rebase after earlier PRs merge and add WF15 prefixes is correct.

Note: This is M3 (v3.2.0) — Must Have priority. The integration test batch has a merge ordering dependency: earlier PRs in the sequence should merge first to reduce rebase churn.

Reviewer: @hurui200320 — please review after Brent pushes the P1 fixes. Target: Day 38 EOD.

Who Action Deadline
@brent.edwards Push P1 fixes, rebase after earlier PRs merge Day 37 EOD
@hurui200320 Review Day 38 EOD
## PM Status — Day 36 (2026-03-16) @brent.edwards — Self-review P1 response acknowledged (Day 35). The plan to rebase after earlier PRs merge and add WF15 prefixes is correct. **Note**: This is M3 (v3.2.0) — Must Have priority. The integration test batch has a merge ordering dependency: earlier PRs in the sequence should merge first to reduce rebase churn. **Reviewer**: @hurui200320 — please review after Brent pushes the P1 fixes. Target: Day 38 EOD. | Who | Action | Deadline | |-----|--------|----------| | @brent.edwards | Push P1 fixes, rebase after earlier PRs merge | Day 37 EOD | | @hurui200320 | Review | Day 38 EOD |
freemo requested review from freemo 2026-03-17 18:23:55 +00:00
freemo requested review from hamza.khyari 2026-03-17 18:23:55 +00:00
brent.edwards force-pushed test/int-wf15-disaster-recovery from 0dc4cb4b23 to 3d96ad85a7 2026-03-19 00:03:47 +00:00 Compare
brent.edwards commented 2026-03-19 00:16:20 +00:00
Author
Member
Copy Link
Copy Source

Self-Review P1 Fixes Applied — Commit 3d96ad85

Branch squash-rebased onto origin/master. All merge commits eliminated. Self-review findings verified/fixed:

Finding Status
P1: Missing WF15 prefix on test names Already prefixed
P1: Missing reset_global_state() Already present
P1: Shared-file merge sequencing Resolved by rebase — unrelated files no longer in diff
Force Tags updated Fixed — added disaster-recovery, removed stale TDD tags
on_timeout=kill Fixed — all 5 Run Process calls
CHANGELOG entry for #779 Fixed
  • nox -s lint — PASS
  • nox -s typecheck — PASS (0 errors)
## Self-Review P1 Fixes Applied — Commit `3d96ad85` Branch squash-rebased onto `origin/master`. All merge commits eliminated. Self-review findings verified/fixed: | Finding | Status | |---------|--------| | **P1**: Missing WF15 prefix on test names | Already prefixed | | **P1**: Missing `reset_global_state()` | Already present | | **P1**: Shared-file merge sequencing | Resolved by rebase — unrelated files no longer in diff | | Force Tags updated | **Fixed** — added `disaster-recovery`, removed stale TDD tags | | `on_timeout=kill` | **Fixed** — all 5 Run Process calls | | CHANGELOG entry for #779 | **Fixed** | - `nox -s lint` — **PASS** - `nox -s typecheck` — **PASS** (0 errors)
freemo approved these changes 2026-03-19 04:57:34 +00:00
Dismissed
freemo left a comment
Owner
Copy Link
Copy Source

Code Review — PR #951

Well-structured integration test for WF15 (disaster recovery/rollback). Proper labels, milestone, and issue linkage. Approved.

## Code Review — PR #951 Well-structured integration test for WF15 (disaster recovery/rollback). Proper labels, milestone, and issue linkage. **Approved.**
freemo requested review from freemo 2026-03-19 05:19:16 +00:00
brent.edwards force-pushed test/int-wf15-disaster-recovery from 3d96ad85a7 to 9f74fbbbc3 2026-03-20 00:03:30 +00:00 Compare
brent.edwards dismissed freemo's review 2026-03-20 00:03:30 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards commented 2026-03-20 03:59:32 +00:00
Author
Member
Copy Link
Copy Source

Rebased onto origin/master (79b0a2c5). CHANGELOG conflict resolved (kept master, re-added PR entry). nox -s lint PASS, nox -s typecheck PASS (0 errors). Commit 9f74fbbb.

Rebased onto `origin/master` (`79b0a2c5`). CHANGELOG conflict resolved (kept master, re-added PR entry). `nox -s lint` PASS, `nox -s typecheck` PASS (0 errors). Commit `9f74fbbb`.
brent.edwards force-pushed test/int-wf15-disaster-recovery from d95dd70499 to 2fe1628f45 2026-03-26 20:03:06 +00:00 Compare
freemo self-assigned this 2026-04-02 06:15:21 +00:00
freemo commented 2026-04-02 17:31:42 +00:00
Owner
Copy Link
Copy Source

🤖 Backlog Groomer (groomer-1): Closing as duplicate of #779.

Issue #779 (test(integration): workflow example 15 — disaster recovery, rollback and failed plan recovery) is the canonical version with full labels (MoSCoW/Must have, Priority/Medium, State/In Review, Type/Testing) and milestone v3.2.0. This issue is an exact title duplicate.

🤖 **Backlog Groomer (groomer-1):** Closing as duplicate of #779. Issue #779 (`test(integration): workflow example 15 — disaster recovery, rollback and failed plan recovery`) is the canonical version with full labels (`MoSCoW/Must have`, `Priority/Medium`, `State/In Review`, `Type/Testing`) and milestone `v3.2.0`. This issue is an exact title duplicate.
freemo closed this pull request 2026-04-02 17:31:52 +00:00
Some required checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 40s
Required
Details
CI / lint (pull_request) Failing after 4m32s
Required
Details
CI / typecheck (pull_request) Successful in 6m27s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 7m32s
Required
Details
CI / security (pull_request) Successful in 8m19s
Required
Details
CI / unit_tests (pull_request) Successful in 11m12s
Required
Details
CI / integration_tests (pull_request) Successful in 11m13s
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / e2e_tests (pull_request) Successful in 16m37s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
brent.edwards
hamza.khyari
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
MoSCoW
Must have
Points
3
Priority
Medium
Type
Testing
Milestone
No items
No Milestone v3.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees freemo
2 Participants
Notifications
Due Date
No due date set.
Depends on
#627 Implement @tdd_expected_fail tag handling in Behave environment
cleveragents/cleveragents-core
#628 Implement @tdd_expected_fail tag handling in Robot Framework
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#951
Delete Branch "test/int-wf15-disaster-recovery"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?