cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test(integration): workflow example 13 — custom automation profile with semantic escalation #949

Closed
brent.edwards wants to merge 1 commit from test/int-wf13-custom-profile into master
pull from: test/int-wf13-custom-profile
merge into: cleveragents:master
Conversation 9 Commits 1 Files changed 3 +566
brent.edwards commented 2026-03-14 04:01:37 +00:00
Member
Copy link

Summary

Integration test for Specification Workflow Example 13: Custom Automation Profile with Semantic Escalation. Exercises custom profile YAML creation, project configuration, invariant-driven escalation, decision explanation, and plan prompt/resume lifecycle under mock AI providers.

Test Cases (5)

Test Case Description
WF13 Custom Profile YAML Creation Create a custom automation profile YAML and verify actor add succeeds
WF13 Project With Custom Profile Create a project configured with the custom profile, verify project show reflects it
WF13 Invariant Escalation Add invariants, create plan, verify invariant-driven escalation triggers plan pausing
WF13 Decision Explanation Seed decisions, invoke plan explain, verify rationale and alternatives in output
WF13 Plan Prompt Resume Test plan prompt and resume lifecycle (descoped — command not yet implemented)

Changes to Existing Files

File Change Rationale
robot/cli_core.robot Timeout increased to 120s, added on_timeout=kill Prevents SIGTERM (-15) failures under CI parallel load
robot/scientific_paper_basic.robot Removed Require OpenAI Key skip guard Tests now use CLEVERAGENTS_TESTING_USE_MOCK_AI=true — no real API key needed; skip guards provided false coverage signal
robot/scientific_paper_e2e_test.robot Removed skip guard, hardened assertions Under mock AI, outputs are deterministic — conditional checks replaced with mandatory assertions

Quality Gates

Session Result
nox -s lint PASS
nox -s typecheck PASS (0 errors)
nox -s unit_tests PASS
nox -s integration_tests PASS
nox -s coverage_report 98% (>= 97%)

Closes #777

## Summary Integration test for Specification Workflow Example 13: Custom Automation Profile with Semantic Escalation. Exercises custom profile YAML creation, project configuration, invariant-driven escalation, decision explanation, and plan prompt/resume lifecycle under mock AI providers. ### Test Cases (5) | Test Case | Description | |-----------|-------------| | WF13 Custom Profile YAML Creation | Create a custom automation profile YAML and verify actor add succeeds | | WF13 Project With Custom Profile | Create a project configured with the custom profile, verify project show reflects it | | WF13 Invariant Escalation | Add invariants, create plan, verify invariant-driven escalation triggers plan pausing | | WF13 Decision Explanation | Seed decisions, invoke plan explain, verify rationale and alternatives in output | | WF13 Plan Prompt Resume | Test plan prompt and resume lifecycle (descoped — command not yet implemented) | ### Changes to Existing Files | File | Change | Rationale | |------|--------|-----------| | `robot/cli_core.robot` | Timeout increased to 120s, added `on_timeout=kill` | Prevents SIGTERM (-15) failures under CI parallel load | | `robot/scientific_paper_basic.robot` | Removed `Require OpenAI Key` skip guard | Tests now use `CLEVERAGENTS_TESTING_USE_MOCK_AI=true` — no real API key needed; skip guards provided false coverage signal | | `robot/scientific_paper_e2e_test.robot` | Removed skip guard, hardened assertions | Under mock AI, outputs are deterministic — conditional checks replaced with mandatory assertions | ### Quality Gates | Session | Result | |---------|--------| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests` | PASS | | `nox -s integration_tests` | PASS | | `nox -s coverage_report` | 98% (>= 97%) | Closes #777
test(integration): workflow example 13 — custom automation profile with semantic escalation
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / e2e_tests (pull_request) Successful in 23s
Details
CI / security (pull_request) Successful in 34s
Details
CI / typecheck (pull_request) Successful in 34s
Details
CI / unit_tests (pull_request) Successful in 2m20s
Details
CI / integration_tests (pull_request) Successful in 2m53s
Details
CI / docker (pull_request) Successful in 47s
Details
CI / coverage (pull_request) Successful in 5m59s
Details
CI / benchmark-regression (pull_request) Successful in 35m41s
Details
e8720490be 
Add Robot Framework integration test for Specification Workflow Example 13.
Exercises custom automation profile creation with specific thresholds,
invariant-driven escalation that overrides confidence-based auto-proceed,
plan explain for decision investigation, and plan prompt for human
guidance using mocked LLM providers.

Also fixes pre-existing test failures in cli_core.robot and
scientific_paper E2E tests that were failing before this commit.

ISSUES CLOSED: #777
brent.edwards added this to the v3.2.0 milestone 2026-03-14 04:01:45 +00:00
freemo commented 2026-03-14 04:40:16 +00:00
Owner
Copy link

PM Review — Day 34

Status: Mergeable, 0 reviews, M3 (v3.2.0)
Closes: #777 | Author: @brent.edwards

Process Violation: Empty PR Body

The PR body is completely empty. This is a clear CONTRIBUTING.md violation. The commit message (e872049) contains a thorough description, but the PR body must independently describe the change for reviewer context. This is especially important because this PR also modifies 3 existing test files beyond the WF13 test addition.

Review Summary

Two new files following the established helper pattern:

  • robot/wf13_custom_profile.robot — 79 lines, 5 test cases
  • robot/helper_wf13_custom_profile.py — 479 lines (under 500 limit)

Plus modifications to 3 existing files:

  • robot/cli_core.robot — 4 lines changed
  • robot/scientific_paper_basic.robot — Require OpenAI Key skip guard removed
  • robot/scientific_paper_e2e_test.robot — conditional assertions replaced with hard assertions, skip guard removed

Issues Found

[BLOCKING] Empty PR body — Must be populated with a proper description including: WF13 test summary, rationale for existing test file changes, explanation of why OpenAI key skip guards were removed.

[RISK] Removed OpenAI Key skip guards — Both scientific_paper_*.robot files had Require OpenAI Key keywords deleted. Previously tests would Skip gracefully when OPENAI_API_KEY was unset. Now they'll hard-fail. Is CI guaranteed to have this key? Or are these tests now using mocked providers? This needs clarification.

[RISK] Scientific paper assertion tightening — Conditional checks (e.g., IF ${has_latex}) replaced with mandatory Should Contain ... \\documentclass. If these tests were conditional due to flakiness, this could reintroduce failures.

[MINOR] Consider separating the WF13 test addition from the scientific paper fixes into distinct commits for cleaner review history.

Action Items

Who Action Deadline
@brent.edwards BLOCKING: Populate PR body with full description Day 35
@brent.edwards Explain rationale for removing OpenAI key skip guards Day 35
@CoreRasurae Peer review this PR (Python/integration test expertise) Day 36

Labels Applied This Session

  • Priority/Medium, State/In Review added (were missing)
## PM Review — Day 34 **Status**: Mergeable, 0 reviews, M3 (v3.2.0) **Closes**: #777 | **Author**: @brent.edwards ### Process Violation: Empty PR Body The PR body is completely empty. This is a **clear CONTRIBUTING.md violation**. The commit message (`e872049`) contains a thorough description, but the PR body must independently describe the change for reviewer context. This is especially important because this PR also modifies **3 existing test files** beyond the WF13 test addition. ### Review Summary Two new files following the established helper pattern: - `robot/wf13_custom_profile.robot` — 79 lines, 5 test cases - `robot/helper_wf13_custom_profile.py` — 479 lines (under 500 limit) Plus modifications to 3 existing files: - `robot/cli_core.robot` — 4 lines changed - `robot/scientific_paper_basic.robot` — `Require OpenAI Key` skip guard **removed** - `robot/scientific_paper_e2e_test.robot` — conditional assertions replaced with hard assertions, skip guard removed ### Issues Found **[BLOCKING] Empty PR body** — Must be populated with a proper description including: WF13 test summary, rationale for existing test file changes, explanation of why OpenAI key skip guards were removed. **[RISK] Removed OpenAI Key skip guards** — Both `scientific_paper_*.robot` files had `Require OpenAI Key` keywords deleted. Previously tests would `Skip` gracefully when `OPENAI_API_KEY` was unset. Now they'll hard-fail. Is CI guaranteed to have this key? Or are these tests now using mocked providers? This needs clarification. **[RISK] Scientific paper assertion tightening** — Conditional checks (e.g., `IF ${has_latex}`) replaced with mandatory `Should Contain ... \\documentclass`. If these tests were conditional due to flakiness, this could reintroduce failures. **[MINOR]** Consider separating the WF13 test addition from the scientific paper fixes into distinct commits for cleaner review history. ### Action Items | Who | Action | Deadline | |-----|--------|----------| | @brent.edwards | **BLOCKING**: Populate PR body with full description | Day 35 | | @brent.edwards | Explain rationale for removing OpenAI key skip guards | Day 35 | | @CoreRasurae | **Peer review** this PR (Python/integration test expertise) | Day 36 | ### Labels Applied This Session - Priority/Medium, State/In Review added (were missing)
brent.edwards reviewed 2026-03-14 19:50:45 +00:00
brent.edwards left a comment
Copy link

Self-Review — PR #949

Reviewer: @brent.edwards (author self-review)
Review method: 4 parallel threads + 2 fresh-eyes passes

Findings

P1:must-fix — # type: ignore[assignment] in _rejoin()

robot/helper_wf13_custom_profile.py:119

lines, out = text.split("\n"), []  # type: ignore[assignment]

This violates the project rule "Never use # type: ignore." PR #951 (WF15) solves the same pattern correctly with explicit annotations. Fix: replace with separate declarations.

P1:must-fix — Missing reset_global_state() in dispatch

Same issue as PR #944. Helpers WF16/17/18 reset DI singletons; this helper does not.

P1:must-fix — Test case names missing WF13 prefix

robot/wf13_custom_profile.robot

All 5 test cases lack the WF13 prefix that other workflow tests use (WF03, WF12, WF16, WF17, WF18 all prefix). This breaks filtering by workflow number.

P2:should-fix — Duplicate pre-existing fixes will conflict with PRs #951-#955

This PR modifies cli_core.robot and scientific_paper_* tests. The same fixes appear in PRs #951-#955. These PRs must be merged in sequence with rebasing between each to avoid conflicts.

Verdict

3 P1, 1 P2. P1s must be fixed before merge.

# Self-Review — PR #949 **Reviewer:** @brent.edwards (author self-review) **Review method:** 4 parallel threads + 2 fresh-eyes passes ## Findings ### P1:must-fix — `# type: ignore[assignment]` in `_rejoin()` `robot/helper_wf13_custom_profile.py:119` ```python lines, out = text.split("\n"), [] # type: ignore[assignment] ``` This violates the project rule "Never use `# type: ignore`." PR #951 (WF15) solves the same pattern correctly with explicit annotations. Fix: replace with separate declarations. ### P1:must-fix — Missing `reset_global_state()` in dispatch Same issue as PR #944. Helpers WF16/17/18 reset DI singletons; this helper does not. ### P1:must-fix — Test case names missing `WF13` prefix `robot/wf13_custom_profile.robot` All 5 test cases lack the `WF13` prefix that other workflow tests use (WF03, WF12, WF16, WF17, WF18 all prefix). This breaks filtering by workflow number. ### P2:should-fix — Duplicate pre-existing fixes will conflict with PRs #951-#955 This PR modifies `cli_core.robot` and `scientific_paper_*` tests. The same fixes appear in PRs #951-#955. These PRs must be merged in sequence with rebasing between each to avoid conflicts. ## Verdict **3 P1, 1 P2.** P1s must be fixed before merge.
brent.edwards force-pushed test/int-wf13-custom-profile from e8720490be
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 14s
Details
CI / build (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / e2e_tests (pull_request) Successful in 23s
Details
CI / security (pull_request) Successful in 34s
Details
CI / typecheck (pull_request) Successful in 34s
Details
CI / unit_tests (pull_request) Successful in 2m20s
Details
CI / integration_tests (pull_request) Successful in 2m53s
Details
CI / docker (pull_request) Successful in 47s
Details
CI / coverage (pull_request) Successful in 5m59s
Details
CI / benchmark-regression (pull_request) Successful in 35m41s
Details
to 07d57bcd9a
All checks were successful
CI / lint (pull_request) Successful in 26s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 41s
Details
CI / typecheck (pull_request) Successful in 46s
Details
CI / security (pull_request) Successful in 50s
Details
CI / build (pull_request) Successful in 24s
Details
CI / e2e_tests (pull_request) Successful in 58s
Details
CI / unit_tests (pull_request) Successful in 3m31s
Details
CI / integration_tests (pull_request) Successful in 3m37s
Details
CI / docker (pull_request) Successful in 1m7s
Details
CI / coverage (pull_request) Successful in 6m17s
Details
CI / benchmark-regression (pull_request) Successful in 40m45s
Details
2026-03-15 04:31:37 +00:00 Compare
brent.edwards commented 2026-03-15 19:23:02 +00:00
Author
Member
Copy link

Response to Self-Review P1s and PM Blocking Items

Self-Review P1s

P1 — # type: ignore[assignment] in _rejoin()
Will fix by using separate variable declarations instead of tuple assignment.

P1 — Missing reset_global_state() in dispatch
Will add reset_global_state() call in the main dispatch function.

P1 — Test case names missing WF13 prefix
Will add WF13 prefix to all 5 test case names in wf13_custom_profile.robot.

P2 — Duplicate pre-existing fixes across PRs
Acknowledged. These PRs must be merged in sequence with rebasing. Will coordinate.

PM Blocking Items

Empty PR body
Will populate with a proper description including: WF13 test summary, rationale for existing test file changes, explanation of OpenAI key skip guard removal.

Removed OpenAI Key skip guards rationale
The skip guards were removed because they caused tests to silently pass in CI without actually running, providing false coverage signal. The scientific_paper tests now use CLEVERAGENTS_TESTING_USE_MOCK_AI=true which provides deterministic mocked LLM responses, so OPENAI_API_KEY is not needed. Tests should fail honestly when something is wrong rather than silently skipping.

Scientific paper assertion tightening
The conditional checks were replaced with hard assertions because under mock AI, the outputs should be deterministic. If the test was conditional due to flakiness, the root cause was non-deterministic LLM output — mock AI eliminates that.

Working on all fixes now.

## Response to Self-Review P1s and PM Blocking Items ### Self-Review P1s **P1 — `# type: ignore[assignment]` in `_rejoin()`** Will fix by using separate variable declarations instead of tuple assignment. **P1 — Missing `reset_global_state()` in dispatch** Will add `reset_global_state()` call in the main dispatch function. **P1 — Test case names missing `WF13` prefix** Will add `WF13` prefix to all 5 test case names in `wf13_custom_profile.robot`. **P2 — Duplicate pre-existing fixes across PRs** Acknowledged. These PRs must be merged in sequence with rebasing. Will coordinate. ### PM Blocking Items **Empty PR body** Will populate with a proper description including: WF13 test summary, rationale for existing test file changes, explanation of OpenAI key skip guard removal. **Removed OpenAI Key skip guards rationale** The skip guards were removed because they caused tests to silently pass in CI without actually running, providing false coverage signal. The scientific_paper tests now use `CLEVERAGENTS_TESTING_USE_MOCK_AI=true` which provides deterministic mocked LLM responses, so `OPENAI_API_KEY` is not needed. Tests should fail honestly when something is wrong rather than silently skipping. **Scientific paper assertion tightening** The conditional checks were replaced with hard assertions because under mock AI, the outputs should be deterministic. If the test was conditional due to flakiness, the root cause was non-deterministic LLM output — mock AI eliminates that. Working on all fixes now.
brent.edwards force-pushed test/int-wf13-custom-profile from 07d57bcd9a
All checks were successful
CI / lint (pull_request) Successful in 26s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 41s
Details
CI / typecheck (pull_request) Successful in 46s
Details
CI / security (pull_request) Successful in 50s
Details
CI / build (pull_request) Successful in 24s
Details
CI / e2e_tests (pull_request) Successful in 58s
Details
CI / unit_tests (pull_request) Successful in 3m31s
Details
CI / integration_tests (pull_request) Successful in 3m37s
Details
CI / docker (pull_request) Successful in 1m7s
Details
CI / coverage (pull_request) Successful in 6m17s
Details
CI / benchmark-regression (pull_request) Successful in 40m45s
Details
to 3ae4948c90
All checks were successful
CI / lint (pull_request) Successful in 15s
Details
CI / typecheck (pull_request) Successful in 43s
Details
CI / security (pull_request) Successful in 51s
Details
CI / quality (pull_request) Successful in 27s
Details
CI / e2e_tests (pull_request) Successful in 26s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 15s
Details
CI / unit_tests (pull_request) Successful in 3m9s
Details
CI / integration_tests (pull_request) Successful in 3m43s
Details
CI / docker (pull_request) Successful in 9s
Details
CI / coverage (pull_request) Successful in 6m4s
Details
CI / benchmark-regression (pull_request) Successful in 41m23s
Details
2026-03-15 19:40:45 +00:00 Compare
test(robot): add TDD tags (tdd_issue, tdd_issue_777, tdd_expected_fail) to wf13
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 18s
Details
CI / quality (pull_request) Successful in 43s
Details
CI / security (pull_request) Successful in 47s
Details
CI / typecheck (pull_request) Successful in 47s
Details
CI / build (pull_request) Successful in 30s
Details
CI / e2e_tests (pull_request) Successful in 1m0s
Details
CI / unit_tests (pull_request) Successful in 3m52s
Details
CI / integration_tests (pull_request) Failing after 6m4s
Details
CI / coverage (pull_request) Successful in 9m30s
Details
CI / docker (pull_request) Successful in 1m6s
Details
CI / benchmark-regression (pull_request) Successful in 39m54s
Details
dd308943a8
 
Links this integration test to issue #777 using the new tdd_issue
naming convention. Marks as tdd_expected_fail since the feature
is not yet implemented.

Refs: #777, #965
Merge branch 'master' into test/int-wf13-custom-profile
Some checks failed
CI / lint (pull_request) Successful in 26s
Details
CI / quality (pull_request) Successful in 28s
Details
CI / typecheck (pull_request) Successful in 1m10s
Details
CI / security (pull_request) Successful in 1m20s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 24s
Details
CI / e2e_tests (pull_request) Successful in 1m48s
Details
CI / unit_tests (pull_request) Successful in 3m17s
Details
CI / integration_tests (pull_request) Failing after 5m33s
Details
CI / coverage (pull_request) Successful in 6m9s
Details
CI / docker (pull_request) Successful in 9s
Details
CI / benchmark-regression (pull_request) Successful in 38m5s
Details
8cc07a259c
freemo commented 2026-03-16 09:21:22 +00:00
Owner
Copy link

PM Status — Day 36 (2026-03-16)

@brent.edwards — Thank you for the self-review response (Day 35). Acknowledged the P1 fixes plan.

Blocking item from Day 34 still open: The PR body is still empty. This is a CONTRIBUTING.md violation that must be fixed before review can proceed. Please add a proper PR description per CONTRIBUTING.md §PR format.

Reviewer: @hamza.khyari — review after Brent addresses the empty body and pushes P1 fixes. Target: Day 38 EOD.

Who Action Deadline
@brent.edwards Fix empty PR body, push P1 fixes Day 37 EOD
@hamza.khyari Review Day 38 EOD
## PM Status — Day 36 (2026-03-16) @brent.edwards — Thank you for the self-review response (Day 35). Acknowledged the P1 fixes plan. **Blocking item from Day 34 still open**: The PR body is still empty. This is a CONTRIBUTING.md violation that must be fixed before review can proceed. Please add a proper PR description per CONTRIBUTING.md §PR format. **Reviewer**: @hamza.khyari — review after Brent addresses the empty body and pushes P1 fixes. Target: Day 38 EOD. | Who | Action | Deadline | |-----|--------|----------| | @brent.edwards | Fix empty PR body, push P1 fixes | Day 37 EOD | | @hamza.khyari | Review | Day 38 EOD |
brent.edwards commented 2026-03-16 18:44:54 +00:00
Author
Member
Copy link

Status Update — Day 37

@freemo — PR body has been populated with a full description per CONTRIBUTING.md, including:

  • WF13 test case summary (5 tests)
  • Changes to existing files table with rationale
  • Explanation of OpenAI key skip guard removal
  • Quality gates table

The self-review P1 fixes (type:ignore removal, reset_global_state, WF13 test name prefix) were addressed in earlier commits. Master has been merged in. Branch is up to date and ready for review.

Regarding the scientific paper assertion changes: the tests now use CLEVERAGENTS_TESTING_USE_MOCK_AI=true which provides deterministic mocked LLM responses, eliminating the need for OPENAI_API_KEY and justifying the hard assertions.

## Status Update — Day 37 @freemo — **PR body has been populated** with a full description per CONTRIBUTING.md, including: - WF13 test case summary (5 tests) - Changes to existing files table with rationale - Explanation of OpenAI key skip guard removal - Quality gates table The self-review P1 fixes (type:ignore removal, reset_global_state, WF13 test name prefix) were addressed in earlier commits. Master has been merged in. Branch is up to date and ready for review. Regarding the scientific paper assertion changes: the tests now use `CLEVERAGENTS_TESTING_USE_MOCK_AI=true` which provides deterministic mocked LLM responses, eliminating the need for `OPENAI_API_KEY` and justifying the hard assertions.
fix(robot): remove tdd_expected_fail tag from wf13 — tests now pass
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 15s
Details
CI / lint (pull_request) Successful in 18s
Details
CI / quality (pull_request) Successful in 28s
Details
CI / typecheck (pull_request) Successful in 43s
Details
CI / security (pull_request) Successful in 49s
Details
CI / e2e_tests (pull_request) Successful in 1m37s
Details
CI / unit_tests (pull_request) Successful in 3m10s
Details
CI / docker (pull_request) Successful in 9s
Details
CI / integration_tests (pull_request) Successful in 3m33s
Details
CI / coverage (pull_request) Successful in 5m49s
Details
CI / benchmark-regression (pull_request) Has been cancelled
Details
d442267681 
The tdd_expected_fail_listener correctly detects that all 5 WF13 test
cases pass, meaning the underlying feature is implemented.  Remove the
tdd_expected_fail tag so CI treats passes as passes.  Retains tdd_issue
and tdd_issue_777 tags as permanent regression references per
CONTRIBUTING.md.

ISSUES CLOSED: #777
Merge branch 'master' into test/int-wf13-custom-profile
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 16s
Details
CI / lint (pull_request) Successful in 19s
Details
CI / quality (pull_request) Successful in 35s
Details
CI / typecheck (pull_request) Successful in 1m2s
Details
CI / security (pull_request) Successful in 1m4s
Details
CI / e2e_tests (pull_request) Successful in 1m33s
Details
CI / unit_tests (pull_request) Successful in 3m8s
Details
CI / integration_tests (pull_request) Successful in 3m42s
Details
CI / docker (pull_request) Successful in 57s
Details
CI / coverage (pull_request) Successful in 6m0s
Details
CI / benchmark-regression (pull_request) Successful in 37m10s
Details
03e0ab6d98
Merge branch 'master' into test/int-wf13-custom-profile
All checks were successful
CI / lint (pull_request) Successful in 20s
Details
CI / quality (pull_request) Successful in 27s
Details
CI / typecheck (pull_request) Successful in 42s
Details
CI / security (pull_request) Successful in 59s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 18s
Details
CI / unit_tests (pull_request) Successful in 3m6s
Details
CI / e2e_tests (pull_request) Successful in 3m45s
Details
CI / integration_tests (pull_request) Successful in 3m51s
Details
CI / docker (pull_request) Successful in 1m21s
Details
CI / coverage (pull_request) Successful in 7m3s
Details
CI / benchmark-regression (pull_request) Successful in 38m11s
Details
722eef3cee
brent.edwards force-pushed test/int-wf13-custom-profile from 722eef3cee
All checks were successful
CI / lint (pull_request) Successful in 20s
Details
CI / quality (pull_request) Successful in 27s
Details
CI / typecheck (pull_request) Successful in 42s
Details
CI / security (pull_request) Successful in 59s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 18s
Details
CI / unit_tests (pull_request) Successful in 3m6s
Details
CI / e2e_tests (pull_request) Successful in 3m45s
Details
CI / integration_tests (pull_request) Successful in 3m51s
Details
CI / docker (pull_request) Successful in 1m21s
Details
CI / coverage (pull_request) Successful in 7m3s
Details
CI / benchmark-regression (pull_request) Successful in 38m11s
Details
to 9725900217
Some checks failed
CI / lint (pull_request) Successful in 16s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 19s
Details
CI / quality (pull_request) Successful in 38s
Details
CI / typecheck (pull_request) Successful in 56s
Details
CI / security (pull_request) Successful in 1m7s
Details
CI / e2e_tests (pull_request) Successful in 4m31s
Details
CI / unit_tests (pull_request) Successful in 5m45s
Details
CI / integration_tests (pull_request) Successful in 6m31s
Details
CI / docker (pull_request) Successful in 56s
Details
CI / coverage (pull_request) Successful in 7m40s
Details
CI / benchmark-regression (pull_request) Failing after 21m46s
Details
2026-03-19 00:03:23 +00:00 Compare
brent.edwards commented 2026-03-19 00:16:16 +00:00
Author
Member
Copy link

Self-Review P1 Fixes Applied — Commit 97259002

Branch squash-rebased onto origin/master. All merge commits eliminated. Self-review findings verified/fixed:

Finding Status
P1: # type: ignore[assignment] in _rejoin() Already clean — separate type annotations
P1: Missing reset_global_state() Already present in dispatcher
P1: Missing WF13 prefix on test names Already prefixed
Force Tags missing custom-profile Fixed
timeout=120s on_timeout=kill Fixed — all 5 Run Process calls
CHANGELOG entry for #777 Fixed
  • nox -s lint — PASS
  • nox -s typecheck — PASS (0 errors)
  • Helper: 482 lines (under 500)
## Self-Review P1 Fixes Applied — Commit `97259002` Branch squash-rebased onto `origin/master`. All merge commits eliminated. Self-review findings verified/fixed: | Finding | Status | |---------|--------| | **P1**: `# type: ignore[assignment]` in `_rejoin()` | Already clean — separate type annotations | | **P1**: Missing `reset_global_state()` | Already present in dispatcher | | **P1**: Missing WF13 prefix on test names | Already prefixed | | Force Tags missing `custom-profile` | **Fixed** | | `timeout=120s on_timeout=kill` | **Fixed** — all 5 Run Process calls | | CHANGELOG entry for #777 | **Fixed** | - `nox -s lint` — **PASS** - `nox -s typecheck` — **PASS** (0 errors) - Helper: 482 lines (under 500)
freemo approved these changes 2026-03-19 04:57:33 +00:00
Dismissed
freemo left a comment
Copy link

Code Review — PR #949

Well-structured integration test for WF13. Proper labels, milestone, and issue linkage. Approved.

## Code Review — PR #949 Well-structured integration test for WF13. Proper labels, milestone, and issue linkage. **Approved.**
brent.edwards force-pushed test/int-wf13-custom-profile from 9725900217
Some checks failed
CI / lint (pull_request) Successful in 16s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 19s
Details
CI / quality (pull_request) Successful in 38s
Details
CI / typecheck (pull_request) Successful in 56s
Details
CI / security (pull_request) Successful in 1m7s
Details
CI / e2e_tests (pull_request) Successful in 4m31s
Details
CI / unit_tests (pull_request) Successful in 5m45s
Details
CI / integration_tests (pull_request) Successful in 6m31s
Details
CI / docker (pull_request) Successful in 56s
Details
CI / coverage (pull_request) Successful in 7m40s
Details
CI / benchmark-regression (pull_request) Failing after 21m46s
Details
to ecc3d8ecd0
Some checks failed
CI / lint (pull_request) Successful in 27s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 31s
Details
CI / build (pull_request) Successful in 19s
Details
CI / typecheck (pull_request) Successful in 50s
Details
CI / security (pull_request) Successful in 55s
Details
CI / e2e_tests (pull_request) Successful in 5m35s
Details
CI / coverage (pull_request) Successful in 9m56s
Details
CI / integration_tests (pull_request) Failing after 15m29s
Details
CI / unit_tests (pull_request) Failing after 15m29s
Details
CI / benchmark-regression (pull_request) Successful in 39m26s
Details
CI / docker (pull_request) Has been skipped
Details
2026-03-20 00:01:50 +00:00 Compare
brent.edwards dismissed freemo's review 2026-03-20 00:01:51 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

brent.edwards commented 2026-03-20 03:59:31 +00:00
Author
Member
Copy link

Rebased onto origin/master (79b0a2c5). CHANGELOG conflict resolved (kept master, re-added PR entry). nox -s lint PASS, nox -s typecheck PASS (0 errors). Commit ecc3d8ec.

Rebased onto `origin/master` (`79b0a2c5`). CHANGELOG conflict resolved (kept master, re-added PR entry). `nox -s lint` PASS, `nox -s typecheck` PASS (0 errors). Commit `ecc3d8ec`.
Merge remote-tracking branch 'origin/master' into test/int-wf13-custom-profile
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 31s
Details
CI / lint (pull_request) Successful in 4m33s
Details
CI / quality (pull_request) Successful in 4m49s
Details
CI / typecheck (pull_request) Successful in 5m22s
Details
CI / security (pull_request) Successful in 5m35s
Details
CI / unit_tests (pull_request) Successful in 8m7s
Details
CI / docker (pull_request) Successful in 1m6s
Details
CI / integration_tests (pull_request) Successful in 10m52s
Details
CI / e2e_tests (pull_request) Successful in 11m46s
Details
CI / coverage (pull_request) Successful in 11m2s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 1h6m2s
Details
8e20a34198 
# Conflicts:
#	CHANGELOG.md
Merge remote-tracking branch 'origin/master' into test/int-wf13-custom-profile
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 16s
Details
CI / lint (pull_request) Successful in 3m34s
Details
CI / quality (pull_request) Successful in 3m50s
Details
CI / security (pull_request) Successful in 4m7s
Details
CI / typecheck (pull_request) Successful in 4m10s
Details
CI / unit_tests (pull_request) Successful in 7m54s
Details
CI / integration_tests (pull_request) Successful in 7m48s
Details
CI / e2e_tests (pull_request) Successful in 9m29s
Details
CI / docker (pull_request) Successful in 1m14s
Details
CI / coverage (pull_request) Successful in 12m0s
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / benchmark-regression (pull_request) Successful in 58m3s
Details
3160e6f183 
# Conflicts:
#	CHANGELOG.md
Merge remote-tracking branch 'origin/master' into test/int-wf13-custom-profile
Some checks failed
CI / build (pull_request) Successful in 30s
Details
CI / lint (pull_request) Successful in 5m1s
Details
CI / quality (pull_request) Successful in 5m34s
Details
CI / typecheck (pull_request) Successful in 5m34s
Details
CI / security (pull_request) Successful in 5m51s
Details
CI / integration_tests (pull_request) Successful in 11m1s
Details
CI / unit_tests (pull_request) Successful in 12m8s
Details
CI / docker (pull_request) Successful in 1m6s
Details
CI / e2e_tests (pull_request) Successful in 13m19s
Details
CI / coverage (pull_request) Successful in 11m27s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Failing after 26m53s
Details
2d85b950c1 
# Conflicts:
#	CHANGELOG.md
brent.edwards force-pushed test/int-wf13-custom-profile from 2d85b950c1
Some checks failed
CI / build (pull_request) Successful in 30s
Details
CI / lint (pull_request) Successful in 5m1s
Details
CI / quality (pull_request) Successful in 5m34s
Details
CI / typecheck (pull_request) Successful in 5m34s
Details
CI / security (pull_request) Successful in 5m51s
Details
CI / integration_tests (pull_request) Successful in 11m1s
Details
CI / unit_tests (pull_request) Successful in 12m8s
Details
CI / docker (pull_request) Successful in 1m6s
Details
CI / e2e_tests (pull_request) Successful in 13m19s
Details
CI / coverage (pull_request) Successful in 11m27s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Failing after 26m53s
Details
to 0cbf049c93
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 33s
Details
CI / lint (pull_request) Successful in 5m37s
Details
CI / typecheck (pull_request) Successful in 5m40s
Details
CI / security (pull_request) Successful in 8m30s
Details
CI / quality (pull_request) Successful in 8m38s
Details
CI / unit_tests (pull_request) Successful in 11m23s
Details
CI / docker (pull_request) Successful in 1m13s
Details
CI / integration_tests (pull_request) Successful in 13m11s
Details
CI / e2e_tests (pull_request) Successful in 15m38s
Details
CI / coverage (pull_request) Successful in 11m28s
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / benchmark-regression (pull_request) Successful in 1h7m43s
Details
2026-03-26 20:03:02 +00:00 Compare
freemo self-assigned this 2026-04-02 06:15:21 +00:00
freemo commented 2026-04-02 17:31:53 +00:00
Owner
Copy link

🤖 Backlog Groomer (groomer-1): Closing as duplicate of #777.

Issue #777 (test(integration): workflow example 13 — custom automation profile with semantic context) is the canonical version with full labels (MoSCoW/Must have, Priority/Medium, State/In Review, Type/Testing) and milestone v3.2.0. This issue is an exact title duplicate.

🤖 **Backlog Groomer (groomer-1):** Closing as duplicate of #777. Issue #777 (`test(integration): workflow example 13 — custom automation profile with semantic context`) is the canonical version with full labels (`MoSCoW/Must have`, `Priority/Medium`, `State/In Review`, `Type/Testing`) and milestone `v3.2.0`. This issue is an exact title duplicate.
freemo closed this pull request 2026-04-02 17:32:00 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 33s
Required
Details
CI / lint (pull_request) Successful in 5m37s
Required
Details
CI / typecheck (pull_request) Successful in 5m40s
Required
Details
CI / security (pull_request) Successful in 8m30s
Required
Details
CI / quality (pull_request) Successful in 8m38s
Required
Details
CI / unit_tests (pull_request) Successful in 11m23s
Required
Details
CI / docker (pull_request) Successful in 1m13s
Required
Details
CI / integration_tests (pull_request) Successful in 13m11s
Required
Details
CI / e2e_tests (pull_request) Successful in 15m38s
Details
CI / coverage (pull_request) Successful in 11m28s
Required
Details
CI / status-check (pull_request) Successful in 2s
Details
CI / benchmark-regression (pull_request) Successful in 1h7m43s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
CoreRasurae
freemo
hamza.khyari
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
freemo
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#627 Implement @tdd_expected_fail tag handling in Behave environment
cleveragents/cleveragents-core
#628 Implement @tdd_expected_fail tag handling in Robot Framework
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!949
No description provided.