fix(testing): document and harden non-AssertionError guard in apply_tdd_inversion to reduce flaky CI #8325
Merged
hurui200320
merged 1 commits from 2026-04-15 05:49:14 +00:00
fix/tdd-inversion-non-assertion-guard into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
hurui200320
Notifications
Due Date
No due date set.
Blocks
#8294 Bug: @tdd_expected_fail scenarios fail intermittently when steps raise non-AssertionError exceptions, causing flaky CI
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#8325
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/tdd-inversion-non-assertion-guard"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
apply_tdd_inversion()surface non-AssertionErrorguard firings instandard Behave output by emitting the warning to both
stderrand thestructured logger via a new
_warning_with_stderrhelper.features/tdd_expected_fail_infrastructure.feature:a non-
AssertionErrorexception (e.g.RuntimeError) prevents inversion.exception IS an
AssertionError(correct expected-fail signal path), andconfirms the step is correctly set to
passedafter inversion.CONTRIBUTING.mdthat@tdd_expected_failbug-signaling failuresmust use
AssertionError(assert/raise AssertionError(...)) soinfrastructure/runtime exceptions are not accidentally treated as expected bug
failures.
CHANGELOG.mdentry for #8294 under[Unreleased] → ### Fixed.Approach
_warning_with_stderr(message: str)is a module-private helper that calls_tdd_logger.warning(message)andprint(message, file=sys.stderr). The callsite uses an f-string rather than lazy
%-style formatting; an inline commentdocuments this is intentional because the message is always emitted to
stderrvia
print()so deferred formatting provides no benefit. An additional inlinecomment in
_warning_with_stderrdocuments that the dual-emit is intentional:the logger may route to structured sinks not visible in CI output, so stderr
guarantees visibility in Behave's console output.
Exception text in the guard warning is defensively truncated to 500 characters
(
exc_text = str(step.exception)[:500]) to avoid runaway output for exceptionswith very long
str()representations.The
stderr output should not containBDD step validates the negative path usingredirect_stderr/StringIOcapture, the same mechanism as the positivescenario. The negative scenario now also asserts
And the step "bug step" should have status "passed"to match the positive scenario's step-level status coverageand make the asymmetry explicit.
Audit (AC #4)
An audit was performed of all existing
apply_tdd_inversioncallers and@tdd_expected_failscenarios across the codebase. No violations were found:all existing scenarios correctly use
AssertionError-based failures.Deferred items
_tdd_logger.warningon line ~238)was not updated to use
_warning_with_stderr; this is out of scope for #8294and will be addressed if it causes CI visibility issues (follow-up ticket
recommended).
_warning_with_stderr— acceptable for this PR.A dedicated unit test should be added in a follow-up ticket.
Validation
nox -e lint✓nox -e typecheck✓ (0 errors, 3 import-source warnings — pre-existing)nox -e unit_tests✓ (22 scenarios intdd_expected_fail_infrastructure.feature, all pass)nox -e integration_tests✓ (1873 Robot Framework tests passed, 0 failed; pabot exit 252 is a reporting artifact, not a test failure — confirmed via xunit.xml and output.xml)nox -e e2e_tests✓ (114 E2E tests passed, 0 failed; LLM API keys available in environment)nox(full suite) ✓ (lint, format, typecheck, security_scan, dead_code, unit_tests, integration_tests, docs, build, coverage_report — all sessions successful)nox -s coverage_report✓ (coverage: 97.25% ≥ 97% threshold — AC5 satisfied)Closes #8294
c237658e6dto43106f951cThank you for submitting this PR, @hurui200320.
Acknowledgment:
PR #8325 (
fix(testing): harden TDD expected-fail non-assertion guard visibility) has been received. This PR addresses issue #8294 by:AssertionErrorguard warnings to stderr in addition to structured loggingAssertionErrorrequirement inCONTRIBUTING.mdStatus: This PR is open and awaiting review. The automated review pipeline will assess it against the project's quality gates. A human or automated review will follow.
If you have any questions about the review process or timeline, please comment here.
Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor
HAL9000 referenced this pull request2026-04-13 21:28:54 +00:00
[GROOMED]
Quality issues identified:
Actions taken:
Outstanding follow-ups:
Automated by CleverAgents Bot
Supervisor: Grooming Pool | Agent: grooming-pool-supervisor
Worker: [AUTO-GROOM-8325]
43106f951cto854f608a21854f608a21to74c6d2651bfix(testing): harden TDD expected-fail non-assertion guard visibilityto fix(testing): document and harden non-AssertionError guard in apply_tdd_inversion to reduce flaky CI@HAL9001 please review this PR
@HAL9000 please review this PR
[GROOMED]
Summary:
Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor
Code Review: APPROVED ✅
Summary
This PR correctly addresses all acceptance criteria from issue #8294. The implementation is clean, well-documented, and all quality gates pass.
Checklist
fix(testing): ...withISSUES CLOSED: #8294footerCloses #8294in PR descriptionType/*labelType/Bug[Unreleased] → ### Fixedtdd_expected_fail_infrastructure.featurenox -s coverage_reportImplementation Review
features/environment.py—_warning_with_stderrhelper%-style to f-string is intentional and correctly documented with an inline comment.message: str) -> None) is correct.features/steps/tdd_expected_fail_infrastructure_steps.py— new step definitionsstep_run_apply_inversion_failed_capture_stderrcorrectly usescontextlib.redirect_stderr+StringIOfor clean, side-effect-free stderr capture.step_check_stderr_containsandstep_check_stderr_not_containsboth guard against missingcontext.captured_stderrwith a clear error message pointing to the correct When step.features/tdd_expected_fail_infrastructure.feature— new BDD scenariosapply_tdd_inversion surfaces non-AssertionError guard warning to stderr): correctly asserts guard fires, result isTrue(not inverted), and stderr contains the expected warning text.apply_tdd_inversion does not emit guard warning for AssertionError exceptions): correctly asserts no warning emitted, result isFalse(inverted), and step status ispassed— providing symmetric coverage to the positive path.CHANGELOG.md— entry is accurate, well-scoped, and placed correctly under[Unreleased] → ### Fixed.CONTRIBUTING.md— the new rule is clear, actionable, and placed in the correct section (TDD Issue Test Tags).Deferred Items (Acknowledged)
The PR explicitly documents two acceptable deferrals:
_tdd_logger.warning~line 238) not updated — out of scope for #8294._warning_with_stderr— acceptable; follow-up ticket recommended.Neither deferred item blocks this PR.
Verdict
All five acceptance criteria from issue #8294 are satisfied. The code is correct, well-tested, and does not introduce regressions. Approved for merge.
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-8325]
Code Review Decision: APPROVED ✅
All quality criteria satisfied. PR #8325 correctly implements all five acceptance criteria from issue #8294:
_warning_with_stderrhelper emits guard warnings to both structured logger andstderrAssertionError-only requirement for@tdd_expected_failstepstdd_expected_fail_infrastructure.feature(positive + negative paths)@tdd_expected_failstep definitions — no violations foundAll 13 CI jobs green. Commit message follows Conventional Commit format with
ISSUES CLOSED: #8294footer. Milestone v3.2.0 andType/Buglabel correctly set.Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-8325]
74c6d2651btoed7dba552c@hurui200320 — The automated review pool has approved PR #8325. All five acceptance criteria from issue #8294 have been verified as satisfied:
_warning_with_stderrhelper correctly emits guard warnings to both structured logger and stderrAssertionError-only requirement for@tdd_expected_failstepstdd_expected_fail_infrastructure.feature(positive and negative paths)@tdd_expected_failstep definitions confirmed no violationsAll 13 CI jobs are green. Commit message follows Conventional Commit format with
ISSUES CLOSED: #8294footer. Milestone v3.2.0 andType/Buglabel are correctly set.The merge pool will process this PR for merging. Thank you for the contribution.
Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor
Worker: [AUTO-HUMAN-8]
HAL9000 referenced this pull request2026-04-15 03:17:32 +00:00
ed7dba552ctof67e8a2e07