test(e2e): workflow example 4 — multi-project dependency update (supervised profile) #815
Merged
hurui200320
merged 1 commits from 2026-03-30 04:01:04 +00:00
test/e2e-wf04-multi-project into master
Dismiss Review
Are you sure you want to dismiss this review?
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
hurui200320
Notifications
Due Date
No due date set.
Depends on
#627 Implement @tdd_expected_fail tag handling in Behave environment
cleveragents/cleveragents-core
#628 Implement @tdd_expected_fail tag handling in Robot Framework
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#815
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "test/e2e-wf04-multi-project"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Implements WF04 E2E coverage for ticket #750 — multi-project dependency update using the supervised automation profile. Addresses all review feedback by hardening assertions, adding unit tests, fixing import hygiene, and improving debuggability.
Closes #750.
What changed
Robot test (
robot/e2e/wf04_multi_project.robot):plan useparsing to--format jsonand extractedplan_iddeterministically.project_linksmatch all 4 expected projects exactly.Extract JSON From Stdout(usesjson.JSONDecoder().raw_decode()for resilience against trailing non-JSON output).subplan_count >= 1. If the LLM produces 0 subplans, the entire test isSkipped (visible SKIPPED in CI) rather than silently passing with all ACs individually skipped. After apply, a hard assertion catches the case where subplans existed post-execute but vanished post-apply.Count Decision Nodeskeyword now invokeswf04_snapshot_helper.py --count-nodesas a subprocess, eliminating the complex inlineEvaluateexpression and preventing the application DI container from being imported into the Robot test runner process.WF04 Test Teardownkeyword capturing plan status and decision tree on failure (mirrors WF05 pattern).ULID_PATTERNvariable.plan executecalls and positional argument order.WF04_PLAN_IDtest variable for teardown access.Snapshot helper (
robot/e2e/wf04_snapshot_helper.py):_iso()normalises all timestamps to UTC-aware format before serialisation._iso()guards against non-datetime truthy values (returns empty string).count_decision_nodes()now has amax_depth=50parameter to prevent unbounded recursion on malformed trees.count_decision_nodes()no longer decrements depth for sibling list iteration — list items are siblings, not children, so depth is passed unchanged.count_decision_nodes()root parameter typed withDecisionTreeunion alias (dict[str, Any] | list[Any]) instead of bareAny.--count-nodes <json_file|->CLI mode for subprocess-based decision-node counting from Robot keywords.sys.path.append()instead ofsys.path.insert(0, ...)to avoid shadowing the standard library.unmapped_resourcesfield to each subplan entry for debugging.json.dumps()now usesdefault=strfor defensive serialisation.ValueError | RuntimeErrorfor expected errors, broadexceptwithtraceback.format_exc()for unexpected errors. Broadexceptblocks documented with inline comments explaining the intentional catch-all pattern.Unit tests (
features/wf04_snapshot_helper.feature+features/steps/wf04_snapshot_helper_steps.py):_iso(),_enum_value(),count_decision_nodes(), and_build_snapshot()with mocked lifecycle service._build_snapshotimport moved to top-level per CONTRIBUTING.md import guidelines (no function-scoped imports).sys.path.append()instead ofsys.path.insert(0, ...)in step file to match snapshot helper convention."2026-03-15T10:30:00+00:00") instead of substring checks.plan_id,project_scopes, andvalidation_summaryfields (not justsubplan_countandsubplans).subplan_count == 2, concrete mapped project names per subplan (SUB01→proj-a,SUB02→proj-b), and serialized field values:status,child_phase,started_at, andchild_validation_summary.required_passed.child_phase,child_state,child_updated_at,execute_started_at,execute_completed_at,apply_started_at,applied_at.count_decision_nodes truncates at max_depth— verifies depth truncation behavior with a 5-level deep tree capped at max_depth=3."2026-03-15T05:30:00+00:00").Quality gates
All required gates pass on this branch:
nox -e lint✅nox -e typecheck✅nox -e unit_tests✅ (481 features, 12583 scenarios)nox -e integration_tests✅ (1775 tests)nox -e e2e_tests✅ (55 passed, 1 skipped — WF04 skipped without LLM subplan output)nox -e coverage_report✅ (98%)Notes
origin/master(0762815e, includes feat(lsp) and feat(resource) merges) and force-pushed.Deferred items (nits from prior review cycles)
The following review nits were acknowledged but deferred as they do not affect correctness:
long_descriptionfield from spec (#13)_enum_valuescenarios don't cover non-string non-enum types (#14)_build_snapshot(#15)argssection from spec Example 4 (#7) —lifecycle-applyis the system-level approach used;argsare spec examples, not test requirements.plan lifecycle-applyinstead of per-childplan apply(#6) —lifecycle-applyis the correct user-facing command that handles dependency ordering internally.f7f8017b8cto2e6278bfae2e6278bfaetodd6b24209ddd6b24209dtod57e36f22cd57e36f22cto92ee9f2c5892ee9f2c58toddd0b6accePM Review — Day 34
Status: Mergeable, 0 reviews, M4 (v3.3.0)
Closes: #750 | Author: @freemo
E2E test for WF04 (multi-project dependency update, supervised profile). Creates 4 git repos, exercises full plan lifecycle with subplan spawning. Zero mocking. Good PR body with detailed manual verification steps.
[MINOR]
PLAN_IDplaceholder in manual verification commands could confuse copy-paste users.Action Items
PM Status — Day 36 (2026-03-16)
Day 34 review assignment deadline check. This PR has 0 reviewer activity after 2 days.
Priority note: M3 PRs take precedence. Reviewers should complete M3 reviews first, then address M4+ PRs in milestone order.
Assigned reviewer: Please acknowledge and provide an ETA for your review, or flag if reassignment is needed.
@hurui200320 I am going to have you take over this PR, it is mostly completed but is waiting on #628 and #966 One is yours and one is Brent's. Please be sure to get this PR and the two blocking PRs I listed in asap, thanks.
PM Status — Day 37
Ownership transferred to @hurui200320. Blocked on #628 and #966. PR is M4 (v3.3.0).
Author: Please rebase onto latest
masterby Day 39 EOD (2026-03-19) and confirm blocker status. Check for merge conflicts proactively.PM status — Day 37
ddd0b6accetocc09528a46Code Review — PR #815
(Cannot submit formal approval — self-authored PR.)
E2E test for WF04. Well-structured with proper labels, milestone, and issue linkage. No issues found.
cc09528a46to862b34b6be862b34b6beto839fcc38c7839fcc38c7to6dbdbc618f6dbdbc618fto5c855decb85c855decb8to5ad17c45555ad17c4555to63c7b71a9763c7b71a97tod777417b03d777417b03tocdee9ea73fcdee9ea73ftocbde5e1342cbde5e1342tofd4612b4ebfd4612b4ebto51e1905a0451e1905a04to1e5525e1a91e5525e1a9to364d0b0e6b364d0b0e6btoe986b4dd35e986b4dd35to845cf61b47