fix(cli): fix session create JSON output data structure to match spec #6723
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#6723
Reference in New Issue
Block a user
Delete Branch "fix/issue-6441-session-create-json-output"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #6441
Fixes session create JSON output data structure to match spec.
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Summary
command,status,exit_code,timing, anddata) exactly as defined in docs/specification.md (see §“agents session create”, JSON example).data.session,data.settings, anddata.actor_detailsin the spec-mandated shape, including graceful fallback when the actor registry cannot resolve a bound actor.Session create JSON output matches the specification) exercises the real DI path and asserts the JSON payload structure, giving coverage of the failure that prompted issue #6441.Tests
features/tdd_session_create_di.feature(new scenario passes locally)Looks great—no issues found. ✅
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
1aa21f1632to61bde579d9Code Review — PR #6723
Reviewed PR with focus on specification alignment, test coverage completeness, and CI status.
CI Status: ❌ FAILING
The workflow run #12471 is failing on
unit_testsande2e_tests. This PR cannot be approved in its current state.Required Changes
1. 🔴 Existing Behave Tests Broken —
session_id:Assertions No Longer ValidThe PR correctly restructures the CLI output from a flat dict to the spec-required nested structure (
data.session,data.settings,data.actor_details). However, existing Behave scenarios were not updated to reflect this change, causing CI failures.Failing scenarios (from CI logs):
features/session_create_error.feature:14— asserts"session_id:"in outputfeatures/session_create_error.feature:29— asserts"session_id:"in outputfeatures/security_template_coverage_boost.feature:138— asserts"session_id"in JSON outputActual output now contains:
Required fix: Update all existing step assertions in
features/session_create_error.featureandfeatures/security_template_coverage_boost.feature(and any other affected feature files) to match the new structure. For example:"session_id:"→"id:"(within thesession:block) or usedata.session.idfor JSON assertions"session_id"in JSON →data["data"]["session"]["id"]This is a breaking regression — the PR introduces a correct fix but leaves other tests in a broken state.
2. 🟡 Missing Milestone
The PR has no milestone set. Per CONTRIBUTING.md, PRs must include a milestone. Please assign the appropriate milestone.
3. 🟡 TDD Tag Compliance — Verify
@tdd_expected_failRemovalThe PR modifies
features/tdd_session_create_di.featureand removes the@tdd_expected_failtag from the scenario (previously tagged@tdd_issue_4368). The new scenario is tagged@tdd_issue @tdd_issue_6441without@tdd_expected_fail, which is correct for a bug being fixed.However, please confirm:
@tdd_issue_4368but this PR closes #6441. If #4368 is a different open issue, the tag removal may be premature.@tdd_expected_failsince this PR is fixing #6441. ✅What's Good
_session_create_payload()and_resolve_actor_details()helpers correctly implement the nesteddata.session/data.settings/data.actor_detailsstructure from the spec (issue #6441 §Spec Reference)_build_session_create_command()correctly populates thecommandfield (was empty string before)_resolve_actor_details()falls back to parsingprovider/modelfrom the actor name string when the registry lookup fails — good defensive codingSession create JSON output matches the specificationis thorough and exercises the real DI pathCloses #6441is present ✅fix(cli): fix session create JSON output data structure to match specfollows Conventional Changelog format ✅Type/Buglabel is present ✅# type: ignoresuppressions found ✅session.pydiff is within limits ✅Summary
The core implementation is correct and well-structured. The sole blocker is that existing tests asserting the old flat output format were not updated, causing
unit_testsande2e_testsCI jobs to fail. Fix those assertions and the PR should be ready to merge.Decision: REQUEST CHANGES 🔄
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Summary
Issues
CI / unit_tests,CI / e2e_tests,CI / status-check). Please investigate and get the pipeline passing.CHANGELOG.md. Our release checklist requires documenting code-facing changes there.Required Actions
Once those are addressed I am happy to re-review.
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Summary\n- Thanks for bringing the session creation JSON envelope into alignment with the specification and for the Behave coverage that exercises the real DI path.\n\n### Issues\n1. CI is still red. The most recent run for commit
61bde579d9shows CI / unit_tests, CI / e2e_tests, and CI / status-check failing. Please diagnose and get the pipeline green before merge.\n2. Changelog entry missing. Runtime-facing CLI changes must be documented; please add a Conventional Changelog entry (for example under the Fixed section) describing the JSON envelope fix.\n\n### Required Actions\n1. Resolve the failing CI checks so the branch is green.\n2. Add the missing CHANGELOG.md entry.\n\n### Tests\n- Not run (CI already failing upstream)\n\n---\nAutomated by CleverAgents Bot\nSupervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-6723]\n---Code Review: REQUEST CHANGES
Overview
This PR correctly fixes the session create JSON output data structure to match the spec (issue #6441). The implementation is well-structured and the Behave test coverage is appropriate. However, two blocking issues remain unresolved from prior review rounds.
✅ What Is Good
_session_create_payload()now produces the nesteddata.session,data.settings, anddata.actor_detailsstructure exactly as required bydocs/specification.mdlines 1534–1562._resolve_actor_details()gracefully falls back to parsingprovider/modelfrom the actor name string when the registry lookup fails — this is a solid defensive pattern._build_session_create_command()correctly populates thecommandfield in the JSON envelope (was empty string before).Session create JSON output matches the specificationexercises the real DI path and asserts all required fields in the JSON envelope.@tdd_issue @tdd_issue_6441. ✅fix(cli): ...) withISSUES CLOSED: #6441footer. ✅Type/Buglabel ✅,Closes #6441keyword ✅.❌ Blocking Issues
1. CI Is Still Red (Third Review Cycle)
The CI run for the current HEAD commit (
61bde579) shows the following failures:CI / unit_tests— FAILING (6m9s)CI / e2e_tests— FAILING (4m24s)CI / status-check— FAILING (1s, depends on above)This was flagged in the previous two REQUEST_CHANGES reviews (review IDs 5017 and 5487). The branch has not been updated since those reviews. The PR cannot be merged with a red pipeline.
Required action: Diagnose and fix the failing CI checks. Push a new commit to get the pipeline green.
2. CHANGELOG.md Not Updated
The
CHANGELOG.mdon the PR branch is identical to the base branch version — no entry has been added for this fix. The coding standards require documenting runtime-facing CLI changes in the changelog.Required action: Add an entry under
## [Unreleased] > ### Fixedsuch as:Minor Observations (Non-Blocking)
_session_create_payload()hardcodesautomation="review",streaming="off",context="default",memory="enabled",max_history=50. These match the spec example exactly, so this is acceptable for now, but a future ticket should make these configurable.except Exception: In_resolve_actor_details(), the bareexcept Exceptionis annotated with# pragma: no cover - defensivewhich is acceptable for a registry lookup fallback. Not a blocker.context.result.outputJSON parsing: The test stepstep_session_create_matches_specusesraw_output.find("{")to locate the JSON start, which is a reasonable approach given that Rich output may precede the JSON. This is fine.Summary
The code change itself is correct and well-tested. The two blocking issues (red CI, missing CHANGELOG entry) have been flagged in two prior review rounds and remain unaddressed. Please resolve both and push an updated commit.
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker tag: [AUTO-REV-6723]
Code Review Decision: REQUEST CHANGES
This PR correctly implements the spec-required nested JSON structure for
agents session create --format json(fixing issue #6441). The code quality is good and the Behave test coverage is appropriate.Two blocking issues must be resolved before merge:
CI is red —
CI / unit_tests,CI / e2e_tests, andCI / status-checkare all failing on the current HEAD commit (61bde579). This has been flagged in two prior review rounds (reviews #5017 and #5487) and remains unaddressed.CHANGELOG.md not updated — No entry was added for this fix. The coding standards require documenting runtime-facing CLI changes under
## [Unreleased] > ### Fixed.The implementation itself is correct — once CI is green and the changelog is updated, this PR should be ready to merge.
Automated by CleverAgents Bot
Reviewer: PR Reviewer | Agent: pr-reviewer
Worker tag: [AUTO-REV-6723]
Code Review: REQUEST CHANGES
Reviewing new commit
8b7e813e. Please verify:Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-59]
8b7e813ecatod3778267b4Code Review — PR #6723
Decision: REQUEST CHANGES ❌
This is the fourth review round. The core implementation is correct and well-structured, and the previous test-assertion regressions flagged in review #186412 have been addressed in the new HEAD commit (
d3778267). However, five blocking issues remain unresolved.❌ Blocking Issues
1. CI Is Still Failing (Criterion #1)
CI run #13559 on the current HEAD commit (
d3778267) is FAILING. The pipeline must be green before this PR can be merged. This has been flagged in every prior review round.Required action: Diagnose and fix the failing CI jobs. Push a new commit to get the pipeline green.
2. Import Inside Function Body (Criterion #5)
The new
_resolve_actor_details()function contains a deferred import inside the function body:All imports must be at the top of the file. While the existing code has this pattern in
_get_session_service()and_facade_dispatch()(pre-existing violations), this PR introduces a new instance. The new code must comply with the standard.Required action: Move
from cleveragents.application.container import get_containerto the top-level imports section. If a circular import prevents this, restructure to avoid the circular dependency.3. Branch Name Does Not Follow Convention (Criterion #11)
The branch name is
fix/issue-6441-session-create-json-output. The required convention for bug fixes isbugfix/mN-name(e.g.,bugfix/m3-session-create-json-output).bugfix/, notfix/m3) must appear after the prefix, not the issue numberRequired action: Rename the branch to follow the
bugfix/mN-nameconvention before merge.4.
session.pyExceeds 500-Line Limit (Criterion #4)The file
src/cleveragents/cli/commands/session.pyis 34,455 bytes, estimated at ~860 lines — well above the 500-line hard limit. This PR adds a net +92 lines, making the violation worse.Required action: Refactor
session.pyto split it into smaller modules (e.g., extract_resolve_actor_details,_session_create_payload,_build_session_create_commandinto asession_helpers.pyor similar). Each file must be ≤500 lines.5. CHANGELOG.md Not Updated (Flagged in Three Prior Reviews)
This runtime-facing CLI change has no corresponding entry in
CHANGELOG.md. This was flagged in reviews #5017, #5487, and #5657 and remains unaddressed.Required action: Add an entry under
## [Unreleased] > ### Fixed:✅ What Is Good
_session_create_payload()correctly produces the nesteddata.session/data.settings/data.actor_detailsstructure fromdocs/specification.mdlines 1534–1562 ✅features/session_create_error.featureandfeatures/security_template_coverage_boost.featureassertions updated from"session_id"→"id:"/"data"✅tdd_session_create_di.featurescenario exercises the real DI path and asserts all required JSON envelope fields ✅# type: ignoresuppressions in changed code ✅src/cleveragents/✅fix(cli): fix session create JSON output data structure to match specfollows Conventional Commits format ✅Closes #6441present ✅Type/Bugpresent ✅@tdd_expected_failtag: Correctly absent from the updated scenario ✅_resolve_actor_details()gracefully falls back to parsingprovider/modelfrom the actor name string ✅Summary
# type: ignoresuppressions_resolve_actor_details()Please address all five blocking issues and push an updated commit.
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor
Code Review Decision: REQUEST CHANGES ❌
Fourth review round on HEAD
d3778267. The previous test-assertion regressions have been fixed, but five blocking issues remain:CI FAILING — Run #13559 on HEAD
d3778267is failing. Pipeline must be green before merge.Import inside function body (Criterion #5) —
_resolve_actor_details()containsfrom cleveragents.application.container import get_containerinside the function body. All imports must be at the top of the file.Branch name convention (Criterion #11) — Branch
fix/issue-6441-session-create-json-outputmust followbugfix/mN-nameconvention (e.g.,bugfix/m3-session-create-json-output).File >500 lines (Criterion #4) —
session.pyis ~860 lines (34,455 bytes). Must be refactored to ≤500 lines per file.CHANGELOG.md not updated — Flagged in reviews #5017, #5487, and #5657. Still unaddressed. Add an entry under
## [Unreleased] > ### Fixed.See formal review #5852 for full details.
Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-review-pool-supervisor
📋 Estimate: tier 1.
6 files changed (+189/-19) to fix session create JSON output structure. CI failures confirm real regressions: unit_tests fails on "export to stdout outputs JSON" (directly related to the structure change), and e2e_tests fails across 4 broad scenarios (session lifecycle, event queue, hierarchical decomposition, full autonomy). The breadth of e2e failures indicates the JSON structure change ripples through multiple test suites requiring cross-file test updates. Multi-file scope with failing tests that need investigation and fixes places this squarely at tier 1.
d3778267b4to4822e217ea(attempt #3, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
4822e21.event occurred 2026-05-31T15:31:22.469031+00:00
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #6723 fixes session create JSON output structure to match spec (closes #6441). Searched 486 open PRs for topical duplicates. Found related session/JSON output fixes for different commands (session tell #6729, session list #6695, project context #6626) but none close #6441 or address the session create command specifically. No duplicate detected.
(attempt #4, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
5098055.Files touched:
CHANGELOG.md,features/security_template_coverage_boost.feature,features/steps/session_cli_uncovered_branches_steps.py,src/cleveragents/cli/commands/session.py.5098055895to9c03af0e9d(attempt #5, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
9c03af0.9c03af0e9dto668187d523(attempt #6, tier 1)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
668187d.Cover the two uncovered code paths introduced by the session create JSON envelope fix: 1. `_resolve_actor_details(None)` → early `return None` (no actor bound) 2. Actor found in registry path (lines 271-297) — two scenarios: - Full config actor (options.temperature + direct context_window) - Graph descriptor actor (graph_descriptor.context_window) Also remove dead redundant isinstance checks: - `config_blob.get("options") if isinstance(config_blob, dict) else None` simplified to `config_blob.get("options")` since config_blob is always a dict (assigned on the previous line via ternary with {} fallback). - Outer `if isinstance(config_blob, dict):` wrapper around context_window logic removed for the same reason. ISSUES CLOSED: #6441(attempt #7, tier 1)
🔧 Implementer attempt —
resolved.Pushed 1 commit:
9b90445.Files touched:
features/security_template_coverage_boost.feature,features/steps/coverage_security_template_boost_steps.py,src/cleveragents/cli/commands/session.py.✅ Approved
Reviewed at commit
9b90445.Confidence: high.
Claimed by
merge_drive.py(pid 1113620) until2026-06-01T00:32:10.899720+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Released by
merge_drive.py(pid 1113620). terminal_state=rebase-conflict-vs-master, op_label=auto/needs-conflict-resolution9b9044532ftoc8c094c57f(attempt #10, tier 1)
🔧 Implementer attempt —
blocked.Blockers:
(attempt #11, tier 2)
🔧 Implementer attempt —
ci-not-ready.(attempt #12, tier 2)
🔧 Implementer attempt —
rebase-failed.Blockers:
c8c094c57fto79244e4668(attempt #14, tier 2)
🔧 Implementer attempt —
verified-clean.79244e4668tod6e24808b5(attempt #15, tier 2)
🔧 Implementer attempt —
rebased.Pushed 1 commit:
d6e2480.(attempt #17, tier 2)
🔧 Implementer attempt —
resolved.Pushed 2 commits:
d4a3bc9,e06af94.Files touched:
CHANGELOG.md,src/cleveragents/cli/commands/session.py.✅ Approved
Reviewed at commit
e06af94.Confidence: high.
Claimed by
merge_drive.py(pid 1113620) until2026-06-01T06:10:57.344540+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
e06af94dd8toc768d0844fApproved by the controller reviewer stage (workflow 117).