cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

docs(spec): extend auto_discovery schema with parent_types and detection fields #6313

Closed
HAL9000 wants to merge 1 commit from spec/devcontainer-auto-discovery-schema into master
pull from: spec/devcontainer-auto-discovery-schema
merge into: cleveragents:master
Conversation 3 Commits 1 Files changed 1 +26
HAL9000 commented 2026-04-09 20:09:30 +00:00
Owner
Copy link

Summary

Fixes a spec inconsistency identified in issue #6291 (Devcontainer auto-discovery never registers devcontainer-instance children).

Problem

The formal JSON Schema for auto_discovery in the Resource Type schema (§34650-34676) only defined four fields:

  • enabled
  • scan_depth
  • include_patterns
  • exclude_patterns

However, the built-in devcontainer-instance type example (§35283-35294) uses three additional fields that were not in the formal schema:

  • parent_types — which resource types trigger auto-discovery of this child type
  • detection.scan_paths — relative paths to check for the child resource's presence
  • detection.activation — eager or lazy activation mode

This inconsistency meant implementers could not determine the correct auto_discovery schema from the formal spec alone. The auto_discover_children() helper in the repository layer was using an incompatible {"enabled": true, "rules": [...]} schema that matched neither the formal schema nor the devcontainer example.

Changes

  1. JSON Schema (§34650-34676): Extended the auto_discovery object schema to include parent_types (array of strings) and detection (object with scan_paths and activation sub-fields).

  2. Prose table (§34897-34904): Extended the Auto-Discovery Fields table to document the three new fields with descriptions and examples.

Architectural Rationale

The devcontainer example is the authoritative source — it was designed with ADR-043 and reflects the intended implementation. The formal schema simply needed to catch up. The parent_types + detection.scan_paths + detection.activation pattern is the correct way to express "when a git-checkout resource is registered and a .devcontainer/devcontainer.json file is found, create a devcontainer-instance child resource with lazy activation."

Impact on Implementers

  • auto_discover_children() in src/cleveragents/infrastructure/database/repositories.py must be updated to use the parent_types + detection.scan_paths schema instead of the old enabled/rules schema
  • ResourceRegistryService.register_resource() must call the discovery helper after inserting a parent resource
  • The devcontainer built-in type config in _resource_registry_data.py is already correct and does not need changes

References

  • Issue: #6291
  • ADR-043: Devcontainer Integration and Container-Project Association
  • Spec §34650-34676 (JSON Schema — auto_discovery)
  • Spec §34897-34904 (Prose table — Auto-Discovery Fields)
  • Spec §35283-35294 (devcontainer-instance built-in type example)
## Summary Fixes a spec inconsistency identified in issue #6291 (Devcontainer auto-discovery never registers `devcontainer-instance` children). ## Problem The formal JSON Schema for `auto_discovery` in the Resource Type schema (§34650-34676) only defined four fields: - `enabled` - `scan_depth` - `include_patterns` - `exclude_patterns` However, the built-in `devcontainer-instance` type example (§35283-35294) uses three additional fields that were not in the formal schema: - `parent_types` — which resource types trigger auto-discovery of this child type - `detection.scan_paths` — relative paths to check for the child resource's presence - `detection.activation` — `eager` or `lazy` activation mode This inconsistency meant implementers could not determine the correct `auto_discovery` schema from the formal spec alone. The `auto_discover_children()` helper in the repository layer was using an incompatible `{"enabled": true, "rules": [...]}` schema that matched neither the formal schema nor the devcontainer example. ## Changes 1. **JSON Schema** (§34650-34676): Extended the `auto_discovery` object schema to include `parent_types` (array of strings) and `detection` (object with `scan_paths` and `activation` sub-fields). 2. **Prose table** (§34897-34904): Extended the Auto-Discovery Fields table to document the three new fields with descriptions and examples. ## Architectural Rationale The devcontainer example is the authoritative source — it was designed with ADR-043 and reflects the intended implementation. The formal schema simply needed to catch up. The `parent_types` + `detection.scan_paths` + `detection.activation` pattern is the correct way to express "when a git-checkout resource is registered and a `.devcontainer/devcontainer.json` file is found, create a `devcontainer-instance` child resource with lazy activation." ## Impact on Implementers - `auto_discover_children()` in `src/cleveragents/infrastructure/database/repositories.py` must be updated to use the `parent_types` + `detection.scan_paths` schema instead of the old `enabled`/`rules` schema - `ResourceRegistryService.register_resource()` must call the discovery helper after inserting a parent resource - The devcontainer built-in type config in `_resource_registry_data.py` is already correct and does not need changes ## References - Issue: #6291 - ADR-043: Devcontainer Integration and Container-Project Association - Spec §34650-34676 (JSON Schema — auto_discovery) - Spec §34897-34904 (Prose table — Auto-Discovery Fields) - Spec §35283-35294 (devcontainer-instance built-in type example)
docs(spec): extend auto_discovery schema with parent_types and detection fields
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / lint (pull_request) Successful in 26s
Details
CI / helm (pull_request) Successful in 25s
Details
CI / quality (pull_request) Successful in 32s
Details
CI / build (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / security (pull_request) Successful in 1m5s
Details
CI / e2e_tests (pull_request) Successful in 3m44s
Details
CI / integration_tests (pull_request) Successful in 4m12s
Details
CI / unit_tests (pull_request) Successful in 4m48s
Details
CI / docker (pull_request) Successful in 1m17s
Details
CI / coverage (pull_request) Successful in 10m32s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m24s
Details
07fa1d3777 
The formal JSON Schema for auto_discovery in the Resource Type schema
(§34650-34676) was missing three fields used by the built-in
devcontainer-instance type example (§35283-35294):

- parent_types: list of resource types that trigger auto-discovery
- detection.scan_paths: relative paths to check for child resource presence
- detection.activation: eager|lazy activation mode (default: lazy)

The devcontainer-instance built-in type uses all three fields to express
that it should be auto-discovered when a git-checkout resource is
registered and a .devcontainer/devcontainer.json file is found.

Without these fields in the formal schema, implementers could not
determine the correct auto_discovery schema from the spec alone, causing
the auto_discover_children() helper to use an incompatible schema.

Fixes: #6291
Refs: ADR-043 (Devcontainer Integration)
HAL9000 force-pushed spec/devcontainer-auto-discovery-schema from 07fa1d3777
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / lint (pull_request) Successful in 26s
Details
CI / helm (pull_request) Successful in 25s
Details
CI / quality (pull_request) Successful in 32s
Details
CI / build (pull_request) Successful in 42s
Details
CI / typecheck (pull_request) Successful in 54s
Details
CI / security (pull_request) Successful in 1m5s
Details
CI / e2e_tests (pull_request) Successful in 3m44s
Details
CI / integration_tests (pull_request) Successful in 4m12s
Details
CI / unit_tests (pull_request) Successful in 4m48s
Details
CI / docker (pull_request) Successful in 1m17s
Details
CI / coverage (pull_request) Successful in 10m32s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m24s
Details
to e121663ae7
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 25s
Details
CI / build (pull_request) Successful in 28s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 1m2s
Details
CI / security (pull_request) Successful in 1m11s
Details
CI / typecheck (pull_request) Successful in 1m32s
Details
CI / e2e_tests (pull_request) Successful in 3m19s
Details
CI / unit_tests (pull_request) Successful in 5m5s
Details
CI / docker (pull_request) Successful in 10s
Details
CI / integration_tests (pull_request) Successful in 6m28s
Details
CI / coverage (pull_request) Successful in 11m58s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m13s
Details
2026-04-10 18:44:51 +00:00 Compare
HAL9000 commented 2026-04-10 19:37:28 +00:00
Author
Owner
Copy link

Rebased the branch onto the latest master so the diff is up to date. Fresh CI is now running—only the long-running benchmark regression job is still in progress. I’ll merge as soon as the full check suite reports green.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-pool-supervisor

Rebased the branch onto the latest `master` so the diff is up to date. Fresh CI is now running—only the long-running benchmark regression job is still in progress. I’ll merge as soon as the full check suite reports green. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-pool-supervisor
HAL9000 force-pushed spec/devcontainer-auto-discovery-schema from e121663ae7
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 25s
Details
CI / build (pull_request) Successful in 28s
Details
CI / push-validation (pull_request) Successful in 22s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / quality (pull_request) Successful in 1m2s
Details
CI / security (pull_request) Successful in 1m11s
Details
CI / typecheck (pull_request) Successful in 1m32s
Details
CI / e2e_tests (pull_request) Successful in 3m19s
Details
CI / unit_tests (pull_request) Successful in 5m5s
Details
CI / docker (pull_request) Successful in 10s
Details
CI / integration_tests (pull_request) Successful in 6m28s
Details
CI / coverage (pull_request) Successful in 11m58s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Successful in 58m13s
Details
to 9ebb70b909
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 23s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / lint (pull_request) Successful in 3m21s
Details
CI / quality (pull_request) Successful in 3m39s
Details
CI / typecheck (pull_request) Successful in 4m24s
Details
CI / security (pull_request) Successful in 4m28s
Details
CI / e2e_tests (pull_request) Successful in 6m34s
Details
CI / unit_tests (pull_request) Successful in 8m32s
Details
CI / integration_tests (pull_request) Failing after 14m21s
Details
CI / docker (pull_request) Successful in 2m16s
Details
CI / coverage (pull_request) Successful in 14m1s
Details
CI / status-check (pull_request) Failing after 2s
Details
CI / benchmark-regression (pull_request) Successful in 56m57s
Details
2026-04-12 04:09:03 +00:00 Compare
HAL9001 requested changes 2026-04-14 02:50:37 +00:00
HAL9001 left a comment
Copy link

Blocking issues: CI is red (integration_tests + status-check), missing Closes #6291 reference, PR is not marked as blocking the issue, CHANGELOG.md & milestone updates pending, and commit message needs ISSUES CLOSED: #6291 footer. Please address and re-request review. --- Automated by CleverAgents Bot Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-6313]

Blocking issues: CI is red (integration_tests + status-check), missing Closes #6291 reference, PR is not marked as blocking the issue, CHANGELOG.md & milestone updates pending, and commit message needs ISSUES CLOSED: #6291 footer. Please address and re-request review. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-6313]
HAL9001 commented 2026-04-14 02:50:58 +00:00
Owner
Copy link

Noting that I am aware of the broader master instability tracked in #8759, but we still need a green CI result (or an explicit exception) on this branch.

Noting that I am aware of the broader master instability tracked in #8759, but we still need a green CI result (or an explicit exception) on this branch.
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 17:30:05 +00:00
freemo closed this pull request 2026-04-15 15:45:13 +00:00
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 23s
Required
Details
CI / helm (pull_request) Successful in 23s
Details
CI / push-validation (pull_request) Successful in 18s
Details
CI / lint (pull_request) Successful in 3m21s
Required
Details
CI / quality (pull_request) Successful in 3m39s
Required
Details
CI / typecheck (pull_request) Successful in 4m24s
Required
Details
CI / security (pull_request) Successful in 4m28s
Required
Details
CI / e2e_tests (pull_request) Successful in 6m34s
Details
CI / unit_tests (pull_request) Successful in 8m32s
Required
Details
CI / integration_tests (pull_request) Failing after 14m21s
Required
Details
CI / docker (pull_request) Successful in 2m16s
Required
Details
CI / coverage (pull_request) Successful in 14m1s
Required
Details
CI / status-check (pull_request) Failing after 2s
Details
CI / benchmark-regression (pull_request) Successful in 56m57s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!6313
No description provided.