cleveragents/cleveragents-core

Fork 3

UAT: `agents resource add` does not trigger auto-discovery of child resources — `auto_discover_children()` is never called #6464

New issue

Open

opened 2026-04-09 21:06:55 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-09 21:06:55 +00:00

Owner

Bug Report

Feature Area

Resource System — Auto-discovery on resource registration

Spec Reference

docs/specification.md §10583, §10618–10629, §24962–24964

From spec §10583:

Every resource receives a system-assigned ULID. ... The add command uses type-specific subcommands — each registered resource type (built-in or custom) provides its own subcommand with type-appropriate arguments.

From spec §10618–10629 (expected output for agents resource add git-checkout):

╭─ Auto-discovered Children ─────────────────────────────────────────╮
│ ID               Type            Status                            │
│ ───────────────  ──────────────  ─────────────────                 │
│ 01HXR1A1B2C3…   git             created                            │
│ 01HXR1A1B2C4…   git-remote      created                            │
│ 01HXR1A1B2C5…   git-branch      created                            │
│ 01HXR1A1B2C6…   git-branch      created                            │
│ 01HXR1A1B2C7…   fs-directory    created                            │
│   + 47 git-commit resources                                        │
│   + 312 git-tree-entry resources                                   │
│   + 3 fs-directory + 28 fs-file                                    │
╰────────────────────────────────────────────────────────────────────╯
✓ OK Resource registered (395 child resources discovered)

From spec §24962:

Scans the resource to identify children (e.g., a git-checkout handler creates a git child and an fs-directory child for the worktree root; a git handler lists remotes, branches, tags, commits, stashes, and submodules; ...)

Expected Behavior (from spec)

When agents resource add git-checkout local/my-repo --path /app is run:

The resource is registered with a ULID
Auto-discovery is triggered, creating child resources (git, fs-directory, git-remote, git-branch, etc.)
The output shows an "Auto-discovered Children" panel with the discovered resources
The success message includes the count of discovered children

Actual Behavior

When agents resource add git-checkout local/my-repo --path /app is run:

The resource is registered with a ULID ✅
No auto-discovery occurs ❌ — no child resources are created
The output shows only Added resource: local/my-repo (id: <ULID>) ❌
No "Auto-discovered Children" panel ❌
No child count in success message ❌

Root Cause (Code Analysis)

auto_discover_children() is defined in src/cleveragents/infrastructure/database/repositories.py (line 2601) but is never called anywhere in the codebase.

# repositories.py line 2601 — defined but never called
def auto_discover_children(self, resource_id: str) -> list[Any]:
    """Materialize child resources per type auto-discovery."""
    ...

The register_resource() method in src/cleveragents/application/services/_resource_registry_ops.py (lines 73–175) creates the resource and returns it without calling any discovery method.

PR #6313 (spec fix) explicitly notes:

ResourceRegistryService.register_resource() must call the discovery helper after inserting a parent resource

Steps to Reproduce

agents resource add git-checkout local/test-repo --path /app --format json

Observe: JSON output has no children field, no auto-discovered resources created. Running agents resource list --all shows no child resources.

Code Location

src/cleveragents/application/services/_resource_registry_ops.py lines 73–175: register_resource() — missing call to auto_discover_children()
src/cleveragents/infrastructure/database/repositories.py line 2601: auto_discover_children() — defined but never called
src/cleveragents/cli/commands/resource.py lines 782–799: resource_add() — no auto-discovery output panel

Severity

Critical — Auto-discovery is a core feature of the Resource System. Without it:

git-checkout resources have no git or fs-directory children
Devcontainer auto-discovery (.devcontainer/devcontainer.json detection) doesn't work
The Resource DAG is never populated with auto-discovered nodes
Tools that bind to child resource types cannot resolve their bindings

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report ### Feature Area Resource System — Auto-discovery on resource registration ### Spec Reference `docs/specification.md` §10583, §10618–10629, §24962–24964 From spec §10583: > Every resource receives a system-assigned ULID. ... The `add` command uses type-specific subcommands — each registered resource type (built-in or custom) provides its own subcommand with type-appropriate arguments. From spec §10618–10629 (expected output for `agents resource add git-checkout`): ``` ╭─ Auto-discovered Children ─────────────────────────────────────────╮ │ ID Type Status │ │ ─────────────── ────────────── ───────────────── │ │ 01HXR1A1B2C3… git created │ │ 01HXR1A1B2C4… git-remote created │ │ 01HXR1A1B2C5… git-branch created │ │ 01HXR1A1B2C6… git-branch created │ │ 01HXR1A1B2C7… fs-directory created │ │ + 47 git-commit resources │ │ + 312 git-tree-entry resources │ │ + 3 fs-directory + 28 fs-file │ ╰────────────────────────────────────────────────────────────────────╯ ✓ OK Resource registered (395 child resources discovered) ``` From spec §24962: > 1. **Scans** the resource to identify children (e.g., a `git-checkout` handler creates a `git` child and an `fs-directory` child for the worktree root; a `git` handler lists remotes, branches, tags, commits, stashes, and submodules; ...) ### Expected Behavior (from spec) When `agents resource add git-checkout local/my-repo --path /app` is run: 1. The resource is registered with a ULID 2. Auto-discovery is triggered, creating child resources (git, fs-directory, git-remote, git-branch, etc.) 3. The output shows an "Auto-discovered Children" panel with the discovered resources 4. The success message includes the count of discovered children ### Actual Behavior When `agents resource add git-checkout local/my-repo --path /app` is run: 1. The resource is registered with a ULID ✅ 2. **No auto-discovery occurs** ❌ — no child resources are created 3. The output shows only `Added resource: local/my-repo (id: <ULID>)` ❌ 4. No "Auto-discovered Children" panel ❌ 5. No child count in success message ❌ ### Root Cause (Code Analysis) `auto_discover_children()` is defined in `src/cleveragents/infrastructure/database/repositories.py` (line 2601) but is **never called anywhere in the codebase**. ```python # repositories.py line 2601 — defined but never called def auto_discover_children(self, resource_id: str) -> list[Any]: """Materialize child resources per type auto-discovery.""" ... ``` The `register_resource()` method in `src/cleveragents/application/services/_resource_registry_ops.py` (lines 73–175) creates the resource and returns it without calling any discovery method. PR #6313 (spec fix) explicitly notes: > `ResourceRegistryService.register_resource()` must call the discovery helper after inserting a parent resource ### Steps to Reproduce ```bash agents resource add git-checkout local/test-repo --path /app --format json ``` Observe: JSON output has no `children` field, no auto-discovered resources created. Running `agents resource list --all` shows no child resources. ### Code Location - `src/cleveragents/application/services/_resource_registry_ops.py` lines 73–175: `register_resource()` — missing call to `auto_discover_children()` - `src/cleveragents/infrastructure/database/repositories.py` line 2601: `auto_discover_children()` — defined but never called - `src/cleveragents/cli/commands/resource.py` lines 782–799: `resource_add()` — no auto-discovery output panel ### Severity **Critical** — Auto-discovery is a core feature of the Resource System. Without it: - `git-checkout` resources have no `git` or `fs-directory` children - Devcontainer auto-discovery (`.devcontainer/devcontainer.json` detection) doesn't work - The Resource DAG is never populated with auto-discovered nodes - Tools that bind to child resource types cannot resolve their bindings --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 referenced this issue

2026-04-09 21:08:55 +00:00

UAT: agents resource add rich output missing spec-required Resource, Auto-discovered Children, and Capabilities panels #6484

HAL9000 added the

labels

2026-04-09 21:17:20 +00:00

HAL9000 referenced this issue

2026-04-09 21:37:14 +00:00

[AUTO-UAT-SUP] UAT Testing Pool Status (Cycle 6) #6372

HAL9000 referenced this issue

2026-04-10 00:40:12 +00:00

[AUTO-UAT-SUP] UAT Testing Pool Status (Cycle 7) #6738

HAL9000 referenced this issue from a commit

2026-04-10 00:53:59 +00:00

fix(resource): trigger auto-discovery when adding resource (#6464)

HAL9000 referenced this issue from a pull request that will close it,

2026-04-10 00:57:10 +00:00

fix(resource): trigger auto-discovery when adding resource #6745

HAL9000 commented

2026-04-10 00:58:51 +00:00

Author

Owner

PR #6745 created on branch fix/issue-6464-resource-add-auto-discovery. I will monitor and handle all review feedback until merged.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

PR #6745 created on branch `fix/issue-6464-resource-add-auto-discovery`. I will monitor and handle all review feedback until merged. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: implementation-worker

HAL9000 referenced this issue from a commit

2026-04-10 03:21:43 +00:00

fix(resource): trigger auto-discovery when adding resource (#6464)

HAL9000 referenced this issue from a commit

2026-04-10 19:43:31 +00:00

fix(resource): keep register resource atomic

HAL9000 referenced this issue from a commit

2026-04-11 03:33:46 +00:00

test(resource-cli): expect auto-discovered children

HAL9000 added

State

Verified