fix(ci): resolve lint errors and remove stale tdd_expected_fail tag #5264
Merged
hurui200320
merged 1 commits from 2026-04-09 04:41:01 +00:00
fix/broken-ci into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
hurui200320
Notifications
Due Date
No due date set.
Blocks
#5266 fix(ci): resolve broken lint and integration_tests on master
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#5264
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "fix/broken-ci"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The
lintandintegration_testsCI jobs onmasterare currently failing. This PR fixes both:Lint (
nox -e lint) — 51 ruff violations inscripts/validate_automation_tracking.py:typing.List/Dict/Tuple/Optionalwith builtin equivalents (list,dict,tuple)Optionalimport and unused local variableissuesdict.keys()withdictin membership testsmain()Integration tests (
nox -e integration_tests) — 1 failure inrobot/coverage_threshold.robot:tdd_expected_fail,tdd_issue, andtdd_issue_4305tags from theNoxfile Contains Coverage Threshold ConstanttestCOVERAGE_THRESHOLD = 97exists innoxfile.pyLocal verification
nox -e lint— All checks passednox -e integration_tests— 1962 tests, 1962 passed, 0 failed, 0 skippedFiles changed
scripts/validate_automation_tracking.pyrobot/coverage_threshold.robottdd_expected_failtagCloses #5266
@HAL9000 please review this PR asap since it tries to get the CI back into a working state.
PR Review — fix(ci): resolve lint errors and remove stale tdd_expected_fail tag
This PR addresses the two active master CI failures. The changes are correct and well-scoped.
Lint Fix (
scripts/validate_automation_tracking.py)The 51 ruff violations are standard modernization fixes:
Optionalimporttyping.List/Dict/Tuple/Optionalto builtin equivalents — correct per Python 3.9+ conventionsdict.keys()membership test fixesThese are all mechanical correctness fixes with no behavioral change. The approach is correct.
TDD Tag Removal (
robot/coverage_threshold.robot)Removing
tdd_expected_fail,tdd_issue, andtdd_issue_4305from theNoxfile Contains Coverage Threshold Constanttest is the correct action. Per our TDD workflow:tdd_expected_failmust be removed in the same commit that fixes the underlying bugCOVERAGE_THRESHOLD = 97exists innoxfile.pyRemoving all three TDD tags together is correct procedure.
Assessment
The PR is well-formed, the changes are correct, and local verification was performed (1962 tests, 0 failures). CI checks are currently pending.
Recommendation: Merge once CI passes.
Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison
Review Summary
Reviewed PR with focus on specification-compliance, requirements-coverage, and behavior-correctness.
The lint fixes in
scripts/validate_automation_tracking.pyare correct and well-executed. However, there is a critical TDD tag violation inrobot/coverage_threshold.robot, plus two missing required PR metadata fields.❌ Required Changes
1. [CRITICAL] TDD Regression Markers Incorrectly Removed
Location:
robot/coverage_threshold.robot—Noxfile Contains Coverage Threshold ConstanttestIssue: The PR removed ALL three TDD tags from this test, but only
tdd_expected_failshould be removed. Thetdd_issueandtdd_issue_4305tags are permanent regression markers and must remain.Master (before):
This PR (after):
Required (correct):
Why this matters: Per CONTRIBUTING.md (Bug Fix Workflow / TDD Issue Test Tags):
The
tdd_issueandtdd_issue_4305tags serve as permanent regression guards. IfCOVERAGE_THRESHOLD = 97is ever removed fromnoxfile.pyin the future, these tags ensure the test is still identifiable as a TDD regression test for issue #4305. Removing them silently strips that traceability and regression protection.2. [REQUIRED] Missing Milestone on PR
Reference: CONTRIBUTING.md — Pull Request Process, item 11:
Issue #5266 is assigned to milestone v3.2.0. This PR has no milestone assigned. Please assign milestone v3.2.0 to this PR.
3. [REQUIRED] Missing Type/ Label on PR
Reference: CONTRIBUTING.md — Pull Request Process, item 12:
This PR has no labels at all. Given this is a bug/CI fix, the appropriate label is
Type/Bug. Please apply it.⚠️ Concern (Non-blocking but should be addressed)
Issue #4305 Still Open
The PR description states: "The bug this TDD tag tracked (issue #4305) is now fixed —
COVERAGE_THRESHOLD = 97exists innoxfile.py."However, issue #4305 (
fix(integration): coverage_threshold — 1 failing test(s)) is still open withState/Verified. If the underlying fix is already merged to master, issue #4305 should be closed. Consider either:Closes #4305to this PR's description (if this PR is the appropriate place to close it), orCOVERAGE_THRESHOLD = 97tonoxfile.py✅ What's Good
scripts/validate_automation_tracking.pyare properly addressed:typing.List/Dict/Tuple/Optionalreplaced with builtin equivalents (list,dict,tuple) ✅Optionalimport removed ✅main() -> int✅dict.keys()membership test replaced withdictdirectly ✅# type: ignoresuppressions ✅fix(ci): resolve lint errors and remove stale tdd_expected_fail tag✅Closes #5266✅tdd_expected_failremoval itself is correct —COVERAGE_THRESHOLD = 97is confirmed present innoxfile.pyon master, so the TDD listener was correctly inverting a passing test to a failure ✅Summary of Required Changes
robot/coverage_threshold.robottdd_issueandtdd_issue_4305tags; keep onlytdd_expected_failremovedType/BuglabelDecision: REQUEST CHANGES 🔄
The lint fixes are solid and the CI motivation is urgent — but the TDD tag removal is incorrect and would silently eliminate permanent regression protection for issue #4305. The fix is a one-line change: restore
tdd_issueandtdd_issue_4305to theNoxfile Contains Coverage Threshold Constanttest while keepingtdd_expected_failremoved.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-self-reviewer
@@ -9,7 +9,7 @@ Suite Teardown Cleanup Test Environment*** Test Cases ***Noxfile Contains Coverage Threshold ConstantTDD Regression Markers Incorrectly Removed
Only
tdd_expected_failshould be removed when a bug is fixed. Thetdd_issueandtdd_issue_4305tags are permanent regression markers and must remain.Current (incorrect):
Required (correct):
Per CONTRIBUTING.md TDD Issue Test Tags:
For the record, I'm merging this PR anyway since:
I see no harm on merging this, instead, merging this should bring the CI back to a working state so it will unblock other issues and PRs.
PR merged. The master CI fix is now in. Thank you @hurui200320 for the clear explanation and for resolving this promptly.
The reasoning is sound:
tdd_expected_failtag was the only remaining artifactMaster CI should now pass on the next run.
Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison
HAL9000 referenced this pull request2026-04-09 05:48:51 +00:00
HAL9000 referenced this pull request2026-04-09 18:14:00 +00:00
HAL9000 referenced this pull request2026-04-10 18:10:04 +00:00