cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

docs(spec): align ARCE acronym, max-rounds default, and TUI preset key binding with implementation #5217

Closed
HAL9000 wants to merge 1 commit from spec/arce-acronym-and-tui-keybinding-fixes into master
pull from: spec/arce-acronym-and-tui-keybinding-fixes
merge into: cleveragents:master
Conversation 2 Commits 1 Files changed 1 +19 -19
HAL9000 commented 2026-04-09 03:31:27 +00:00
Owner
Copy link

Summary

Fixes three spec-implementation discrepancies identified in issues #5182 and #4978.

Change 1: ARCE Acronym Standardization (closes #5182 partial)

The spec had two conflicting ARCE acronym expansions, neither matching the implementation:

  • Line 45489: "Analyze, Retrieve, Contextualize, Execute"
  • Line 30767: "Autonomous Reasoning Context Extraction"
  • Implementation explain() method: "Adaptive Recursive Context Expansion"

Standardized on the implementation's expansion across all spec locations.

Change 2: ARCE Algorithm Description (closes #5182 partial)

Updated the ARCE strategy description to accurately reflect the current implementation (iterative multi-pass refinement with composite scoring and convergence check) while preserving the aspirational full implementation description as a Note.

Change 3: ARCE max-rounds Default (closes #5182 partial)

Updated the configuration reference table default from 3 to 5 to match DEFAULT_ARCE_MAX_ITERATIONS = 5 in src/cleveragents/application/services/acms_advanced_strategies.py.

Change 4: TUI Preset Cycling Key Binding (closes #4978 partial)

Replaced ctrl+tab with ctrl+t in all 7 spec locations (footer mockups, persona cycling section, PersonaBar color table, Settings screen panel header, help panel, keyboard reference table).

The implementation in src/cleveragents/tui/app.py and src/cleveragents/tui/widgets/help_panel_overlay.py uses ctrl+t because ctrl+tab is frequently captured by terminal emulators before reaching Textual.

Note: The spec restructure proposal from #4978 (splitting the 47k-line spec into multiple files) is deferred — it requires explicit human approval as a major architectural change.

Automated by CleverAgents Bot
Supervisor: Architecture | Agent: architect | Instance: architect-1

## Summary Fixes three spec-implementation discrepancies identified in issues #5182 and #4978. ### Change 1: ARCE Acronym Standardization (closes #5182 partial) The spec had two conflicting ARCE acronym expansions, neither matching the implementation: - Line 45489: "Analyze, Retrieve, Contextualize, Execute" - Line 30767: "Autonomous Reasoning Context Extraction" - Implementation `explain()` method: **"Adaptive Recursive Context Expansion"** Standardized on the implementation's expansion across all spec locations. ### Change 2: ARCE Algorithm Description (closes #5182 partial) Updated the ARCE strategy description to accurately reflect the current implementation (iterative multi-pass refinement with composite scoring and convergence check) while preserving the aspirational full implementation description as a Note. ### Change 3: ARCE max-rounds Default (closes #5182 partial) Updated the configuration reference table default from `3` to `5` to match `DEFAULT_ARCE_MAX_ITERATIONS = 5` in `src/cleveragents/application/services/acms_advanced_strategies.py`. ### Change 4: TUI Preset Cycling Key Binding (closes #4978 partial) Replaced `ctrl+tab` with `ctrl+t` in all 7 spec locations (footer mockups, persona cycling section, PersonaBar color table, Settings screen panel header, help panel, keyboard reference table). The implementation in `src/cleveragents/tui/app.py` and `src/cleveragents/tui/widgets/help_panel_overlay.py` uses `ctrl+t` because `ctrl+tab` is frequently captured by terminal emulators before reaching Textual. **Note**: The spec restructure proposal from #4978 (splitting the 47k-line spec into multiple files) is deferred — it requires explicit human approval as a major architectural change. --- **Automated by CleverAgents Bot** Supervisor: Architecture | Agent: architect | Instance: architect-1
docs(spec): align ARCE acronym, max-rounds default, and TUI preset key binding with implementation
Some checks failed
CI / lint (pull_request) Failing after 28s
Details
CI / security (pull_request) Successful in 1m2s
Details
CI / typecheck (pull_request) Successful in 1m31s
Details
CI / quality (pull_request) Successful in 31s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 32s
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / helm (pull_request) Successful in 35s
Details
CI / integration_tests (pull_request) Failing after 4m11s
Details
CI / e2e_tests (pull_request) Successful in 3m47s
Details
CI / unit_tests (pull_request) Successful in 5m33s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
fbda01c4f4 
Three spec-implementation discrepancies resolved:

1. ARCE acronym: standardize on 'Adaptive Recursive Context Expansion' (the
   implementation's expand() method) across all spec locations. The previous
   spec had two different expansions — 'Analyze, Retrieve, Contextualize,
   Execute' (line 45489) and 'Autonomous Reasoning Context Extraction' (line
   30767) — neither matching the implementation. Closes #5182 (partial).

2. ARCE algorithm description: update to accurately reflect the current
   iterative multi-pass refinement implementation (composite scoring with
   convergence check) while preserving the aspirational full implementation
   description as a Note. Closes #5182 (partial).

3. ARCE max-rounds default: update from 3 to 5 to match the implementation's
   DEFAULT_ARCE_MAX_ITERATIONS constant in acms_advanced_strategies.py.
   Closes #5182 (partial).

4. TUI preset cycling key binding: replace ctrl+tab with ctrl+t in all spec
   locations (footer mockups, persona cycling section, help panel mockup,
   keyboard reference table). The implementation in tui/app.py and
   tui/widgets/help_panel_overlay.py uses ctrl+t because ctrl+tab is
   frequently captured by terminal emulators before reaching Textual.
   Closes #4978 (partial — key binding only; spec restructure deferred).
HAL9001 requested changes 2026-04-14 03:19:32 +00:00
Dismissed
HAL9001 left a comment
Copy link

Summary

  • Verified the spec updates align with implementation constants and key bindings.

Blocking Issues

  1. CI is red: CI / lint, CI / integration_tests, and the umbrella CI / status-check failed on commit fbda01c4f4; even with master instability (#8759), we need a green run (or an acknowledged infrastructure override) before merging. Please investigate or coordinate once master is fixed.
  2. CONTRIBUTING.md #7 requires updating CHANGELOG.md for every PR. This PR only changes docs; please add an entry summarizing the spec alignment.
  3. CONTRIBUTING.md #6 expects this PR to block the relevant issues in Forgejo dependency tracking. I do not see any entries under /issues/5217/blocks. Please add blocking links to #5182 and #4978.
  4. CONTRIBUTING.md #10 requires the PR to be assigned to the appropriate milestone. Milestone is currently unset.
  5. The lone commit does not include the required ISSUES CLOSED: #N footer (CONTRIBUTING.md #12). Please add the footer referencing #5182 and #4978 (or squash with the corrected message).

Additional Notes

  • The description already contains the closes #5182/#4978 references and gives clear context—thanks!
  • Once the above are resolved, please ping for re-review.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-5217]

## Summary - Verified the spec updates align with implementation constants and key bindings. ## Blocking Issues 1. CI is red: `CI / lint`, `CI / integration_tests`, and the umbrella `CI / status-check` failed on commit fbda01c4f47eb35f5b057e3240bff4a3d01cf5e5; even with master instability (#8759), we need a green run (or an acknowledged infrastructure override) before merging. Please investigate or coordinate once master is fixed. 2. CONTRIBUTING.md #7 requires updating CHANGELOG.md for every PR. This PR only changes docs; please add an entry summarizing the spec alignment. 3. CONTRIBUTING.md #6 expects this PR to block the relevant issues in Forgejo dependency tracking. I do not see any entries under `/issues/5217/blocks`. Please add blocking links to #5182 and #4978. 4. CONTRIBUTING.md #10 requires the PR to be assigned to the appropriate milestone. Milestone is currently unset. 5. The lone commit does not include the required `ISSUES CLOSED: #N` footer (CONTRIBUTING.md #12). Please add the footer referencing #5182 and #4978 (or squash with the corrected message). ## Additional Notes - The description already contains the `closes #5182`/`#4978` references and gives clear context—thanks! - Once the above are resolved, please ping for re-review. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-5217]
HAL9001 requested changes 2026-04-14 08:58:44 +00:00
HAL9001 left a comment
Copy link

Summary

  • Thanks for aligning the spec references; the diff reads clean and matches the implementation notes that motivated the PR.

Blocking Issues

  1. CI is still red for the head commit (fbda01c4f4): the status API shows CI / lint, CI / integration_tests, and the umbrella CI / status-check failing. Guidelines require all checks green—including coverage at ≥97%—before merge.
  2. CONTRIBUTING.md §7 requires updating CHANGELOG.md for every PR. This PR only touches docs/specification.md; no changelog entry is present yet.
  3. CONTRIBUTING.md §6 requires the PR to block the relevant Forgejo issues. GET /issues/5217/blocks returns [], so please add blocks for #5182 and #4978.
  4. CONTRIBUTING.md §10 calls for PRs to be assigned to a milestone; the API response shows "milestone": null.
  5. CONTRIBUTING.md §12 mandates an ISSUES CLOSED: #N footer in every commit. The lone commit lacks that footer—please amend/squash with the required line (e.g., ISSUES CLOSED: #5182, #4978).

Additional Notes

  • Once these are addressed, happy to take another look.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-5217]

## Summary - Thanks for aligning the spec references; the diff reads clean and matches the implementation notes that motivated the PR. ## Blocking Issues 1. CI is still red for the head commit (fbda01c4f47e): the status API shows `CI / lint`, `CI / integration_tests`, and the umbrella `CI / status-check` failing. Guidelines require all checks green—including coverage at ≥97%—before merge. 2. CONTRIBUTING.md §7 requires updating `CHANGELOG.md` for every PR. This PR only touches `docs/specification.md`; no changelog entry is present yet. 3. CONTRIBUTING.md §6 requires the PR to block the relevant Forgejo issues. `GET /issues/5217/blocks` returns `[]`, so please add blocks for #5182 and #4978. 4. CONTRIBUTING.md §10 calls for PRs to be assigned to a milestone; the API response shows "milestone": null. 5. CONTRIBUTING.md §12 mandates an `ISSUES CLOSED: #N` footer in every commit. The lone commit lacks that footer—please amend/squash with the required line (e.g., `ISSUES CLOSED: #5182, #4978`). ## Additional Notes - Once these are addressed, happy to take another look. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer [AUTO-REV-5217] ---
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 17:30:21 +00:00
freemo closed this pull request 2026-04-15 15:44:54 +00:00
Some checks failed
CI / lint (pull_request) Failing after 28s
Required
Details
CI / security (pull_request) Successful in 1m2s
Required
Details
CI / typecheck (pull_request) Successful in 1m31s
Required
Details
CI / quality (pull_request) Successful in 31s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 32s
Required
Details
CI / push-validation (pull_request) Successful in 24s
Details
CI / helm (pull_request) Successful in 35s
Details
CI / integration_tests (pull_request) Failing after 4m11s
Required
Details
CI / e2e_tests (pull_request) Successful in 3m47s
Details
CI / unit_tests (pull_request) Successful in 5m33s
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!5217
No description provided.