cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test(cli): cover action and plan extensions #420

Closed
brent.edwards wants to merge 0 commits from feature/m4-cli-extension-tests into master
pull from: feature/m4-cli-extension-tests
merge into: cleveragents:master
Conversation 3 Commits - Files changed - +1029
brent.edwards commented 2026-02-24 20:12:38 +00:00
Member
Copy link

Summary

  • Added comprehensive Behave test coverage (27 new scenarios) for CLI extension features: automation profile resolution across all builtin profiles, invariant ordering preservation, actor override error cases, and output snapshot assertions for JSON/YAML/table formats
  • Added Robot Framework integration tests (4 new test cases) for action show with optional actors/invariants and profile resolution
  • Created benchmarks/cli_extension_tests_bench.py with ASV performance baselines across 4 suites (12 benchmarks)
  • Updated docs/development/testing.md with CLI extension test fixture documentation

Closes #326

## Summary - Added comprehensive Behave test coverage (27 new scenarios) for CLI extension features: automation profile resolution across all builtin profiles, invariant ordering preservation, actor override error cases, and output snapshot assertions for JSON/YAML/table formats - Added Robot Framework integration tests (4 new test cases) for `action show` with optional actors/invariants and profile resolution - Created `benchmarks/cli_extension_tests_bench.py` with ASV performance baselines across 4 suites (12 benchmarks) - Updated `docs/development/testing.md` with CLI extension test fixture documentation Closes #326
brent.edwards added this to the v3.1.0 milestone 2026-02-24 20:12:38 +00:00
test(cli): cover action and plan extensions
All checks were successful
CI / lint (pull_request) Successful in 25s
Details
CI / quality (pull_request) Successful in 37s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 55s
Details
CI / typecheck (pull_request) Successful in 1m1s
Details
CI / build (pull_request) Successful in 33s
Details
CI / integration_tests (pull_request) Successful in 5m13s
Details
CI / unit_tests (pull_request) Successful in 12m53s
Details
CI / docker (pull_request) Successful in 9s
Details
CI / benchmark-regression (pull_request) Successful in 21m31s
Details
CI / coverage (pull_request) Successful in 51m7s
Details
2c21611ad5 
Added comprehensive test coverage for CLI extension features from #325:
- Behave scenarios for automation_profile resolution, invariant ordering,
  and actor override error cases
- Output snapshot assertions for JSON/YAML/table formats
- Robot integration test for action show with optional actors/invariants
- ASV benchmark for extended CLI scenario runtime baseline
- Updated testing.md with CLI extension test fixture documentation

ISSUES CLOSED: #326
Merge branch 'master' into feature/m4-cli-extension-tests
All checks were successful
CI / lint (pull_request) Successful in 25s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Successful in 35s
Details
CI / security (pull_request) Successful in 50s
Details
CI / typecheck (pull_request) Successful in 1m2s
Details
CI / build (pull_request) Successful in 36s
Details
CI / integration_tests (pull_request) Successful in 5m6s
Details
CI / unit_tests (pull_request) Successful in 21m56s
Details
CI / docker (pull_request) Successful in 15s
Details
CI / benchmark-regression (pull_request) Successful in 22m7s
Details
CI / coverage (pull_request) Successful in 56m13s
Details
c8434e21f3
freemo requested changes 2026-02-24 22:26:03 +00:00
Dismissed
freemo left a comment
Copy link

Code Review: PR #420 — test(cli): cover action and plan extensions

This is a well-organized testing PR with good Behave/Robot/ASV coverage structure. The description clearly summarizes what was done and references the correct issue. A few items need attention before merge.

Required Changes

1. Missing CHANGELOG update (CONTRIBUTING.md §6)
No CHANGELOG entry was added for this test suite. Per guidelines: "The PR must include an update to the changelog file. Add one new entry per commit in the PR that describes the change from the user's perspective."

2. Missing CONTRIBUTORS.md update (CONTRIBUTING.md §8)
Brent Edwards is not listed in CONTRIBUTORS.md and was not added in this PR.

Advisory (Non-Blocking)

3. Broad except Exception: pass in benchmarks
benchmarks/cli_extension_tests_bench.py (around line 233) contains except Exception: pass which silently swallows all errors. Per CONTRIBUTING.md error handling guidelines: "Do not use bare catch-all exception handlers without re-raising unless you have specific recovery logic." While benchmarks are less critical than production code, consider catching a more specific exception or at minimum logging the error.

4. Import inside function body
robot/helper_cli_extensions.py contains import json inside a function body. Per the project's Import Guidelines: "Ensure all imports are at the top of the Python file. Do not scatter imports throughout the file or bury them inside functions or methods."

What's Good

  • Proper Closes #326 linking in description
  • Commit message follows Conventional Changelog format
  • Issue #326 referenced in commit footer
  • Correct milestone (v3.1.0)
  • All files in correct directories
  • Appropriate Type/Testing label

Please address items 1-2 (and ideally 3-4) and push updated commits.

## Code Review: PR #420 — `test(cli): cover action and plan extensions` This is a well-organized testing PR with good Behave/Robot/ASV coverage structure. The description clearly summarizes what was done and references the correct issue. A few items need attention before merge. ### Required Changes **1. Missing CHANGELOG update (CONTRIBUTING.md §6)** No CHANGELOG entry was added for this test suite. Per guidelines: "The PR must include an update to the changelog file. Add one new entry per commit in the PR that describes the change from the user's perspective." **2. Missing CONTRIBUTORS.md update (CONTRIBUTING.md §8)** Brent Edwards is not listed in `CONTRIBUTORS.md` and was not added in this PR. ### Advisory (Non-Blocking) **3. Broad `except Exception: pass` in benchmarks** `benchmarks/cli_extension_tests_bench.py` (around line 233) contains `except Exception: pass` which silently swallows all errors. Per CONTRIBUTING.md error handling guidelines: "Do not use bare catch-all exception handlers without re-raising unless you have specific recovery logic." While benchmarks are less critical than production code, consider catching a more specific exception or at minimum logging the error. **4. Import inside function body** `robot/helper_cli_extensions.py` contains `import json` inside a function body. Per the project's Import Guidelines: "Ensure all imports are at the top of the Python file. Do not scatter imports throughout the file or bury them inside functions or methods." ### What's Good - Proper `Closes #326` linking in description - Commit message follows Conventional Changelog format - Issue #326 referenced in commit footer - Correct milestone (v3.1.0) - All files in correct directories - Appropriate `Type/Testing` label Please address items 1-2 (and ideally 3-4) and push updated commits.
freemo dismissed freemo's review 2026-02-24 22:45:57 +00:00
Reason:

dont want hard block

chore(pr): address code review feedback for PR #420
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 16s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / build (pull_request) Successful in 17s
Details
CI / typecheck (pull_request) Successful in 32s
Details
CI / security (pull_request) Successful in 33s
Details
CI / unit_tests (pull_request) Has been cancelled
Details
CI / integration_tests (pull_request) Has been cancelled
Details
CI / benchmark-regression (pull_request) Has been cancelled
Details
CI / coverage (pull_request) Has been cancelled
Details
CI / docker (pull_request) Has been cancelled
Details
f3ddb48faf 
Added CHANGELOG entry for CLI extension test suite. Added Brent Edwards
to CONTRIBUTORS.md. Replaced broad except Exception with specific
ValidationError catch in benchmark. Moved import json to module
top-level in robot helper script.

ISSUES CLOSED: #326
brent.edwards commented 2026-02-25 02:56:14 +00:00
Author
Member
Copy link

Thanks for the thorough review, Jeff. All four items have been addressed in commit f3ddb48:

  1. CHANGELOG — Added entry under Unreleased.
  2. CONTRIBUTORS.md — Added Brent E. Edwards.
  3. Broad exception catch — Replaced except Exception with except ValidationError in benchmarks/cli_extension_tests_bench.py. The validate_namespaced_actor function raises cleveragents.core.exceptions.ValidationError, so this is the correct specific type.
  4. Import placement — Moved import json from inside action_show_json() to module-level imports in robot/helper_cli_extensions.py.

All nox stages pass (lint, typecheck, unit_tests, integration_tests, coverage_report at 97.2%).

Thanks for the thorough review, Jeff. All four items have been addressed in commit `f3ddb48`: 1. **CHANGELOG** — Added entry under Unreleased. 2. **CONTRIBUTORS.md** — Added Brent E. Edwards. 3. **Broad exception catch** — Replaced `except Exception` with `except ValidationError` in `benchmarks/cli_extension_tests_bench.py`. The `validate_namespaced_actor` function raises `cleveragents.core.exceptions.ValidationError`, so this is the correct specific type. 4. **Import placement** — Moved `import json` from inside `action_show_json()` to module-level imports in `robot/helper_cli_extensions.py`. All nox stages pass (lint, typecheck, unit_tests, integration_tests, coverage_report at 97.2%).
Merge branch 'master' into feature/m4-cli-extension-tests
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Details
CI / quality (pull_request) Successful in 18s
Details
CI / build (pull_request) Successful in 20s
Details
CI / typecheck (pull_request) Successful in 32s
Details
CI / security (pull_request) Successful in 33s
Details
CI / integration_tests (pull_request) Successful in 3m47s
Details
CI / unit_tests (pull_request) Successful in 17m13s
Details
CI / benchmark-regression (pull_request) Successful in 20m7s
Details
CI / docker (pull_request) Successful in 20s
Details
CI / coverage (pull_request) Successful in 1h5m29s
Details
3a66ce4d02
brent.edwards commented 2026-02-25 07:43:51 +00:00
Author
Member
Copy link

⚠️ Do not merge this PR individually. This branch exists for review convenience only.

All changes from this branch are consolidated in PR #431 (develop-brent-4), which should be the one merged into master.

→ #431

⚠️ **Do not merge this PR individually.** This branch exists for review convenience only. All changes from this branch are consolidated in **PR #431** (`develop-brent-4`), which should be the one merged into `master`. → https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/431
brent.edwards closed this pull request 2026-02-25 19:45:48 +00:00
brent.edwards deleted branch feature/m4-cli-extension-tests 2026-02-25 19:46:01 +00:00
All checks were successful
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 15s
Required
Details
CI / quality (pull_request) Successful in 18s
Required
Details
CI / build (pull_request) Successful in 20s
Required
Details
CI / typecheck (pull_request) Successful in 32s
Required
Details
CI / security (pull_request) Successful in 33s
Required
Details
CI / integration_tests (pull_request) Successful in 3m47s
Required
Details
CI / unit_tests (pull_request) Successful in 17m13s
Required
Details
CI / benchmark-regression (pull_request) Successful in 20m7s
Details
CI / docker (pull_request) Successful in 20s
Required
Details
CI / coverage (pull_request) Successful in 1h5m29s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.1.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!420
No description provided.