chore(pr): address code review feedback for PR #420
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 18s
CI / build (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 32s
CI / security (pull_request) Successful in 33s
CI / unit_tests (pull_request) Has been cancelled
CI / integration_tests (pull_request) Has been cancelled
CI / benchmark-regression (pull_request) Has been cancelled
CI / coverage (pull_request) Has been cancelled
CI / docker (pull_request) Has been cancelled

Added CHANGELOG entry for CLI extension test suite. Added Brent Edwards
to CONTRIBUTORS.md. Replaced broad except Exception with specific
ValidationError catch in benchmark. Moved import json to module
top-level in robot helper script.

ISSUES CLOSED: #326
This commit is contained in:
2026-02-25 02:55:40 +00:00
parent c8434e21f3
commit f3ddb48faf
4 changed files with 8 additions and 3 deletions
+3
View File
@@ -2,6 +2,9 @@
## Unreleased
- Added comprehensive Behave, Robot Framework, and ASV test coverage for CLI extension
features including automation profile resolution, invariant ordering, actor override
error cases, and output format snapshot assertions.
- Expanded CONTRIBUTING.md with detailed guidance on the issue creation process, label system,
ticket lifecycle, pull request requirements, and review/merge process.
- Added commit scope, quality, and message format guidelines to CONTRIBUTING.md.
+2
View File
@@ -1,10 +1,12 @@
# Contributors
* Jeffrey Phillips Freeman <jeffrey.freeman@syncleus.com>
* Brent E. Edwards <brent.edwards@cleverthis.com>
# Details
Below are some of the specific details of various contributions.
* Jeffrey Phillips Freeman has acted as Lead Developer, daily contributor, and Project Owner.
* Brent E. Edwards has contributed quality assurance, test coverage, and CI pipeline improvements.
* This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
+2 -1
View File
@@ -32,6 +32,7 @@ from cleveragents.cli.commands.plan import app as plan_app # noqa: E402
from cleveragents.cli.commands.plan import ( # noqa: E402
validate_namespaced_actor,
)
from cleveragents.core.exceptions import ValidationError # noqa: E402
from cleveragents.domain.models.core.action import ( # noqa: E402
Action,
ActionState,
@@ -255,7 +256,7 @@ class ActorValidationErrorSuite:
"""Benchmark rejecting an invalid actor name."""
try:
validate_namespaced_actor("bad-format", "--strategy-actor")
except Exception:
except ValidationError:
pass
def time_plan_use_invalid_actor_cli(self) -> None:
+1 -2
View File
@@ -5,6 +5,7 @@ Each subcommand is a self-contained check that prints a sentinel on success.
from __future__ import annotations
import json
import sys
from datetime import datetime
from pathlib import Path
@@ -288,8 +289,6 @@ def action_show_extended() -> None:
def action_show_json() -> None:
"""Verify action show JSON output includes optional fields."""
import json
mock_svc = MagicMock()
mock_svc.get_action_by_name.return_value = _mock_action_extended()
with patch(