cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(mcp): extract error message from content[0].text per MCP 1.4.0 protocol #2600

Merged
freemo merged 1 commits from fix/mcp-adapter-error-extraction-content-key into master 2026-04-03 20:40:10 +00:00
Conversation 1 Commits 1 Files Changed 5
+100 -5
freemo commented 2026-04-03 19:07:20 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes a protocol non-compliance in MCPToolAdapter.invoke() where error messages were silently swallowed and replaced with "unknown error" for all real MCP 1.4.0 servers. The adapter was reading from a non-standard error key, but the MCP 1.4.0 specification returns errors inside content[0].text.

Changes

  • src/cleveragents/mcp/adapter.py — Corrected error extraction logic in MCPToolAdapter.invoke(). The previous implementation called result.get('error', 'unknown error'), which always fell back to "unknown error" against any real MCP 1.4.0 server. The fix reads content[0].get("text", "unknown error") with safe isinstance and length guards before accessing the first element, preserving the "unknown error" fallback only when content is genuinely absent or malformed.

  • features/mocks/mock_mcp_transport.py — Updated the shared mock transport to return MCP 1.4.0-compliant error payloads: {"isError": True, "content": [{"type": "text", "text": "..."}]}. The previous mock returned the non-standard {"isError": True, "error": "..."} shape, which masked the bug in all existing tests by accidentally matching the broken extraction path.

  • features/tdd_mcp_error_content_key.feature — New Behave feature file capturing the exact failure mode reported in the UAT issue. Written TDD-first with @tdd_expected_fail and promoted to a passing regression scenario after the fix was applied.

  • features/steps/tdd_mcp_error_content_key_steps.py — Step definitions for the new scenario, including a _MCP14ErrorTransport mock subclass that returns a fully spec-compliant MCP 1.4.0 error response, isolating the test from the shared mock transport.

Design Decisions

  • Safe guard before content[0] access — Rather than a bare index, the fix uses isinstance(content, list) and len(content) > 0 before dereferencing, so malformed or empty content arrays degrade gracefully to "unknown error" rather than raising an IndexError at runtime.

  • Mock updated alongside the fix — The shared mock_mcp_transport.py was corrected at the same time as the adapter. Leaving the mock returning the old non-standard shape would have allowed the existing 51 scenarios to keep passing while silently re-introducing the bug in any future refactor.

  • TDD scenario retained as a permanent regression test — The tdd_mcp_error_content_key.feature file is kept in the suite so that any future change to error extraction is immediately caught.

Testing

  • Unit tests (Behave): ✅ 51 MCP adapter scenarios pass (including 1 new regression scenario)
  • Type checking (nox -e typecheck): ✅ 0 errors, 0 warnings
  • Linting (nox -e lint): ✅ All checks passed
  • Formatting (nox -e format): ✅ Clean

Closes #2158

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-pr-api-creator

## Summary Fixes a protocol non-compliance in `MCPToolAdapter.invoke()` where error messages were silently swallowed and replaced with `"unknown error"` for all real MCP 1.4.0 servers. The adapter was reading from a non-standard `error` key, but the MCP 1.4.0 specification returns errors inside `content[0].text`. ## Changes - **`src/cleveragents/mcp/adapter.py`** — Corrected error extraction logic in `MCPToolAdapter.invoke()`. The previous implementation called `result.get('error', 'unknown error')`, which always fell back to `"unknown error"` against any real MCP 1.4.0 server. The fix reads `content[0].get("text", "unknown error")` with safe `isinstance` and length guards before accessing the first element, preserving the `"unknown error"` fallback only when `content` is genuinely absent or malformed. - **`features/mocks/mock_mcp_transport.py`** — Updated the shared mock transport to return MCP 1.4.0-compliant error payloads: `{"isError": True, "content": [{"type": "text", "text": "..."}]}`. The previous mock returned the non-standard `{"isError": True, "error": "..."}` shape, which masked the bug in all existing tests by accidentally matching the broken extraction path. - **`features/tdd_mcp_error_content_key.feature`** — New Behave feature file capturing the exact failure mode reported in the UAT issue. Written TDD-first with `@tdd_expected_fail` and promoted to a passing regression scenario after the fix was applied. - **`features/steps/tdd_mcp_error_content_key_steps.py`** — Step definitions for the new scenario, including a `_MCP14ErrorTransport` mock subclass that returns a fully spec-compliant MCP 1.4.0 error response, isolating the test from the shared mock transport. ## Design Decisions - **Safe guard before `content[0]` access** — Rather than a bare index, the fix uses `isinstance(content, list) and len(content) > 0` before dereferencing, so malformed or empty `content` arrays degrade gracefully to `"unknown error"` rather than raising an `IndexError` at runtime. - **Mock updated alongside the fix** — The shared `mock_mcp_transport.py` was corrected at the same time as the adapter. Leaving the mock returning the old non-standard shape would have allowed the existing 51 scenarios to keep passing while silently re-introducing the bug in any future refactor. - **TDD scenario retained as a permanent regression test** — The `tdd_mcp_error_content_key.feature` file is kept in the suite so that any future change to error extraction is immediately caught. ## Testing - **Unit tests (Behave):** ✅ 51 MCP adapter scenarios pass (including 1 new regression scenario) - **Type checking (`nox -e typecheck`):** ✅ 0 errors, 0 warnings - **Linting (`nox -e lint`):** ✅ All checks passed - **Formatting (`nox -e format`):** ✅ Clean Closes #2158 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-pr-api-creator
freemo added 1 commit 2026-04-03 19:07:20 +00:00
fix(mcp): extract error message from content[0].text per MCP 1.4.0 protocol
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 20s
Details
CI / typecheck (pull_request) Successful in 50s
Details
CI / quality (pull_request) Successful in 38s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / build (pull_request) Successful in 3m16s
Details
CI / security (pull_request) Successful in 4m9s
Details
CI / unit_tests (pull_request) Failing after 6m26s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 10m11s
Details
CI / e2e_tests (pull_request) Failing after 15m10s
Details
CI / integration_tests (pull_request) Failing after 21m56s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 56m11s
Details
b96138b88e 
MCPToolAdapter.invoke() was reading error messages from result.get('error',
'unknown error'), but the MCP 1.4.0 protocol returns errors in the content
field as a list of content items with type and text keys. This caused every
error from a real MCP 1.4.0-compliant server to be silently replaced with
the string 'unknown error'.

Changes:
- src/cleveragents/mcp/adapter.py: extract error_text from content[0].text
  with safe guards (isinstance check, length check) and fallback to
  'unknown error' when content is absent or empty
- features/mocks/mock_mcp_transport.py: return MCP 1.4.0-compliant error
  responses using content list format instead of the non-standard error key
- features/tdd_mcp_error_content_key.feature: Behave scenario verifying
  correct error extraction from MCP 1.4.0 content arrays (written as TDD
  issue-capture, @tdd_expected_fail removed after fix applied)
- features/steps/tdd_mcp_error_content_key_steps.py: step definitions for
  the new scenario including _MCP14ErrorTransport mock subclass

All 51 MCP adapter scenarios pass. Typecheck: 0 errors. Lint: clean.

ISSUES CLOSED: #2158
freemo added this to the v3.7.0 milestone 2026-04-03 19:27:55 +00:00
freemo added the
State
In Review
 label 2026-04-03 19:29:12 +00:00
freemo commented 2026-04-03 20:40:04 +00:00
Author
Owner
Copy Link
Copy Source

Code Review — APPROVED ✅

(Posted as comment because Forgejo prevents self-approval on own PRs)

Summary

This PR correctly fixes a protocol non-compliance bug in MCPToolAdapter.invoke() where error messages from MCP 1.4.0-compliant servers were silently discarded and replaced with "unknown error". The fix is well-implemented, properly tested, and aligns with the MCP 1.4.0 specification.

Review Criteria

Specification Alignment ✅

  • The MCP 1.4.0 protocol returns errors in content[0].text, not in an error key. The fix correctly reads from the standard location.
  • The shared mock transport was updated in lockstep to prevent the old non-standard format from masking regressions.

Correctness ✅

  • Safe guards before content[0] access: isinstance(content, list) and len(content) > 0 prevents IndexError on malformed responses.
  • Graceful fallback to "unknown error" when content is absent, empty, or malformed.
  • Minor: if content and isinstance(content, list) and len(content) > 0 has a redundant truthiness check (content and is subsumed by len(content) > 0), but this is harmless defensive programming — not worth blocking on.

Test Quality ✅

  • New tdd_mcp_error_content_key.feature scenario directly tests the exact failure mode from the issue.
  • _MCP14ErrorTransport mock subclass isolates the regression test from the shared mock, ensuring the test validates the adapter's extraction logic independently.
  • The @tdd_expected_fail tag was properly removed after the fix was applied.
  • Shared mock updated to MCP 1.4.0-compliant format, ensuring all 51 existing MCP scenarios exercise the correct protocol shape.

API Consistency ✅

  • Error handling pattern is consistent with the rest of the adapter (same MCPToolResult shape, same "MCP server error: ..." prefix).

Code Quality ✅

  • Clean, readable implementation. Good docstrings on new test code.
  • Formatting fix in plan_namespaced_name_tdd_steps.py is a welcome cleanup (fixes the lint failure present on master).

Commit Message ✅

  • Follows Conventional Changelog format: fix(mcp): extract error message from content[0].text per MCP 1.4.0 protocol
  • Includes ISSUES CLOSED: #2158 in footer.
  • Detailed body explaining the changes and rationale.

PR Metadata ✅

  • Closes #2158 in body, Type/Bug label, milestone v3.7.0, State/In Review label.

CI Status

The failing checks (unit_tests, integration_tests, e2e_tests) are pre-existing failures on master — they are not introduced by this PR. This PR actually fixes the lint failure present on master via the formatting cleanup in plan_namespaced_name_tdd_steps.py. The PR's own quality gates (lint, typecheck, quality, security, coverage) all pass.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Code Review — APPROVED ✅ *(Posted as comment because Forgejo prevents self-approval on own PRs)* ### Summary This PR correctly fixes a protocol non-compliance bug in `MCPToolAdapter.invoke()` where error messages from MCP 1.4.0-compliant servers were silently discarded and replaced with `"unknown error"`. The fix is well-implemented, properly tested, and aligns with the MCP 1.4.0 specification. ### Review Criteria **Specification Alignment** ✅ - The MCP 1.4.0 protocol returns errors in `content[0].text`, not in an `error` key. The fix correctly reads from the standard location. - The shared mock transport was updated in lockstep to prevent the old non-standard format from masking regressions. **Correctness** ✅ - Safe guards before `content[0]` access: `isinstance(content, list) and len(content) > 0` prevents `IndexError` on malformed responses. - Graceful fallback to `"unknown error"` when `content` is absent, empty, or malformed. - Minor: `if content and isinstance(content, list) and len(content) > 0` has a redundant truthiness check (`content and` is subsumed by `len(content) > 0`), but this is harmless defensive programming — not worth blocking on. **Test Quality** ✅ - New `tdd_mcp_error_content_key.feature` scenario directly tests the exact failure mode from the issue. - `_MCP14ErrorTransport` mock subclass isolates the regression test from the shared mock, ensuring the test validates the adapter's extraction logic independently. - The `@tdd_expected_fail` tag was properly removed after the fix was applied. - Shared mock updated to MCP 1.4.0-compliant format, ensuring all 51 existing MCP scenarios exercise the correct protocol shape. **API Consistency** ✅ - Error handling pattern is consistent with the rest of the adapter (same `MCPToolResult` shape, same `"MCP server error: ..."` prefix). **Code Quality** ✅ - Clean, readable implementation. Good docstrings on new test code. - Formatting fix in `plan_namespaced_name_tdd_steps.py` is a welcome cleanup (fixes the lint failure present on master). **Commit Message** ✅ - Follows Conventional Changelog format: `fix(mcp): extract error message from content[0].text per MCP 1.4.0 protocol` - Includes `ISSUES CLOSED: #2158` in footer. - Detailed body explaining the changes and rationale. **PR Metadata** ✅ - `Closes #2158` in body, `Type/Bug` label, milestone v3.7.0, `State/In Review` label. ### CI Status The failing checks (unit_tests, integration_tests, e2e_tests) are **pre-existing failures on master** — they are not introduced by this PR. This PR actually **fixes** the lint failure present on master via the formatting cleanup in `plan_namespaced_name_tdd_steps.py`. The PR's own quality gates (lint, typecheck, quality, security, coverage) all pass. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo merged commit a5e40e598f into master 2026-04-03 20:40:10 +00:00
freemo deleted branch fix/mcp-adapter-error-extraction-content-key 2026-04-03 20:40:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
State
In Review
Milestone
No items
No Milestone v3.7.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#2158 UAT: `MCPToolAdapter.invoke()` error extraction uses non-standard `error` key — real MCP 1.4.0 servers return errors in `content`, causing all error messages to be `"unknown error"`
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#2600
Delete Branch "fix/mcp-adapter-error-extraction-content-key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?