fix(strategize): propagate actor options (openai_api_base, openai_api_key) to LLM client creation in Strategize/Execute paths #11257
Merged
HAL9000
merged 4 commits from 2026-05-29 00:09:42 +00:00
bugfix/m5-actor-options-ignored into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Blocks
Reference: cleveragents/cleveragents-core#11257
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "bugfix/m5-actor-options-ignored"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Propagates actor-level YAML
options(such asopenai_api_baseandopenai_api_key) through toProviderRegistry.create_llm()in the Strategize and Execute phases, and in session-based workflows.Previously these options were silently ignored, causing LLM calls to fall back to the real OpenAI internet endpoint instead of the user-configured local backend.
Root Cause
Two independent gaps:
ActorConfigSchemasilently droppedoptions— nooptionsfield, and Pydantic v2 defaults toextra='ignore', sooptionswas stripped during validation.Four call sites never forwarded options to
create_llm()—StrategyActor._execute_with_llm(),LLMStrategizeActor.execute(),LLMExecuteActor.execute(), andSessionWorkflow._resolve_llm()all created the LLM with zero extra kwargs.Changes
New shared utility (
src/cleveragents/actor/config.py)build_llm_kwargs_from_options()— extractsopenai_api_base,openai_api_key(via__api_key_sentinel), and other allowed kwargs from actor options dict_ALLOWED_LLM_OPTIONS/_RESERVED_LLM_OPTIONSconstantsSchema fix (
src/cleveragents/actor/schema.py)options: dict[str, Any]field toActorConfigSchemaLifecycle/protocol additions
PlanLifecycleService.resolve_actor_options()— retrieves options from actorconfig_blobresolve_actor_options()toLifecycleServiceprotocol (strategy_resolution.py)resolve_actor_options()toPlanLifecycleProtocol(llm_actors.py)build_actor_options_resolver()utility in strategy_resolution.pyFixed 4 call sites
StrategyActor._execute_with_llm()— resolves options before callingcreate_llm()LLMStrategizeActor.execute()— resolves options before callingcreate_llm()LLMExecuteActor.execute()— resolves options before callingcreate_llm()SessionWorkflow._resolve_llm()— newactor_options_resolverparameterRefactored reactive path
reactive/stream_router.pyandreactive/tool_caller.pynow usebuild_llm_kwargs_from_options()instead of inline copiesWiring
_build_actor_options_resolver()wired toSessionWorkflow_build_actor_options_resolver_for_session_workflow()wiredTests
features/actor_options_propagation.feature— 14 BDD scenarios passingCloses #11256
options.openai_api_baseandoptions.openai_api_keyto LLM client creation in Strategize/Execute paths7a7d3b8121to0ecacf9f220ecacf9f22to9a10e79b029a10e79b02to080e1d5e3fClaimed by
merge_drive.py(pid 1264876) until2026-05-28T23:05:06.184455+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
8d9cedce8ctofae4384370Claimed by
merge_drive.py(pid 1264876) until2026-05-29T01:39:37.590838+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Approved by the controller reviewer stage (workflow 19).
event occurred 2026-05-28T13:54:29.105366+00:00
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11257 is a focused bugfix for actor options (openai_api_base, openai_api_key) not being propagated through LLM client creation in Strategize, Execute, and session workflow paths. Searched open PRs by component name (ActorConfigSchema, StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow) and by semantic keywords (propagate, options, actor configuration). Related PRs (#10587, #10660, #10676) address broader LLM provider abstraction and multi-provider support but do not overlap with this targeted options-propagation bugfix. No duplicates found.
event occurred 2026-05-28T13:58:30.893624+00:00
📋 Estimate: tier 1.
13 files changed (+759/-93) across multiple subsystems: new utility module, Pydantic schema addition, protocol interface extensions on LifecycleService/PlanLifecycleProtocol, 4 call-site fixes, reactive path refactor, CLI and A2A facade wiring, and 14 new BDD scenarios. Protocol additions have downstream coupling implications. CI integration_tests gate is currently failing (1/7 Robot tests), requiring cross-file diagnosis to resolve. Multi-file, cross-subsystem scope with new logic and test work is a clear Tier 1 fit; not Tier 2 because the fix approach is well-understood and requires no repo-wide architectural research.
(attempt #3, tier 1)
event occurred 2026-05-28T14:03:18.138476+00:00
🔧 Implementer attempt —
rebased.Pushed 1 commit:
9a10e79.event occurred 2026-05-28T19:44:06.346313+00:00
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11257 addresses a unique gap in the actor options propagation pipeline: ActorConfigSchema silently dropped options, and four call sites (StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow) never forwarded options to create_llm(). No other open PR targets this specific configuration-to-LLM-creation coupling. Related PRs address LLM provider abstraction, cost tracking, or actor loading—all orthogonal to option propagation.
event occurred 2026-05-28T19:45:47.490240+00:00
📋 Estimate: tier 1.
Cross-subsystem change touching 13 files (+759/-93): new actor/config.py utility, schema additions, lifecycle protocol extensions across multiple layers (strategy_resolution.py, llm_actors.py), 4 fixed call sites (StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow), reactive path refactor (stream_router.py, tool_caller.py), CLI/A2A facade wiring, and 14 new BDD scenarios. CI has two real failures: unit_tests shows a traceback-outside-scenario (test setup/teardown error in Behave) and integration_tests has 1/7 Robot tests failing on paths directly touched by this PR. Standard multi-file cross-subsystem engineering work with failing tests to diagnose and fix.
(attempt #6, tier 1)
event occurred 2026-05-28T19:46:37.111234+00:00
🔧 Implementer attempt —
rebased.Pushed 1 commit:
080e1d5.(attempt #7, tier 1)
event occurred 2026-05-28T20:10:35.168505+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
4f53c21.Files touched:
features/mocks/mock_strategy_llm.py,features/steps/llm_actors_coverage_steps.py,robot/helper_m5_e2e_context.py.(attempt #8, tier 1)
event occurred 2026-05-28T21:03:50.425437+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
8d9cedc.Files touched:
src/cleveragents/reactive/stream_router.py,src/cleveragents/reactive/tool_caller.py.event occurred 2026-05-28T21:25:29.660618+00:00
✅ Approved
Reviewed at commit
8d9cedc.Confidence: high.
(attempt #10, tier 1)
event occurred 2026-05-28T23:37:43.730072+00:00
🔧 Implementer attempt —
blocked.Blockers:
8cace12f66but dispatch base wasfae4384370. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.(attempt #11, tier 2)
event occurred 2026-05-28T23:40:05.687706+00:00
🔧 Implementer attempt —
ci-not-ready.event occurred 2026-05-29T00:02:19.173183+00:00
✅ Approved
Reviewed at commit
8cace12.Confidence: high.