fix(strategize): propagate actor options (openai_api_base, openai_api_key) to LLM client creation in Strategize/Execute paths #11257
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Blocks
Reference
cleveragents/cleveragents-core!11257
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "bugfix/m5-actor-options-ignored"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Propagates actor-level YAML
options(such asopenai_api_baseandopenai_api_key) through toProviderRegistry.create_llm()in the Strategize and Execute phases, and in session-based workflows.Previously these options were silently ignored, causing LLM calls to fall back to the real OpenAI internet endpoint instead of the user-configured local backend.
Root Cause
Two independent gaps:
ActorConfigSchemasilently droppedoptions— nooptionsfield, and Pydantic v2 defaults toextra='ignore', sooptionswas stripped during validation.Four call sites never forwarded options to
create_llm()—StrategyActor._execute_with_llm(),LLMStrategizeActor.execute(),LLMExecuteActor.execute(), andSessionWorkflow._resolve_llm()all created the LLM with zero extra kwargs.Changes
New shared utility (
src/cleveragents/actor/config.py)build_llm_kwargs_from_options()— extractsopenai_api_base,openai_api_key(via__api_key_sentinel), and other allowed kwargs from actor options dict_ALLOWED_LLM_OPTIONS/_RESERVED_LLM_OPTIONSconstantsSchema fix (
src/cleveragents/actor/schema.py)options: dict[str, Any]field toActorConfigSchemaLifecycle/protocol additions
PlanLifecycleService.resolve_actor_options()— retrieves options from actorconfig_blobresolve_actor_options()toLifecycleServiceprotocol (strategy_resolution.py)resolve_actor_options()toPlanLifecycleProtocol(llm_actors.py)build_actor_options_resolver()utility in strategy_resolution.pyFixed 4 call sites
StrategyActor._execute_with_llm()— resolves options before callingcreate_llm()LLMStrategizeActor.execute()— resolves options before callingcreate_llm()LLMExecuteActor.execute()— resolves options before callingcreate_llm()SessionWorkflow._resolve_llm()— newactor_options_resolverparameterRefactored reactive path
reactive/stream_router.pyandreactive/tool_caller.pynow usebuild_llm_kwargs_from_options()instead of inline copiesWiring
_build_actor_options_resolver()wired toSessionWorkflow_build_actor_options_resolver_for_session_workflow()wiredTests
features/actor_options_propagation.feature— 14 BDD scenarios passingCloses #11256
options.openai_api_baseandoptions.openai_api_keyto LLM client creation in Strategize/Execute paths7a7d3b81210ecacf9f22options(openai_api_base,openai_api_key) ignored in Strategize/Execute paths — LLM calls fall back to real OpenAI instead of local backend0ecacf9f229a10e79b029a10e79b02080e1d5e3fClaimed by
merge_drive.py(pid1264876) until2026-05-28T23:05:06.184455+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
8d9cedce8cfae4384370Claimed by
merge_drive.py(pid1264876) until2026-05-29T01:39:37.590838+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
Approved by the controller reviewer stage (workflow 19).
event occurred 2026-05-28T13:54:29.105366+00:00
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11257 is a focused bugfix for actor options (openai_api_base, openai_api_key) not being propagated through LLM client creation in Strategize, Execute, and session workflow paths. Searched open PRs by component name (ActorConfigSchema, StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow) and by semantic keywords (propagate, options, actor configuration). Related PRs (#10587, #10660, #10676) address broader LLM provider abstraction and multi-provider support but do not overlap with this targeted options-propagation bugfix. No duplicates found.
event occurred 2026-05-28T13:58:30.893624+00:00
📋 Estimate: tier 1.
13 files changed (+759/-93) across multiple subsystems: new utility module, Pydantic schema addition, protocol interface extensions on LifecycleService/PlanLifecycleProtocol, 4 call-site fixes, reactive path refactor, CLI and A2A facade wiring, and 14 new BDD scenarios. Protocol additions have downstream coupling implications. CI integration_tests gate is currently failing (1/7 Robot tests), requiring cross-file diagnosis to resolve. Multi-file, cross-subsystem scope with new logic and test work is a clear Tier 1 fit; not Tier 2 because the fix approach is well-understood and requires no repo-wide architectural research.
(attempt #3, tier 1)
event occurred 2026-05-28T14:03:18.138476+00:00
🔧 Implementer attempt —
rebased.Pushed 1 commit:
9a10e79.event occurred 2026-05-28T19:44:06.346313+00:00
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11257 addresses a unique gap in the actor options propagation pipeline: ActorConfigSchema silently dropped options, and four call sites (StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow) never forwarded options to create_llm(). No other open PR targets this specific configuration-to-LLM-creation coupling. Related PRs address LLM provider abstraction, cost tracking, or actor loading—all orthogonal to option propagation.
event occurred 2026-05-28T19:45:47.490240+00:00
📋 Estimate: tier 1.
Cross-subsystem change touching 13 files (+759/-93): new actor/config.py utility, schema additions, lifecycle protocol extensions across multiple layers (strategy_resolution.py, llm_actors.py), 4 fixed call sites (StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow), reactive path refactor (stream_router.py, tool_caller.py), CLI/A2A facade wiring, and 14 new BDD scenarios. CI has two real failures: unit_tests shows a traceback-outside-scenario (test setup/teardown error in Behave) and integration_tests has 1/7 Robot tests failing on paths directly touched by this PR. Standard multi-file cross-subsystem engineering work with failing tests to diagnose and fix.
(attempt #6, tier 1)
event occurred 2026-05-28T19:46:37.111234+00:00
🔧 Implementer attempt —
rebased.Pushed 1 commit:
080e1d5.(attempt #7, tier 1)
event occurred 2026-05-28T20:10:35.168505+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
4f53c21.Files touched:
features/mocks/mock_strategy_llm.py,features/steps/llm_actors_coverage_steps.py,robot/helper_m5_e2e_context.py.(attempt #8, tier 1)
event occurred 2026-05-28T21:03:50.425437+00:00
🔧 Implementer attempt —
resolved.Pushed 1 commit:
8d9cedc.Files touched:
src/cleveragents/reactive/stream_router.py,src/cleveragents/reactive/tool_caller.py.event occurred 2026-05-28T21:25:29.660618+00:00
✅ Approved
Reviewed at commit
8d9cedc.Confidence: high.
(attempt #10, tier 1)
event occurred 2026-05-28T23:37:43.730072+00:00
🔧 Implementer attempt —
blocked.Blockers:
8cace12f66but dispatch base wasfae4384370. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.(attempt #11, tier 2)
event occurred 2026-05-28T23:40:05.687706+00:00
🔧 Implementer attempt —
ci-not-ready.event occurred 2026-05-29T00:02:19.173183+00:00
✅ Approved
Reviewed at commit
8cace12.Confidence: high.