feat(server): entity sync (_cleveragents/sync/*) #1125

Merged
HAL9000 merged 6 commits from feature/m9-entity-sync into master 2026-05-29 13:14:35 +00:00

6 Commits

Author SHA1 Message Date
HAL9000 6c684d920f test(a2a): cover facade DI fallbacks and message/send validation
CI / lint (pull_request) Successful in 42s
CI / typecheck (pull_request) Successful in 54s
CI / security (pull_request) Successful in 1m7s
CI / push-validation (pull_request) Successful in 38s
CI / helm (pull_request) Successful in 39s
CI / build (pull_request) Successful in 46s
CI / quality (pull_request) Successful in 1m13s
CI / integration_tests (pull_request) Successful in 5m0s
CI / unit_tests (pull_request) Successful in 6m13s
CI / docker (pull_request) Successful in 1m25s
CI / coverage (pull_request) Successful in 11m16s
CI / status-check (pull_request) Successful in 3s
Add 5 BDD scenarios to features/a2a_facade_coverage_boost.feature that
exercise previously uncovered paths in src/cleveragents/a2a/facade.py:

- _handle_message_send raises ValueError on empty session_id (line 469)
- _handle_message_send raises ValueError on empty message (line 471)
- _build_actor_resolver_for_session_workflow exception fallback (411-425)
- _build_actor_options_resolver_for_session_workflow exception fallback
  (434-452)
- _provider_registry property read (line 160)

Pushes overall coverage past the 96.5% slipcover --fail-under threshold
that the CI / coverage gate enforces; the prior run was 96.4%.
2026-05-29 08:41:06 -04:00
HAL9000 77ff45ca7e fix(server): return full JSON-RPC envelope from /a2a and fix health status
CI / lint (pull_request) Successful in 41s
CI / typecheck (pull_request) Successful in 54s
CI / quality (pull_request) Successful in 59s
CI / push-validation (pull_request) Successful in 36s
CI / security (pull_request) Successful in 1m13s
CI / helm (pull_request) Successful in 38s
CI / build (pull_request) Successful in 45s
CI / integration_tests (pull_request) Successful in 4m51s
CI / unit_tests (pull_request) Successful in 6m16s
CI / docker (pull_request) Successful in 1m27s
CI / coverage (pull_request) Failing after 11m15s
CI / status-check (pull_request) Failing after 3s
The /a2a endpoint was returning response.result directly instead of the
full A2aResponse envelope, so callers checking data["result"]["status"]
received None. Also _handle_health_check returned "ok" instead of "healthy",
mismatching both the Behave and Robot Framework tests.

- asgi_app.py: use response.model_dump(exclude_none=True) to return the
  complete {"jsonrpc", "result", ...} envelope per A2A spec
- facade.py: change _handle_health_check status from "ok" to "healthy"
  to match the GET /health liveness probe and the test expectations

ISSUES CLOSED: #866
2026-05-29 07:44:44 -04:00
HAL9000 c77f90b4ff fix(sync): add missing coverage scenarios and remove dead _iso_now from sync_models
CI / push-validation (pull_request) Successful in 26s
CI / helm (pull_request) Successful in 28s
CI / lint (pull_request) Successful in 46s
CI / quality (pull_request) Successful in 47s
CI / build (pull_request) Successful in 48s
CI / typecheck (pull_request) Successful in 1m8s
CI / security (pull_request) Successful in 1m17s
CI / integration_tests (pull_request) Failing after 2m54s
CI / unit_tests (pull_request) Failing after 4m48s
CI / coverage (pull_request) Has been skipped
CI / docker (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
- Remove unused _iso_now() from sync_models.py (dead code: called nowhere in
  the module; sync_service.py has its own _iso_now())
- Remove now-unused `from datetime import UTC, datetime` import
- Add 5 new BDD scenarios covering previously uncovered code paths:
  - VectorClock.happens_before() TypeError guard (sync_models.py:134-135)
  - VectorClock.is_concurrent() TypeError guard (sync_models.py:159-160)
  - process_offline_queue() PULL direction branch (sync_service.py:468-475)
  - resolve_conflict() last_writer_wins when server entity is newer (sync_service.py:549 else)
  - SyncService.push() with CLIENT_WINS resolution (_resolve_conflict lines 663-665)
- Add corresponding step implementations for the new scenarios

ISSUES CLOSED: #1125
2026-05-29 07:21:08 -04:00
cleveragents-auto ee1ec2b56d chore: worker ruff auto-fix (pre-push lint gate) 2026-05-29 07:21:08 -04:00
HAL9000 5ede1c018a fix(server,sync): use A2aRequest.method not .operation in tests and helpers
The new entity-sync feature introduced A2aRequest with a `method` field
(JSON-RPC 2.0 wire format), but several test/helper files used the wrong
field name `operation` when constructing requests or logging, and checked
non-existent `.status`/`.data` attributes on A2aResponse instead of
`.result`/`.error`.

Fixes:
- asgi_app.py: log `a2a_request.method`, not `.operation` (typecheck error)
- server_lifecycle_steps.py: send `method` key in JSON-RPC payload; look
  up status in `result` dict, not top-level response body
- server_lifecycle.feature: expect "healthy" (what the handler returns),
  not "ok"
- entity_sync_steps.py: construct A2aRequest(method=...) not (operation=...);
  assert on .result/.error instead of .status/.data
- robot/helper_entity_sync.py: same method= and result/error fixes across
  sync_pull, sync_push, sync_status, sync_facade_no_service helpers
- robot/helper_server_lifecycle.py: same method= and result path fixes

ISSUES CLOSED: #1125
2026-05-29 07:21:08 -04:00
freemo ff9c6540a2 feat(server): entity sync (_cleveragents/sync/*)
Implement entity synchronization between client and server using
the _cleveragents/sync/* A2A extension methods per the specification.

Sync models (src/cleveragents/a2a/sync_models.py):
- Pydantic v2 models for pull/push/status requests and responses
- VectorClock with increment, merge, happens-before, and concurrency
  detection for distributed conflict detection
- SyncEntitySnapshot, SyncConflict, SyncState, SyncQueueEntry models
- SyncEntityType enum: actor, skill, action, plan, session
- ConflictResolution enum: last_writer_wins, manual, server_wins,
  client_wins

SyncService (src/cleveragents/application/services/sync_service.py):
- pull(): download server namespace entities to local cache with
  incremental sync (since timestamps) and force-overwrite option
- push(): push local entity definitions to server namespace with
  configurable conflict resolution strategy
- status(): compare local and server entity versions, detect drift,
  report local-ahead, server-ahead, and concurrent conflicts
- resolve_conflict(): manually resolve detected conflicts with
  winner selection (local or server)
- Offline queue: enqueue_offline() and process_offline_queue() for
  retry on reconnect, with max-retries enforcement
- The local/ namespace is never synced per specification

A2A facade (src/cleveragents/a2a/facade.py):
- Replaced sync stub handlers with real _handle_sync_pull,
  _handle_sync_push, _handle_sync_status routing to SyncService
- Added sync_service property and TYPE_CHECKING import
- Facade returns stubs when no SyncService is registered

Tests:
- Behave BDD: features/entity_sync.feature (65 scenarios, 247 steps)
  covering models, vector clocks, pull/push/status, conflict resolution,
  offline queue, facade integration, constructor validation, edge cases
- Robot Framework: robot/entity_sync.robot (8 integration tests)

ISSUES CLOSED: #866
2026-05-29 07:21:08 -04:00