cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test: restore complete M2 acceptance e2e test #11191

Open
freemo wants to merge 1 commit from fix/m2-acceptance-test into master
pull from: fix/m2-acceptance-test
merge into: cleveragents:master
Conversation 3 Commits 1 Files changed 1 +115 -31
freemo commented 2026-05-13 06:16:29 +00:00
Owner
Copy link

Summary

Restore the complete M2 acceptance e2e test which was truncated at line 48, causing rc=1 failures during execution.

Root Cause

The M2 acceptance test file (robot/e2e/m2_acceptance.robot) was incomplete. It contained only the test setup (steps 1-4 lines), but was missing steps 2-10 that comprise the actual test logic:

  • Actor YAML compilation and registration
  • Resource registration and project creation
  • Action creation with custom actor configuration
  • Full plan lifecycle: use, strategize, execute, diff, apply
  • Plan status and integrity verification

When Robot Framework executed the truncated test, it immediately exited after the setup step without running any actual test logic, resulting in rc=1 (test failure).

Changes

robot/e2e/m2_acceptance.robot: Restore complete M2 milestone acceptance test with all 10 steps:

  1. Create temp git repo with sample project files
  2. Create and register custom actor YAML
  3. Register resource and create project
  4. Create action referencing the custom actor
  5. Plan use
  6. Plan execute — strategize phase
  7. Plan execute — execute phase
  8. Plan diff
  9. Plan apply
  10. Verify actor compilation and plan integrity

The test exercises:

  • Real LLM API integration (OpenAI GPT-4)
  • Actor YAML compilation and CLI registration
  • Resource and project management
  • Full plan lifecycle execution
  • Plan state verification

Quality Gates

All quality gates pass:

  • Robot Framework syntax validation: ✓ (dry-run passes)
  • Test framework compatibility: ✓ (no missing keywords)
  • Integration with common_e2e.resource: ✓ (all helper keywords available)

Closes #10812
This PR blocks issue #10812

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Summary Restore the complete M2 acceptance e2e test which was truncated at line 48, causing rc=1 failures during execution. ## Root Cause The M2 acceptance test file (robot/e2e/m2_acceptance.robot) was incomplete. It contained only the test setup (steps 1-4 lines), but was missing steps 2-10 that comprise the actual test logic: - Actor YAML compilation and registration - Resource registration and project creation - Action creation with custom actor configuration - Full plan lifecycle: use, strategize, execute, diff, apply - Plan status and integrity verification When Robot Framework executed the truncated test, it immediately exited after the setup step without running any actual test logic, resulting in rc=1 (test failure). ## Changes **robot/e2e/m2_acceptance.robot**: Restore complete M2 milestone acceptance test with all 10 steps: 1. Create temp git repo with sample project files 2. Create and register custom actor YAML 3. Register resource and create project 4. Create action referencing the custom actor 5. Plan use 6. Plan execute — strategize phase 7. Plan execute — execute phase 8. Plan diff 9. Plan apply 10. Verify actor compilation and plan integrity The test exercises: - Real LLM API integration (OpenAI GPT-4) - Actor YAML compilation and CLI registration - Resource and project management - Full plan lifecycle execution - Plan state verification ## Quality Gates All quality gates pass: - Robot Framework syntax validation: ✓ (dry-run passes) - Test framework compatibility: ✓ (no missing keywords) - Integration with common_e2e.resource: ✓ (all helper keywords available) --- Closes #10812 This PR blocks issue #10812 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor
freemo added this to the v3.2.0 milestone 2026-05-13 06:16:29 +00:00
test: restore complete M2 acceptance e2e test
All checks were successful
CI / lint (pull_request) Successful in 39s
Details
CI / typecheck (pull_request) Successful in 1m20s
Details
CI / quality (pull_request) Successful in 58s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / push-validation (pull_request) Successful in 30s
Details
CI / build (pull_request) Successful in 50s
Details
CI / security (pull_request) Successful in 3m2s
Details
CI / integration_tests (pull_request) Successful in 3m6s
Details
CI / unit_tests (pull_request) Successful in 4m49s
Details
CI / docker (pull_request) Successful in 1m27s
Details
CI / coverage (pull_request) Successful in 12m33s
Details
CI / status-check (pull_request) Successful in 3s
Details
87d248396a 
The M2 acceptance test was incomplete (truncated at line 48).
Restore the full test case that exercises the complete M2 milestone:
- Actor YAML compilation and registration
- Resource registration and project creation
- Action creation with custom actor configuration
- Full plan lifecycle: use, strategize, execute, diff, apply
- Verification of plan status and integrity

Exercises real LLM API integration using OpenAI GPT-4 model.

ISSUES CLOSED: #10812
HAL9001 requested changes 2026-05-13 23:41:45 +00:00
Dismissed
HAL9001 left a comment
Copy link

PR Review — REQUEST_CHANGES

PR #11191: test: restore complete M2 acceptance e2e test
Reviewed by: HAL9001 (reviewer bot)

Overall Assessment

This PR correctly identifies and addresses a real problem — the M2 acceptance test was truncated at line 48, causing it to fail immediately after setup with no actual test logic running. The restored test logic is well-structured and the 10-step flow makes sense. All CI checks pass.

However, there are several blocking issues that must be resolved before this PR can be approved.

BLOCKING Issues

1. Missing Type/ label
The PR has no Type/ label. Per CONTRIBUTING.md, every PR must have exactly one Type/ label (Type/Bug, Type/Feature, or Type/Task) before it can be merged. For a test restore fix, Type/Testing or Type/Bug would be appropriate.

2. Non-standard branch name
The branch fix/m2-acceptance-test uses a fix/ prefix that is not in the allowed branch naming scheme. The project requires feature/mN-, bugfix/mN-, or tdd/mN- with the milestone number. The issue Metadata section lists test/restore-e2e-tests as the branch name — this also does not match the convention. The PR branch should follow the format bugfix/m2-restore-m2-acceptance-test (milestone number from the target milestone v3.1.0 = m1? or the current assignment v3.2.0 = m2?). Please use the correct convention.

3. Commit message does not follow Conventional Changelog format
The commit message first line test: restore complete M2 acceptance e2e test is missing the required scope: test(<scope>): .... Per CONTRIBUTING.md, all commit messages must follow type(scope): description format — the scope cannot be omitted. For example: test(e2e): restore complete M2 acceptance test.

4. CHANGELOG not updated
The PR commit does not include a CHANGELOG.md entry. Per CONTRIBUTING.md, every commit must be accompanied by a changelog entry describing the change for users.

5. Forgejo dependency link not set up
The PR body states "This PR blocks issue #10812" but the actual Forgejo dependency link is not configured. The PR must formally block issue #10812 via Forgejos dependency system (add issue #10812 under the PRs "Blocks" section). This ensures the correct unresolvable-deadlock-free direction: PR → blocks → issue.

Concerns (Non-blocking)

6. Removal of TDD regression tags
The original test had [Tags] E2E tdd_issue tdd_issue_4189 tdd_expected_fail which tracked this as a TDD regression test for issue #4189. The restored version drops all of these in favour of just [Tags] E2E. If the underlying bug (#4189) is now resolved and this test is expected to pass, removing tdd_expected_fail is correct — but this should be explicitly documented in the commit message or PR body. If the TDD linkage to #4189 should be preserved, the tdd_issue_4189 tag should be retained.

7. Actor registration success not validated
In Step 2, the actor registration command result is only checked for the absence of "Traceback" — the return code is never checked and no positive confirmation (Output Should Contain) is performed. Compare with steps 3 and 4 which use Output Should Contain for positive validation. This could silently succeed with a non-zero rc or produce no useful output. Consider adding Should Be Equal As Integers ${r_actor.rc} 0 or using Output Should Contain ${r_actor} ${ACTOR_NAME}.

8. Hardcoded OpenAI model
Steps 2 and 4 hardcode gpt-4 / openai/gpt-4 rather than using the Resolve LLM Actor keyword already present in common_e2e.resource. This keyword probes the OpenAI key and falls back to Anthropic when unavailable. The hardcoded model will cause the test to fail in environments where only Anthropic keys are available — defeating the purpose of the graceful fallback infrastructure already built.

What is correct

  • The restored test logic properly exercises the full M2 plan lifecycle (10 steps)
  • Robot Framework indentation style corrected to 4-space throughout
  • CI passes all required gates (lint, typecheck, security, unit_tests, coverage, integration_tests)
  • ISSUES CLOSED: #10812 in the commit footer
  • Skip If No LLM Keys guard is present
  • Correct use of ${SUITE_HOME} for file paths
  • Plan ID extraction via ULID regex is correct
  • Error checking ("Traceback", "INTERNAL") is appropriate for most steps

Summary

Please address the 5 blocking issues above (missing Type/ label, branch naming, commit message scope, CHANGELOG entry, Forgejo dependency link) and consider the 3 concerns (TDD tag removal justification, actor registration validation, hardcoded model). The core test logic is sound and the fix is correct in substance.

## PR Review — REQUEST_CHANGES **PR #11191**: test: restore complete M2 acceptance e2e test **Reviewed by**: HAL9001 (reviewer bot) --- ### Overall Assessment This PR correctly identifies and addresses a real problem — the M2 acceptance test was truncated at line 48, causing it to fail immediately after setup with no actual test logic running. The restored test logic is well-structured and the 10-step flow makes sense. All CI checks pass. However, there are several **blocking issues** that must be resolved before this PR can be approved. --- ### BLOCKING Issues **1. Missing Type/ label** The PR has no `Type/` label. Per CONTRIBUTING.md, every PR must have exactly one `Type/` label (`Type/Bug`, `Type/Feature`, or `Type/Task`) before it can be merged. For a test restore fix, `Type/Testing` or `Type/Bug` would be appropriate. **2. Non-standard branch name** The branch `fix/m2-acceptance-test` uses a `fix/` prefix that is not in the allowed branch naming scheme. The project requires `feature/mN-`, `bugfix/mN-`, or `tdd/mN-` with the milestone number. The issue Metadata section lists `test/restore-e2e-tests` as the branch name — this also does not match the convention. The PR branch should follow the format `bugfix/m2-restore-m2-acceptance-test` (milestone number from the target milestone v3.1.0 = m1? or the current assignment v3.2.0 = m2?). Please use the correct convention. **3. Commit message does not follow Conventional Changelog format** The commit message first line `test: restore complete M2 acceptance e2e test` is missing the required scope: `test(<scope>): ...`. Per CONTRIBUTING.md, all commit messages must follow `type(scope): description` format — the scope cannot be omitted. For example: `test(e2e): restore complete M2 acceptance test`. **4. CHANGELOG not updated** The PR commit does not include a CHANGELOG.md entry. Per CONTRIBUTING.md, every commit must be accompanied by a changelog entry describing the change for users. **5. Forgejo dependency link not set up** The PR body states "This PR blocks issue #10812" but the actual Forgejo dependency link is not configured. The PR must formally block issue #10812 via Forgejos dependency system (add issue #10812 under the PRs "Blocks" section). This ensures the correct unresolvable-deadlock-free direction: PR → blocks → issue. --- ### Concerns (Non-blocking) **6. Removal of TDD regression tags** The original test had `[Tags] E2E tdd_issue tdd_issue_4189 tdd_expected_fail` which tracked this as a TDD regression test for issue #4189. The restored version drops all of these in favour of just `[Tags] E2E`. If the underlying bug (#4189) is now resolved and this test is expected to pass, removing `tdd_expected_fail` is correct — but this should be explicitly documented in the commit message or PR body. If the TDD linkage to #4189 should be preserved, the `tdd_issue_4189` tag should be retained. **7. Actor registration success not validated** In Step 2, the actor registration command result is only checked for the absence of "Traceback" — the return code is never checked and no positive confirmation (`Output Should Contain`) is performed. Compare with steps 3 and 4 which use `Output Should Contain` for positive validation. This could silently succeed with a non-zero rc or produce no useful output. Consider adding `Should Be Equal As Integers ${r_actor.rc} 0` or using `Output Should Contain ${r_actor} ${ACTOR_NAME}`. **8. Hardcoded OpenAI model** Steps 2 and 4 hardcode `gpt-4` / `openai/gpt-4` rather than using the `Resolve LLM Actor` keyword already present in `common_e2e.resource`. This keyword probes the OpenAI key and falls back to Anthropic when unavailable. The hardcoded model will cause the test to fail in environments where only Anthropic keys are available — defeating the purpose of the graceful fallback infrastructure already built. --- ### What is correct - The restored test logic properly exercises the full M2 plan lifecycle (10 steps) - Robot Framework indentation style corrected to 4-space throughout - CI passes all required gates (lint, typecheck, security, unit_tests, coverage, integration_tests) - `ISSUES CLOSED: #10812` in the commit footer - `Skip If No LLM Keys` guard is present - Correct use of `${SUITE_HOME}` for file paths - Plan ID extraction via ULID regex is correct - Error checking ("Traceback", "INTERNAL") is appropriate for most steps --- ### Summary Please address the 5 blocking issues above (missing Type/ label, branch naming, commit message scope, CHANGELOG entry, Forgejo dependency link) and consider the 3 concerns (TDD tag removal justification, actor registration validation, hardcoded model). The core test logic is sound and the fix is correct in substance.
robot/e2e/m2_acceptance.robot Outdated
@ -10,0 +5,4 @@
... tool lifecycle, and plan execution with a custom actor using real LLM keys.
... Zero mocking — all CLI invocations hit the real CleverAgents binary with
... real provider keys.
Resource common_e2e.resource
HAL9001 commented 2026-05-13 23:41:45 +00:00
Owner
Copy link

BLOCKING — Missing Type/ label on PR

This review comment is anchored at the test tags line for context. The PR itself is missing a Type/ label. Per CONTRIBUTING.md, every PR must have exactly one Type/ label before it can be merged. Please add Type/Testing or Type/Bug to this PR via the Forgejo UI.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Missing Type/ label on PR** This review comment is anchored at the test tags line for context. The PR itself is missing a `Type/` label. Per CONTRIBUTING.md, every PR must have exactly one `Type/` label before it can be merged. Please add `Type/Testing` or `Type/Bug` to this PR via the Forgejo UI. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-13 23:41:45 +00:00
Owner
Copy link

BLOCKING — Commit message missing scope

The commit message first line is:

test: restore complete M2 acceptance e2e test

This is missing the required (<scope>) component. Per CONTRIBUTING.md, all commit messages must follow Conventional Changelog format: type(scope): description. For example:

test(e2e): restore complete M2 acceptance e2e test

Please amend/rebase to fix the commit message.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Commit message missing scope** The commit message first line is: ``` test: restore complete M2 acceptance e2e test ``` This is missing the required `(<scope>)` component. Per CONTRIBUTING.md, all commit messages must follow Conventional Changelog format: `type(scope): description`. For example: ``` test(e2e): restore complete M2 acceptance e2e test ``` Please amend/rebase to fix the commit message. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-13 23:41:45 +00:00
Owner
Copy link

BLOCKING — CHANGELOG.md not updated

This commit does not update CHANGELOG.md. Per CONTRIBUTING.md, every commit must include a changelog entry describing the change for users. Please add an entry to CHANGELOG.md in the same commit.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — CHANGELOG.md not updated** This commit does not update `CHANGELOG.md`. Per CONTRIBUTING.md, every commit must include a changelog entry describing the change for users. Please add an entry to CHANGELOG.md in the same commit. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
robot/e2e/m2_acceptance.robot Outdated
@ -41,1 +61,4 @@
Should Not Contain ${r_actor.stdout}${r_actor.stderr} Traceback
Log Actor registration: ${r_actor.stdout}
# ---- Step 3: Register resource and create project ----
HAL9001 commented 2026-05-13 23:41:45 +00:00
Owner
Copy link

Concern — Actor registration success not validated

The actor registration result is only checked for the absence of "Traceback":

Should Not Contain    ${r_actor.stdout}${r_actor.stderr}    Traceback

The return code is not checked and no positive assertion confirms the actor was actually registered. Compare with Steps 3 and 4 which use Output Should Contain for positive validation.

Consider adding:

Should Be Equal As Integers    ${r_actor.rc}    0    msg=actor add failed

or a positive assertion like:

Output Should Contain    ${r_actor}    ${ACTOR_NAME}

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Concern — Actor registration success not validated** The actor registration result is only checked for the absence of "Traceback": ```robot Should Not Contain ${r_actor.stdout}${r_actor.stderr} Traceback ``` The return code is not checked and no positive assertion confirms the actor was actually registered. Compare with Steps 3 and 4 which use `Output Should Contain` for positive validation. Consider adding: ```robot Should Be Equal As Integers ${r_actor.rc} 0 msg=actor add failed ``` or a positive assertion like: ```robot Output Should Contain ${r_actor} ${ACTOR_NAME} ``` --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
robot/e2e/m2_acceptance.robot Outdated
@ -43,0 +79,4 @@
... definition_of_done: Generate or modify at least one source file
... strategy_actor: openai/gpt-4
... execution_actor: openai/gpt-4
${action_yaml_path}= Set Variable ${SUITE_HOME}${/}action.yaml
HAL9001 commented 2026-05-13 23:41:45 +00:00
Owner
Copy link

Concern — Hardcoded OpenAI model bypasses graceful fallback

strategy_actor: openai/gpt-4
execution_actor: openai/gpt-4

The common_e2e.resource already provides the Resolve LLM Actor keyword that probes the OpenAI API and falls back to Anthropic if unavailable. Hardcoding openai/gpt-4 here means this test will fail in environments where only Anthropic keys are available, defeating the purpose of that infrastructure.

Consider using Resolve LLM Actor to dynamically pick the actor:

${resolved_actor}=    Resolve LLM Actor
# then use ${resolved_actor} in the action YAML

Same applies to Step 2 where model: gpt-4 is also hardcoded.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**Concern — Hardcoded OpenAI model bypasses graceful fallback** ```robot strategy_actor: openai/gpt-4 execution_actor: openai/gpt-4 ``` The `common_e2e.resource` already provides the `Resolve LLM Actor` keyword that probes the OpenAI API and falls back to Anthropic if unavailable. Hardcoding `openai/gpt-4` here means this test will fail in environments where only Anthropic keys are available, defeating the purpose of that infrastructure. Consider using `Resolve LLM Actor` to dynamically pick the actor: ```robot ${resolved_actor}= Resolve LLM Actor # then use ${resolved_actor} in the action YAML ``` Same applies to Step 2 where `model: gpt-4` is also hardcoded. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 force-pushed fix/m2-acceptance-test from 87d248396a
All checks were successful
CI / lint (pull_request) Successful in 39s
Details
CI / typecheck (pull_request) Successful in 1m20s
Details
CI / quality (pull_request) Successful in 58s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / push-validation (pull_request) Successful in 30s
Details
CI / build (pull_request) Successful in 50s
Details
CI / security (pull_request) Successful in 3m2s
Details
CI / integration_tests (pull_request) Successful in 3m6s
Details
CI / unit_tests (pull_request) Successful in 4m49s
Details
CI / docker (pull_request) Successful in 1m27s
Details
CI / coverage (pull_request) Successful in 12m33s
Details
CI / status-check (pull_request) Successful in 3s
Details
to 133e794dbd
Some checks failed
CI / lint (pull_request) Failing after 3s
Details
CI / typecheck (pull_request) Failing after 3s
Details
CI / security (pull_request) Failing after 2s
Details
CI / quality (pull_request) Failing after 4s
Details
CI / helm (pull_request) Successful in 1m1s
Details
CI / push-validation (pull_request) Successful in 1m6s
Details
CI / integration_tests (pull_request) Failing after 1m37s
Details
CI / build (pull_request) Failing after 1m37s
Details
CI / unit_tests (pull_request) Failing after 1m38s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 3s
Details
2026-05-15 01:23:45 +00:00 Compare
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-05-15 01:25:45 +00:00
HAL9001 requested changes 2026-05-15 08:02:07 +00:00
Dismissed
HAL9001 left a comment
Copy link

Review of PR #11191 - Re-evaluation after push

Reviewer: HAL9001 | Milestone: v3.2.0

Verification Summary

  • Files changed: 1 (net +115 -31) only robot/e2e/m2_acceptance.robot
  • Commits: 1 commit on branch fix/m2-acceptance-test
  • Python files reviewed: 0
  • Prior HAL9001 REQUEST_CHANGES: #8739

Blocking Issues from HAL9001 (#8739) - Status

1. Missing Type/ label -- STILL UNRESOLVED
PR has no labels ([]). Per CONTRIBUTING.md every PR must have exactly one Type/ label (Type/Bug, Type/Feature, or Type/Task). A test restore fix warrants Type/Testing or Type/Bug.

2. Non-standard branch name fix/m2-acceptance-test -- STILL UNRESOLVED
The branch uses fix/ prefix which does not match the required convention (feature/mN-, bugfix/mN-, or tdd/mN-). Should be e.g., bugfix/m2-restore-m2-acceptance-test.

3. Commit message scope missing -- STILL UNRESOLVED
First line: test: restore complete M2 acceptance e2e test
Required format per CONTRIBUTING.md is type(scope): description - the scope cannot be omitted. Should be e.g., test(e2e): restore complete M2 acceptance test.

4. CHANGELOG not updated -- STILL UNRESOLVED
Only 1 file changed (robot/e2e/m2_acceptance.robot). No CHANGELOG.md entry exists for this change.

5. Forgejo dependency link for #10812 -- STILL UNRESOLVED
PR body states This PR blocks issue #10812 but no formal dependency link is configured via the Forgejo dependency system.

Non-blocking Concerns from HAL9001 - Status

6. TDD regression tags removed -- PARTIALLY ADDRESSED
The original test had [Tags] E2E tdd_issue tdd_issue_4189 tdd_expected_fail. The restored version drops all of these. The PR body notes the restore but does not explicitly justify why the TDD regression tags for bug #4189 were removed.

7. Actor registration success not validated -- STILL UNRESOLVED
Step 2 checks Should Not Contain ... but does NOT verify ${r_actor.rc} equals 0 or use Output Should Contain. Compare with steps 3/4 which do positive validation.

8. Hardcoded OpenAI model -- STILL UNRESOLVED
The file hardcodes gpt-4 / openai/gpt-4 in 4 places instead of using the Resolve LLM Actor keyword from common_e2e.resource. This causes failures where only Anthropic keys are available.

Conclusion

All 5 blocking issues remain unresolved in this revision. The 3 non-blocking concerns also largely carry through unchanged (concern #6 is partially addressed by PR body documentation, but concerns #7 and #8 persist).

The core test logic restoration is sound - the 10-step flow is correct and well-structured as HAL9001 previously noted.

Action items required before approval:

  1. Add appropriate Type/ label(s)
  2. Rename branch to follow convention (bugfix/m2-...) - requires force-push
  3. Fix commit message to test(e2e): restore complete M2 acceptance test - amend + force-push
  4. Update CHANGELOG.md with an entry describing the restored test
  5. Add formal dependency link: add issue #10812 to PR Blocks section in Forgejo UI
  6. In Step 2, add Should Be Equal As Integers ${{r_actor.rc}} 0 or positive validation
  7. Replace all hardcoded gpt-4 references with the Resolve LLM Actor keyword from common_e2e.resource
## Review of PR #11191 - Re-evaluation after push **Reviewer:** HAL9001 | **Milestone:** v3.2.0 ### Verification Summary - **Files changed:** 1 (net +115 -31) only `robot/e2e/m2_acceptance.robot` - **Commits:** 1 commit on branch `fix/m2-acceptance-test` - **Python files reviewed:** 0 - **Prior HAL9001 REQUEST_CHANGES:** #8739 ### Blocking Issues from HAL9001 (#8739) - Status **1. Missing `Type/` label -- STILL UNRESOLVED** PR has no labels ([]). Per CONTRIBUTING.md every PR must have exactly one `Type/` label (`Type/Bug`, `Type/Feature`, or `Type/Task`). A test restore fix warrants `Type/Testing` or `Type/Bug`. **2. Non-standard branch name `fix/m2-acceptance-test` -- STILL UNRESOLVED** The branch uses `fix/` prefix which does not match the required convention (`feature/mN-`, `bugfix/mN-`, or `tdd/mN-`). Should be e.g., `bugfix/m2-restore-m2-acceptance-test`. **3. Commit message scope missing -- STILL UNRESOLVED** First line: `test: restore complete M2 acceptance e2e test` Required format per CONTRIBUTING.md is `type(scope): description` - the scope cannot be omitted. Should be e.g., `test(e2e): restore complete M2 acceptance test`. **4. CHANGELOG not updated -- STILL UNRESOLVED** Only 1 file changed (`robot/e2e/m2_acceptance.robot`). No CHANGELOG.md entry exists for this change. **5. Forgejo dependency link for #10812 -- STILL UNRESOLVED** PR body states This PR blocks issue #10812 but no formal dependency link is configured via the Forgejo dependency system. --- ### Non-blocking Concerns from HAL9001 - Status **6. TDD regression tags removed -- PARTIALLY ADDRESSED** The original test had `[Tags] E2E tdd_issue tdd_issue_4189 tdd_expected_fail`. The restored version drops all of these. The PR body notes the restore but does not explicitly justify why the TDD regression tags for bug #4189 were removed. **7. Actor registration success not validated -- STILL UNRESOLVED** Step 2 checks `Should Not Contain` ... but does NOT verify `${r_actor.rc}` equals 0 or use `Output Should Contain`. Compare with steps 3/4 which do positive validation. **8. Hardcoded OpenAI model -- STILL UNRESOLVED** The file hardcodes `gpt-4` / `openai/gpt-4` in 4 places instead of using the `Resolve LLM Actor` keyword from `common_e2e.resource`. This causes failures where only Anthropic keys are available. --- ### Conclusion All **5 blocking issues** remain unresolved in this revision. The 3 non-blocking concerns also largely carry through unchanged (concern #6 is partially addressed by PR body documentation, but concerns #7 and #8 persist). The core test logic restoration is sound - the 10-step flow is correct and well-structured as HAL9001 previously noted. **Action items required before approval:** 1. Add appropriate `Type/` label(s) 2. Rename branch to follow convention (`bugfix/m2-...`) - requires force-push 3. Fix commit message to `test(e2e): restore complete M2 acceptance test` - amend + force-push 4. Update CHANGELOG.md with an entry describing the restored test 5. Add formal dependency link: add issue #10812 to PR Blocks section in Forgejo UI 6. In Step 2, add `Should Be Equal As Integers ${{r_actor.rc}} 0` or positive validation 7. Replace all hardcoded `gpt-4` references with the `Resolve LLM Actor` keyword from `common_e2e.resource`
HAL9001 requested changes 2026-05-15 08:18:43 +00:00
HAL9001 left a comment
Copy link

Review of PR #11191 -- Re-evaluation after push

Reviewer: HAL9001 | Milestone: v3.2.0

Verification Summary

  • Files changed: 1 (net +115 -31) only robot/e2e/m2_acceptance.robot
  • Commits: 1 commit on branch fix/m2-acceptance-test
  • Python files reviewed: 0
  • Prior HAL9001 REQUEST_CHANGES: review that identified 5 blocking + 3 non-blocking issues

Issues from Prior HAL9001 Review -- Current Status

1. Missing Type/ label -- STILL UNRESOLVED
PR has no labels ([]). Per CONTRIBUTING.md every PR must have exactly one Type/ label.

2. Non-standard branch name fix/m2-acceptance-test -- STILL UNRESOLVED
The branch uses fix/ prefix which does not match the required convention.

3. Commit message scope missing -- STILL UNRESOLVED
First line: test: restore complete M2 acceptance e2e test
Required format per CONTRIBUTING.md is type(scope): description.

4. CHANGELOG not updated -- STILL UNRESOLVED
No CHANGELOG.md entry exists for this change.

5. Forgejo dependency link for #10812 -- STILL UNRESOLVED
PR body references #10812 but no formal dependency link is configured via the Forgejo system.

--- Non-Blocking Concerns ---

6. TDD regression tags removed -- PARTIALLY ADDRESSED
TDD tags (tdd_issue, tdd_issue_4189, tdd_expected_fail) were removed from [Tags]. PR body mentions the restore but does not explicitly justify why TDD regression tags for bug #4189 were dropped.

7. Actor registration success not validated -- STILL UNRESOLVED
Step 2 checks Should Not Contain ... but does NOT verify return code equals 0 or use positive validation like steps 3/4.

8. Hardcoded OpenAI model -- STILL UNRESOLVED
The file contains 4 hardcoded gpt-4 references instead of using the Resolve LLM Actor keyword from common_e2e.resource.

Action items required before approval:

  1. Add appropriate Type/ label(s)
  2. Rename branch to bugfix/m2-... convention - requires force-push
  3. Fix commit message to test(e2e): restore complete M2 acceptance test - amend + force-push
  4. Update CHANGELOG.md with an entry describing the restored test
  5. Add formal dependency link: add issue #10812 to PR Blocks section in Forgejo UI
  6. In Step 2, add return code validation (Should Be Equal As Integers) or positive output check
  7. Replace all hardcoded gpt-4 references with the Resolve LLM Actor keyword
## Review of PR #11191 -- Re-evaluation after push **Reviewer:** HAL9001 | **Milestone:** v3.2.0 ### Verification Summary - **Files changed:** 1 (net +115 -31) only `robot/e2e/m2_acceptance.robot` - **Commits:** 1 commit on branch `fix/m2-acceptance-test` - **Python files reviewed:** 0 - **Prior HAL9001 REQUEST_CHANGES:** review that identified 5 blocking + 3 non-blocking issues ### Issues from Prior HAL9001 Review -- Current Status **1. Missing `Type/` label -- STILL UNRESOLVED** PR has no labels ([]). Per CONTRIBUTING.md every PR must have exactly one `Type/` label. **2. Non-standard branch name `fix/m2-acceptance-test` -- STILL UNRESOLVED** The branch uses `fix/` prefix which does not match the required convention. **3. Commit message scope missing -- STILL UNRESOLVED** First line: `test: restore complete M2 acceptance e2e test` Required format per CONTRIBUTING.md is `type(scope): description`. **4. CHANGELOG not updated -- STILL UNRESOLVED** No CHANGELOG.md entry exists for this change. **5. Forgejo dependency link for #10812 -- STILL UNRESOLVED** PR body references #10812 but no formal dependency link is configured via the Forgejo system. --- Non-Blocking Concerns --- **6. TDD regression tags removed -- PARTIALLY ADDRESSED** TDD tags (tdd_issue, tdd_issue_4189, tdd_expected_fail) were removed from [Tags]. PR body mentions the restore but does not explicitly justify why TDD regression tags for bug #4189 were dropped. **7. Actor registration success not validated -- STILL UNRESOLVED** Step 2 checks `Should Not Contain` ... but does NOT verify return code equals 0 or use positive validation like steps 3/4. **8. Hardcoded OpenAI model -- STILL UNRESOLVED** The file contains 4 hardcoded `gpt-4` references instead of using the `Resolve LLM Actor` keyword from `common_e2e.resource`. **Action items required before approval:** 1. Add appropriate `Type/` label(s) 2. Rename branch to `bugfix/m2-...` convention - requires force-push 3. Fix commit message to `test(e2e): restore complete M2 acceptance test` - amend + force-push 4. Update CHANGELOG.md with an entry describing the restored test 5. Add formal dependency link: add issue #10812 to PR Blocks section in Forgejo UI 6. In Step 2, add return code validation (Should Be Equal As Integers) or positive output check 7. Replace all hardcoded `gpt-4` references with the `Resolve LLM Actor` keyword
Some checks failed
CI / lint (pull_request) Failing after 3s
Required
Details
CI / typecheck (pull_request) Failing after 3s
Required
Details
CI / security (pull_request) Failing after 2s
Required
Details
CI / quality (pull_request) Failing after 4s
Required
Details
CI / helm (pull_request) Successful in 1m1s
Details
CI / push-validation (pull_request) Successful in 1m6s
Details
CI / integration_tests (pull_request) Failing after 1m37s
Required
Details
CI / build (pull_request) Failing after 1m37s
Required
Details
CI / unit_tests (pull_request) Failing after 1m38s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / status-check (pull_request) Failing after 3s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/m2-acceptance-test:fix/m2-acceptance-test
git switch fix/m2-acceptance-test
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!11191
No description provided.