Fix: CI pipeline failures — replace brittle bash comparisons in status-check job with native expression conditions #11184

Closed
freemo wants to merge 4 commits from fix/status-check-native-expressions into master

4 Commits

Author SHA1 Message Date
freemo b81401fdf6 fix(ci): fix trailing whitespace indentation in push-validation job
CI / lint (pull_request) Failing after 1m0s
CI / build (pull_request) Successful in 47s
CI / typecheck (pull_request) Successful in 1m26s
CI / security (pull_request) Successful in 1m25s
CI / quality (pull_request) Successful in 1m0s
CI / push-validation (pull_request) Successful in 25s
CI / helm (pull_request) Successful in 26s
CI / integration_tests (pull_request) Successful in 3m2s
CI / unit_tests (pull_request) Failing after 5m49s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Has been skipped
CI / status-check (pull_request) Failing after 3s
Line 557 had 17-space indent instead of required 18-spaces on the
final echo statement in push-validation job's run block. This caused
a YAML parse error preventing the entire CI workflow from loading,
manifesting as "Failing after 0s" for all jobs.

ISSUES CLOSED: #11177
2026-05-13 02:07:51 +00:00
freemo 7628588a98 fix(ci): lint/format cleanup for BDD step definitions
ci.yml / fix(ci): lint/format cleanup for BDD step definitions (push) Failing after 0s
ci.yml / fix(ci): lint/format cleanup for BDD step definitions (pull_request) Failing after 0s
Fix ruff violations (UP015, formatting) in status_check_job_steps.py
to unblock CI builds on PR #11184.

ISSUES CLOSED: #11177
2026-05-13 01:58:46 +00:00
freemo ba3d3d1ef5 fix(ruff): resolve UP015 and format violations in status_check_job_steps.py (#11178)
- Remove unnecessary file mode argument from open() call (UP015, line 31)
- Fix PEP 8 spacing around slice expression (+ 7 → + 7 space before :)
2026-05-13 01:56:17 +00:00
freemo b96427d86a fix(ci): replace brittle bash comparisons in status-check job with native expression conditions (#11177)
ci.yml / fix(ci): replace brittle bash comparisons in status-check job with native expression conditions (#11177) (push) Failing after 0s
ci.yml / fix(ci): replace brittle bash comparisons in status-check job with native expression conditions (#11177) (pull_request) Failing after 0s
Replaced fragile `[ "${{ needs.X.result }}" != "success" ]` shell comparisons
in the CI `status-check` job with robust `[[ "${{ needs.X.result }}" == "success" ]]`
native expression conditions using bash's `[[ ]]` operator. This eliminates issues
with whitespace, unquoted variables, and multi-line job result values that caused
brittle test-command failures. The new approach uses short-circuit `&&` evaluation
for clean early-exit when any single job fails.

Also added BDD tests for CI status-check behavior in features/status_check_job.feature.
Fixed merge conflict marker in CONTRIBUTORS.md.

ISSUES CLOSED: #11177
2026-05-13 01:01:09 +00:00