chore: fix CI pipeline flakiness by stabilizing test fixtures and assertions #11119
Merged
HAL9000
merged 4 commits from 2026-06-14 21:33:40 +00:00
bugfix/m3.6.0-ci-pipeline-flakiness-stabilization into master
Labels
Clear labels
auto/needs-reevaluation
controller-managed
overdue
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveragents-core#11119
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "bugfix/m3.6.0-ci-pipeline-flakiness-stabilization"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Replace four
time.sleep(0.01)timestamp guards inmemory_service_coverage_steps.pywith a deterministic_wait_for_clock_advance()helper that busy-waits on the monotonic clock until the UTC clock actually advances past the recordedbeforetimestamp, bounded by a 2-second deadline.This eliminates four sources of intermittent CI failures in the entity-tracking scenarios where two consecutive
datetime.now(UTC)calls could return the same microsecond value on fast CI runners.Changes
features/steps/memory_service_coverage_steps.py: Added_wait_for_clock_advance()helper; replaced 4×time.sleep(0.01)instep_track_same_entity(),step_memory_service_entities_over_time()(×2), andstep_track_same_entity_with_additional_metadata()features/memory_service_clock_wait.feature: New Behave feature verifying the helper raisesAssertionErroron deadline exceeded and returns normally once the clock advancesfeatures/steps/memory_service_clock_wait_steps.py: Step definitions for the above featureQuality Gates
nox -e lintnox -e typechecknox -e unit_tests(15,585 scenarios, 0 failed)nox -e integration_tests(1,865 tests, 0 failed/errors)nox -e e2e_tests(pre-existing LLM-secret failures unrelated to these changes)References
Closes #9963
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor
First Review — PR #11119: chore: fix CI pipeline flakiness by stabilizing test fixtures and assertions
Overall Assessment
The core implementation is well-engineered:
_wait_for_clock_advance()is deterministic, correctly bounded, type-annotated, well-documented, and the new Behave feature verifying the helper behavior is a solid addition. The approach correctly follows the established pattern from issue #1542.However, several blocking process compliance issues prevent approval. This PR addresses a
Type/Bugissue (#9963), which triggers the mandatory TDD workflow — and that workflow was not followed. There are also commit footer, PR metadata, and Forgejo dependency direction issues that must be corrected.CI Status
✅ All 5 required gates pass: lint, typecheck, security, unit_tests, coverage
⚠️
CI / benchmark-regressionis failing (1m33s). This check is not a required merge gate, and the failure appears unrelated to the changes in this PR (no benchmark code was modified). The author should verify this failure is pre-existing and not introduced by this PR.Blocking Issues
1. TDD Workflow Not Followed (BLOCKING)
Issue #9963 is labelled
Type/Bug. Per CONTRIBUTING.md §"Bug Fix Workflow", ALL bug fixes must follow the mandatory TDD workflow:Type/Testingissue titledTDD: <description>must exist and be closed before this fix PR can land.@tdd_issue,@tdd_issue_9963, and@tdd_expected_failin a separatetdd/mN-ci-pipeline-flakiness-stabilizationbranch.@tdd_expected_fail(leaving@tdd_issueand@tdd_issue_9963permanently).memory_service_clock_wait.featuremust carry@tdd_issue @tdd_issue_9963tags to serve as the permanent regression guard.Neither a TDD companion issue nor a
tdd/branch with the matching suffix exists. The new scenarios inmemory_service_clock_wait.featureuse@mock_onlybut lack the required@tdd_issueand@tdd_issue_9963tags.How to fix:
a) Create a companion
Type/Testingissue titledTDD: [AUTO-INF-4] Replace time.sleep() timestamp guards in memory_service_coverage_steps.py with monotonic busy-waitwithPriority/CriticalandMoSCoW/Must Have.b) Set issue #9963 to depend on (be blocked by) the TDD issue.
c) Add
@tdd_issue @tdd_issue_9963tags to the scenarios inmemory_service_clock_wait.feature(the deadline-exceeded scenario is the regression guard for the original flaky behavior; the normal-advance scenario validates the fix).d) Ensure the TDD issue is closed (its work is represented by this PR).
2. Commit Footer Uses Wrong Format (BLOCKING)
The commit footer reads
Closes #9963but the project requiresISSUES CLOSED: #9963format. All recent commits on master useISSUES CLOSED: #N(e.g.,ISSUES CLOSED: #4300,ISSUES CLOSED: #9163). TheCloseskeyword is a GitHub/Forgejo PR-level autoclose feature — it does not satisfy the commit traceability requirement.How to fix: Amend the commit footer to read
ISSUES CLOSED: #9963.3. No Milestone Assigned to PR (BLOCKING)
The PR has no milestone assigned. Per CONTRIBUTING.md, every PR must be assigned to the same milestone as its linked issue(s). Issue #9963 has no milestone either — this should be corrected on both the issue and the PR before merging.
How to fix: Assign the appropriate milestone (e.g., v3.6.0 based on the branch name) to both issue #9963 and this PR.
4. No Type/ Label on PR (BLOCKING)
The PR has no
Type/label. Per CONTRIBUTING.md §"Pull Request Requirements" item 12, exactly oneType/label must be applied. For a bug fix this should beType/Bug.How to fix: Add
Type/Buglabel to this PR.5. Forgejo Dependency Direction Missing (BLOCKING)
The PR must "block" issue #9963 in the Forgejo dependency graph (PR → blocks → issue). Currently no dependency link exists between PR #11119 and issue #9963. Without this, the issue cannot auto-close when the PR merges, and the PR/issue lifecycle tracking is broken.
How to fix: On this PR, add issue #9963 under "blocks".
6. CHANGELOG Not Updated (BLOCKING)
No entry for this fix appears in
CHANGELOG.md. Per CONTRIBUTING.md §"Pull Request Requirements" item 7, the changelog must be updated with one entry per commit.How to fix: Add an entry to the
[Unreleased]section ofCHANGELOG.mddescribing the fix (e.g., under### Fixed: "Replaced fourtime.sleep(0.01)timestamp guards inmemory_service_coverage_steps.pywith a deterministic_wait_for_clock_advance()helper to eliminate intermittent timestamp failures on fast CI runners (#9963).").Non-Blocking Observations
Branch Name Convention Deviation
The branch
bugfix/m3.6.0-ci-pipeline-flakiness-stabilizationusesm3.6.0as the milestone segment. Convention isbugfix/mN-<name>where N is just the milestone number digit (e.g.,bugfix/m3-...,bugfix/m4-...). While this does not block merging, future branches should follow the simplermNformat.Issue #9963 Priority Label
Issue #9963 is labelled
Priority/High. Per CONTRIBUTING.md, allType/Bugissues must bePriority/Critical. This is a process compliance issue on the issue itself (not this PR), but the reviewer should flag it: please update the priority label toPriority/Critical.Code Quality Assessment (Passes)
✅ Correctness:
_wait_for_clock_advance()correctly solves the root cause. The busy-wait loop uses the monotonic clock for deadline enforcement (immune to wall-clock adjustments) while checking the UTC clock for the actual advancement condition. The 2-second deadline prevents infinite hangs. All 4 call sites correctly capturedatetime.now(UTC)before the operation that needs the timestamp gap.✅ Test Quality: The new
memory_service_clock_wait.featuretests both the deadline-exceeded error path and the normal-advance success path. Step definitions are well-documented with clear docstrings. The import of_wait_for_clock_advancefrom the coverage steps module is correct.✅ Type Safety: All new functions are fully type-annotated. No
# type: ignorepresent.✅ Readability: Naming is clear, the helper docstring accurately describes behaviour, comments in the modified step functions are updated to match.
✅ Security: No security concerns. No hardcoded secrets.
✅ Code Style: SOLID principles respected. Files well within 500-line limit. Follows ruff conventions.
✅ Documentation: Docstrings present on all new functions.
Please address the 6 blocking issues above and re-request review.
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
@@ -0,0 +13,4 @@# deadline is exceeded.@mock_onlyScenario: Clock-advance guard raises AssertionError when deadline is exceededBLOCKING — TDD regression tags missing
This scenario verifies the deadline-exceeded error path introduced to fix bug #9963. It must carry the permanent TDD regression tags so it serves as the regression guard for this bug:
Per CONTRIBUTING.md §"TDD Issue Test Tags": once
@tdd_expected_failis removed (i.e., the bug is fixed),@tdd_issueand@tdd_issue_<N>must remain permanently as a regression guard. Without these tags the test is not linked to the bug and the three-tag workflow is incomplete.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
@@ -0,0 +19,4 @@Then an AssertionError should be raised mentioning the deadline@mock_onlyScenario: Clock-advance guard returns successfully once the clock advancesBLOCKING — TDD regression tags missing
This scenario should also carry
@tdd_issue @tdd_issue_9963as the permanent regression guard for the normal-advance path (proving the fix works). Both scenarios together replace the behaviour that was previously guarded by the four baretime.sleep()calls.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11119 addresses a specific memory_service test flakiness issue caused by microsecond-level timing collisions in datetime comparisons. The solution—a deterministic _wait_for_clock_advance() helper replacing time.sleep() calls—is novel. Scanning 331 open PRs found no overlap: CI optimization PRs address execution time (not flakiness), E2E test fixes target specific failures (OOM, container clone), and infrastructure PRs cover tools/coverage. No other PR references #9963 or memory_service clock timing issues. Unique scope and approach confirm no duplicate.
📋 Estimate: tier 1.
Test-additive work across 3 files in features/: replaces 4x time.sleep with a deterministic clock-advance helper, adds a new Behave feature file, and adds new step definitions. Format-sensitive (Behave .feature syntax) and test-additive changes consistently regress at tier 0 per calibration history. Scope is focused and logic is straightforward, but the new feature + steps files warrant tier 1. The sole CI failure (benchmark-regression, no parser available) is a pre-existing infrastructure issue unrelated to these changes.
(attempt #4, tier 1)
🔧 Implementer attempt —
blocked.Blockers:
e302ddd34bbut dispatch base was87d035bab4. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.(attempt #5, tier 2)
🔧 Implementer attempt —
rebase-failed.Blockers:
e302ddd34bto1a230ee4e4(attempt #7, tier 2)
🔧 Implementer attempt —
ci-not-ready.(attempt #11, tier 1)
🔧 Implementer attempt —
blocked.Blockers:
1069d36f4ebut dispatch base was1a230ee4e4. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.🌱 Grooming: proceed — PR cleared for processing.
(check
no_duplicates, categoryno_duplicates)PR #11119 addresses a specialized test fixture timing issue in memory_service scenarios by replacing brittle sleep guards with deterministic clock-advance logic. No other open PR tackles the same clock-synchronization problem or touches memory_service test fixtures with similar intent. Related CI PRs focus on performance optimization, not fixture stability.
📋 Estimate: tier 1.
Multi-file test-layer change: replaces 4 sleep() calls with a busy-wait helper, adds a new Behave feature file, and adds new step definitions. All CI failures are infrastructure DNS failures (forgejo-http.cleverlibre.svc.cluster.local unresolvable on runners) unrelated to the code changes. The PR itself has additive test logic — per calibration notes, test-additive work consistently regresses at tier 0. Scope is isolated to the features/steps layer with no production code changes, but multi-file with new logic branches warrants tier 1.
(attempt #14, tier 1)
🔧 Implementer attempt —
blocked.Blockers:
fa42709facbut dispatch base was1069d36f4e. The implementer pushed from inside the worktree (forbidden by the git contract) OR a third party pushed during the attempt. Re-dispatch will re-prefetch and pick up the new head.fa42709facto217b7ffe9f✅ Approved
Reviewed at commit
217b7ff.Confidence: high.
Claimed by
merge_drive.py(pid 2329255) until2026-06-14T22:45:03.449287+00:00.This claim is advisory and will be released when the cycle ends, or after the TTL by a sibling driver's expired-claim sweep.
217b7ffe9fto9be3d6e169Approved by the controller reviewer stage (workflow 493).