cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

test: add TDD bug-capture test for #620 — skill add cross-process persistence #1110

Closed
brent.edwards wants to merge 2 commits from tdd/m3-skill-add-regression into master
pull from: tdd/m3-skill-add-regression
merge into: cleveragents:master
Conversation 5 Commits 2 Files changed 7 +622 -4
brent.edwards commented 2026-03-23 00:15:38 +00:00
Member
Copy link

Summary

Write cross-process Behave and Robot tests capturing the skill persistence regression for bug #620. Tests execute the real agents CLI via subprocess.run so each command runs in a separate OS process with its own interpreter, DI container, and DB connection.

Approach

  • Use subprocess-based CLI invocations for init, skill add, skill list, and skill show.
  • Ensure environment/bootstrap mirrors real usage (agents init --yes, on-disk SQLite DB).
  • Keep expected-failure workflow via @tdd_expected_fail while bug remains open.
  • Add explicit returncode == 0 guards for skill list assertions in both Behave and Robot paths (matching existing skill show assertion strictness).

Ticket Alignment Updates (Cycle 2)

  • Aligned bug/ticket references to bug #620 and ticket #1091 across:
    • Behave tags and feature text (@tdd_bug_620)
    • Behave/Robot helper docstrings/comments
    • Changelog entry text
    • Commit message + issue footer
  • Updated close keyword to match the ticket tracked by this PR.

Files Updated

  • CHANGELOG.md
  • features/tdd_skill_add_regression.feature
  • features/steps/tdd_skill_add_regression_steps.py
  • robot/tdd_skill_add_regression.robot
  • robot/helper_tdd_skill_add_regression.py

Quality Gates

  • ✅ nox -e lint
  • ✅ nox -e typecheck
  • ✅ nox -e unit_tests
  • ⚠️ nox -e integration_tests currently fails in unrelated existing suites (timeouts/rc=-9 in Robot.Resource Cli, Robot.M3 E2E Verification, and intermittently Robot.Rxpy Route Validation) during full parallel run; not in touched files
  • ✅ nox -e e2e_tests
  • ✅ nox -e coverage_report (summary coverage: 98%)

Closes #1091

## Summary Write cross-process Behave and Robot tests capturing the skill persistence regression for **bug #620**. Tests execute the real `agents` CLI via `subprocess.run` so each command runs in a separate OS process with its own interpreter, DI container, and DB connection. ### Approach - Use subprocess-based CLI invocations for `init`, `skill add`, `skill list`, and `skill show`. - Ensure environment/bootstrap mirrors real usage (`agents init --yes`, on-disk SQLite DB). - Keep expected-failure workflow via `@tdd_expected_fail` while bug remains open. - Add explicit `returncode == 0` guards for `skill list` assertions in both Behave and Robot paths (matching existing `skill show` assertion strictness). ### Ticket Alignment Updates (Cycle 2) - Aligned bug/ticket references to **bug #620** and **ticket #1091** across: - Behave tags and feature text (`@tdd_bug_620`) - Behave/Robot helper docstrings/comments - Changelog entry text - Commit message + issue footer - Updated close keyword to match the ticket tracked by this PR. ### Files Updated - `CHANGELOG.md` - `features/tdd_skill_add_regression.feature` - `features/steps/tdd_skill_add_regression_steps.py` - `robot/tdd_skill_add_regression.robot` - `robot/helper_tdd_skill_add_regression.py` ### Quality Gates - ✅ `nox -e lint` - ✅ `nox -e typecheck` - ✅ `nox -e unit_tests` - ⚠️ `nox -e integration_tests` currently fails in unrelated existing suites (timeouts/rc=-9 in `Robot.Resource Cli`, `Robot.M3 E2E Verification`, and intermittently `Robot.Rxpy Route Validation`) during full parallel run; not in touched files - ✅ `nox -e e2e_tests` - ✅ `nox -e coverage_report` (summary coverage: **98%**) Closes #1091
test: add TDD bug-capture test for #620 — skill add regression
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 18s
Details
CI / build (pull_request) Successful in 25s
Details
CI / quality (pull_request) Successful in 3m42s
Details
CI / typecheck (pull_request) Successful in 3m56s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 4m24s
Details
CI / integration_tests (pull_request) Successful in 9m0s
Details
CI / unit_tests (pull_request) Successful in 9m11s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / e2e_tests (pull_request) Failing after 20m52s
Details
2b401b06dd 
Add a Behave BDD scenario that captures bug #620 — skill add does not
persist across CLI invocations.  The test mirrors the DI container
construction pattern (standard sessionmaker creating separate sessions
per call) and verifies that a skill added via SkillService survives
service destruction and recreation from the same database.

Root cause identified during test construction: SkillRepository.create()
flushes on Session A while SkillService._commit() commits on Session B
(a different session from the factory).  Data is never committed.  The
existing skill_add_persist.feature tests mask this by sharing a single
session instance.

Tagged with @tdd_bug, @tdd_bug_620, and @tdd_expected_fail per
CONTRIBUTING.md Bug Fix Workflow.  The underlying assertion fails
(proving the bug exists) and the tag inversion causes CI to pass.
When the fix for #620 is implemented, the fixer removes
@tdd_expected_fail and the test runs as a permanent regression guard.

ISSUES CLOSED: #1091
brent.edwards added this to the v3.2.0 milestone 2026-03-23 00:15:45 +00:00
freemo force-pushed tdd/m3-skill-add-regression from 2b401b06dd
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Failing after 18s
Details
CI / build (pull_request) Successful in 25s
Details
CI / quality (pull_request) Successful in 3m42s
Details
CI / typecheck (pull_request) Successful in 3m56s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / security (pull_request) Successful in 4m24s
Details
CI / integration_tests (pull_request) Successful in 9m0s
Details
CI / unit_tests (pull_request) Successful in 9m11s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / e2e_tests (pull_request) Failing after 20m52s
Details
to 7fdbf5d4c6
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / build (pull_request) Successful in 34s
Details
CI / typecheck (pull_request) Successful in 4m2s
Details
CI / quality (pull_request) Successful in 4m1s
Details
CI / integration_tests (pull_request) Successful in 9m7s
Details
CI / unit_tests (pull_request) Successful in 9m17s
Details
CI / e2e_tests (pull_request) Failing after 11m42s
Details
CI / security (pull_request) Failing after 13m26s
Details
CI / coverage (pull_request) Successful in 12m26s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 56m8s
Details
2026-03-23 01:06:48 +00:00 Compare
freemo changed title from test: add TDD bug-capture test for #620 — skill add regression to test: add TDD bug-capture test for #980 — skill add cross-process persistence 2026-03-23 01:07:12 +00:00
freemo approved these changes 2026-03-23 02:44:57 +00:00
Dismissed
freemo left a comment
Copy link

TDD Bug-Capture Review: PR #1110 — Bug #980 (skill add cross-process persistence)

Overall Assessment: APPROVE

All seven review criteria pass cleanly.

1. Tag Compliance ✅

  • Feature file: @tdd_expected_fail @tdd_bug @tdd_bug_980 — all three required tags present at feature level.
  • Robot file: [Tags] tdd_bug tdd_bug_980 tdd_expected_fail — all three present on both test cases.

2. Branch Naming ✅

  • Branch: tdd/m3-skill-add-regression
  • Milestone: v3.2.0 (M3: Decisions + Validations + Invariants) — tdd/m3- prefix is correct.

3. File Organization ✅

  • features/tdd_skill_add_regression.feature
  • features/steps/tdd_skill_add_regression_steps.py
  • robot/tdd_skill_add_regression.robot
  • robot/helper_tdd_skill_add_regression.py

All files in the correct directories.

4. Step File Naming ✅

  • Feature tdd_skill_add_regression.feature → steps in tdd_skill_add_regression_steps.py — naming convention followed.

5. No Production Code Changes ✅

  • 4 new files added, all in features/ and robot/. Zero deletions, zero modifications to src/.

6. Issue References ✅

  • PR body: Closes #981 (the TDD tracking issue for bug #980).
  • Bug #980 referenced extensively in docstrings and feature description.

7. PR Description Quality ✅

  • Clearly explains why existing tests pass (shared in-memory SQLAlchemy session) and how the new test exposes the real cross-process bug (container reset between CLI invocations). Quality gates all reported passing.

No issues found. Well-structured TDD bug-capture PR.

## TDD Bug-Capture Review: PR #1110 — Bug #980 (skill add cross-process persistence) ### Overall Assessment: **APPROVE** All seven review criteria pass cleanly. --- ### 1. Tag Compliance ✅ - Feature file: `@tdd_expected_fail @tdd_bug @tdd_bug_980` — all three required tags present at feature level. - Robot file: `[Tags] tdd_bug tdd_bug_980 tdd_expected_fail` — all three present on both test cases. ### 2. Branch Naming ✅ - Branch: `tdd/m3-skill-add-regression` - Milestone: v3.2.0 (M3: Decisions + Validations + Invariants) — `tdd/m3-` prefix is correct. ### 3. File Organization ✅ - `features/tdd_skill_add_regression.feature` - `features/steps/tdd_skill_add_regression_steps.py` - `robot/tdd_skill_add_regression.robot` - `robot/helper_tdd_skill_add_regression.py` All files in the correct directories. ### 4. Step File Naming ✅ - Feature `tdd_skill_add_regression.feature` → steps in `tdd_skill_add_regression_steps.py` — naming convention followed. ### 5. No Production Code Changes ✅ - 4 new files added, all in `features/` and `robot/`. Zero deletions, zero modifications to `src/`. ### 6. Issue References ✅ - PR body: `Closes #981` (the TDD tracking issue for bug #980). - Bug #980 referenced extensively in docstrings and feature description. ### 7. PR Description Quality ✅ - Clearly explains _why_ existing tests pass (shared in-memory SQLAlchemy session) and _how_ the new test exposes the real cross-process bug (container reset between CLI invocations). Quality gates all reported passing. --- No issues found. Well-structured TDD bug-capture PR.
freemo approved these changes 2026-03-23 02:46:51 +00:00
Dismissed
freemo left a comment
Copy link

Review: APPROVED

Clean TDD bug-capture PR for skill-add cross-process persistence regression (#980).

  • Tag compliance: @tdd_expected_fail @tdd_bug @tdd_bug_980 all correct
  • Branch naming: tdd/m3-skill-add-regression correctly matches M3 (v3.2.0)
  • File organization: Proper placement in features/ and robot/
  • Step file naming: Follows convention
  • No production code changes: Test files only
  • Issue reference: Closing keyword present
  • PR description: Clear explanation of the cross-process persistence bug being captured

The reset_container() pattern for simulating independent process boundaries is a sound approach for testing DI container state leaks.

## Review: APPROVED Clean TDD bug-capture PR for skill-add cross-process persistence regression (#980). - **Tag compliance**: `@tdd_expected_fail @tdd_bug @tdd_bug_980` all correct - **Branch naming**: `tdd/m3-skill-add-regression` correctly matches M3 (v3.2.0) - **File organization**: Proper placement in `features/` and `robot/` - **Step file naming**: Follows convention - **No production code changes**: Test files only - **Issue reference**: Closing keyword present - **PR description**: Clear explanation of the cross-process persistence bug being captured The `reset_container()` pattern for simulating independent process boundaries is a sound approach for testing DI container state leaks.
freemo approved these changes 2026-03-23 03:41:04 +00:00
Dismissed
freemo left a comment
Copy link

Day 43 Review — PR #1110 test: TDD for #980 — skill add cross-process persistence

Verdict: APPROVED

TDD Tag Verification

Tag Behave Robot
@tdd_bug Present Present
@tdd_bug_980 Present Present
@tdd_expected_fail Present Present
Tag validation rules PASS PASS

Test Quality Assessment

The tests correctly capture the cross-process persistence regression by calling reset_container() between CLI invocations to simulate independent process lifecycles. This is the exact code path that fails in bug #980 — existing tests pass because they share the same in-memory session factory.

Two scenarios per framework (Behave + Robot) covering skill list and skill show after cross-process skill add. Test cleanup is thorough with add_cleanup() and try/finally patterns.

Checklist

Criterion Status
Single commit PASS (1 commit: 7fdbf5d4)
Clean diff (test files only) PASS (4 new files, 0 modified)
Commit message format PASS (test: prefix, references #980, lists tags)
Closing keyword PASS (Closes #981)
No unrelated changes PASS

This is a well-structured TDD PR that accurately captures the bug behavior described in #980. Ready for merge.

## Day 43 Review — PR #1110 `test: TDD for #980 — skill add cross-process persistence` **Verdict: APPROVED** ### TDD Tag Verification | Tag | Behave | Robot | |---|---|---| | `@tdd_bug` | Present | Present | | `@tdd_bug_980` | Present | Present | | `@tdd_expected_fail` | Present | Present | | Tag validation rules | PASS | PASS | ### Test Quality Assessment The tests correctly capture the cross-process persistence regression by calling `reset_container()` between CLI invocations to simulate independent process lifecycles. This is the exact code path that fails in bug #980 — existing tests pass because they share the same in-memory session factory. Two scenarios per framework (Behave + Robot) covering `skill list` and `skill show` after cross-process `skill add`. Test cleanup is thorough with `add_cleanup()` and `try/finally` patterns. ### Checklist | Criterion | Status | |---|---| | Single commit | PASS (1 commit: `7fdbf5d4`) | | Clean diff (test files only) | PASS (4 new files, 0 modified) | | Commit message format | PASS (`test:` prefix, references #980, lists tags) | | Closing keyword | PASS (`Closes #981`) | | No unrelated changes | PASS | This is a well-structured TDD PR that accurately captures the bug behavior described in #980. Ready for merge.
brent.edwards force-pushed tdd/m3-skill-add-regression from 7fdbf5d4c6
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / build (pull_request) Successful in 34s
Details
CI / typecheck (pull_request) Successful in 4m2s
Details
CI / quality (pull_request) Successful in 4m1s
Details
CI / integration_tests (pull_request) Successful in 9m7s
Details
CI / unit_tests (pull_request) Successful in 9m17s
Details
CI / e2e_tests (pull_request) Failing after 11m42s
Details
CI / security (pull_request) Failing after 13m26s
Details
CI / coverage (pull_request) Successful in 12m26s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-regression (pull_request) Successful in 56m8s
Details
to 720eeea49e
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 23s
Details
CI / lint (pull_request) Successful in 3m33s
Details
CI / typecheck (pull_request) Successful in 4m14s
Details
CI / security (pull_request) Successful in 4m17s
Details
CI / integration_tests (pull_request) Successful in 7m9s
Details
CI / e2e_tests (pull_request) Successful in 8m40s
Details
CI / unit_tests (pull_request) Failing after 10m54s
Details
CI / quality (pull_request) Failing after 11m28s
Details
CI / coverage (pull_request) Successful in 12m0s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 2s
Details
CI / benchmark-regression (pull_request) Successful in 52m0s
Details
2026-03-23 05:38:30 +00:00 Compare
brent.edwards dismissed freemo's review 2026-03-23 05:38:30 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

freemo force-pushed tdd/m3-skill-add-regression from 720eeea49e
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 23s
Details
CI / lint (pull_request) Successful in 3m33s
Details
CI / typecheck (pull_request) Successful in 4m14s
Details
CI / security (pull_request) Successful in 4m17s
Details
CI / integration_tests (pull_request) Successful in 7m9s
Details
CI / e2e_tests (pull_request) Successful in 8m40s
Details
CI / unit_tests (pull_request) Failing after 10m54s
Details
CI / quality (pull_request) Failing after 11m28s
Details
CI / coverage (pull_request) Successful in 12m0s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 2s
Details
CI / benchmark-regression (pull_request) Successful in 52m0s
Details
to 6f94183359
Some checks failed
CI / coverage (pull_request) Blocked by required conditions
Details
CI / benchmark-regression (pull_request) Blocked by required conditions
Details
CI / docker (pull_request) Blocked by required conditions
Details
CI / status-check (pull_request) Blocked by required conditions
Details
CI / build (pull_request) Successful in 21s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m18s
Details
CI / security (pull_request) Successful in 4m0s
Details
CI / quality (pull_request) Successful in 4m4s
Details
CI / integration_tests (pull_request) Successful in 5m56s
Details
CI / unit_tests (pull_request) Successful in 7m9s
Details
CI / e2e_tests (pull_request) Successful in 8m54s
Details
CI / typecheck (pull_request) Failing after 16m2s
Details
2026-03-23 12:00:40 +00:00 Compare
brent.edwards changed title from test: add TDD bug-capture test for #980 — skill add cross-process persistence to test: add TDD bug-capture test for #620 — skill add cross-process persistence 2026-03-23 21:24:03 +00:00
brent.edwards force-pushed tdd/m3-skill-add-regression from 6f94183359
Some checks failed
CI / coverage (pull_request) Blocked by required conditions
Details
CI / benchmark-regression (pull_request) Blocked by required conditions
Details
CI / docker (pull_request) Blocked by required conditions
Details
CI / status-check (pull_request) Blocked by required conditions
Details
CI / build (pull_request) Successful in 21s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m18s
Details
CI / security (pull_request) Successful in 4m0s
Details
CI / quality (pull_request) Successful in 4m4s
Details
CI / integration_tests (pull_request) Successful in 5m56s
Details
CI / unit_tests (pull_request) Successful in 7m9s
Details
CI / e2e_tests (pull_request) Successful in 8m54s
Details
CI / typecheck (pull_request) Failing after 16m2s
Details
to 5bf0baa1db
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 41s
Details
CI / integration_tests (pull_request) Successful in 2m41s
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / unit_tests (pull_request) Successful in 3m33s
Details
CI / quality (pull_request) Successful in 3m43s
Details
CI / typecheck (pull_request) Successful in 3m56s
Details
CI / security (pull_request) Successful in 4m0s
Details
CI / docker (pull_request) Successful in 56s
Details
CI / e2e_tests (pull_request) Successful in 8m29s
Details
CI / coverage (pull_request) Failing after 21m1s
Details
CI / benchmark-regression (pull_request) Successful in 52m59s
Details
CI / status-check (pull_request) Failing after 2s
Details
2026-03-23 21:24:19 +00:00 Compare
freemo force-pushed tdd/m3-skill-add-regression from 5bf0baa1db
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 41s
Details
CI / integration_tests (pull_request) Successful in 2m41s
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / unit_tests (pull_request) Successful in 3m33s
Details
CI / quality (pull_request) Successful in 3m43s
Details
CI / typecheck (pull_request) Successful in 3m56s
Details
CI / security (pull_request) Successful in 4m0s
Details
CI / docker (pull_request) Successful in 56s
Details
CI / e2e_tests (pull_request) Successful in 8m29s
Details
CI / coverage (pull_request) Failing after 21m1s
Details
CI / benchmark-regression (pull_request) Successful in 52m59s
Details
CI / status-check (pull_request) Failing after 2s
Details
to 49c4473218
Some checks failed
CI / quality (pull_request) Successful in 34s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m17s
Details
CI / build (pull_request) Successful in 11s
Details
CI / typecheck (pull_request) Successful in 3m38s
Details
CI / integration_tests (pull_request) Successful in 5m25s
Details
CI / e2e_tests (pull_request) Failing after 13m53s
Details
CI / unit_tests (pull_request) Failing after 14m38s
Details
CI / security (pull_request) Failing after 14m48s
Details
CI / benchmark-regression (pull_request) Failing after 16m7s
Details
CI / coverage (pull_request) Successful in 8m23s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
2026-03-24 00:19:38 +00:00 Compare
freemo force-pushed tdd/m3-skill-add-regression from 49c4473218
Some checks failed
CI / quality (pull_request) Successful in 34s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 3m17s
Details
CI / build (pull_request) Successful in 11s
Details
CI / typecheck (pull_request) Successful in 3m38s
Details
CI / integration_tests (pull_request) Successful in 5m25s
Details
CI / e2e_tests (pull_request) Failing after 13m53s
Details
CI / unit_tests (pull_request) Failing after 14m38s
Details
CI / security (pull_request) Failing after 14m48s
Details
CI / benchmark-regression (pull_request) Failing after 16m7s
Details
CI / coverage (pull_request) Successful in 8m23s
Details
CI / docker (pull_request) Has been skipped
Details
CI / status-check (pull_request) Failing after 1s
Details
to e709e3bd95
Some checks failed
CI / docker (pull_request) Blocked by required conditions
Details
CI / status-check (pull_request) Blocked by required conditions
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Failing after 21m2s
Details
CI / security (pull_request) Failing after 21m2s
Details
CI / lint (pull_request) Failing after 25m23s
Details
CI / typecheck (pull_request) Successful in 21m15s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 28m0s
Details
CI / e2e_tests (pull_request) Failing after 28m4s
Details
CI / integration_tests (pull_request) Failing after 28m4s
Details
CI / unit_tests (pull_request) Failing after 28m4s
Details
2026-03-24 01:39:56 +00:00 Compare
freemo force-pushed tdd/m3-skill-add-regression from e709e3bd95
Some checks failed
CI / docker (pull_request) Blocked by required conditions
Details
CI / status-check (pull_request) Blocked by required conditions
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / quality (pull_request) Failing after 21m2s
Details
CI / security (pull_request) Failing after 21m2s
Details
CI / lint (pull_request) Failing after 25m23s
Details
CI / typecheck (pull_request) Successful in 21m15s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Has been skipped
Details
CI / build (pull_request) Failing after 28m0s
Details
CI / e2e_tests (pull_request) Failing after 28m4s
Details
CI / integration_tests (pull_request) Failing after 28m4s
Details
CI / unit_tests (pull_request) Failing after 28m4s
Details
to a5ced58289
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 26s
Details
CI / lint (pull_request) Successful in 3m20s
Details
CI / quality (pull_request) Successful in 3m48s
Details
CI / typecheck (pull_request) Successful in 4m2s
Details
CI / security (pull_request) Successful in 4m6s
Details
CI / e2e_tests (pull_request) Successful in 6m14s
Details
CI / integration_tests (pull_request) Successful in 7m1s
Details
CI / unit_tests (pull_request) Successful in 7m33s
Details
CI / docker (pull_request) Successful in 1m35s
Details
CI / coverage (pull_request) Successful in 11m53s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Failing after 28m26s
Details
2026-03-24 15:22:38 +00:00 Compare
freemo approved these changes 2026-03-24 15:28:03 +00:00
freemo left a comment
Copy link

Review: APPROVED

The most thorough TDD test in the batch. Uses real subprocess.run calls across process boundaries (not just in-process CliRunner) — sets up temp CLEVERAGENTS_HOME, on-disk SQLite, runs agents init, skill add, and skill list/skill show as independent OS processes. Tags correct. Both Behave and Robot tests present with proper timeout handling.

Minor Note

Unrelated change in noxfile.py adds session.install("setuptools<81") to the security_scan session. This is a drive-by fix for pkg_resources/semgrep compatibility. Per CONTRIBUTING.md §Atomic Commits: "Do not mix concerns." Ideally this should be a separate commit, though it's understandable as a pragmatic fix to unblock CI.

## Review: APPROVED The most thorough TDD test in the batch. Uses real `subprocess.run` calls across process boundaries (not just in-process `CliRunner`) — sets up temp `CLEVERAGENTS_HOME`, on-disk SQLite, runs `agents init`, `skill add`, and `skill list`/`skill show` as independent OS processes. Tags correct. Both Behave and Robot tests present with proper timeout handling. ### Minor Note Unrelated change in `noxfile.py` adds `session.install("setuptools<81")` to the `security_scan` session. This is a drive-by fix for `pkg_resources`/semgrep compatibility. Per CONTRIBUTING.md §Atomic Commits: *"Do not mix concerns."* Ideally this should be a separate commit, though it's understandable as a pragmatic fix to unblock CI.
freemo closed this pull request 2026-03-24 20:27:34 +00:00
brent.edwards commented 2026-03-24 23:40:24 +00:00
Author
Member
Copy link

Self-QA Closeout Status (Current Work Posted)

Current PR state

  • PR status observed during closeout: closed (not merged)
  • Branch: tdd/m3-skill-add-regression

Work completed in the latest self-QA pass

  • Aligned references to ticket/bug scope (#1091 / #620) across tags, commit/PR metadata, and docs.
  • Added missing returncode == 0 guard in skill list assertions (Behave + Robot), matching skill show strictness.
  • Updated PR description with closeout details.

Quality-gate snapshot from latest fix pass

  • lint ✅
  • typecheck ✅
  • unit_tests ✅
  • e2e_tests ✅
  • coverage_report ✅
  • integration_tests ⚠️ (reported as unrelated/pre-existing suite instability)

Closeout note

This comment records the latest implemented work from the internal self-QA loop. Since the PR is currently closed, merge follow-up requires maintainer direction (reopen this PR or open a successor PR from the updated branch state).

## Self-QA Closeout Status (Current Work Posted) ### Current PR state - PR status observed during closeout: **closed (not merged)** - Branch: `tdd/m3-skill-add-regression` ### Work completed in the latest self-QA pass - Aligned references to ticket/bug scope (`#1091` / `#620`) across tags, commit/PR metadata, and docs. - Added missing `returncode == 0` guard in `skill list` assertions (Behave + Robot), matching `skill show` strictness. - Updated PR description with closeout details. ### Quality-gate snapshot from latest fix pass - lint ✅ - typecheck ✅ - unit_tests ✅ - e2e_tests ✅ - coverage_report ✅ - integration_tests ⚠️ (reported as unrelated/pre-existing suite instability) ### Closeout note This comment records the latest implemented work from the internal self-QA loop. Since the PR is currently closed, merge follow-up requires maintainer direction (reopen this PR or open a successor PR from the updated branch state).
Some checks failed
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / build (pull_request) Successful in 26s
Required
Details
CI / lint (pull_request) Successful in 3m20s
Required
Details
CI / quality (pull_request) Successful in 3m48s
Required
Details
CI / typecheck (pull_request) Successful in 4m2s
Required
Details
CI / security (pull_request) Successful in 4m6s
Required
Details
CI / e2e_tests (pull_request) Successful in 6m14s
Details
CI / integration_tests (pull_request) Successful in 7m1s
Required
Details
CI / unit_tests (pull_request) Successful in 7m33s
Required
Details
CI / docker (pull_request) Successful in 1m35s
Required
Details
CI / coverage (pull_request) Successful in 11m53s
Required
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-regression (pull_request) Failing after 28m26s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
hamza.khyari
freemo
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#1091 TDD: Write failing test for #620 — skill add does not persist across CLI invocations
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core!1110
No description provided.