cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(skill): resolve skill add persistence regression after PR #640 #1120

Merged
freemo merged 2 commits from bugfix/m3-skill-add-regression into master 2026-03-24 17:23:10 +00:00
Conversation 2 Commits 2 Files Changed 6
+541 -5
freemo commented 2026-03-23 02:39:42 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes the cross-process skill persistence regression reported in #980. Skills registered via agents skill add --config <file> in one CLI process are now correctly persisted to the database and visible in subsequent CLI invocations.

Root Cause

Two issues in the skill persistence layer:

  1. Missing table creation: _build_skill_service() in container.py created a SkillRepository pointing at the database but did not ensure the skills and skill_items tables existed. When the tables were missing, all repository operations failed silently (caught by SkillService._load_from_db and _persist_skill exception handlers), causing the service to operate in in-memory-only mode.

  2. Session mismatch: SkillRepository lacked auto_commit support. Each call to session_factory() returned a new session, so the flush() in create()/update()/delete() operated on a different session than the commit() in SkillService._commit(), meaning data was never actually persisted.

Fix

  1. Add targeted table creation in _build_skill_service (following the pattern in _build_session_service) — checks for missing skills and skill_items tables and creates them via Base.metadata.create_all.
  2. Add auto_commit parameter to SkillRepository (following the pattern in SessionRepository) so each mutating method commits and closes its own session.
  3. Pass auto_commit=True from the container builder.
  4. Remove @tdd_expected_fail from TDD test (leaving @tdd_bug and @tdd_bug_980 as permanent regression guards).

Quality Gates

  • ✅ nox -e lint — passed
  • ✅ nox -e typecheck — 0 errors
  • ✅ nox -e unit_tests — 462 features, 12232 scenarios passed
  • ✅ nox -e integration_tests — 1674 tests, 1674 passed, 0 failed
  • ✅ nox -e coverage_report — 98% coverage (threshold: 97%)

Note: This PR depends on PR #1110 (TDD test for #981) being merged first.

Closes #980

## Summary Fixes the cross-process skill persistence regression reported in #980. Skills registered via `agents skill add --config <file>` in one CLI process are now correctly persisted to the database and visible in subsequent CLI invocations. ### Root Cause Two issues in the skill persistence layer: 1. **Missing table creation**: `_build_skill_service()` in `container.py` created a `SkillRepository` pointing at the database but did not ensure the `skills` and `skill_items` tables existed. When the tables were missing, all repository operations failed silently (caught by `SkillService._load_from_db` and `_persist_skill` exception handlers), causing the service to operate in in-memory-only mode. 2. **Session mismatch**: `SkillRepository` lacked `auto_commit` support. Each call to `session_factory()` returned a new session, so the `flush()` in `create()`/`update()`/`delete()` operated on a different session than the `commit()` in `SkillService._commit()`, meaning data was never actually persisted. ### Fix 1. Add targeted table creation in `_build_skill_service` (following the pattern in `_build_session_service`) — checks for missing `skills` and `skill_items` tables and creates them via `Base.metadata.create_all`. 2. Add `auto_commit` parameter to `SkillRepository` (following the pattern in `SessionRepository`) so each mutating method commits and closes its own session. 3. Pass `auto_commit=True` from the container builder. 4. Remove `@tdd_expected_fail` from TDD test (leaving `@tdd_bug` and `@tdd_bug_980` as permanent regression guards). ### Quality Gates - ✅ `nox -e lint` — passed - ✅ `nox -e typecheck` — 0 errors - ✅ `nox -e unit_tests` — 462 features, 12232 scenarios passed - ✅ `nox -e integration_tests` — 1674 tests, 1674 passed, 0 failed - ✅ `nox -e coverage_report` — 98% coverage (threshold: 97%) **Note**: This PR depends on PR #1110 (TDD test for #981) being merged first. Closes #980
freemo added this to the v3.2.0 milestone 2026-03-23 02:39:42 +00:00
freemo added the
Type
Bug
 label 2026-03-23 02:39:42 +00:00
freemo added the
MoSCoW
Must have
Priority
Critical
State
In Review
 labels 2026-03-23 03:33:55 +00:00
freemo requested review from hamza.khyari 2026-03-23 03:38:55 +00:00
freemo requested review from brent.edwards 2026-03-23 03:38:55 +00:00
freemo reviewed 2026-03-23 03:41:12 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Day 43 Review — PR #1120 fix(skill): resolve skill add persistence regression

Verdict: Review complete — meets all standards. Awaiting 2 peer approvals.

Review Findings

Category Status
Specification alignment PASS — Closes #980, all acceptance criteria addressed
Commit message format PASS — Conventional Changelog fix(skill): prefix
Code quality PASS — Defensive table check with sqlalchemy.inspect, backward-compatible auto_commit parameter
Testing (Behave) PASS — 2 cross-process scenarios
Testing (Robot) PASS — 2 integration test cases
@tdd_expected_fail removal PASS — Tag removed, @tdd_bug + @tdd_bug_980 remain as regression guards
Issue reference PASS — Closes #980 in body, ISSUES CLOSED: #980 in footer

@hamza.khyari @brent.edwards — please review and approve if findings are satisfactory.

## Day 43 Review — PR #1120 `fix(skill): resolve skill add persistence regression` **Verdict: Review complete — meets all standards. Awaiting 2 peer approvals.** ### Review Findings | Category | Status | |---|---| | Specification alignment | PASS — Closes #980, all acceptance criteria addressed | | Commit message format | PASS — Conventional Changelog `fix(skill):` prefix | | Code quality | PASS — Defensive table check with `sqlalchemy.inspect`, backward-compatible `auto_commit` parameter | | Testing (Behave) | PASS — 2 cross-process scenarios | | Testing (Robot) | PASS — 2 integration test cases | | `@tdd_expected_fail` removal | PASS — Tag removed, `@tdd_bug` + `@tdd_bug_980` remain as regression guards | | Issue reference | PASS — `Closes #980` in body, `ISSUES CLOSED: #980` in footer | @hamza.khyari @brent.edwards — please review and approve if findings are satisfactory.
freemo force-pushed bugfix/m3-skill-add-regression from 159cb7f730 to a652d6fb78 2026-03-23 11:51:20 +00:00 Compare
freemo force-pushed bugfix/m3-skill-add-regression from a652d6fb78 to 65d38e4759 2026-03-23 16:48:21 +00:00 Compare
freemo force-pushed bugfix/m3-skill-add-regression from 65d38e4759 to 312aa3d4f8 2026-03-23 22:49:29 +00:00 Compare
freemo force-pushed bugfix/m3-skill-add-regression from 312aa3d4f8 to 75161acf4b 2026-03-24 01:15:25 +00:00 Compare
freemo force-pushed bugfix/m3-skill-add-regression from 75161acf4b to fe8881b1c4 2026-03-24 14:26:15 +00:00 Compare
freemo reviewed 2026-03-24 15:26:26 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: Looks Good (with Minor Notes)

Clean, well-documented bug fix that directly addresses both root causes of the cross-process skill persistence regression. The implementation follows established codebase patterns (SessionRepository auto_commit, _build_session_service table creation), maintains backward compatibility (auto_commit defaults to False), and includes thorough test coverage at BDD and Robot levels.

Minor Notes

  1. DRY opportunity. The if self._auto_commit: session.commit(); session.close() block is duplicated in create(), update(), and delete(). Consider extracting to a _finalize_session(session) helper or context manager. Not blocking — consistent with existing SessionRepository pattern.

  2. Session not closed on commit failure. If session.commit() raises (e.g., late IntegrityError), session.close() is skipped. The except block does session.rollback() but never closes. Minor resource hygiene issue — consider adding session.close() to a finally block when auto_commit=True.

  3. PR dependency. PR body states this depends on PR #1110 (TDD test). Ensure #1110 is merged first to avoid conflicts.

Overall this is solid work — the two-pronged fix (table creation + auto_commit) is the right approach.

Note: Cannot formally approve as PR author matches the authenticated API user.

## Review: Looks Good (with Minor Notes) Clean, well-documented bug fix that directly addresses both root causes of the cross-process skill persistence regression. The implementation follows established codebase patterns (`SessionRepository` auto_commit, `_build_session_service` table creation), maintains backward compatibility (`auto_commit` defaults to `False`), and includes thorough test coverage at BDD and Robot levels. ### Minor Notes 1. **DRY opportunity.** The `if self._auto_commit: session.commit(); session.close()` block is duplicated in `create()`, `update()`, and `delete()`. Consider extracting to a `_finalize_session(session)` helper or context manager. Not blocking — consistent with existing `SessionRepository` pattern. 2. **Session not closed on commit failure.** If `session.commit()` raises (e.g., late `IntegrityError`), `session.close()` is skipped. The `except` block does `session.rollback()` but never closes. Minor resource hygiene issue — consider adding `session.close()` to a `finally` block when `auto_commit=True`. 3. **PR dependency.** PR body states this depends on PR #1110 (TDD test). Ensure #1110 is merged first to avoid conflicts. Overall this is solid work — the two-pronged fix (table creation + auto_commit) is the right approach. *Note: Cannot formally approve as PR author matches the authenticated API user.*
freemo force-pushed bugfix/m3-skill-add-regression from fe8881b1c4 to 93da31e80f 2026-03-24 17:08:23 +00:00 Compare
freemo scheduled this pull request to auto merge when all checks succeed 2026-03-24 17:08:36 +00:00
freemo merged commit 93da31e80f into master 2026-03-24 17:23:10 +00:00
freemo deleted branch bugfix/m3-skill-add-regression 2026-03-24 17:23:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
hamza.khyari
brent.edwards
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
MoSCoW
Must have
Priority
Critical
State
In Review
Type
Bug
Milestone
No items
No Milestone v3.2.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#1120
Delete Branch "bugfix/m3-skill-add-regression"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?