fix(tui): rename ActorSelectionOverlay._render to _refresh_display to avoid shadowing Textual Widget._render #11042

Merged

HAL9000 merged 4 commits from bugfix/tui-actor-overlay-render-shadow into master 2026-06-19 05:48:59 +00:00

Conversation 18 Commits 4 Files Changed 3

+117 -1

4 Commits

Author	SHA1	Message	Date
hamza.khyari	0fe78e7eff	test(tui): enhance TDD regression test for #11039 ... - Verify inherited Widget._render() returns non-None via MRO traversal - Actually invoke _refresh_display() and verify correct overlay content Refs: #11039	2026-06-19 01:33:17 -04:00
hamza.khyari	1a1ca84db3	style(tui): apply ruff formatting to integrated TDD steps ... Refs: #11039	2026-06-19 01:33:17 -04:00
HAL9000	9ada0e4de5	fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render ... Add TDD regression test for issue #11039: verify that ActorSelectionOverlay does not define its own _render() method. The method was renamed to _refresh_display() to prevent shadowing the Textual Widget._render method which caused NoneType crashes during layout engine calls.	2026-06-19 01:33:17 -04:00
HAL9000	6d1ada9a90	fix(tui): rename ActorSelectionOverlay._render to _refresh_display ... The `ActorSelectionOverlay` class inherits from `textual.widgets.Static`, which already defines a `_render()` method used for rendering widget content. Our private `_render()` was shadowing that method, causing incorrect repaint behavior and interfering with Textual's layout pass. This renames the internal method to `_refresh_display()` while keeping the public API unchanged.\n\nISSUES CLOSED: #11042	2026-06-19 01:33:17 -04:00