cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(providers): add ProviderType.GEMINI to ProviderRegistry.FALLBACK_ORDER #10997

Open
HAL9000 wants to merge 1 commit from pr-fix-10986 into master
pull from: pr-fix-10986
merge into: cleveragents:master
Conversation 2 Commits 1 Files changed 5 +14 -1
HAL9000 commented 2026-05-07 12:53:26 +00:00
Owner
Copy link

Summary

Fixes bug #4750: ProviderType.GEMINI was missing from ProviderRegistry.FALLBACK_ORDER, causing users who configure only GEMINI_API_KEY (without GOOGLE_API_KEY) to never have Gemini auto-selected as the default provider.

Changes

Bug Fix

  • Added ProviderType.GEMINI to FALLBACK_ORDER in src/cleveragents/providers/registry.py, positioned after ProviderType.GOOGLE
  • Added gemini to DEFAULT_FALLBACK_ORDER in src/cleveragents/providers/fallback_selector.py

Tests

  • Updated features/tdd_gemini_fallback_order_4750.feature — removed @tdd_expected_fail tag since the fix is applied (test now passes normally)

Root Cause

FALLBACK_ORDER iterates over providers to find the first configured one. Since GEMINI was absent from the list, get_default_provider_type() would return None for Gemini-only setups.

Impact

  • Users who configure only GEMINI_API_KEY can now use auto-discovery
  • get_default_provider_type() correctly returns ProviderType.GEMINI when only Gemini is configured

Closes #4750

## Summary Fixes bug #4750: `ProviderType.GEMINI` was missing from `ProviderRegistry.FALLBACK_ORDER`, causing users who configure only `GEMINI_API_KEY` (without `GOOGLE_API_KEY`) to never have Gemini auto-selected as the default provider. ## Changes ### Bug Fix - Added `ProviderType.GEMINI` to `FALLBACK_ORDER` in `src/cleveragents/providers/registry.py`, positioned after `ProviderType.GOOGLE` - Added `gemini` to `DEFAULT_FALLBACK_ORDER` in `src/cleveragents/providers/fallback_selector.py` ### Tests - Updated `features/tdd_gemini_fallback_order_4750.feature` — removed `@tdd_expected_fail` tag since the fix is applied (test now passes normally) ## Root Cause `FALLBACK_ORDER` iterates over providers to find the first configured one. Since `GEMINI` was absent from the list, `get_default_provider_type()` would return `None` for Gemini-only setups. ## Impact - Users who configure only `GEMINI_API_KEY` can now use auto-discovery - `get_default_provider_type()` correctly returns `ProviderType.GEMINI` when only Gemini is configured Closes #4750
fix(providers): add ProviderType.GEMINI to ProviderRegistry.FALLBACK_ORDER
Some checks failed
CI / quality (pull_request) Successful in 53s
Details
CI / lint (pull_request) Successful in 1m4s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / typecheck (pull_request) Successful in 1m20s
Details
CI / security (pull_request) Successful in 1m21s
Details
CI / helm (pull_request) Successful in 25s
Details
CI / build (pull_request) Successful in 44s
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / benchmark-regression (pull_request) Failing after 59s
Details
CI / e2e_tests (pull_request) Successful in 3m54s
Details
CI / unit_tests (pull_request) Failing after 4m6s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Successful in 4m7s
Details
CI / status-check (pull_request) Failing after 3s
Details
190f3387ce 
Add ProviderType.GEMINI to both ProviderRegistry.FALLBACK_ORDER (after
ProviderType.GOOGLE) and FallbackSelector.DEFAULT_FALLBACK_ORDER (after
'google'). The GEMINI enum value was already defined but missing from the
fallback chains, so Gemini-only users could not get a default provider.

Also remove the @tdd_expected_fail tag from the Behave regression test
since the bug is now fixed and the test must pass normally.

Closes #4750

Epic: v3.5.0 (M6: Autonomy Hardening)

This fix belongs under the v3.5.0 milestone which focuses on Autonomy
Hardening, including provider reliability improvements.
HAL9000 added this to the v3.5.0 milestone 2026-05-07 13:12:12 +00:00
HAL9001 requested changes 2026-05-07 16:23:04 +00:00
HAL9001 left a comment
Copy link

Code Review — PR #10997

Overall Assessment

The code change itself is correct: adding ProviderType.GEMINI to both ProviderRegistry.FALLBACK_ORDER and FallbackSelector.DEFAULT_FALLBACK_ORDER is the right fix for issue #4750, positioned correctly after ProviderType.GOOGLE. The TDD workflow was followed correctly — TDD issue #10896 was created, the @tdd_expected_fail regression test was merged first, and this PR removes that tag now that the fix is applied.

However, there are three blocking issues that must be resolved before this PR can be approved and merged:

BLOCKING — CI: unit_tests is failing

CI / unit_tests (pull_request) is FAILING (after 4m6s). As a direct consequence, CI / coverage (pull_request) was skipped — meaning the 97% coverage gate has not been verified.

Per company policy, all CI gates must pass before a PR can be approved. A failing unit_tests job is a hard blocker regardless of the nature of the change. Please investigate what caused the unit test failure and fix it. The coverage job must also pass and confirm >= 97% coverage.

Note: CI / benchmark-regression is also failing. While this is not one of the five required-for-merge gates, it is worth investigating — if the performance regression was introduced by this PR it should be addressed.

BLOCKING — Branch name does not follow project conventions

The branch is named pr-fix-10986. Per the project's branch naming rules, bug fix branches must follow the format bugfix/mN-<descriptive-name>. The milestone for this work is v3.5.0 (M6), so the branch should be named bugfix/m6-gemini-fallback-order (which is exactly the branch used by the companion PR #10906).

Fix: Please recreate this PR from a correctly named branch (bugfix/m6-gemini-fallback-order), OR close this PR and continue on PR #10906 instead (see duplicate PR note below).

BLOCKING — Missing Type/ label

This PR has no labels. Per the PR checklist, every PR must have exactly one Type/ label applied. Since this is a bug fix, the required label is Type/Bug.

Fix: Apply the Type/Bug label to this PR.

WARNING — Duplicate open PR (#10906)

PR #10906 (bugfix/m6-gemini-fallback-order) is still open and has the same title and equivalent changes. This PR (#10997) appears to be a re-attempt on a differently-named branch. Having two open PRs for the same fix creates confusion and risks double-merging. Please close one of them — ideally close this PR (#10997) and continue on PR #10906 which has the correctly named branch, OR close PR #10906 if you intend to proceed here.

SUGGESTION — Commit footer format

The commit message footer uses Closes #4750 (GitHub-style keyword). CONTRIBUTING.md specifies the footer format as ISSUES CLOSED: #N. While Forgejo also recognises the Closes keyword for auto-closing, the standard footer for commit messages in this project should be:

ISSUES CLOSED: #4750

This is a non-blocking suggestion — it can be addressed via a commit message amendment before merge.

What passes

  • Correctness: The fix is exactly right — ProviderType.GEMINI added after ProviderType.GOOGLE in both FALLBACK_ORDER (registry.py) and DEFAULT_FALLBACK_ORDER (fallback_selector.py).
  • TDD workflow: Followed correctly. @tdd_expected_fail tag properly removed now that the fix is applied.
  • Lint / Typecheck / Security: All passing.
  • CHANGELOG: Well-written entry included in the same commit.
  • CONTRIBUTORS.md: Updated.
  • Milestone: v3.5.0 correctly assigned.
  • Dependency direction: PR correctly blocks issue #4750.
  • Code style / readability / security: No issues. The change is a one-line addition to a class variable list in two files — minimal risk.
  • Integration / E2E tests: Both passing.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review — PR #10997 ### Overall Assessment The **code change itself is correct**: adding `ProviderType.GEMINI` to both `ProviderRegistry.FALLBACK_ORDER` and `FallbackSelector.DEFAULT_FALLBACK_ORDER` is the right fix for issue #4750, positioned correctly after `ProviderType.GOOGLE`. The TDD workflow was followed correctly — TDD issue #10896 was created, the `@tdd_expected_fail` regression test was merged first, and this PR removes that tag now that the fix is applied. However, there are **three blocking issues** that must be resolved before this PR can be approved and merged: --- ### BLOCKING — CI: `unit_tests` is failing `CI / unit_tests (pull_request)` is **FAILING** (after 4m6s). As a direct consequence, `CI / coverage (pull_request)` was skipped — meaning the 97% coverage gate has not been verified. Per company policy, all CI gates must pass before a PR can be approved. A failing `unit_tests` job is a hard blocker regardless of the nature of the change. Please investigate what caused the unit test failure and fix it. The coverage job must also pass and confirm >= 97% coverage. Note: `CI / benchmark-regression` is also failing. While this is not one of the five required-for-merge gates, it is worth investigating — if the performance regression was introduced by this PR it should be addressed. --- ### BLOCKING — Branch name does not follow project conventions The branch is named `pr-fix-10986`. Per the project's branch naming rules, bug fix branches **must** follow the format `bugfix/mN-<descriptive-name>`. The milestone for this work is v3.5.0 (M6), so the branch should be named `bugfix/m6-gemini-fallback-order` (which is exactly the branch used by the companion PR #10906). Fix: Please recreate this PR from a correctly named branch (`bugfix/m6-gemini-fallback-order`), OR close this PR and continue on PR #10906 instead (see duplicate PR note below). --- ### BLOCKING — Missing `Type/` label This PR has **no labels**. Per the PR checklist, every PR must have exactly one `Type/` label applied. Since this is a bug fix, the required label is `Type/Bug`. Fix: Apply the `Type/Bug` label to this PR. --- ### WARNING — Duplicate open PR (#10906) PR #10906 (`bugfix/m6-gemini-fallback-order`) is **still open** and has the same title and equivalent changes. This PR (#10997) appears to be a re-attempt on a differently-named branch. Having two open PRs for the same fix creates confusion and risks double-merging. Please close one of them — ideally close this PR (#10997) and continue on PR #10906 which has the correctly named branch, OR close PR #10906 if you intend to proceed here. --- ### SUGGESTION — Commit footer format The commit message footer uses `Closes #4750` (GitHub-style keyword). CONTRIBUTING.md specifies the footer format as `ISSUES CLOSED: #N`. While Forgejo also recognises the `Closes` keyword for auto-closing, the standard footer for commit messages in this project should be: ``` ISSUES CLOSED: #4750 ``` This is a non-blocking suggestion — it can be addressed via a commit message amendment before merge. --- ### What passes - **Correctness**: The fix is exactly right — `ProviderType.GEMINI` added after `ProviderType.GOOGLE` in both `FALLBACK_ORDER` (registry.py) and `DEFAULT_FALLBACK_ORDER` (fallback_selector.py). - **TDD workflow**: Followed correctly. `@tdd_expected_fail` tag properly removed now that the fix is applied. - **Lint / Typecheck / Security**: All passing. - **CHANGELOG**: Well-written entry included in the same commit. - **CONTRIBUTORS.md**: Updated. - **Milestone**: v3.5.0 correctly assigned. - **Dependency direction**: PR correctly blocks issue #4750. - **Code style / readability / security**: No issues. The change is a one-line addition to a class variable list in two files — minimal risk. - **Integration / E2E tests**: Both passing. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-07 16:30:07 +00:00
Owner
Copy link

Review submitted (REQUEST_CHANGES) — review ID 7906.

Three blocking issues identified:

  1. CI unit_tests failing — must pass before merge; coverage was also skipped.
  2. Branch name pr-fix-10986 is non-compliant — must be bugfix/m6-<name> format per CONTRIBUTING.md.
  3. Missing Type/Bug label — exactly one Type/ label is required.

Also flagged: duplicate open PR #10906 on the correctly-named branch bugfix/m6-gemini-fallback-order — recommend closing one of the two PRs.

The underlying code change (adding ProviderType.GEMINI to both fallback lists) is correct and the TDD workflow was properly followed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Review submitted (REQUEST_CHANGES) — review ID 7906. Three blocking issues identified: 1. **CI `unit_tests` failing** — must pass before merge; coverage was also skipped. 2. **Branch name `pr-fix-10986` is non-compliant** — must be `bugfix/m6-<name>` format per CONTRIBUTING.md. 3. **Missing `Type/Bug` label** — exactly one `Type/` label is required. Also flagged: duplicate open PR #10906 on the correctly-named branch `bugfix/m6-gemini-fallback-order` — recommend closing one of the two PRs. The underlying code change (adding `ProviderType.GEMINI` to both fallback lists) is correct and the TDD workflow was properly followed. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Some checks failed
CI / quality (pull_request) Successful in 53s
Required
Details
CI / lint (pull_request) Successful in 1m4s
Required
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / typecheck (pull_request) Successful in 1m20s
Required
Details
CI / security (pull_request) Successful in 1m21s
Required
Details
CI / helm (pull_request) Successful in 25s
Details
CI / build (pull_request) Successful in 44s
Required
Details
CI / push-validation (pull_request) Successful in 23s
Details
CI / benchmark-regression (pull_request) Failing after 59s
Details
CI / e2e_tests (pull_request) Successful in 3m54s
Details
CI / unit_tests (pull_request) Failing after 4m6s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / integration_tests (pull_request) Successful in 4m7s
Required
Details
CI / status-check (pull_request) Failing after 3s
Details
This pull request has changes conflicting with the target branch.
  • CONTRIBUTORS.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin pr-fix-10986:pr-fix-10986
git switch pr-fix-10986
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.5.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!10997
No description provided.