TDD: ProviderType.GEMINI missing from ProviderRegistry.FALLBACK_ORDER — Gemini-only users never get auto-selected provider (#4750) #10896

New issue

Closed

opened 2026-04-28 08:37:38 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-28 08:37:38 +00:00

Owner

Metadata

Commit Message: test(providers): add TDD failing test for GEMINI missing from FALLBACK_ORDER
Branch Name: tdd/m6-gemini-fallback-order

Background

This is the TDD companion issue for bug #4750 — ProviderType.GEMINI missing from ProviderRegistry.FALLBACK_ORDER.

Per the mandatory TDD bug fix workflow, a failing test must be written and merged before the fix is implemented.

What This Issue Covers

Write a BDD scenario that captures the bug: when only GEMINI_API_KEY is set (without GOOGLE_API_KEY), ProviderRegistry.get_default_provider_type() should return ProviderType.GEMINI but currently returns None because GEMINI is absent from FALLBACK_ORDER.

The test must:

Create a ProviderRegistry with only gemini_api_key set
Call get_default_provider_type()
Assert the result is ProviderType.GEMINI

The test is tagged @tdd_expected_fail so CI passes while the bug exists.

Acceptance Criteria

Feature file features/tdd_gemini_fallback_order_4750.feature created with @tdd_issue @tdd_issue_4750 @tdd_expected_fail tags
Step definitions in features/steps/tdd_gemini_fallback_order_4750_steps.py
Test fails via AssertionError (not any other exception type)
All other quality gates pass (lint, typecheck, unit_tests, coverage)
PR created on branch tdd/m6-gemini-fallback-order

Definition of Done

TDD PR merged to master
This issue closed

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

## Metadata - **Commit Message**: `test(providers): add TDD failing test for GEMINI missing from FALLBACK_ORDER` - **Branch Name**: `tdd/m6-gemini-fallback-order` ## Background This is the TDD companion issue for bug #4750 — `ProviderType.GEMINI` missing from `ProviderRegistry.FALLBACK_ORDER`. Per the mandatory TDD bug fix workflow, a failing test must be written and merged before the fix is implemented. ## What This Issue Covers Write a BDD scenario that captures the bug: when only `GEMINI_API_KEY` is set (without `GOOGLE_API_KEY`), `ProviderRegistry.get_default_provider_type()` should return `ProviderType.GEMINI` but currently returns `None` because `GEMINI` is absent from `FALLBACK_ORDER`. The test must: 1. Create a `ProviderRegistry` with only `gemini_api_key` set 2. Call `get_default_provider_type()` 3. Assert the result is `ProviderType.GEMINI` The test is tagged `@tdd_expected_fail` so CI passes while the bug exists. ## Acceptance Criteria - [ ] Feature file `features/tdd_gemini_fallback_order_4750.feature` created with `@tdd_issue @tdd_issue_4750 @tdd_expected_fail` tags - [ ] Step definitions in `features/steps/tdd_gemini_fallback_order_4750_steps.py` - [ ] Test fails via `AssertionError` (not any other exception type) - [ ] All other quality gates pass (lint, typecheck, unit_tests, coverage) - [ ] PR created on branch `tdd/m6-gemini-fallback-order` ## Definition of Done - TDD PR merged to master - This issue closed --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: task-implementor

Rows
Columns