chore(merge): batch merge of 7 known-good pull requests #10802

Merged

brent.edwards merged 22 commits from chore/merge-batch-1 into master 2026-04-21 02:42:20 +00:00

Conversation 2 Commits 22 Files Changed 75

+1592 -1003

22 Commits

Author	SHA1	Message	Date
brent.edwards	6bad73bad7	fix(tests): update a2a SDK TDD test to use Client instead of A2AClient ... The a2a-sdk floating constraint (>=0.3.0) in pyproject.toml allows nox's uv pip install to resolve the latest SDK version from PyPI, bypassing uv.lock. A newer a2a-sdk release removed the legacy A2AClient class, causing the TDD test to fail on CI while master (which ran against an older cached version) continued to pass. The modern Client class (a2a.client.Client) exists in all SDK versions including 0.3.25 (locked) and all subsequent releases. Updating the test to check for Client instead of A2AClient makes it forward-compatible and accurately reflects the SDK's current public API. See follow-up issue for the architectural fix: nox should use uv sync --frozen so that uv.lock is always respected for all packages.	2026-04-21 01:59:07 +00:00
brent.edwards	ba7dbe4838	fix: update automation profile field names in TDD bug #989 test ... The test was using legacy phase-transition field names that were renamed to spec-defined task-type semantics: - auto_strategize → decompose_task - auto_execute → create_tool - auto_apply → select_tool - auto_decisions_strategize → edit_code - auto_decisions_execute → execute_command - auto_validation_fix → create_file - auto_strategy_revision → delete_content - auto_reversion_from_apply → access_network - auto_child_plans → install_dependency - auto_retry_transient → modify_config - auto_checkpoint_restore → approve_plan This fix allows the TDD test for issue #989 to run properly instead of failing with TypeError during model instantiation. The test now correctly executes and fails at the assertion level as expected for a TDD bug-capture test. Fixes: Failure preventing PR #10802 batch merge of 7 PRs	2026-04-21 00:08:30 +00:00
brent.edwards	32b5029ea0	chore(merge): merge PR #10003 — fix plan cancel worktree cleanup ... Merged PR #10003 from branch bugfix/cancel-worktree-cleanup Resolved conflict in: - CHANGELOG.md: Accepted incoming version documenting the worktree cleanup fix The PR fixes a critical issue where plan cancellation did not properly clean up the isolated worktree, leaving stale branches behind. This fix ensures the sandbox is properly cleaned when a plan is cancelled.	2026-04-20 22:24:22 +00:00
brent.edwards	7d9a91eb1e	chore(merge): merge PR #8176 — fix pr-review-pool-supervisor tracking prefix ... Merged PR #8176 from branch fix/pr-review-pool-supervisor-prefix-mismatch Resolved conflicts in: - .opencode/agents/pr-review-pool-supervisor.md: Accepted incoming version with corrected tracking prefix AUTO-REV-SUP (instead of AUTO-REV-POOL) - CHANGELOG.md: Accepted incoming version documenting the tracking prefix fix - CONTRIBUTORS.md: Accepted incoming version with updated contributor tracking The PR fixes the tracking prefix inconsistency, changing from AUTO-REV-POOL to AUTO-REV-SUP to match the actual tracking issues created by the agent. This prevents duplicate tracking issues from being created each cycle.	2026-04-20 22:23:23 +00:00
brent.edwards	df8cd4c0a9	chore(merge): merge PR #7586 — fix bug-hunt-pool-supervisor tracking prefix ... Merged PR #7586 from branch improvement/agent-bug-hunt-pool-supervisor-tracking-prefix Resolved conflicts in: - .opencode/agents/bug-hunt-pool-supervisor.md: Accepted incoming version with improved tracking prefix AUTO-BUG-SUP and restructured tracking procedures - CHANGELOG.md: Accepted incoming version with clearer tracking fix documentation The PR fixes the tracking prefix inconsistency, changing from AUTO-BUG-POOL to AUTO-BUG-SUP for consistency with other agents, and improves the tracking issue format with better structured health reports and announcements.	2026-04-20 22:22:01 +00:00
brent.edwards	bb9695dec3	chore(merge): resolve conflicts in context-tiers and subplan-execution ... Resolved merge conflicts from PR #5276 (fix/v3.4.0/context-settings-defaults): - context_tiers.py: Accepted PR #5276's corrected default values - _DEFAULT_MAX_TOKENS_HOT: 8000 → 16000 - _DEFAULT_MAX_DECISIONS_WARM: 500 → 100 - _DEFAULT_MAX_DECISIONS_COLD: 5000 → 500 - subplan_execution_service.py: Accepted PR #5276's improved fail-fast logic - Replaced status_map with status_lookup naming - Added fail_fast_ids set tracking for better cancellation handling - Improved edge-case handling for concurrent subplan execution - Enhanced comments explaining fail-fast semantics All linting and type checks pass.	2026-04-20 22:20:45 +00:00
brent.edwards	53d3c18c34	Merge remote-tracking branch 'origin/improvement/agent-ca-test-infra-improver-failure-handling' into chore/merge-batch-1	2026-04-20 15:05:09 -07:00
brent.edwards	27eeaf946e	Merge remote-tracking branch 'origin/fix/test-infra-remove-redundant-python-variable-robot-files' into chore/merge-batch-1	2026-04-20 15:02:19 -07:00
hamza.khyari	805fef32a4	fix(test): patch get_container at module level after import move ... The G2 fix moved get_container to a top-level import in plan.py. The Behave step must now patch 'cleveragents.cli.commands.plan.get_container' instead of 'cleveragents.application.container.get_container' so the mock is resolved at the call site. ISSUES CLOSED: #9230	2026-04-20 14:27:44 +00:00
hamza.khyari	770dee16b8	fix(plan): address review findings on worktree sandbox cleanup ... - Move get_container and GitWorktreeSandbox imports to module top level (G2: satisfies top-of-file import requirement) - Replace bare 'except Exception' with specific NotFoundError, CleverAgentsError, SQLAlchemyError catches with structlog logging (G3: proper error handling) - Add input validation: empty/whitespace plan_id returns early with warning log (G4: guard against invalid input) - cleanup_stale() now tracks branch_deleted flag and logs partial cleanup warning when branch deletion fails (G5: accurate reporting) - Check off all issue #9230 subtasks (G7: process compliance) ISSUES CLOSED: #9230	2026-04-20 14:18:04 +00:00
hamza.khyari	b907ccd9f8	fix(plan): clean up worktree sandbox on plan cancel ... When a user cancels a plan after execute, the git worktree branch and directory created during execute are not cleaned up, causing resource leaks (dangling worktrees accumulate over time). Add GitWorktreeSandbox.cleanup_stale() classmethod in the infrastructure layer with idempotent error handling. _cleanup_sandbox_for_plan() in the CLI layer resolves the plan's linked git-checkout resource and delegates to cleanup_stale(). Called after service.cancel_plan() in the cancel CLI handler. ISSUES CLOSED: #9230	2026-04-20 13:54:28 +00:00
HAL9000	1b6e5f8fc3	docs(changelog): document bug-hunt-pool-supervisor tracking prefix fix ... Added CHANGELOG entry documenting the fix for tracking prefix inconsistency in the bug-hunt-pool-supervisor agent definition. ISSUES CLOSED: #7523	2026-04-17 10:29:13 +00:00
HAL9000	9bff689212	chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL → AUTO-BUG-SUP ... Complete the tracking prefix fix by updating all remaining references: - Embedded CREATE_TRACKING_ISSUE call (lines 195-196) - REVIEW_OWN_ANNOUNCEMENTS call (line 219) - CLOSE_ANNOUNCEMENT_ISSUE call (line 225) - Template header from 'Bug Detection Pool Status' to 'Bug Hunt Status' All 8 instances of AUTO-BUG-SUP are now consistent throughout the file. ISSUES CLOSED: #7523	2026-04-17 10:05:29 +00:00
HAL9000	04023d88c3	docs: add CHANGELOG and CONTRIBUTORS entries for pr-review-pool-supervisor fix ... - Added CHANGELOG entry documenting the tracking prefix mismatch fix (#7602) - Updated CONTRIBUTORS.md with latest HAL 9000 contributions - Addresses blocking review requirements for PR #8176	2026-04-15 00:36:35 +00:00
freemo	b122ec7ed5	fix(test-infra): remove redundant ${PYTHON} variable definitions from robot files ... Remove the local ${PYTHON} python (and python3) variable definitions from the *** Variables *** sections of all affected robot files. These local definitions were overriding the pabot-injected venv Python path passed via --variable PYTHON:/path/to/venv/python, causing tests to use the system Python (which lacks required packages like structlog, sqlalchemy, etc.) instead of the nox venv Python. The correct ${PYTHON} value is already set by Setup Test Environment in common.resource via sys.executable, and pabot passes it via --variable. The local fallback definitions are redundant and harmful in parallel runs. Audit found 56 robot files with the pattern (more than the 9 originally identified in the issue). All occurrences have been removed. ISSUES CLOSED: #1309	2026-04-14 14:50:55 +00:00
HAL9000	3ce17a3b74	fix(agents): correct pr-review-pool-supervisor tracking prefix from AUTO-REV-POOL to AUTO-REV-SUP\n\nThe agent definition specified AUTO-REV-POOL as the tracking prefix, but the actual\ntracking issues created by this agent use AUTO-REV-SUP. This mismatch prevented the\nautomation-tracking-manager from finding and closing previous tracking issues,\nresulting in duplicate issues being created each cycle.\n\nChanges:\n- Updated tracking prefix from AUTO-REV-POOL to AUTO-REV-SUP\n- Updated tracking type to PR Review Pool Status\n- Added Tracking Issue Format section documenting the correct format\n\nThis aligns the agent definition with actual observed behavior and resolves the\nsystemic duplicate tracking issue reported by the system watchdog.\n\nISSUES CLOSED: #7602	2026-04-13 04:12:17 +00:00
HAL9000	0f0c621b14	chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL → AUTO-BUG-SUP ... Complete the tracking prefix fix by updating all remaining references: - Embedded CREATE_TRACKING_ISSUE call (lines 195-196) - REVIEW_OWN_ANNOUNCEMENTS call (line 219) - CLOSE_ANNOUNCEMENT_ISSUE call (line 225) All 8 instances of AUTO-BUG-SUP are now consistent throughout the file.	2026-04-13 02:15:29 +00:00
HAL9000	00143aad7d	fix(planning): enforce cancel status for fail-fast parallel subplans	2026-04-12 16:43:30 +00:00
HAL9000	adfee4d195	fix(context): support spec env aliases for tier defaults	2026-04-12 16:43:30 +00:00
HAL9000	3a4fde9b0c	fix(context): correct Settings defaults for context tier limits per spec ... Align context tier defaults with the specification and ensure invalid values are rejected via positive-integer validation. Behave coverage locks in the defaults and validation behavior. ISSUES CLOSED: #5230 #4907	2026-04-12 16:43:30 +00:00
HAL9000	2a01aa3061	chore(agents): improve bug-hunt-pool-supervisor — fix tracking prefix inconsistency ... Approved proposal: #7523 Pattern: prompt_improvement Evidence: Agent definition specified [AUTO-BUG-POOL] prefix and 'Bug Detection Report' tracking type, but actual tracking issues use [AUTO-BUG-SUP] prefix and 'Bug Hunt Status' type (e.g., issue #7470). Watchdog health audit also references AUTO-BUG-SUP. Definition was out of sync with actual behavior. Fix: Updated all tracking prefix references from AUTO-BUG-POOL to AUTO-BUG-SUP and tracking type from 'Bug Detection Report' to 'Bug Hunt Status'. ISSUES CLOSED: #7523	2026-04-11 03:00:31 +00:00
freemo	cd35284e31	chore(agents): improve ca-test-infra-improver — graceful handling of clone and tool failures ... Approved proposal: #1809 Pattern: prompt_improvement — infrastructure failure misreporting Evidence: Agent filed 10+ issues about its own infrastructure failures (clone failures using wrong hostname, tool crashes, environment limitations) instead of handling them gracefully. Issues #1673, #1686, #1691, #1694, #1699, #1713, #1732 were all clone failures; #1695, #1726, #1727, #1740 were tool failures. Fix: Add hostname resolution guidance, clone failure handling with retry logic, tool failure handling with graceful degradation, and explicit scope restriction against filing issues about own environment. ISSUES CLOSED: #1809	2026-04-05 06:56:24 +00:00