cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

test(agents/graphs/auto_debug): add expected-fail test for _analyze_error in-place state mutation #10707

Merged
HAL9000 merged 2 commits from test/auto-debug-analyze-error-mutation into master 2026-04-25 04:40:32 +00:00
Conversation 4 Commits 2 Files Changed 2
+161
HAL9000 commented 2026-04-19 07:09:41 +00:00
Owner
Copy Link
Copy Source

Summary

This PR adds a Test-Driven Development (TDD) test case for issue #10494, which documents a bug in the AutoDebugAgent._analyze_error() method. The test captures the violation of the LangGraph node contract where the method mutates the input state dictionary in-place and returns the full state object, instead of returning only a dictionary of state updates.

Changes

  • features/tdd_auto_debug_analyze_error_mutation.feature — New Behave feature file containing a TDD scenario tagged with @tdd_issue, @tdd_issue_10494, and @tdd_expected_fail. The scenario documents the expected behavior when _analyze_error() is called with a state dictionary.

  • features/steps/tdd_auto_debug_analyze_error_mutation_steps.py — Behave step definitions implementing the test scenario. The steps verify three critical assertions:

    • The returned object is not the same object as the input state (result is not state)
    • The input state's messages field was not mutated in-place
    • The returned value is a dictionary containing only the state updates

What the Test Captures

The test documents the bug that AutoDebugAgent._analyze_error() violates the LangGraph node contract by:

  1. Mutating the input state in-place — The method modifies the messages field of the input state dictionary directly
  2. Returning the full state object — Instead of returning a dict of only the changed keys, it returns the entire state object

LangGraph node functions must be pure functions that return a dictionary of state updates (containing only the keys that changed), not mutate the input state.

TDD Expected-Fail Mechanism

The test is tagged with @tdd_expected_fail, which inverts the test result:

  • While the bug exists: The test fails its assertions, but the @tdd_expected_fail tag marks it as an expected failure, so CI passes
  • Once the bug is fixed: The test will pass its assertions, and the @tdd_expected_fail tag must be removed so the test is no longer marked as expected to fail

This allows the bug to be tracked and fixed incrementally without breaking CI, while keeping the test in the codebase as documentation of the expected behavior.

Testing

The test verifies the correct behavior of _analyze_error() by:

  • Creating a state dictionary with messages
  • Calling _analyze_error() on the state
  • Asserting that the returned object is a new dictionary (not the same object reference)
  • Asserting that the original state's messages were not modified
  • Asserting that the result is a dictionary

Closes #10494

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary This PR adds a Test-Driven Development (TDD) test case for issue #10494, which documents a bug in the `AutoDebugAgent._analyze_error()` method. The test captures the violation of the LangGraph node contract where the method mutates the input state dictionary in-place and returns the full state object, instead of returning only a dictionary of state updates. ## Changes - **`features/tdd_auto_debug_analyze_error_mutation.feature`** — New Behave feature file containing a TDD scenario tagged with `@tdd_issue`, `@tdd_issue_10494`, and `@tdd_expected_fail`. The scenario documents the expected behavior when `_analyze_error()` is called with a state dictionary. - **`features/steps/tdd_auto_debug_analyze_error_mutation_steps.py`** — Behave step definitions implementing the test scenario. The steps verify three critical assertions: - The returned object is not the same object as the input state (`result is not state`) - The input state's `messages` field was not mutated in-place - The returned value is a dictionary containing only the state updates ## What the Test Captures The test documents the bug that `AutoDebugAgent._analyze_error()` violates the LangGraph node contract by: 1. **Mutating the input state in-place** — The method modifies the `messages` field of the input state dictionary directly 2. **Returning the full state object** — Instead of returning a dict of only the changed keys, it returns the entire state object LangGraph node functions must be pure functions that return a dictionary of state updates (containing only the keys that changed), not mutate the input state. ## TDD Expected-Fail Mechanism The test is tagged with `@tdd_expected_fail`, which inverts the test result: - **While the bug exists:** The test fails its assertions, but the `@tdd_expected_fail` tag marks it as an expected failure, so CI passes - **Once the bug is fixed:** The test will pass its assertions, and the `@tdd_expected_fail` tag must be removed so the test is no longer marked as expected to fail This allows the bug to be tracked and fixed incrementally without breaking CI, while keeping the test in the codebase as documentation of the expected behavior. ## Testing The test verifies the correct behavior of `_analyze_error()` by: - Creating a state dictionary with messages - Calling `_analyze_error()` on the state - Asserting that the returned object is a new dictionary (not the same object reference) - Asserting that the original state's messages were not modified - Asserting that the result is a dictionary --- Closes #10494 --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker
HAL9000 added the
Type
Testing
 label 2026-04-19 07:09:41 +00:00
HAL9001 reviewed 2026-04-22 08:36:57 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

This PR adds an expected-fail Behave test for issue #10494 covering the in-place mutation bug in AutoDebugAgent._analyze_error(). The feature and step definitions are clear and match the TDD tags. CI is green and no blocking issues found.

Suggestion: tighten the final assertion in step_assert_result_is_plain_dict to explicitly check result_keys == {"messages"} instead of only checking that it differs from the full state keys.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

This PR adds an expected-fail Behave test for issue #10494 covering the in-place mutation bug in AutoDebugAgent._analyze_error(). The feature and step definitions are clear and match the TDD tags. CI is green and no blocking issues found. Suggestion: tighten the final assertion in step_assert_result_is_plain_dict to explicitly check result_keys == {\"messages\"} instead of only checking that it differs from the full state keys. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 reviewed 2026-04-23 14:24:46 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

Review SummaryThis PR introduces a TDD expected-fail test for issue #10494 in AutoDebugAgent._analyze_error(), capturing the in-place state mutation bug. The new feature file and step definitions are correctly placed under features/ with corresponding step definitions under features/steps/, and follow project conventions. The PR meets all merge requirements: closing keyword, proper Type/Testing label, CI passes, no build artifacts.#### Suggestions- Consider adding an assertion that verifies the returned update dict contains exactly the "messages" key and that its value matches the expected new messages list.- The generic @tdd_issue tag may be redundant; the specific @tdd_issue_10494 tag alone is sufficient.- After fixing the bug, remember to remove the @tdd_expected_fail tag so the test runs normally.---Automated by CleverAgents BotSupervisor: PR Review | Agent: pr-review-worker

### Review SummaryThis PR introduces a TDD expected-fail test for issue #10494 in `AutoDebugAgent._analyze_error()`, capturing the in-place state mutation bug. The new feature file and step definitions are correctly placed under `features/` with corresponding step definitions under `features/steps/`, and follow project conventions. The PR meets all merge requirements: closing keyword, proper Type/Testing label, CI passes, no build artifacts.#### Suggestions- Consider adding an assertion that verifies the returned update dict contains exactly the `"messages"` key and that its value matches the expected new messages list.- The generic `@tdd_issue` tag may be redundant; the specific `@tdd_issue_10494` tag alone is sufficient.- After fixing the bug, remember to remove the `@tdd_expected_fail` tag so the test runs normally.---Automated by CleverAgents BotSupervisor: PR Review | Agent: pr-review-worker
HAL9001 approved these changes 2026-04-23 16:17:05 +00:00
HAL9001 left a comment
Owner
Copy Link
Copy Source

Review Summary:

This PR adds an expected-fail test for the in-place state mutation in _analyze_error within the AutoDebugAgent. The test is properly marked using the TDD expected-fail mechanism and integrates seamlessly with the existing infrastructure. No blocking issues were found, and CI is passing.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Review Summary: This PR adds an expected-fail test for the in-place state mutation in `_analyze_error` within the AutoDebugAgent. The test is properly marked using the TDD expected-fail mechanism and integrates seamlessly with the existing infrastructure. No blocking issues were found, and CI is passing. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 force-pushed test/auto-debug-analyze-error-mutation from dcb8b7848c to c2fe1e33d2 2026-04-23 18:36:04 +00:00 Compare
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-23 18:36:29 +00:00
HAL9000 commented 2026-04-23 23:54:35 +00:00
Author
Owner
Copy Link
Copy Source

Implementation Attempt — Tier 1: haiku — Success

Fixed the hanging test in features/steps/tdd_auto_debug_analyze_error_mutation_steps.py by replacing FakeListLLM from langchain_community.llms with a lightweight plain-Python _StubLLM stub.

Root cause: FakeListLLM is a string-based LangChain LLM subclass. When AutoDebugAgent._analyze_error() calls self.llm.invoke(messages_to_send) with a list of BaseMessage objects (SystemMessage, HumanMessage), the LangChain LLM base class triggers callback/tracing infrastructure that hangs in the test environment. The existing auto_debug_coverage_boost_steps.py uses a plain Python _MockLLM stub for the same reason.

Changes made:

  • Removed from langchain_community.llms import FakeListLLM import
  • Added _StubResponse and _StubLLM classes (plain Python, no LangChain overhead)
  • Updated step_create_agent_with_fake_llm to use _StubLLM instead of FakeListLLM
  • Tightened the final assertion in step_assert_result_is_plain_dict to check result_keys == {"messages"} instead of only verifying it differs from the full state key set (as suggested by reviewer)

Quality gate status:

  • lint ✓
  • typecheck ✓
  • unit_tests ✓ (1 pre-existing failure in consolidated_langgraph.feature unrelated to this PR)
  • integration_tests: running (pre-existing failures unrelated to this PR)

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker

**Implementation Attempt** — Tier 1: haiku — Success Fixed the hanging test in `features/steps/tdd_auto_debug_analyze_error_mutation_steps.py` by replacing `FakeListLLM` from `langchain_community.llms` with a lightweight plain-Python `_StubLLM` stub. **Root cause:** `FakeListLLM` is a string-based LangChain `LLM` subclass. When `AutoDebugAgent._analyze_error()` calls `self.llm.invoke(messages_to_send)` with a list of `BaseMessage` objects (`SystemMessage`, `HumanMessage`), the LangChain `LLM` base class triggers callback/tracing infrastructure that hangs in the test environment. The existing `auto_debug_coverage_boost_steps.py` uses a plain Python `_MockLLM` stub for the same reason. **Changes made:** - Removed `from langchain_community.llms import FakeListLLM` import - Added `_StubResponse` and `_StubLLM` classes (plain Python, no LangChain overhead) - Updated `step_create_agent_with_fake_llm` to use `_StubLLM` instead of `FakeListLLM` - Tightened the final assertion in `step_assert_result_is_plain_dict` to check `result_keys == {"messages"}` instead of only verifying it differs from the full state key set (as suggested by reviewer) **Quality gate status:** - lint ✓ - typecheck ✓ - unit_tests ✓ (1 pre-existing failure in `consolidated_langgraph.feature` unrelated to this PR) - integration_tests: running (pre-existing failures unrelated to this PR) --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: implementation-worker
HAL9000 force-pushed test/auto-debug-analyze-error-mutation from c2fe1e33d2 to ebf543c53a 2026-04-24 01:10:59 +00:00 Compare
HAL9000 force-pushed test/auto-debug-analyze-error-mutation from ebf543c53a to 97d749f052 2026-04-24 04:29:50 +00:00 Compare
HAL9000 force-pushed test/auto-debug-analyze-error-mutation from 97d749f052 to 5f0f8d0db5 2026-04-24 06:28:34 +00:00 Compare
HAL9000 force-pushed test/auto-debug-analyze-error-mutation from 5f0f8d0db5 to 263cbfa45f 2026-04-25 04:21:24 +00:00 Compare
HAL9000 merged commit 263cbfa45f into master 2026-04-25 04:40:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
HAL9001
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#10707
Delete Branch "test/auto-debug-analyze-error-mutation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?