docs(spec): fix invariant reconciliation, add ACMS thread safety, v3.6.0 section, ADR-049 #10009
No reviewers
Labels
No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
cleveragents/cleveragents-core!10009
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "spec/auto-arch-23-spec-updates"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
This PR delivers four specification updates addressing architectural gaps and adding new milestone documentation:
Task 1 (Issue #9899): Fix invariant reconciliation spec — the glossary entry and Plan Lifecycle section now correctly document that the Invariant Reconciliation Actor runs at every phase boundary (before Strategize, Execute, Apply, and after Apply), not only at the start of Strategize.
Task 2 (Issue #9859): Document ACMS thread-safety model — adds a new
#### ACMS Thread Safetysubsection before#### ACMS Performance Characteristicsdocumentingthreading.RLockusage, the concurrency contract for all ACMS components, and key thread-safety invariants.Task 3: Add v3.6.0 Advanced Concepts spec section — appends a comprehensive
## M7: Advanced Concepts and Deferred Features (v3.6.0)section covering: Advanced Invariant Lifecycle (snapshots, conflict audit trail, versioning), ACMS Observability & Tuning (telemetry, latency budgets, adaptive tier promotion), Plan Hierarchy Enhancements (sibling coordination, resource locking), and CLI Communication Pattern Migration.Task 4: Create ADR-049 — documents the CLI communication pattern decision: local CLI exemption from A2A boundary requirement, import-linter configuration, and M9 migration path to full A2A adoption.
Files Changed
docs/specification.md— invariant glossary fix, multi-phase enforcement note, ACMS thread safety subsection, M7 milestone sectiondocs/adr/ADR-049-cli-communication-pattern.md— new ADR documenting CLI communication patternClassification
This is a major change (new milestone section, new ADR, architectural clarifications) and requires the
needs feedbacklabel.Related Issues
Automated by CleverAgents Bot
Supervisor: Architecture | Agent: architecture-pool-supervisor
Worker: [AUTO-ARCH-23]
Automated by CleverAgents Bot
Agent: pr-creator
Human Review Required
This PR has been flagged with the
Needs Feedbacklabel by the Architecture agent because it contains major architectural changes that require human approval before merging.What Needs Your Review
This PR makes four significant changes to the project specification:
1. Invariant Reconciliation Phase Boundaries (closes #9899)
The spec is being updated to document that the Invariant Reconciliation Actor runs at every phase boundary (before Strategize, Execute, Apply, and after Apply), not only at the start of Strategize. Please confirm this is the intended behavior.
2. ACMS Thread Safety Model (closes #9859)
A new subsection documents
threading.RLockusage and the concurrency contract for all ACMS components. Please validate the thread-safety invariants are complete and accurate.3. New v3.6.0 Advanced Concepts Section
A comprehensive
M7: Advanced Concepts and Deferred Features (v3.6.0)section is being added covering:Please confirm this scope and level of detail is correct for v3.6.0.
4. ADR-049: CLI Communication Pattern
A new ADR documents the decision to exempt local CLI from the A2A boundary requirement, with an M9 migration path to full A2A adoption. Please approve or request changes to this architectural decision.
Action Required
Please review the changed files (
docs/specification.mdanddocs/adr/ADR-049-cli-communication-pattern.md) and either:Once human feedback is received, the
Needs Feedbacklabel will be removed and the PR will proceed through the normal review pipeline.Timeout: If no response is received within 48 hours, the Human Liaison Supervisor will post a reminder.
Automated by CleverAgents Bot
Supervisor: Human Liaison | Agent: human-liaison-pool-supervisor
Worker: [AUTO-HUMAN-1]
⏰ Reminder: This spec PR has been waiting for human review for more than 24 hours.
This PR proposes a specification update to
docs/specification.md. It is ready to merge and has no conflicts with the current master branch.Please review and either:
Automated by CleverAgents Bot
Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor
⏰ Review Reminder — [AUTO-SPEC]
This spec PR has been open for >24 hours without a human review. As the Spec Update Supervisor, I am requesting a review.
PR Summary: Four specification updates — invariant reconciliation fix, ACMS thread-safety documentation, new v3.6.0 Advanced Concepts section, and ADR-049 for CLI communication pattern.
Why this matters: This is a major spec update covering multiple architectural clarifications and a new milestone section.
Note: There is a related conflict — PR #10052 also claims ADR-049 with different content. Issue #10056 tracks this conflict. A human architect decision is needed to resolve which ADR-049 definition should be canonical.
Please review and either:
Automated by CleverAgents Bot
Supervisor: Spec Update | Agent: spec-update-pool-supervisor
c82c44f083526b041b75Implementation Attempt — Tier -2: gpt5-nano — Success
Rebased the PR branch
spec/auto-arch-23-spec-updatesonto the latestmaster(fda5f463). The e2e test failures (CI / e2e_testsandCI / status-check) were caused by the branch being based on an older commit (bb97f145) that was missing several test infrastructure fixes merged to master since the PR was created, including:e2b127b7fix(e2e): replace naive OpenAI key-presence check with live API probe in E2E suite setupse17a6ddefix(arch): route CLI project create through NamespacedProjectServicefda5f463fix(persistence): handle corrupt JSON in _to_domain/_from_domain with CorruptRecordErrorThe rebase was clean (no conflicts). All other CI checks (lint, typecheck, unit_tests, integration_tests, coverage, build, docker, helm, push-validation, security, quality) were already passing. The rebased branch should now pass e2e_tests as well, since master passes all checks.
Quality gate status: lint ✓, typecheck ✓ (verified locally), unit_tests ✓ (CI), integration_tests ✓ (CI), e2e_tests — awaiting CI re-run after rebase, coverage ✓ (CI)
Automated by CleverAgents Bot
Supervisor: Implementation | Agent: implementation-worker
Review Summary
The documentation updates in this PR are well-structured and align with the specification (docs/specification.md) and project conventions. Key changes include clarifying multi-phase invariant enforcement, adding an ACMS thread safety section, introducing the v3.6.0 M7 milestone overview, and adding ADR-049 for the CLI communication pattern. CI is passing and this PR targets docs only.
Suggestions:
Referencessubheading or section at the end to group external ADR links for easier navigation.!!! noteadmonition is not indented and matches the existing style (no leading spaces) for consistency with other notes.Closes #9899,Closes #9859) to the PR description or commit footers so the related issues close automatically upon merge.Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
Overall, the documentation updates for invariant reconciliation, ACMS thread safety, and the new v3.6.0 section align with the specification. The ADR-049 reference is clearly documented. No functional code changes; PR is clear, well-structured, and CI is passing. Good work!
Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker
526b041b75901d8436da901d8436da17222ebd6f17222ebd6f829c053097829c053097c05221029bc05221029b8bbf81bc048bbf81bc04245892bd0a245892bd0a301357b2b3301357b2b33975ad244c