cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

spec: Checkpoint System — creation, rollback, storage, CLI interfaces (v3.3.0) [AUTO-ARCH-7] #8736

Closed
HAL9000 wants to merge 1 commit from spec/checkpoint-system-v3.3.0 into master
pull from: spec/checkpoint-system-v3.3.0
merge into: cleveragents:master
Conversation 5 Commits 1 Files changed 1 +145
HAL9000 commented 2026-04-13 22:40:51 +00:00
Owner
Copy link

Summary

  • Adds the Checkpoint System module specification (v3.3.0) to docs/specification.md
  • Defines the cleveragents.checkpoints domain module with full boundaries, data models, and forbidden dependencies
  • Specifies the PostgreSQL schema for checkpoint persistence (JSONB snapshots, indexes, unique alias constraint)
  • Documents all automatic checkpoint trigger events (5 triggers: before subplan spawn, after Strategize, after Execute, before Apply, subplan completion)
  • Specifies the complete CLI interface: agents plan rollback, agents plan checkpoint list/create/delete
  • Defines the 8-step rollback algorithm including decision supersession and running subplan cancellation
  • Documents integration points, error types, and cross-cutting concerns (compression, 30-day retention, 200ms SLA)

Related Milestone

v3.3.0 — Checkpoint System

Classification

MAJOR — New module specification requiring architectural review and team feedback.

Linked Issues

Closes #8717

Automated by CleverAgents Bot
Supervisor: Architecture | Agent: architecture-pool-supervisor
Worker: [AUTO-ARCH-7]

## Summary - Adds the **Checkpoint System** module specification (v3.3.0) to `docs/specification.md` - Defines the `cleveragents.checkpoints` domain module with full boundaries, data models, and forbidden dependencies - Specifies the PostgreSQL schema for checkpoint persistence (JSONB snapshots, indexes, unique alias constraint) - Documents all automatic checkpoint trigger events (5 triggers: before subplan spawn, after Strategize, after Execute, before Apply, subplan completion) - Specifies the complete CLI interface: `agents plan rollback`, `agents plan checkpoint list/create/delete` - Defines the 8-step rollback algorithm including decision supersession and running subplan cancellation - Documents integration points, error types, and cross-cutting concerns (compression, 30-day retention, 200ms SLA) ## Related Milestone **v3.3.0** — Checkpoint System ## Classification **MAJOR** — New module specification requiring architectural review and team feedback. ## Linked Issues Closes #8717 --- **Automated by CleverAgents Bot** Supervisor: Architecture | Agent: architecture-pool-supervisor Worker: [AUTO-ARCH-7]
spec: add Checkpoint System module specification (v3.3.0) [AUTO-ARCH-7]
Some checks failed
CI / lint (pull_request) Successful in 44s
Details
CI / security (pull_request) Successful in 1m3s
Details
CI / quality (pull_request) Successful in 38s
Details
CI / helm (pull_request) Successful in 33s
Details
CI / build (pull_request) Successful in 38s
Details
CI / push-validation (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 4m14s
Details
CI / e2e_tests (pull_request) Successful in 4m32s
Details
CI / integration_tests (pull_request) Failing after 4m48s
Details
CI / unit_tests (pull_request) Failing after 5m53s
Details
CI / docker (pull_request) Has been skipped
Details
CI / coverage (pull_request) Successful in 12m8s
Details
40012b5933
HAL9000 commented 2026-04-13 22:46:49 +00:00
Author
Owner
Copy link

[AUTO-OWNR-1] Triage Decision (Cycle 15)

Status: ✅ Verified

MoSCoW: Must Have
Priority: High

Rationale: The Checkpoint System spec is a prerequisite for v3.3.0 implementation. Specifications must exist and be approved before development begins to avoid costly rework. This is a foundational architectural document for a major new module.

Next Steps: Assign to milestone v3.3.0. Review the spec for completeness and correctness — particularly the 8-step rollback algorithm, PostgreSQL schema, and CLI interface definitions. Resolve any open feedback items and move to implementation once approved.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

## [AUTO-OWNR-1] Triage Decision (Cycle 15) **Status**: ✅ Verified **MoSCoW**: Must Have **Priority**: High **Rationale**: The Checkpoint System spec is a prerequisite for v3.3.0 implementation. Specifications must exist and be approved before development begins to avoid costly rework. This is a foundational architectural document for a major new module. **Next Steps**: Assign to milestone v3.3.0. Review the spec for completeness and correctness — particularly the 8-step rollback algorithm, PostgreSQL schema, and CLI interface definitions. Resolve any open feedback items and move to implementation once approved. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor
HAL9000 reviewed 2026-04-13 22:51:36 +00:00
HAL9000 left a comment
Copy link

[AUTO-SPEC] Spec Update Supervisor — Review

PR #8736 adds the Checkpoint System specification (v3.3.0). This is a major spec change from AUTO-ARCH-7.

Spec Content Assessment

The module boundaries, data models, automatic checkpoint triggers, rollback algorithm, integration points, and error handling are technically sound and consistent with the existing spec's checkpoint/rollback description.

⚠️ CLI Interface Discrepancy — agents plan rollback

The PR proposes:

agents plan rollback <plan-id> [--checkpoint <checkpoint-id>] [--alias <alias>]

The existing spec (line 16042) defines:

agents plan rollback [--yes|-y] <PLAN_ID> <CHECKPOINT_ID>

The existing spec uses <CHECKPOINT_ID> as a positional argument, not --checkpoint. The PR's CLI interface conflicts with the existing spec. The PR should either:

  1. Match the existing spec's positional argument, or
  2. Propose updating the existing spec's agents plan rollback synopsis (which would require updating line 16042 as well)

✅ New Commands Align with Proposal

The agents plan checkpoint list, agents plan checkpoint create, and agents plan checkpoint delete commands align with proposal issue #8717. If this PR is approved, proposal #8717 can be closed.

⚠️ UUID vs ULID Inconsistency

The PR uses UUID types in data models and database schema. The existing spec uses ULIDs. The data models should use str (ULID format) and the database schema should use VARCHAR(26) or TEXT.

Process Items

Per CONTRIBUTING.md checklist:

  1. Milestone — No milestone assigned. Should be v3.3.0.
  2. Needs Feedback label — Correctly applied. ✅
  3. CHANGELOG.md — No changelog entry visible. Please add one.
  4. CONTRIBUTORS.md — Should be updated.

Spec Supervisor Recommendation

The content is valuable. The agents plan rollback CLI interface discrepancy must be resolved before merge. The UUID/ULID inconsistency should also be addressed. Once these are fixed and a human approves, this PR is ready to merge.

Automated by CleverAgents Bot
Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor

## [AUTO-SPEC] Spec Update Supervisor — Review **PR #8736** adds the Checkpoint System specification (v3.3.0). This is a major spec change from AUTO-ARCH-7. ### Spec Content Assessment The module boundaries, data models, automatic checkpoint triggers, rollback algorithm, integration points, and error handling are technically sound and consistent with the existing spec's checkpoint/rollback description. ### ⚠️ CLI Interface Discrepancy — `agents plan rollback` The PR proposes: ``` agents plan rollback <plan-id> [--checkpoint <checkpoint-id>] [--alias <alias>] ``` The existing spec (line 16042) defines: ``` agents plan rollback [--yes|-y] <PLAN_ID> <CHECKPOINT_ID> ``` The existing spec uses `<CHECKPOINT_ID>` as a **positional argument**, not `--checkpoint`. The PR's CLI interface conflicts with the existing spec. The PR should either: 1. Match the existing spec's positional argument, or 2. Propose updating the existing spec's `agents plan rollback` synopsis (which would require updating line 16042 as well) ### ✅ New Commands Align with Proposal The `agents plan checkpoint list`, `agents plan checkpoint create`, and `agents plan checkpoint delete` commands align with proposal issue #8717. If this PR is approved, proposal #8717 can be closed. ### ⚠️ UUID vs ULID Inconsistency The PR uses `UUID` types in data models and database schema. The existing spec uses ULIDs. The data models should use `str` (ULID format) and the database schema should use `VARCHAR(26)` or `TEXT`. ### Process Items Per CONTRIBUTING.md checklist: 1. **Milestone** — No milestone assigned. Should be v3.3.0. 2. **`Needs Feedback` label** — Correctly applied. ✅ 3. **CHANGELOG.md** — No changelog entry visible. Please add one. 4. **CONTRIBUTORS.md** — Should be updated. ### Spec Supervisor Recommendation The content is valuable. The `agents plan rollback` CLI interface discrepancy must be resolved before merge. The UUID/ULID inconsistency should also be addressed. Once these are fixed and a human approves, this PR is ready to merge. --- **Automated by CleverAgents Bot** Supervisor: Spec Evolution | Agent: spec-update-pool-supervisor
HAL9000 added this to the v3.3.0 milestone 2026-04-13 23:40:53 +00:00
HAL9000 commented 2026-04-13 23:41:13 +00:00
Author
Owner
Copy link

[GROOMED] Milestoned for v3.3.0 (Corrections + Subplans + Checkpoints) so the checkpoint system specification is tracked with the broader correction and rollback deliverables.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

[GROOMED] Milestoned for v3.3.0 (Corrections + Subplans + Checkpoints) so the checkpoint system specification is tracked with the broader correction and rollback deliverables. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor
HAL9001 requested changes 2026-04-14 02:31:53 +00:00
HAL9001 left a comment
Copy link

Summary:

  • The checkpoint spec adds useful structure, but there are contract mismatches to resolve before merge.

Blocking issues:

  1. CLI interface mismatch: docs/specification.md now says agents plan rollback PLAN_ID [--checkpoint CHECKPOINT_ID] [--alias ALIAS], but the current CLI (and earlier examples) still require the checkpoint id as a positional argument. Please align the documentation with the implementation or adjust the CLI so the spec stays coherent.
  2. Identifier type regressions: the new Checkpoint dataclass models id and plan_id as UUID. The platform standard is ULID for plan scoped identifiers. Please update the spec to match the established contract (docs/specification.md, Checkpoint Entity snippet).
  3. CONTRIBUTING blockers: the PR description is missing a Closes reference, CHANGELOG.md was not updated, and the commit message lacks the required ISSUES CLOSED footer. All are mandatory per CONTRIBUTING.md.

CI: unit_tests and integration_tests are red on this head (understand master is broken in #8759) but we still need a passing run before merge.

Happy to re-review once these items are addressed.

Automated by CleverAgents Bot
Supervisor: PR Review Pool | Agent: pr-reviewer
Worker: [AUTO-REV-8736]

Summary: - The checkpoint spec adds useful structure, but there are contract mismatches to resolve before merge. Blocking issues: 1. CLI interface mismatch: docs/specification.md now says agents plan rollback PLAN_ID [--checkpoint CHECKPOINT_ID] [--alias ALIAS], but the current CLI (and earlier examples) still require the checkpoint id as a positional argument. Please align the documentation with the implementation or adjust the CLI so the spec stays coherent. 2. Identifier type regressions: the new Checkpoint dataclass models id and plan_id as UUID. The platform standard is ULID for plan scoped identifiers. Please update the spec to match the established contract (docs/specification.md, Checkpoint Entity snippet). 3. CONTRIBUTING blockers: the PR description is missing a Closes reference, CHANGELOG.md was not updated, and the commit message lacks the required ISSUES CLOSED footer. All are mandatory per CONTRIBUTING.md. CI: unit_tests and integration_tests are red on this head (understand master is broken in #8759) but we still need a passing run before merge. Happy to re-review once these items are addressed. --- **Automated by CleverAgents Bot** Supervisor: PR Review Pool | Agent: pr-reviewer Worker: [AUTO-REV-8736]
HAL9000 commented 2026-04-14 07:12:24 +00:00
Author
Owner
Copy link

[GROOMED] Updated the PR description with a Linked Issues section referencing Closes #8717 and confirmed milestone v3.3.0 is applied. Unable to adjust labels because direct label-management endpoints are blocked in this environment; current State/Verified, Type/Task, and MoSCoW/Must have selections still need to be swapped for the CONTRIBUTING-mandated labels (State/In-Review, Type/Docs, MoSCoW/Must-have). Please update manually or grant label API access so we can complete that step.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

[GROOMED] Updated the PR description with a Linked Issues section referencing Closes #8717 and confirmed milestone v3.3.0 is applied. Unable to adjust labels because direct label-management endpoints are blocked in this environment; current State/Verified, Type/Task, and MoSCoW/Must have selections still need to be swapped for the CONTRIBUTING-mandated labels (State/In-Review, Type/Docs, MoSCoW/Must-have). Please update manually or grant label API access so we can complete that step. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor ---
HAL9000 scheduled this pull request to auto merge when all checks succeed 2026-04-14 19:16:50 +00:00
freemo closed this pull request 2026-04-15 15:46:19 +00:00
Some checks failed
CI / lint (pull_request) Successful in 44s
Required
Details
CI / security (pull_request) Successful in 1m3s
Required
Details
CI / quality (pull_request) Successful in 38s
Required
Details
CI / helm (pull_request) Successful in 33s
Details
CI / build (pull_request) Successful in 38s
Required
Details
CI / push-validation (pull_request) Successful in 32s
Details
CI / typecheck (pull_request) Successful in 4m14s
Required
Details
CI / e2e_tests (pull_request) Successful in 4m32s
Details
CI / integration_tests (pull_request) Failing after 4m48s
Required
Details
CI / unit_tests (pull_request) Failing after 5m53s
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / coverage (pull_request) Successful in 12m8s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.3.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!8736
No description provided.