cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [data-integrity] CleanupService._get_sandbox_dirs() caches result permanently — new sandboxes created after first call are invisible to cleanup #7443

New issue

Open

opened 2026-04-10 19:29:31 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-10 19:29:31 +00:00

Owner

Bug Report: Data Integrity — CleanupService Stale Sandbox Directory Cache

Severity Assessment

Impact: After the first call to scan() or purge(), the CleanupService permanently caches the list of sandbox directories from that moment. Any sandboxes created AFTER the first call will never be cleaned up by subsequent scan() or purge() calls on the same service instance. This leads to accumulation of stale sandboxes even when the cleanup service is running.
Likelihood: High — any long-running process that creates sandboxes over time and runs periodic cleanup will be affected
Priority: Medium

Location

File: src/cleveragents/application/services/cleanup_service.py
Function: CleanupService._get_sandbox_dirs()
Lines: 104–127

Description

The _get_sandbox_dirs() method caches the result permanently in self._sandbox_dirs_cache:

def _get_sandbox_dirs(self) -> list[Path]:
    if self._sandbox_dirs_cache is not None:  # ← Never invalidated!
        return self._sandbox_dirs_cache
    tmp = Path(tempfile.gettempdir())
    # ... scan /tmp ...
    self._sandbox_dirs_cache = dirs
    return dirs

The docstring says "cached for the lifetime of the service instance", but this is a design flaw: the cleanup service is likely a singleton, so sandboxes created after initialization will never appear in the cache.

Scenario:

CleanupService created at app startup
First scan() call → scans /tmp, finds 0 sandboxes, caches []
User runs 10 plans → 10 sandbox directories created in /tmp
Second scan() call → returns cached [], finds no sandboxes
Stale sandboxes accumulate

Evidence

# src/cleveragents/application/services/cleanup_service.py, lines 104-127
def _get_sandbox_dirs(self) -> list[Path]:
    if self._sandbox_dirs_cache is not None:   # ← cache hit: never rescans /tmp
        return self._sandbox_dirs_cache
    ...
    self._sandbox_dirs_cache = dirs            # ← permanently cached
    return dirs

This is called by both _scan_sandboxes() and _purge_sandboxes(), meaning both scan and purge operations are equally affected.

Expected Behavior

Each call to scan() or purge() should re-discover sandbox directories in /tmp, as they are created dynamically.

Actual Behavior

After the first scan, no new sandboxes are ever discovered.

Suggested Fix

Remove the permanent caching, or use a short-lived cache with TTL:

def _get_sandbox_dirs(self) -> list[Path]:
    # Don't cache - directories change dynamically
    tmp = Path(tempfile.gettempdir())
    if not tmp.exists():
        return []
    dirs = []
    try:
        entries = list(tmp.iterdir())
    except OSError:
        return []
    for p in entries:
        try:
            is_dir = p.is_dir()
        except OSError:
            continue
        if is_dir and any(p.name.startswith(pfx) for pfx in ("ca-sandbox-", "ca-cow-sandbox-")):
            dirs.append(p)
    return dirs

Or alternatively, invalidate the cache at the start of each scan() / purge() call.

TDD Note

After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD with tags: @tdd_issue, @tdd_issue_, @tdd_expected_fail.

Automated by CleverAgents Bot
Supervisor: Bug Detection Pool | Agent: bug-hunt-pool-supervisor

## Bug Report: Data Integrity — CleanupService Stale Sandbox Directory Cache ### Severity Assessment - **Impact**: After the first call to `scan()` or `purge()`, the `CleanupService` permanently caches the list of sandbox directories from that moment. Any sandboxes created AFTER the first call will never be cleaned up by subsequent `scan()` or `purge()` calls on the same service instance. This leads to accumulation of stale sandboxes even when the cleanup service is running. - **Likelihood**: High — any long-running process that creates sandboxes over time and runs periodic cleanup will be affected - **Priority**: Medium ### Location - **File**: `src/cleveragents/application/services/cleanup_service.py` - **Function**: `CleanupService._get_sandbox_dirs()` - **Lines**: 104–127 ### Description The `_get_sandbox_dirs()` method caches the result permanently in `self._sandbox_dirs_cache`: ```python def _get_sandbox_dirs(self) -> list[Path]: if self._sandbox_dirs_cache is not None: # ← Never invalidated! return self._sandbox_dirs_cache tmp = Path(tempfile.gettempdir()) # ... scan /tmp ... self._sandbox_dirs_cache = dirs return dirs ``` The docstring says "cached for the lifetime of the service instance", but this is a design flaw: the cleanup service is likely a singleton, so sandboxes created after initialization will never appear in the cache. Scenario: 1. `CleanupService` created at app startup 2. First `scan()` call → scans `/tmp`, finds 0 sandboxes, caches `[]` 3. User runs 10 plans → 10 sandbox directories created in `/tmp` 4. Second `scan()` call → returns cached `[]`, finds no sandboxes 5. Stale sandboxes accumulate ### Evidence ```python # src/cleveragents/application/services/cleanup_service.py, lines 104-127 def _get_sandbox_dirs(self) -> list[Path]: if self._sandbox_dirs_cache is not None: # ← cache hit: never rescans /tmp return self._sandbox_dirs_cache ... self._sandbox_dirs_cache = dirs # ← permanently cached return dirs ``` This is called by both `_scan_sandboxes()` and `_purge_sandboxes()`, meaning both scan and purge operations are equally affected. ### Expected Behavior Each call to `scan()` or `purge()` should re-discover sandbox directories in `/tmp`, as they are created dynamically. ### Actual Behavior After the first scan, no new sandboxes are ever discovered. ### Suggested Fix Remove the permanent caching, or use a short-lived cache with TTL: ```python def _get_sandbox_dirs(self) -> list[Path]: # Don't cache - directories change dynamically tmp = Path(tempfile.gettempdir()) if not tmp.exists(): return [] dirs = [] try: entries = list(tmp.iterdir()) except OSError: return [] for p in entries: try: is_dir = p.is_dir() except OSError: continue if is_dir and any(p.name.startswith(pfx) for pfx in ("ca-sandbox-", "ca-cow-sandbox-")): dirs.append(p) return dirs ``` Or alternatively, invalidate the cache at the start of each `scan()` / `purge()` call. ### Category data-flow ### TDD Note After this bug issue is verified, a corresponding Type/Testing issue will be created for TDD with tags: @tdd_issue, @tdd_issue_<this-issue-number>, @tdd_expected_fail. --- **Automated by CleverAgents Bot** Supervisor: Bug Detection Pool | Agent: bug-hunt-pool-supervisor

HAL9000 referenced this issue from a commit

2026-04-10 19:38:04 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan

~~HAL9000 referenced this issue 2026-04-10 19:38:46 +00:00~~

docs(spec): clarify sandbox cleanup must re-discover directories on each scan #7448

HAL9000 referenced this issue

2026-04-10 19:38:52 +00:00

[AUTO-BUG-SUP] Bug Hunt Status (Cycle 3) #7449

HAL9000 referenced this issue

2026-04-10 19:40:07 +00:00

[AUTO-ARCH] Architecture Status (Cycle 1) #7343

HAL9000 referenced this issue

2026-04-10 19:53:06 +00:00

[AUTO-ARCH] Architecture Status (Cycle 2) #7460

HAL9000 added the

labels

2026-04-10 20:33:15 +00:00

HAL9000 referenced this issue

2026-04-10 20:39:58 +00:00

[AUTO-BUG-SUP] Bug Hunt Status (Cycle 4) #7470

HAL9000 referenced this issue from a commit

2026-04-11 01:47:28 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan

HAL9000 referenced this issue

2026-04-12 03:16:59 +00:00

[AUTO-BUG-POOL] Bug Detection Report (Cycle 1) #7709

HAL9000 referenced this issue from a pull request that will close it,

2026-04-12 16:22:05 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan #7448

HAL9000 referenced this issue from a commit

2026-04-12 17:04:19 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan

freemo added the

Type

Bug

label

2026-04-12 18:34:09 +00:00

HAL9000 referenced this issue from a pull request that will close it,

2026-04-13 05:00:10 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan #7448

HAL9000 added

and removed

labels

2026-04-14 06:24:03 +00:00

HAL9000 commented

2026-04-14 06:24:03 +00:00

Author

Owner

✅ Verified — Data integrity bug: CleanupService caches sandbox dirs permanently — new sandboxes invisible to cleanup. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

✅ **Verified** — Data integrity bug: CleanupService caches sandbox dirs permanently — new sandboxes invisible to cleanup. MoSCoW: Should-have. Priority: Medium. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 commented

2026-04-14 06:29:41 +00:00

Author

Owner

✅ Verified — Data integrity bug: CleanupService caches sandbox dirs permanently — new sandboxes invisible to cleanup. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 commented

2026-04-14 06:36:10 +00:00

Author

Owner

✅ Verified — Data integrity bug: CleanupService caches sandbox dirs permanently — new sandboxes invisible to cleanup. MoSCoW: Should-have. Priority: Medium.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner-pool-supervisor

HAL9000 referenced this issue from a commit

2026-04-28 09:30:39 +00:00

docs(spec): clarify sandbox cleanup must re-discover directories on each scan