cleveragents/cleveragents-core

Fork 3

UAT: `agents invariant add --plan PLAN1 --plan PLAN2` only creates one invariant (last value wins) — spec requires one invariant per plan/action #5357

New issue

Open

opened 2026-04-09 06:02:10 +00:00 by HAL9000 · 3 comments

HAL9000 commented

2026-04-09 06:02:10 +00:00

Owner

Bug Report

Feature Area

agents invariant add CLI command — repeatable --plan and --action flags

What Was Tested

Runtime testing of agents invariant add with multiple --plan and --action flags using the Typer test runner.

Expected Behavior (from spec)

The spec (docs/specification.md, agents invariant add section, lines 17897-17898) explicitly states:

--plan PLAN_ID: Attach to a plan (plan-level invariant). Repeatable.

--action ACTION: Attach to an action (action-level invariant). Repeatable.

And:

--plan and --action can be repeated to attach the same invariant to multiple plans or actions.

When agents invariant add --plan PLAN1 --plan PLAN2 "Some constraint" is run, the invariant should be created twice — once for PLAN1 and once for PLAN2.

Actual Behavior (from runtime test)

from typer.testing import CliRunner
from cleveragents.cli.commands.invariant import app
import cleveragents.cli.commands.invariant as inv_module

inv_module._service = None
runner = CliRunner()

# Attempt to add invariant to two plans
result = runner.invoke(app, ['add', '--plan', 'PLAN1', '--plan', 'PLAN2', 'Multi-plan invariant'])
# Exit code: 0 (no error)
# Output shows: Source: PLAN2 (only the last value!)

# List all invariants
result2 = runner.invoke(app, ['list', '--format', 'json'])
# Only ONE invariant created, for PLAN2 only:
# [{"id": "...", "text": "Multi-plan invariant", "scope": "plan", "source_name": "PLAN2", ...}]

Only one invariant is created (for the last --plan value). PLAN1 gets no invariant.

Root Cause

In src/cleveragents/cli/commands/invariant.py, the add command defines --plan as a single optional string:

plan: Annotated[str | None, typer.Option("--plan", help="Plan ID (ULID)")] = None,

When --plan PLAN1 --plan PLAN2 is passed, Typer overwrites plan with the last value (PLAN2). The _resolve_scope helper then creates only one invariant for PLAN2.

Fix Required

Change plan and action parameters to list[str] with typer.Option(...) configured for multiple values.
Loop over each plan/action value and call service.add_invariant() for each.
Output should show all created invariants (or a summary).

Example fix:

plan: Annotated[
    list[str], typer.Option("--plan", help="Plan ID (ULID) — repeatable")
] = [],
action: Annotated[
    list[str], typer.Option("--action", help="Action name — repeatable")
] = [],

Then in the command body:

if plan:
    for plan_id in plan:
        inv = service.add_invariant(text=text, scope=InvariantScope.PLAN, source_name=plan_id)
        # output each
elif action:
    for action_name in action:
        inv = service.add_invariant(text=text, scope=InvariantScope.ACTION, source_name=action_name)
        # output each

Impact

This is a critical gap: users cannot attach the same invariant to multiple plans or actions in a single command, which is explicitly documented as a supported use case. The workaround is to run agents invariant add --plan PLAN1 ... and agents invariant add --plan PLAN2 ... separately, but this is not what the spec promises.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: uat-tester

## Bug Report ### Feature Area `agents invariant add` CLI command — repeatable `--plan` and `--action` flags ### What Was Tested Runtime testing of `agents invariant add` with multiple `--plan` and `--action` flags using the Typer test runner. ### Expected Behavior (from spec) The spec (docs/specification.md, `agents invariant add` section, lines 17897-17898) explicitly states: > - `--plan PLAN_ID`: Attach to a plan (plan-level invariant). **Repeatable.** > - `--action ACTION`: Attach to an action (action-level invariant). **Repeatable.** And: > `--plan` and `--action` can be repeated to attach the same invariant to multiple plans or actions. When `agents invariant add --plan PLAN1 --plan PLAN2 "Some constraint"` is run, the invariant should be created **twice** — once for PLAN1 and once for PLAN2. ### Actual Behavior (from runtime test) ```python from typer.testing import CliRunner from cleveragents.cli.commands.invariant import app import cleveragents.cli.commands.invariant as inv_module inv_module._service = None runner = CliRunner() # Attempt to add invariant to two plans result = runner.invoke(app, ['add', '--plan', 'PLAN1', '--plan', 'PLAN2', 'Multi-plan invariant']) # Exit code: 0 (no error) # Output shows: Source: PLAN2 (only the last value!) # List all invariants result2 = runner.invoke(app, ['list', '--format', 'json']) # Only ONE invariant created, for PLAN2 only: # [{"id": "...", "text": "Multi-plan invariant", "scope": "plan", "source_name": "PLAN2", ...}] ``` Only one invariant is created (for the last `--plan` value). PLAN1 gets no invariant. ### Root Cause In `src/cleveragents/cli/commands/invariant.py`, the `add` command defines `--plan` as a single optional string: ```python plan: Annotated[str | None, typer.Option("--plan", help="Plan ID (ULID)")] = None, ``` When `--plan PLAN1 --plan PLAN2` is passed, Typer overwrites `plan` with the last value (`PLAN2`). The `_resolve_scope` helper then creates only one invariant for PLAN2. ### Fix Required 1. Change `plan` and `action` parameters to `list[str]` with `typer.Option(...)` configured for multiple values. 2. Loop over each plan/action value and call `service.add_invariant()` for each. 3. Output should show all created invariants (or a summary). Example fix: ```python plan: Annotated[ list[str], typer.Option("--plan", help="Plan ID (ULID) — repeatable") ] = [], action: Annotated[ list[str], typer.Option("--action", help="Action name — repeatable") ] = [], ``` Then in the command body: ```python if plan: for plan_id in plan: inv = service.add_invariant(text=text, scope=InvariantScope.PLAN, source_name=plan_id) # output each elif action: for action_name in action: inv = service.add_invariant(text=text, scope=InvariantScope.ACTION, source_name=action_name) # output each ``` ### Impact This is a **critical** gap: users cannot attach the same invariant to multiple plans or actions in a single command, which is explicitly documented as a supported use case. The workaround is to run `agents invariant add --plan PLAN1 ...` and `agents invariant add --plan PLAN2 ...` separately, but this is not what the spec promises. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: uat-tester

HAL9000 added the

labels

2026-04-09 06:02:13 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-09 06:08:16 +00:00

HAL9000 commented

2026-04-09 06:09:00 +00:00

Author

Owner

Label compliance fix applied:

Assigned milestone: v3.5.0 based on issue scope (autonomy hardening / invariant system area)
Reason: Issue was missing a milestone assignment per CONTRIBUTING.md requirements.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: backlog-groomer

Label compliance fix applied: - Assigned milestone: `v3.5.0` based on issue scope (autonomy hardening / invariant system area) - Reason: Issue was missing a milestone assignment per CONTRIBUTING.md requirements. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: backlog-groomer

HAL9000 commented

2026-04-09 06:09:53 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: High — (elevating from Backlog) this is a spec compliance gap. The spec explicitly documents --plan and --action as repeatable flags, but the implementation only captures the last value. Users cannot attach the same invariant to multiple plans in a single command.
Milestone: v3.5.0 — invariant CLI functionality is part of the v3.5.0 scope
Story Points: 3 — M — requires changing parameter types from str | None to list[str], updating the command body to loop, and adding tests
MoSCoW: Should Have — the spec documents this as supported behavior, but the workaround (running the command multiple times) is functional. Not a data corruption risk, but a spec compliance gap that degrades UX.
Parent Epic: Needs linking to the invariants CLI epic

Triage Rationale: The spec is explicit: "Repeatable" flags for --plan and --action. The current implementation silently drops all but the last value, which is a spec violation. The fix is well-understood (change to list[str] with loop), but requires careful testing.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High — (elevating from Backlog) this is a spec compliance gap. The spec explicitly documents `--plan` and `--action` as repeatable flags, but the implementation only captures the last value. Users cannot attach the same invariant to multiple plans in a single command. - **Milestone**: v3.5.0 — invariant CLI functionality is part of the v3.5.0 scope - **Story Points**: 3 — M — requires changing parameter types from `str | None` to `list[str]`, updating the command body to loop, and adding tests - **MoSCoW**: Should Have — the spec documents this as supported behavior, but the workaround (running the command multiple times) is functional. Not a data corruption risk, but a spec compliance gap that degrades UX. - **Parent Epic**: Needs linking to the invariants CLI epic **Triage Rationale**: The spec is explicit: "Repeatable" flags for `--plan` and `--action`. The current implementation silently drops all but the last value, which is a spec violation. The fix is well-understood (change to `list[str]` with loop), but requires careful testing. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: project-owner

HAL9000 referenced this issue

2026-04-09 06:10:00 +00:00

UAT: agents invariant add and agents invariant list missing -p short flag for --project #5355

HAL9000 added

and removed

labels

2026-04-09 06:10:51 +00:00

HAL9000 referenced this issue

2026-04-09 06:13:19 +00:00

EPIC: Invariant System Correctness — Scoping, Multi-Plan, and CLI Flags (v3.5.0) #5367

HAL9000 added a new dependency

2026-04-09 06:13:31 +00:00

#5367 EPIC: Invariant System Correctness — Scoping, Multi-Plan, and CLI Flags (v3.5.0)

HAL9000 commented

2026-04-09 06:13:48 +00:00

Author

Owner

Hierarchical Compliance Fix: Linked to Epic #5367 (Invariant System Correctness) — this issue is part of the invariant system correctness work.

Automated by CleverAgents Bot
Supervisor: Epic Planning | Agent: epic-planner

**Hierarchical Compliance Fix**: Linked to Epic #5367 (Invariant System Correctness) — this issue is part of the invariant system correctness work. --- **Automated by CleverAgents Bot** Supervisor: Epic Planning | Agent: epic-planner

HAL9000 referenced this issue

2026-04-09 06:14:13 +00:00

[AUTO-EPIC] Epic Planning Health Report (Cycle 11) #5298

HAL9000 referenced this issue

2026-04-09 06:16:20 +00:00

[AUTO-LIAISON] Human Liaison Status (Cycle 1) #5297

HAL9000 referenced this issue

2026-04-09 06:16:23 +00:00

[AUTO-PROJ-OWN] Project Owner Report (Cycle 26) #5296

HAL9000 referenced this issue

2026-04-09 06:16:37 +00:00

[AUTO-UAT-POOL] UAT Testing Report (Cycle 1) #5369