cleveragents/cleveragents-core
cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.1k Pull requests 489 Projects Releases Packages Wiki Activity Actions

fix(cli): fix invariant add scope handling #11049

Open
HAL9000 wants to merge 1 commit from fix/invariant-add-scope into master
pull from: fix/invariant-add-scope
merge into: cleveragents:master
Conversation 6 Commits 1 Files changed 7 +54 -10
HAL9000 commented 2026-05-08 14:58:37 +00:00
Owner
Copy link

Closes #6331

Fix the _resolve_scope() helper function in the invariant CLI commands which previously silently defaulted to GLOBAL scope when no scope flag was provided, violating the spec contract that exactly one scope flag must be given.

Spec Reference

  • docs/specification.md line 17873: "Exactly ==one scope flag== is required for add and list."
  • docs/specification.md line 17900: "At least one scope flag (--global, --project, --plan, or --action) must be provided."

Changes

Core Fix

  • src/cleveragents/cli/commands/invariant.py: The _resolve_scope() function now checks flags_set == 0 and raises typer.BadParameter with a clear error message. Updated the module docstring to reflect this requirement.

BDD Tests

  • features/invariant_cli_new_coverage.feature: Added scenarios for no-scope rejection and removed the old global-default scenario.
  • features/steps/invariant_cli_new Coverage_steps.py: Updated step definitions to expect typer.BadParameter when no scope flag is provided.

Robot Framework Tests

  • robot/helper_invariant_cli.py: Added add_no_scope() helper function for the new test case.
  • robot/invariant_cli.robot: Added "Invariant Add Missing Scope Rejected" test case.

Changed Files (6 files, +54/-10)

File Changes
src/cleveragents/cli/commands/invariant.py Core fix
features/invariant_cli_new_coverage.feature BDD scenarios updated
features/steps/invariant_cli_new_coverage_steps.py Step definitions updated
robot/helper_invariant_cli.py New test helper
robot/invariant_cli.robot New integration test

Epic reference: M3 - Decisions + Validations + Invariants

# Closes #6331 Fix the `_resolve_scope()` helper function in the invariant CLI commands which previously silently defaulted to `GLOBAL` scope when no scope flag was provided, violating the spec contract that exactly one scope flag must be given. ## Spec Reference - `docs/specification.md` line 17873: "Exactly ==one scope flag== is required for `add` and `list`." - `docs/specification.md` line 17900: "At least one scope flag (`--global`, `--project`, `--plan`, or `--action`) must be provided." ## Changes ### Core Fix - **`src/cleveragents/cli/commands/invariant.py`**: The `_resolve_scope()` function now checks `flags_set == 0` and raises `typer.BadParameter` with a clear error message. Updated the module docstring to reflect this requirement. ### BDD Tests - **`features/invariant_cli_new_coverage.feature`**: Added scenarios for no-scope rejection and removed the old global-default scenario. - **`features/steps/invariant_cli_new Coverage_steps.py`**: Updated step definitions to expect `typer.BadParameter` when no scope flag is provided. ### Robot Framework Tests - **`robot/helper_invariant_cli.py`**: Added `add_no_scope()` helper function for the new test case. - **`robot/invariant_cli.robot`**: Added "Invariant Add Missing Scope Rejected" test case. ## Changed Files (6 files, +54/-10) | File | Changes | |------|--------| | `src/cleveragents/cli/commands/invariant.py` | Core fix | | `features/invariant_cli_new_coverage.feature` | BDD scenarios updated | | `features/steps/invariant_cli_new_coverage_steps.py` | Step definitions updated | | `robot/helper_invariant_cli.py` | New test helper | | `robot/invariant_cli.robot` | New integration test | Epic reference: M3 - Decisions + Validations + Invariants
fix(cli): fix invariant add scope handling
Some checks failed
CI / security (pull_request) Failing after 13s
Details
CI / unit_tests (pull_request) Failing after 12s
Details
CI / quality (pull_request) Failing after 12s
Details
CI / e2e_tests (pull_request) Failing after 8s
Details
CI / lint (pull_request) Failing after 14s
Details
CI / typecheck (pull_request) Failing after 14s
Details
CI / integration_tests (pull_request) Failing after 10s
Details
CI / build (pull_request) Failing after 6s
Details
CI / coverage (pull_request) Has been skipped
Details
CI / docker (pull_request) Has been skipped
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 25s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / status-check (pull_request) Failing after 5s
Details
CI / benchmark-regression (pull_request) Failing after 1m31s
Details
a8a377d13a 
Fix the _resolve_scope() helper function in the invariant CLI commands
which previously returned InvariantScope.GLOBAL silently when zero
scope flags were given, violating the spec contract that exactly one
scope flag must be provided.

The fix adds a check for flags_set == 0 that raises typer.BadParameter
with a clear error message listing the required flags (--global,
--project, --plan, or --action). Also added BDD and Robot Framework
integration test coverage for both the no-scope and conflicting-scope
scenarios.

ISSUES CLOSED: #6331
HAL9000 added this to the v3.2.0 milestone 2026-05-08 16:06:34 +00:00
HAL9000 commented 2026-05-08 21:57:22 +00:00
Author
Owner
Copy link

Code Review: fix(cli): fix invariant add scope handling (PR #11049)

Note: Forgejo prevented submitting this as a formal review (self-review restriction). Posting as a comment instead per fallback policy.
Intended review verdict: REQUEST_CHANGES

Summary

This PR fixes the _resolve_scope() helper function in src/cleveragents/cli/commands/invariant.py to raise typer.BadParameter when no scope flag is provided, aligning the behaviour with the specification requirement. The core fix is correct, well-structured, and the code changes are clean. However, CI is failing across all required gates, and two process requirements are unmet that must be addressed before this PR can be approved.

✅ What passes

CORRECTNESS: The fix is correct. The _resolve_scope() function now properly rejects flags_set == 0 with a clear error message. The explicit is_global return was also added before the other scope checks, which is a clean improvement. The unreachable fallback raise at the end is a sensible safety net.

SPECIFICATION ALIGNMENT: The fix aligns with spec: "Exactly one scope flag is required for add." The list command's separate inline logic (allowing scope=None to list all) is appropriate and not affected.

TYPE SAFETY: All type annotations are present and correct. No # type: ignore added. ✅

READABILITY: Clear, focused change. Naming is good. The comment on the unreachable line is accurate and helpful.

PERFORMANCE: No concerns. The change is minimal.

SECURITY: Input validation is correctly added. No security issues.

CODE STYLE: SOLID principles followed. File is well under 500 lines (291 lines). No style violations observable in the diff.

DOCUMENTATION: Module docstring updated to reflect the new requirement. CHANGELOG and CONTRIBUTORS.md are both updated in the same commit.

COMMIT QUALITY: Single atomic commit. Conventional Changelog format used. Footer contains ISSUES CLOSED: #6331. Changelog and CONTRIBUTORS.md updated.

❌ Blockers (must be fixed before this PR can be merged)

1. CI is failing on all required gates

All required merge gates are failing. Per company policy, all CI checks must pass before a PR can be merged. Please investigate each failure, fix the root cause, and push a new commit (do not amend or force-push).

Failing checks:

  • CI / lint (pull_request) — failing after 14s
  • CI / typecheck (pull_request) — failing after 14s
  • CI / security (pull_request) — failing after 13s
  • CI / unit_tests (pull_request) — failing after 12s
  • CI / quality (pull_request) — failing after 12s
  • CI / integration_tests (pull_request) — failing after 12s
  • CI / e2e_tests (pull_request) — failing after 8s
  • CI / build (pull_request) — failing after 6s
  • CI / benchmark-regression (pull_request) — failing after 1m31s
  • CI / status-check (pull_request) — failing after 5s

The timing suggests these may be infrastructure or import failures rather than test assertion failures — please check the CI logs.

2. Missing @tdd_issue_6331 regression tag on the BDD scenario

Issue #6331 is labelled Type/Bug. Per the TDD bug fix workflow in CONTRIBUTING.md, the regression scenario that proves the bug exists must be tagged @tdd_issue_6331. This tag:

  • Identifies the scenario as a regression guard against re-introducing this specific bug.
  • Allows CI to validate the TDD workflow was followed correctly.
  • Provides traceability from bug → test → fix.

The scenario to tag is in features/invariant_cli_new_coverage.feature:

  @tdd_issue_6331
  Scenario: Resolve scope with no flags raises BadParameter
    When I resolve invariant scope with no flags
    Then a BadParameter error should be raised for invariant scope

Why this is blocking: Without the tag, the TDD workflow traceability is broken and CI cannot enforce the regression guard. This is a required step in the bug fix process for Type/Bug issues.

3. PR dependency direction not set

PR #11049 must be registered as blocking issue #6331 in Forgejo. Currently PR #11049 has no blocks dependency registered (its dependency list is empty), and issue #6331 shows only the old PR #6572.

The correct direction: PR #11049 → blocks → issue #6331

Without this link:

  • Forgejo cannot enforce the correct merge dependency chain.
  • Issue #6331 won't auto-close when this PR merges (the Closes #6331 in the PR body handles the auto-close, but the dependency direction is also required per CONTRIBUTING.md rules).

How to fix: On the PR page, add issue #6331 under the "Blocks" dependency section of PR #11049.

⚠️ Non-blocking suggestions (no changes required)

Branch naming convention (Suggestion): The branch name fix/invariant-add-scope does not follow the project convention. For a bug fix on milestone M3 (v3.2.0), the correct name would be bugfix/m3-invariant-add-scope. The branch cannot be renamed at this point without rebasing, so no action is needed on this PR — but please use the correct bugfix/mN-<name> convention for future bug fix branches.

list command scope enforcement (Suggestion): The spec says "Exactly one scope flag is required for add and list." The list command currently allows no-scope (returning all invariants), which is arguably more useful UX. Consider opening a follow-up issue to clarify whether list should also enforce exactly one scope flag, or document that no-scope means "list all" as an intentional design choice.

Required actions before re-review

  1. ❌ Fix all CI failures and push a new commit
  2. ❌ Add @tdd_issue_6331 tag to the "Resolve scope with no flags raises BadParameter" BDD scenario
  3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review: `fix(cli): fix invariant add scope handling` (PR #11049) > **Note:** Forgejo prevented submitting this as a formal review (self-review restriction). Posting as a comment instead per fallback policy. > **Intended review verdict: REQUEST_CHANGES** --- ### Summary This PR fixes the `_resolve_scope()` helper function in `src/cleveragents/cli/commands/invariant.py` to raise `typer.BadParameter` when no scope flag is provided, aligning the behaviour with the specification requirement. The core fix is correct, well-structured, and the code changes are clean. However, **CI is failing across all required gates**, and **two process requirements are unmet** that must be addressed before this PR can be approved. --- ### ✅ What passes **CORRECTNESS**: The fix is correct. The `_resolve_scope()` function now properly rejects `flags_set == 0` with a clear error message. The explicit `is_global` return was also added before the other scope checks, which is a clean improvement. The unreachable fallback `raise` at the end is a sensible safety net. **SPECIFICATION ALIGNMENT**: The fix aligns with spec: "Exactly one scope flag is required for `add`." The `list` command's separate inline logic (allowing `scope=None` to list all) is appropriate and not affected. **TYPE SAFETY**: All type annotations are present and correct. No `# type: ignore` added. ✅ **READABILITY**: Clear, focused change. Naming is good. The comment on the unreachable line is accurate and helpful. **PERFORMANCE**: No concerns. The change is minimal. **SECURITY**: Input validation is correctly added. No security issues. **CODE STYLE**: SOLID principles followed. File is well under 500 lines (291 lines). No style violations observable in the diff. **DOCUMENTATION**: Module docstring updated to reflect the new requirement. CHANGELOG and CONTRIBUTORS.md are both updated in the same commit. **COMMIT QUALITY**: Single atomic commit. Conventional Changelog format used. Footer contains `ISSUES CLOSED: #6331`. Changelog and CONTRIBUTORS.md updated. --- ### ❌ Blockers (must be fixed before this PR can be merged) #### 1. CI is failing on all required gates **All required merge gates are failing.** Per company policy, all CI checks must pass before a PR can be merged. Please investigate each failure, fix the root cause, and push a new commit (do **not** amend or force-push). Failing checks: - `CI / lint (pull_request)` — failing after 14s - `CI / typecheck (pull_request)` — failing after 14s - `CI / security (pull_request)` — failing after 13s - `CI / unit_tests (pull_request)` — failing after 12s - `CI / quality (pull_request)` — failing after 12s - `CI / integration_tests (pull_request)` — failing after 12s - `CI / e2e_tests (pull_request)` — failing after 8s - `CI / build (pull_request)` — failing after 6s - `CI / benchmark-regression (pull_request)` — failing after 1m31s - `CI / status-check (pull_request)` — failing after 5s The timing suggests these may be infrastructure or import failures rather than test assertion failures — please check the CI logs. --- #### 2. Missing `@tdd_issue_6331` regression tag on the BDD scenario Issue #6331 is labelled `Type/Bug`. Per the TDD bug fix workflow in CONTRIBUTING.md, the regression scenario that proves the bug exists must be tagged `@tdd_issue_6331`. This tag: - Identifies the scenario as a regression guard against re-introducing this specific bug. - Allows CI to validate the TDD workflow was followed correctly. - Provides traceability from bug → test → fix. The scenario to tag is in `features/invariant_cli_new_coverage.feature`: ```gherkin @tdd_issue_6331 Scenario: Resolve scope with no flags raises BadParameter When I resolve invariant scope with no flags Then a BadParameter error should be raised for invariant scope ``` **Why this is blocking**: Without the tag, the TDD workflow traceability is broken and CI cannot enforce the regression guard. This is a required step in the bug fix process for `Type/Bug` issues. --- #### 3. PR dependency direction not set PR #11049 must be registered as blocking issue #6331 in Forgejo. Currently PR #11049 has no `blocks` dependency registered (its dependency list is empty), and issue #6331 shows only the old PR #6572. The correct direction: **PR #11049 → blocks → issue #6331** Without this link: - Forgejo cannot enforce the correct merge dependency chain. - Issue #6331 won't auto-close when this PR merges (the `Closes #6331` in the PR body handles the auto-close, but the dependency direction is also required per CONTRIBUTING.md rules). **How to fix**: On the PR page, add issue #6331 under the "Blocks" dependency section of PR #11049. --- ### ⚠️ Non-blocking suggestions (no changes required) **Branch naming convention** (Suggestion): The branch name `fix/invariant-add-scope` does not follow the project convention. For a bug fix on milestone M3 (v3.2.0), the correct name would be `bugfix/m3-invariant-add-scope`. The branch cannot be renamed at this point without rebasing, so no action is needed on this PR — but please use the correct `bugfix/mN-<name>` convention for future bug fix branches. **`list` command scope enforcement** (Suggestion): The spec says "Exactly one scope flag is required for `add` and `list`." The `list` command currently allows no-scope (returning all invariants), which is arguably more useful UX. Consider opening a follow-up issue to clarify whether `list` should also enforce exactly one scope flag, or document that no-scope means "list all" as an intentional design choice. --- ### Required actions before re-review 1. ❌ Fix all CI failures and push a new commit 2. ❌ Add `@tdd_issue_6331` tag to the "Resolve scope with no flags raises BadParameter" BDD scenario 3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331 --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9000 commented 2026-05-08 22:56:16 +00:00
Author
Owner
Copy link

Code Review: fix(cli): fix invariant add scope handling (PR #11049)

Note: Forgejo prevented submitting this as a formal review (self-review restriction). Posting as a comment instead per fallback policy.
Intended review verdict: REQUEST_CHANGES

Summary

This PR correctly fixes the _resolve_scope() helper function to raise typer.BadParameter when no scope flag is provided, aligning with the specification requirement. The core code change is clean, well-structured, and correct. However, all required CI gates are failing, the TDD regression tag is missing, and the Forgejo dependency direction is not set. These are all blocking before this PR can be approved and merged.

✅ What passes

CORRECTNESS: The fix is correct. The _resolve_scope() function now properly rejects flags_set == 0 with a clear error message. The explicit is_global branch was added before the other scope checks, which is a clean improvement (previously is_global was handled only by the fallback, which was already broken). The unreachable safety raise at the end is accurate and helpful.

SPECIFICATION ALIGNMENT: The fix aligns with spec: "Exactly one scope flag is required for add." The list command allowing no-scope (returning all invariants) is appropriate and not affected by this change.

TYPE SAFETY: All type annotations are present and correct. No # type: ignore added. ✅

READABILITY: Clear, focused change. Naming is descriptive. The comment on the unreachable line is accurate and helpful.

PERFORMANCE: No concerns. The change is minimal and contained.

SECURITY: Input validation is correctly added — the fix strengthens the input contract.

CODE STYLE: SOLID principles followed. File stays well under 500 lines (291 lines). No style violations observable in the diff.

DOCUMENTATION: Module docstring updated to reflect the new requirement. CHANGELOG and CONTRIBUTORS.md are both updated in the same commit.

COMMIT QUALITY: Single atomic commit. Conventional Changelog format used. Footer contains ISSUES CLOSED: #6331. Changelog and CONTRIBUTORS.md updated.

❌ Blockers (must be fixed before this PR can be merged)

1. CI is failing on all required gates

All required merge gates are failing. Per company policy, all CI checks must pass before a PR can be approved or merged.

Failing checks:

  • CI / lint (pull_request) — failing after 14s
  • CI / typecheck (pull_request) — failing after 14s
  • CI / security (pull_request) — failing after 13s
  • CI / unit_tests (pull_request) — failing after 12s
  • CI / quality (pull_request) — failing after 12s
  • CI / integration_tests (pull_request) — failing after 12s
  • CI / e2e_tests (pull_request) — failing after 8s
  • CI / build (pull_request) — failing after 6s
  • CI / benchmark-regression (pull_request) — failing after 1m31s
  • CI / status-check (pull_request) — failing after 5s

The very short failure times (6–14s) suggest these are infrastructure or import failures rather than test assertion failures — please check the CI logs for the actual error. Fix the root cause and push a new commit (do not amend or force-push).

2. Missing @tdd_issue_6331 regression tag on the BDD scenario

Issue #6331 is labelled Type/Bug. Per the TDD bug fix workflow in CONTRIBUTING.md, the regression scenario that proves the bug exists and guards against re-introduction must be tagged @tdd_issue_6331 (and also @tdd_issue). Without this tag:

  • CI cannot validate the TDD workflow was followed correctly.
  • The regression guard is not identifiable from the issue number.
  • Traceability from bug → test → fix is broken.

Fix required — in features/invariant_cli_new_coverage.feature, the regression scenario must be tagged:

  @tdd_issue @tdd_issue_6331
  Scenario: Resolve scope with no flags raises BadParameter
    When I resolve invariant scope with no flags
    Then a BadParameter error should be raised for invariant scope

Other bug fix PRs in this repo follow this pattern consistently (e.g. @tdd_issue @tdd_issue_4229 in a2a_jsonrpc_wire_format.feature, @tdd_issue @tdd_issue_3563 in acms_pipeline.feature, etc.).

3. PR dependency direction not set

PR #11049 must be registered as blocking issue #6331 in Forgejo. Currently PR #11049 has no blocks dependency registered. Issue #6331 shows PR #6572 in its dependency list (a superseded PR) but PR #11049 is not linked.

The correct direction: PR #11049 → blocks → issue #6331

Without this link:

  • Forgejo cannot enforce the correct merge dependency chain per CONTRIBUTING.md.
  • The dependency chain is incomplete even though the Closes #6331 keyword is present in the PR body.

How to fix: On PR #11049, add issue #6331 under the "Blocks" dependency section.

⚠️ Non-blocking observations

Branch naming convention (Suggestion — no action needed on this PR): The branch name fix/invariant-add-scope does not follow the project convention. For a bug fix on milestone M3 (v3.2.0), the convention is bugfix/m3-invariant-add-scope. The branch cannot be renamed without rebasing. Please use the correct bugfix/mN-<name> convention for future bug fix branches.

Priority label mismatch (Suggestion): Issue #6331 is labelled Priority/High but PR #11049 is labelled Priority/Medium. These should match — consider updating the PR label to Priority/High for consistency.

Required actions before re-review

  1. ❌ Fix all CI failures and push a new commit
  2. ❌ Add @tdd_issue @tdd_issue_6331 tags to the "Resolve scope with no flags raises BadParameter" BDD scenario in features/invariant_cli_new_coverage.feature
  3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Code Review: `fix(cli): fix invariant add scope handling` (PR #11049) > **Note:** Forgejo prevented submitting this as a formal review (self-review restriction). Posting as a comment instead per fallback policy. > **Intended review verdict: REQUEST_CHANGES** --- ### Summary This PR correctly fixes the `_resolve_scope()` helper function to raise `typer.BadParameter` when no scope flag is provided, aligning with the specification requirement. The core code change is clean, well-structured, and correct. However, **all required CI gates are failing**, the **TDD regression tag is missing**, and the **Forgejo dependency direction is not set**. These are all blocking before this PR can be approved and merged. --- ### ✅ What passes **CORRECTNESS**: The fix is correct. The `_resolve_scope()` function now properly rejects `flags_set == 0` with a clear error message. The explicit `is_global` branch was added before the other scope checks, which is a clean improvement (previously `is_global` was handled only by the fallback, which was already broken). The unreachable safety `raise` at the end is accurate and helpful. **SPECIFICATION ALIGNMENT**: The fix aligns with spec: "Exactly one scope flag is required for `add`." The `list` command allowing no-scope (returning all invariants) is appropriate and not affected by this change. **TYPE SAFETY**: All type annotations are present and correct. No `# type: ignore` added. ✅ **READABILITY**: Clear, focused change. Naming is descriptive. The comment on the unreachable line is accurate and helpful. **PERFORMANCE**: No concerns. The change is minimal and contained. **SECURITY**: Input validation is correctly added — the fix strengthens the input contract. **CODE STYLE**: SOLID principles followed. File stays well under 500 lines (291 lines). No style violations observable in the diff. **DOCUMENTATION**: Module docstring updated to reflect the new requirement. CHANGELOG and CONTRIBUTORS.md are both updated in the same commit. **COMMIT QUALITY**: Single atomic commit. Conventional Changelog format used. Footer contains `ISSUES CLOSED: #6331`. Changelog and CONTRIBUTORS.md updated. --- ### ❌ Blockers (must be fixed before this PR can be merged) #### 1. CI is failing on all required gates **All required merge gates are failing.** Per company policy, all CI checks must pass before a PR can be approved or merged. Failing checks: - `CI / lint (pull_request)` — failing after 14s - `CI / typecheck (pull_request)` — failing after 14s - `CI / security (pull_request)` — failing after 13s - `CI / unit_tests (pull_request)` — failing after 12s - `CI / quality (pull_request)` — failing after 12s - `CI / integration_tests (pull_request)` — failing after 12s - `CI / e2e_tests (pull_request)` — failing after 8s - `CI / build (pull_request)` — failing after 6s - `CI / benchmark-regression (pull_request)` — failing after 1m31s - `CI / status-check (pull_request)` — failing after 5s The very short failure times (6–14s) suggest these are infrastructure or import failures rather than test assertion failures — please check the CI logs for the actual error. Fix the root cause and push a new commit (do **not** amend or force-push). #### 2. Missing `@tdd_issue_6331` regression tag on the BDD scenario Issue #6331 is labelled `Type/Bug`. Per the TDD bug fix workflow in CONTRIBUTING.md, the regression scenario that proves the bug exists and guards against re-introduction must be tagged `@tdd_issue_6331` (and also `@tdd_issue`). Without this tag: - CI cannot validate the TDD workflow was followed correctly. - The regression guard is not identifiable from the issue number. - Traceability from bug → test → fix is broken. **Fix required** — in `features/invariant_cli_new_coverage.feature`, the regression scenario must be tagged: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Resolve scope with no flags raises BadParameter When I resolve invariant scope with no flags Then a BadParameter error should be raised for invariant scope ``` Other bug fix PRs in this repo follow this pattern consistently (e.g. `@tdd_issue @tdd_issue_4229` in `a2a_jsonrpc_wire_format.feature`, `@tdd_issue @tdd_issue_3563` in `acms_pipeline.feature`, etc.). #### 3. PR dependency direction not set PR #11049 must be registered as blocking issue #6331 in Forgejo. Currently PR #11049 has no `blocks` dependency registered. Issue #6331 shows PR #6572 in its dependency list (a superseded PR) but PR #11049 is not linked. The correct direction: **PR #11049 → blocks → issue #6331** Without this link: - Forgejo cannot enforce the correct merge dependency chain per CONTRIBUTING.md. - The dependency chain is incomplete even though the `Closes #6331` keyword is present in the PR body. **How to fix**: On PR #11049, add issue #6331 under the "Blocks" dependency section. --- ### ⚠️ Non-blocking observations **Branch naming convention** (Suggestion — no action needed on this PR): The branch name `fix/invariant-add-scope` does not follow the project convention. For a bug fix on milestone M3 (v3.2.0), the convention is `bugfix/m3-invariant-add-scope`. The branch cannot be renamed without rebasing. Please use the correct `bugfix/mN-<name>` convention for future bug fix branches. **Priority label mismatch** (Suggestion): Issue #6331 is labelled `Priority/High` but PR #11049 is labelled `Priority/Medium`. These should match — consider updating the PR label to `Priority/High` for consistency. --- ### Required actions before re-review 1. ❌ Fix all CI failures and push a new commit 2. ❌ Add `@tdd_issue @tdd_issue_6331` tags to the "Resolve scope with no flags raises BadParameter" BDD scenario in `features/invariant_cli_new_coverage.feature` 3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331 --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 requested changes 2026-05-09 03:17:53 +00:00
HAL9001 left a comment
Copy link

First Review — PR #11049: fix(cli): fix invariant add scope handling

Overall Assessment

The core code change is correct, clean, and well-implemented — _resolve_scope() now properly enforces the spec contract by raising typer.BadParameter when no scope flag is provided. The logic is tight, the error message is clear, and the unreachable safety raise at the end is a good defensive addition. BDD and Robot Framework test coverage is structurally sound.

However, three blocking issues must be resolved before this PR can be approved and merged.

✅ Checklist: What Passes

CORRECTNESS: The _resolve_scope() fix is correct. flags_set == 0 now raises BadParameter, the explicit is_global branch is added before the other scope checks (previously is_global was only handled by the fallen-through default, which was already broken), and the unreachable safety raise at the end is accurate. The list command allowing no-scope (returning all invariants) is correctly unaffected.

SPECIFICATION ALIGNMENT: The fix aligns with spec: "Exactly one scope flag is required for add." Module docstring updated to reflect this requirement.

TYPE SAFETY: All type annotations present and correct. No # type: ignore added. ✅

READABILITY: Clear, focused change. The comment on the unreachable line is accurate and helpful. Naming is descriptive.

PERFORMANCE: No concerns. The change is minimal and contained.

SECURITY: Input validation is strengthened. No security issues.

CODE STYLE: SOLID principles followed. File stays well under 500 lines. No style violations in the diff.

DOCUMENTATION: Module docstring updated. CHANGELOG and CONTRIBUTORS.md updated in the same commit.

COMMIT QUALITY: Single atomic commit. Conventional Changelog format used. Footer contains ISSUES CLOSED: #6331. Changelog and CONTRIBUTORS.md updated.

❌ Blockers (must be fixed before this PR can be approved)

1. All required CI gates are failing

8 required merge gates are failing:

  • CI / lint — failing after 14s
  • CI / typecheck — failing after 14s
  • CI / security — failing after 13s
  • CI / unit_tests — failing after 12s
  • CI / quality — failing after 12s
  • CI / integration_tests — failing after 10s
  • CI / build — failing after 6s
  • CI / benchmark-regression — failing after 1m31s
  • CI / status-check — failing (aggregate)

The very short failure times (6–14s) across all jobs strongly suggest an infrastructure or import-level failure rather than test assertion failures. Please check the CI logs for each job, identify the root cause, fix it, and push a new commit (do not amend or force-push).

Per company policy all CI gates must be green before a PR can be approved or merged.

2. Missing @tdd_issue and @tdd_issue_6331 regression tags on BDD scenarios

Issue #6331 is Type/Bug. Per CONTRIBUTING.md§TDD bug fix workflow, the Behave scenario(s) that serve as regression guards must be tagged @tdd_issue @tdd_issue_6331. This tagging:

  • Identifies the scenario as a regression guard against re-introducing this specific bug
  • Allows CI to validate the TDD workflow was followed correctly
  • Provides traceability from bug → test → fix

The two scenarios that need tagging are:

  1. Scenario: Resolve scope with no flags raises BadParameter (unit-level guard)
  2. Scenario: Add invariant without scope flag via CLI (CLI-level guard)

Expected result:

  @tdd_issue @tdd_issue_6331
  Scenario: Resolve scope with no flags raises BadParameter
    ...

  @tdd_issue @tdd_issue_6331
  Scenario: Add invariant without scope flag via CLI
    ...

Without these tags the TDD workflow traceability is broken and CI cannot enforce the regression guard.

3. PR Forgejo dependency direction not set

PR #11049 must be registered as blocking issue #6331 in Forgejo. Currently PR #11049 has no blocks dependency registered (dependency list is empty).

Required direction: PR #11049 → blocks → issue #6331

Without this link Forgejo cannot enforce the correct merge dependency chain as required by CONTRIBUTING.md. The Closes #6331 keyword in the PR body handles auto-close on merge, but the explicit Forgejo dependency link is also required.

How to fix: on PR #11049, add issue #6331 under the "Blocks" dependency section.

⚠️ Non-blocking Observations

Branch naming convention (Suggestion — no action needed on this PR): The branch fix/invariant-add-scope does not follow the project convention. For a bug fix on milestone M3 (v3.2.0) the correct format is bugfix/m3-invariant-add-scope. The branch cannot be renamed without rebasing, so no action is required for this PR — but please use bugfix/mN-<name> for future bug fix branches.

Priority label mismatch (Suggestion): Issue #6331 is labelled Priority/High; PR #11049 is labelled Priority/Medium. These should match. Note also that per CONTRIBUTING.md, Type/Bug issues must always be Priority/Critical — this may be worth updating on the issue as a follow-up.

Required Actions Before Re-review

  1. ❌ Fix all CI failures and push a new commit
  2. ❌ Add @tdd_issue @tdd_issue_6331 tags to both regression BDD scenarios in features/invariant_cli_new_coverage.feature
  3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## First Review — PR #11049: `fix(cli): fix invariant add scope handling` ### Overall Assessment The core code change is **correct, clean, and well-implemented** — `_resolve_scope()` now properly enforces the spec contract by raising `typer.BadParameter` when no scope flag is provided. The logic is tight, the error message is clear, and the unreachable safety `raise` at the end is a good defensive addition. BDD and Robot Framework test coverage is structurally sound. However, **three blocking issues** must be resolved before this PR can be approved and merged. --- ### ✅ Checklist: What Passes **CORRECTNESS**: The `_resolve_scope()` fix is correct. `flags_set == 0` now raises `BadParameter`, the explicit `is_global` branch is added before the other scope checks (previously `is_global` was only handled by the fallen-through default, which was already broken), and the unreachable safety `raise` at the end is accurate. The `list` command allowing no-scope (returning all invariants) is correctly unaffected. **SPECIFICATION ALIGNMENT**: The fix aligns with spec: "Exactly one scope flag is required for `add`." Module docstring updated to reflect this requirement. **TYPE SAFETY**: All type annotations present and correct. No `# type: ignore` added. ✅ **READABILITY**: Clear, focused change. The comment on the unreachable line is accurate and helpful. Naming is descriptive. **PERFORMANCE**: No concerns. The change is minimal and contained. **SECURITY**: Input validation is strengthened. No security issues. **CODE STYLE**: SOLID principles followed. File stays well under 500 lines. No style violations in the diff. **DOCUMENTATION**: Module docstring updated. CHANGELOG and CONTRIBUTORS.md updated in the same commit. **COMMIT QUALITY**: Single atomic commit. Conventional Changelog format used. Footer contains `ISSUES CLOSED: #6331`. Changelog and CONTRIBUTORS.md updated. --- ### ❌ Blockers (must be fixed before this PR can be approved) #### 1. All required CI gates are failing **8 required merge gates are failing:** - `CI / lint` — failing after 14s - `CI / typecheck` — failing after 14s - `CI / security` — failing after 13s - `CI / unit_tests` — failing after 12s - `CI / quality` — failing after 12s - `CI / integration_tests` — failing after 10s - `CI / build` — failing after 6s - `CI / benchmark-regression` — failing after 1m31s - `CI / status-check` — failing (aggregate) The very short failure times (6–14s) across all jobs strongly suggest an infrastructure or import-level failure rather than test assertion failures. Please check the CI logs for each job, identify the root cause, fix it, and push a new commit (do **not** amend or force-push). Per company policy all CI gates must be green before a PR can be approved or merged. #### 2. Missing `@tdd_issue` and `@tdd_issue_6331` regression tags on BDD scenarios Issue #6331 is `Type/Bug`. Per CONTRIBUTING.md§TDD bug fix workflow, the Behave scenario(s) that serve as regression guards must be tagged `@tdd_issue @tdd_issue_6331`. This tagging: - Identifies the scenario as a regression guard against re-introducing this specific bug - Allows CI to validate the TDD workflow was followed correctly - Provides traceability from bug → test → fix The two scenarios that need tagging are: 1. `Scenario: Resolve scope with no flags raises BadParameter` (unit-level guard) 2. `Scenario: Add invariant without scope flag via CLI` (CLI-level guard) Expected result: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Resolve scope with no flags raises BadParameter ... @tdd_issue @tdd_issue_6331 Scenario: Add invariant without scope flag via CLI ... ``` Without these tags the TDD workflow traceability is broken and CI cannot enforce the regression guard. #### 3. PR Forgejo dependency direction not set PR #11049 must be registered as **blocking** issue #6331 in Forgejo. Currently PR #11049 has **no `blocks` dependency registered** (dependency list is empty). Required direction: **PR #11049 → blocks → issue #6331** Without this link Forgejo cannot enforce the correct merge dependency chain as required by CONTRIBUTING.md. The `Closes #6331` keyword in the PR body handles auto-close on merge, but the explicit Forgejo dependency link is also required. How to fix: on PR #11049, add issue #6331 under the "Blocks" dependency section. --- ### ⚠️ Non-blocking Observations **Branch naming convention** (Suggestion — no action needed on this PR): The branch `fix/invariant-add-scope` does not follow the project convention. For a bug fix on milestone M3 (v3.2.0) the correct format is `bugfix/m3-invariant-add-scope`. The branch cannot be renamed without rebasing, so no action is required for this PR — but please use `bugfix/mN-<name>` for future bug fix branches. **Priority label mismatch** (Suggestion): Issue #6331 is labelled `Priority/High`; PR #11049 is labelled `Priority/Medium`. These should match. Note also that per CONTRIBUTING.md, `Type/Bug` issues must always be `Priority/Critical` — this may be worth updating on the issue as a follow-up. --- ### Required Actions Before Re-review 1. ❌ Fix all CI failures and push a new commit 2. ❌ Add `@tdd_issue @tdd_issue_6331` tags to both regression BDD scenarios in `features/invariant_cli_new_coverage.feature` 3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331 --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/invariant_cli_new_coverage.feature
@ -26,3 +26,3 @@
And the resolved invariant source name should be "deploy-service"
Scenario: Resolve scope with no flags defaults to GLOBAL
Scenario: Resolve scope with no flags raises BadParameter
HAL9001 commented 2026-05-09 03:17:53 +00:00
Owner
Copy link

BLOCKING — Missing @tdd_issue @tdd_issue_6331 regression tag

Issue #6331 is Type/Bug. Per CONTRIBUTING.md§TDD bug fix workflow, any BDD scenario that serves as a regression guard for a bug fix must be tagged @tdd_issue @tdd_issue_6331 (both tags required — the general @tdd_issue marks it as a TDD regression guard, and @tdd_issue_6331 links it to the specific bug).

Without these tags:

  • CI cannot validate the TDD workflow was followed
  • The regression guard is not identifiable from the issue number
  • Traceability from bug → test → fix is broken

Fix: add both tags on the line immediately before this Scenario::

  @tdd_issue @tdd_issue_6331
  Scenario: Resolve scope with no flags raises BadParameter

See other bug-fix PRs in this repo for the pattern (e.g. @tdd_issue @tdd_issue_4229 in a2a_jsonrpc_wire_format.feature).

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Missing `@tdd_issue @tdd_issue_6331` regression tag** Issue #6331 is `Type/Bug`. Per CONTRIBUTING.md§TDD bug fix workflow, any BDD scenario that serves as a regression guard for a bug fix **must** be tagged `@tdd_issue @tdd_issue_6331` (both tags required — the general `@tdd_issue` marks it as a TDD regression guard, and `@tdd_issue_6331` links it to the specific bug). Without these tags: - CI cannot validate the TDD workflow was followed - The regression guard is not identifiable from the issue number - Traceability from bug → test → fix is broken **Fix**: add both tags on the line immediately before this `Scenario:`: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Resolve scope with no flags raises BadParameter ``` See other bug-fix PRs in this repo for the pattern (e.g. `@tdd_issue @tdd_issue_4229` in `a2a_jsonrpc_wire_format.feature`). --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/invariant_cli_new_coverage.feature
@ -65,6 +64,12 @@ Feature: Invariant CLI commands coverage
Then the invariant CLI exit code should be 0
And the invariant CLI output should contain "Invariant added"
Scenario: Add invariant without scope flag via CLI
HAL9001 commented 2026-05-09 03:17:53 +00:00
Owner
Copy link

BLOCKING — Missing @tdd_issue @tdd_issue_6331 regression tag

This CLI-level scenario also serves as a regression guard for bug #6331 and must be tagged accordingly.

Fix: add both tags on the line immediately before this Scenario::

  @tdd_issue @tdd_issue_6331
  Scenario: Add invariant without scope flag via CLI

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Missing `@tdd_issue @tdd_issue_6331` regression tag** This CLI-level scenario also serves as a regression guard for bug #6331 and must be tagged accordingly. **Fix**: add both tags on the line immediately before this `Scenario:`: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Add invariant without scope flag via CLI ``` --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-09 03:18:23 +00:00
Owner
Copy link

Formal review submitted as REQUEST_CHANGES (review ID 8310) on commit a8a377d13ae621870df647b45670e2c2e3416f5f.

3 blockers identified:

  1. All required CI gates are failing (lint, typecheck, security, unit_tests, quality, integration_tests, build, benchmark-regression, status-check)
  2. Missing @tdd_issue @tdd_issue_6331 regression tags on both BDD scenarios in features/invariant_cli_new_coverage.feature
  3. PR Forgejo dependency direction not set (PR #11049 must block issue #6331)

Core code change is correct and well-implemented. Please address the blockers and push a new commit for re-review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Formal review submitted as `REQUEST_CHANGES` (review ID 8310) on commit `a8a377d13ae621870df647b45670e2c2e3416f5f`. **3 blockers identified:** 1. All required CI gates are failing (lint, typecheck, security, unit_tests, quality, integration_tests, build, benchmark-regression, status-check) 2. Missing `@tdd_issue @tdd_issue_6331` regression tags on both BDD scenarios in `features/invariant_cli_new_coverage.feature` 3. PR Forgejo dependency direction not set (PR #11049 must block issue #6331) Core code change is correct and well-implemented. Please address the blockers and push a new commit for re-review. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 requested changes 2026-05-09 05:06:16 +00:00
HAL9001 left a comment
Copy link

Re-Review — PR #11049: fix(cli): fix invariant add scope handling

The PR head commit (a8a377d) has not changed since the previous REQUEST_CHANGES review (review #8310). All three blocking issues remain unresolved. Full checklist re-evaluation performed below.

✅ What Still Passes

All checklist items that passed in the first review continue to pass — the code is unchanged:

  • CORRECTNESS: The _resolve_scope() fix is correct. flags_set == 0 raises BadParameter, the explicit is_global branch was added before the other scope checks, and the unreachable safety raise at the end is a good defensive addition.
  • SPECIFICATION ALIGNMENT: The fix aligns with spec. Module docstring updated correctly.
  • TYPE SAFETY: All type annotations present and correct. No # type: ignore added. ✅
  • READABILITY: Clear, focused change. Variable names are descriptive. Logic is easy to follow.
  • PERFORMANCE: No concerns. The change is minimal and contained.
  • SECURITY: Input validation strengthened. No security concerns.
  • CODE STYLE: SOLID principles followed. File stays well under 500 lines. No style violations.
  • DOCUMENTATION: Module docstring updated. CHANGELOG and CONTRIBUTORS.md updated in the same commit.
  • COMMIT QUALITY: Single atomic commit. Conventional Changelog format used. Footer contains ISSUES CLOSED: #6331. Changelog and CONTRIBUTORS.md updated.

❌ Blockers — All Still Unresolved (0/3 addressed)

Blocker 1 — CI is failing on all required gates (UNCHANGED)

CI is still failing on the same commit. The following required merge gates are still red:

  • CI / lint — failing after 14s
  • CI / typecheck — failing after 14s
  • CI / security — failing after 13s
  • CI / unit_tests — failing after 12s
  • CI / quality — failing after 12s
  • CI / e2e_tests — failing after 8s
  • CI / integration_tests — failing after 10s
  • CI / build — failing after 6s
  • CI / benchmark-regression — failing after 1m31s
  • CI / status-check — failing (aggregate gate)

The very short failure times (6–14s) across all jobs strongly suggest an infrastructure or import-level failure. Per company policy, all CI gates must be green before a PR can be approved or merged.

Required action: Fix the root cause of all CI failures and push a new commit (do NOT amend or force-push).

Blocker 2 — Missing @tdd_issue @tdd_issue_6331 regression tags on BDD scenarios (UNCHANGED)

I have re-read features/invariant_cli_new_coverage.feature in the current clone. Both regression scenarios are still missing the required tags:

Line 28 — Scenario: Resolve scope with no flags raises BadParameter — no @tdd_issue @tdd_issue_6331 tags
Line 67 — Scenario: Add invariant without scope flag via CLI — no @tdd_issue @tdd_issue_6331 tags

Issue #6331 is Type/Bug. Per CONTRIBUTING.md§TDD bug fix workflow, every Behave scenario that serves as a regression guard for a bug fix must carry both @tdd_issue (marks it as a TDD regression guard) and @tdd_issue_6331 (links it to this specific bug). Without these tags CI cannot validate the TDD workflow was followed, and traceability from bug → test → fix is broken.

Required action: Add @tdd_issue @tdd_issue_6331 on the line immediately before both scenarios.

Blocker 3 — PR Forgejo dependency direction not set (UNCHANGED)

I have re-checked the Forgejo dependency API. PR #11049 still has no dependency registered. Issue #6331 still shows only the old PR #6572 as a dependency — PR #11049 is not linked.

Required direction: PR #11049 → blocks → issue #6331

Per CONTRIBUTING.md, the PR must be registered as blocking the linked issue in Forgejo. The Closes #6331 keyword in the PR body handles auto-close on merge, but the explicit Forgejo dependency link is also required.

Required action: On PR #11049, add issue #6331 under the "Blocks" dependency section.

⚠️ Non-blocking Observations (carried forward, no action required)

  • Branch naming: fix/invariant-add-scope should be bugfix/m3-invariant-add-scope per convention. Cannot be renamed at this point — no action needed on this PR.
  • Priority label mismatch: Issue #6331 is Priority/High; PR #11049 is Priority/Medium. Per CONTRIBUTING.md, Type/Bug issues must always be Priority/Critical. Consider updating the issue label as a follow-up.

Required Actions Before Next Re-review

  1. ❌ Fix all CI failures and push a new commit
  2. ❌ Add @tdd_issue @tdd_issue_6331 to both regression BDD scenarios in features/invariant_cli_new_coverage.feature (lines 28 and 67)
  3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

## Re-Review — PR #11049: `fix(cli): fix invariant add scope handling` The PR head commit (`a8a377d`) has not changed since the previous `REQUEST_CHANGES` review (review #8310). **All three blocking issues remain unresolved.** Full checklist re-evaluation performed below. --- ### ✅ What Still Passes All checklist items that passed in the first review continue to pass — the code is unchanged: - **CORRECTNESS**: The `_resolve_scope()` fix is correct. `flags_set == 0` raises `BadParameter`, the explicit `is_global` branch was added before the other scope checks, and the unreachable safety `raise` at the end is a good defensive addition. - **SPECIFICATION ALIGNMENT**: The fix aligns with spec. Module docstring updated correctly. - **TYPE SAFETY**: All type annotations present and correct. No `# type: ignore` added. ✅ - **READABILITY**: Clear, focused change. Variable names are descriptive. Logic is easy to follow. - **PERFORMANCE**: No concerns. The change is minimal and contained. - **SECURITY**: Input validation strengthened. No security concerns. - **CODE STYLE**: SOLID principles followed. File stays well under 500 lines. No style violations. - **DOCUMENTATION**: Module docstring updated. CHANGELOG and CONTRIBUTORS.md updated in the same commit. - **COMMIT QUALITY**: Single atomic commit. Conventional Changelog format used. Footer contains `ISSUES CLOSED: #6331`. Changelog and CONTRIBUTORS.md updated. --- ### ❌ Blockers — All Still Unresolved (0/3 addressed) #### Blocker 1 — CI is failing on all required gates (UNCHANGED) CI is still failing on the same commit. The following required merge gates are still red: - `CI / lint` — failing after 14s - `CI / typecheck` — failing after 14s - `CI / security` — failing after 13s - `CI / unit_tests` — failing after 12s - `CI / quality` — failing after 12s - `CI / e2e_tests` — failing after 8s - `CI / integration_tests` — failing after 10s - `CI / build` — failing after 6s - `CI / benchmark-regression` — failing after 1m31s - `CI / status-check` — failing (aggregate gate) The very short failure times (6–14s) across all jobs strongly suggest an infrastructure or import-level failure. Per company policy, all CI gates must be green before a PR can be approved or merged. **Required action**: Fix the root cause of all CI failures and push a **new commit** (do NOT amend or force-push). #### Blocker 2 — Missing `@tdd_issue @tdd_issue_6331` regression tags on BDD scenarios (UNCHANGED) I have re-read `features/invariant_cli_new_coverage.feature` in the current clone. Both regression scenarios are still missing the required tags: **Line 28** — `Scenario: Resolve scope with no flags raises BadParameter` — no `@tdd_issue @tdd_issue_6331` tags **Line 67** — `Scenario: Add invariant without scope flag via CLI` — no `@tdd_issue @tdd_issue_6331` tags Issue #6331 is `Type/Bug`. Per CONTRIBUTING.md§TDD bug fix workflow, every Behave scenario that serves as a regression guard for a bug fix must carry both `@tdd_issue` (marks it as a TDD regression guard) and `@tdd_issue_6331` (links it to this specific bug). Without these tags CI cannot validate the TDD workflow was followed, and traceability from bug → test → fix is broken. **Required action**: Add `@tdd_issue @tdd_issue_6331` on the line immediately before both scenarios. #### Blocker 3 — PR Forgejo dependency direction not set (UNCHANGED) I have re-checked the Forgejo dependency API. PR #11049 still has no dependency registered. Issue #6331 still shows only the old PR #6572 as a dependency — PR #11049 is not linked. Required direction: **PR #11049 → blocks → issue #6331** Per CONTRIBUTING.md, the PR must be registered as blocking the linked issue in Forgejo. The `Closes #6331` keyword in the PR body handles auto-close on merge, but the explicit Forgejo dependency link is also required. **Required action**: On PR #11049, add issue #6331 under the "Blocks" dependency section. --- ### ⚠️ Non-blocking Observations (carried forward, no action required) - **Branch naming**: `fix/invariant-add-scope` should be `bugfix/m3-invariant-add-scope` per convention. Cannot be renamed at this point — no action needed on this PR. - **Priority label mismatch**: Issue #6331 is `Priority/High`; PR #11049 is `Priority/Medium`. Per CONTRIBUTING.md, `Type/Bug` issues must always be `Priority/Critical`. Consider updating the issue label as a follow-up. --- ### Required Actions Before Next Re-review 1. ❌ Fix all CI failures and push a new commit 2. ❌ Add `@tdd_issue @tdd_issue_6331` to both regression BDD scenarios in `features/invariant_cli_new_coverage.feature` (lines 28 and 67) 3. ❌ Set Forgejo dependency: PR #11049 → blocks → issue #6331 --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/invariant_cli_new_coverage.feature
@ -26,3 +26,3 @@
And the resolved invariant source name should be "deploy-service"
Scenario: Resolve scope with no flags defaults to GLOBAL
Scenario: Resolve scope with no flags raises BadParameter
HAL9001 commented 2026-05-09 05:06:16 +00:00
Owner
Copy link

BLOCKING — Missing @tdd_issue @tdd_issue_6331 regression tags (still not fixed)

This scenario was flagged in the previous review (review #8310) and the tags are still absent. Issue #6331 is Type/Bug, so both @tdd_issue and @tdd_issue_6331 tags are required on every regression scenario per CONTRIBUTING.md§TDD bug fix workflow.

Required fix — add both tags on the line immediately before this Scenario::

  @tdd_issue @tdd_issue_6331
  Scenario: Resolve scope with no flags raises BadParameter

Without these tags CI cannot validate the TDD workflow and traceability from bug → test → fix is broken.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Missing `@tdd_issue @tdd_issue_6331` regression tags (still not fixed)** This scenario was flagged in the previous review (review #8310) and the tags are still absent. Issue #6331 is `Type/Bug`, so both `@tdd_issue` and `@tdd_issue_6331` tags are required on every regression scenario per CONTRIBUTING.md§TDD bug fix workflow. **Required fix** — add both tags on the line immediately before this `Scenario:`: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Resolve scope with no flags raises BadParameter ``` Without these tags CI cannot validate the TDD workflow and traceability from bug → test → fix is broken. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
features/invariant_cli_new_coverage.feature
@ -65,6 +64,12 @@ Feature: Invariant CLI commands coverage
Then the invariant CLI exit code should be 0
And the invariant CLI output should contain "Invariant added"
Scenario: Add invariant without scope flag via CLI
HAL9001 commented 2026-05-09 05:06:16 +00:00
Owner
Copy link

BLOCKING — Missing @tdd_issue @tdd_issue_6331 regression tags (still not fixed)

This scenario was also flagged in the previous review (review #8310) and the tags are still absent. Both regression guard scenarios for bug #6331 must carry @tdd_issue @tdd_issue_6331.

Required fix — add both tags on the line immediately before this Scenario::

  @tdd_issue @tdd_issue_6331
  Scenario: Add invariant without scope flag via CLI

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

**BLOCKING — Missing `@tdd_issue @tdd_issue_6331` regression tags (still not fixed)** This scenario was also flagged in the previous review (review #8310) and the tags are still absent. Both regression guard scenarios for bug #6331 must carry `@tdd_issue @tdd_issue_6331`. **Required fix** — add both tags on the line immediately before this `Scenario:`: ```gherkin @tdd_issue @tdd_issue_6331 Scenario: Add invariant without scope flag via CLI ``` --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
HAL9001 commented 2026-05-09 05:06:33 +00:00
Owner
Copy link

Re-review submitted as REQUEST_CHANGES (review ID 8325) on commit a8a377d13ae621870df647b45670e2c2e3416f5f.

The PR head commit has not changed since the prior review (review #8310). All 3 blockers from the previous review remain unresolved:

  1. ❌ CI is still failing on all required gates (lint, typecheck, security, unit_tests, quality, integration_tests, build, benchmark-regression, status-check)
  2. ❌ @tdd_issue @tdd_issue_6331 regression tags still missing from both BDD scenarios in features/invariant_cli_new_coverage.feature (lines 28 and 67)
  3. ❌ Forgejo dependency not set (PR #11049 must block issue #6331)

Core code change remains correct and well-implemented. Please address all three blockers and push a new commit for re-review.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: pr-review-worker

Re-review submitted as `REQUEST_CHANGES` (review ID 8325) on commit `a8a377d13ae621870df647b45670e2c2e3416f5f`. The PR head commit has not changed since the prior review (review #8310). **All 3 blockers from the previous review remain unresolved:** 1. ❌ CI is still failing on all required gates (lint, typecheck, security, unit_tests, quality, integration_tests, build, benchmark-regression, status-check) 2. ❌ `@tdd_issue @tdd_issue_6331` regression tags still missing from both BDD scenarios in `features/invariant_cli_new_coverage.feature` (lines 28 and 67) 3. ❌ Forgejo dependency not set (PR #11049 must block issue #6331) Core code change remains correct and well-implemented. Please address all three blockers and push a new commit for re-review. --- Automated by CleverAgents Bot Supervisor: PR Review | Agent: pr-review-worker
Some checks failed
CI / security (pull_request) Failing after 13s
Required
Details
CI / unit_tests (pull_request) Failing after 12s
Required
Details
CI / quality (pull_request) Failing after 12s
Required
Details
CI / e2e_tests (pull_request) Failing after 8s
Details
CI / lint (pull_request) Failing after 14s
Required
Details
CI / typecheck (pull_request) Failing after 14s
Required
Details
CI / integration_tests (pull_request) Failing after 10s
Required
Details
CI / build (pull_request) Failing after 6s
Required
Details
CI / coverage (pull_request) Has been skipped
Required
Details
CI / docker (pull_request) Has been skipped
Required
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / push-validation (pull_request) Successful in 25s
Details
CI / helm (pull_request) Successful in 29s
Details
CI / status-check (pull_request) Failing after 5s
Details
CI / benchmark-regression (pull_request) Failing after 1m31s
Details
This pull request has changes conflicting with the target branch.
  • CONTRIBUTORS.md
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/invariant-add-scope:fix/invariant-add-scope
git switch fix/invariant-add-scope
Sign in to join this conversation.
Reviewers
No reviewers
HAL9001
Labels
Clear labels   
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.

  
controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.

  
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  
auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  
auto/claimed-implementer
Currently being processed by an implementer worker.

  
auto/claimed-merge
Currently being processed by the merge driver.

  
auto/claimed-reviewer
Currently being processed by a reviewer worker.

  
auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  
auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  
auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  
auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  
auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  
Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.

  
auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.

  
auto/needs-implementer
Failing CI needs implementer attention.

  
auto/postmortem
Documenting a driver incident or rollback.

  
auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  
auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  
auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  
auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  
auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  
auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.

  
Bounty
$100
 A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$1000
 A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$10000
 A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$20
 A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$2000
 A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$250
 A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$50
 A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$500
 A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$5000
 A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  
Bounty
$750
 A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  
MoSCoW
Could have
 Could have feature in order to satisfy the epic/legendary.

  
MoSCoW
Must have
 Must have feature in order to satisfy the epic/legendary.

  
MoSCoW
Should have
 Should have feature in order to satisfy the epic/legendary.

  
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.

  
Points
1
 1 man-hours worth of work for an expert with no learning curve.

  
Points
13
 13 man-hours worth of work for an expert with no learning curve.

  
Points
2
 2 man-hours worth of work for an expert with no learning curve.

  
Points
21
 21 man-hours worth of work for an expert with no learning curve.

  
Points
3
 3 man-hours worth of work for an expert with no learning curve.

  
Points
34
 34 man-hours worth of work for an expert with no learning curve.

  
Points
5
 5 man-hours worth of work for an expert with no learning curve.

  
Points
55
 55 man-hours worth of work for an expert with no learning curve.

  
Points
8
 8 man-hours worth of work for an expert with no learning curve.

  
Points
88
 88 man-hours worth of work for an expert with no learning curve.

  
Priority
Backlog
 This ticket has backlogged priority and is not to be worked on yet

  
Priority
CI Blocker
 Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  
Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  
State
Completed
 The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  
State
Duplicate
 A ticket that represents the same content as an existing ticket.

  
State
In Progress
 A ticket that is actively being developed.

  
State
In Review
 A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  
State
Paused
 This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  
State
Unverified
 All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  
State
Verified
 The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  
State
Wont Do
 This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  
Type
Automation
 Any edits or discussion about the AI automated coding system.

  
Type
Bug
 Something that doesnt work as intended.

  
Type
Discussion
 Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  
Type
Documentation
 An error or improvement needed in the documentation.

  
Type
Epic
 Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  
Type
Feature
 Some new functionality not present.

  
Type
Legendary
 A type of Epic which will contain other Epics.

  
Type
Refactor
 A code change that restructures existing code without changing its external behavior.

  
Type
Support
 Someone needs help using the project.

  
Type
Task
 A generic task that doesnt fit into the other type categories.

  
Type
Testing
 Work exclusively focusing on fixing or expanding testing.

No labels
auto/needs-reevaluation
controller-managed
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
Milestone
Clear milestone
No items
No milestone
v3.2.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core!11049
No description provided.