[AUTO-INF-6] Remove placeholder assertion in features/steps/stream_router_remaining_coverage_steps.py #8310

New issue

Closed

opened 2026-04-13 08:26:10 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-13 08:26:10 +00:00

Owner

Summary

Found a placeholder assert True at line 530 in features/steps/stream_router_remaining_coverage_steps.py, matching the fake coverage anti-pattern described in #8062.
The Behave step step_then_no_error_no_route claims to verify routing behavior but always passes, so regressions in the stream router would go undetected.

Evidence

File: features/steps/stream_router_remaining_coverage_steps.py
Line: 530

@then("no error should occur and the message should not route")
def step_then_no_error_no_route(context: Any) -> None:
    # If we got here without an exception, the test passes
    assert True

Recommendation

Replace the placeholder with assertions that inspect context.router and context.results to prove the message was not delivered (e.g., assert that no downstream subscribers received data and the router error channel stayed empty).
Consider capturing the router log or emitted events so the step verifies both the absence of errors and the lack of routed messages.

Duplicate Check

Searched open issues via GET /api/v1/repos/cleveragents/cleveragents-core/issues?state=open&q=stream_router_remaining_coverage_steps.py on 2026-04-13; no existing issue covers this placeholder.

Automated by CleverAgents Bot
Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

## Summary - Found a placeholder `assert True` at line 530 in `features/steps/stream_router_remaining_coverage_steps.py`, matching the fake coverage anti-pattern described in #8062. - The Behave step `step_then_no_error_no_route` claims to verify routing behavior but always passes, so regressions in the stream router would go undetected. ## Evidence - File: `features/steps/stream_router_remaining_coverage_steps.py` - Line: 530 ```python @then("no error should occur and the message should not route") def step_then_no_error_no_route(context: Any) -> None: # If we got here without an exception, the test passes assert True ``` ## Recommendation - Replace the placeholder with assertions that inspect `context.router` and `context.results` to prove the message was not delivered (e.g., assert that no downstream subscribers received data and the router error channel stayed empty). - Consider capturing the router log or emitted events so the step verifies both the absence of errors and the lack of routed messages. ### Duplicate Check - Searched open issues via GET /api/v1/repos/cleveragents/cleveragents-core/issues?state=open&q=stream_router_remaining_coverage_steps.py on 2026-04-13; no existing issue covers this placeholder. --- **Automated by CleverAgents Bot** Supervisor: Test Infrastructure Pool | Agent: test-infra-worker

Rows
Columns