Three implementation contracts clarified in response to security/correctness
bugs surfaced by the bug hunt pool:
1. Path containment: Sandbox path validation MUST use Path.is_relative_to()
not string prefix comparison. String prefix allows /tmp/sandboxmalicious
to pass a /tmp/sandbox root check. Canonical implementation provided.
2. Datetime handling: All stored ISO timestamp comparisons MUST parse back
to timezone-aware datetime objects before comparing. String comparison
of ISO timestamps is incorrect when timezone offsets differ in format.
Canonical parse_utc_ts() pattern provided.
3. Plugin protocol validation: Protocol compliance MUST be checked
structurally via issubclass() — never by instantiating the plugin class.
Instantiation runs __init__ side effects before the plugin is approved.
These are minor clarifications (implementation contracts, not architectural
changes) added to the existing Security and Extensibility sections.
Refs: BUG-HUNT issues #7336 (path traversal), #7341 (datetime comparison),
#7331 (plugin instantiation)
- Add docs/modules/context-hydration.md: documents the ACMS context
hydration pipeline (context_tier_hydrator) that fixes the empty
ContextTierService bug (#1028). Covers hydrate_tiers_from_project,
hydrate_tiers_for_plan, file listing strategies, limits, and
fragment metadata.
- Add docs/modules/git-worktree-sandbox.md: documents the
GitWorktreeSandbox class that isolates plan apply changes in a
dedicated git branch/worktree and merges back on commit (#4454).
Covers full lifecycle, error types, branch naming, and fallback
for non-git projects.
- Update docs/architecture.md: add Git Worktree Sandbox Apply section
and extend ACMS section with context hydration note.
- Update mkdocs.yml: add both new module pages to the Modules nav.
ISSUES CLOSED: #6841
Reclassify the ACMS context tier hydration entry as a bug fix and add the sandbox root wiring item so the changelog matches the behavior shipped in PR #4219 while preserving newer [Unreleased] additions.
ISSUES CLOSED: #7628
- Add CHANGELOG.md entry under [Unreleased] ### Fixed for the empty-run
guard added to ApplyValidationSummary.all_required_passed
- Add HAL 9000 to CONTRIBUTORS.md per CONTRIBUTING.md §PR Process Rule 8
Previously the product-builder would adopt existing supervisor sessions
from prior runs and skip launching those already running. This caused
stale sessions to persist with outdated configuration and context.
Now Phase C.0 discovers and gracefully stops all existing supervisor
sessions before Phase C.2 unconditionally launches all 18 fresh.
The pr-reviewer agent was falling back to Forgejo MCP tools for reads
instead of using curl, causing actions to be attributed to the wrong
user account. This change:
- Blocks ALL Forgejo MCP tools (forgejo: '*': deny) instead of only
specific write tools
- Adds explicit curl-only mandate section with clear explanation
- Adds tested curl command reference covering every API operation
the reviewer needs (PR details, diffs, issues, CI status, reviews,
file contents, posting reviews, posting comments, dismissals)
- Adds robots.txt override instruction for our self-hosted instance
- Updates all review process steps to reference curl instead of MCP
The product-builder now reads FORGEJO_REVIEWER_* env vars and passes them
as the sole credentials to pr-review-pool-supervisor, which passes them
through to pr-reviewer workers. No agent in the review chain receives the
primary bot credentials, preventing accidental self-approvals. Simplifies
the reviewer instructions to require formal PR reviews (not just comments)
and removes contradictory references to denied MCP write tools.
Add comprehensive responsibility-first analysis of the entire agent system
covering 144 named responsibilities (R-01 through R-144) organized into 8
categories with 29 sub-categories and complete bidirectional cross-references.
Key additions:
- Section 22.0: Categorized Responsibility Index with navigation guide
- Section 7.9: Universal Supervisor Responsibilities (13 shared baseline)
- Section 22.145: Redundancy Analysis Summary with depth distribution,
highest-redundancy items, most cross-referenced agents, and 5 named
redundancy patterns
- 30 agent back-reference tables covering ~50 individual agents
- Category introductions explaining scope and significance
- 6th foundational principle (Defense-in-Depth) added to Section 1.1
Categories: A (Development Lifecycle, 50 items), B (Quality Assurance),
C (Ticket Hygiene), D (Architecture), E (Operational Health),
F (Human Interaction), G (Strategic Governance), H (Project Standards).
ISSUES CLOSED: N/A
Refresh Day 100 entries using Forgejo telemetry across both cycle snapshots to capture scope expansion, milestone progress, and active session data.\n\n- Update today marker and Gantt update log for Day 100\n- Capture scope expansion metrics and milestone completion percentages\n- Refresh risk register, status summary, and track/milestone forecasts\n- Append Day 100 cycle-2 schedule adherence tables for teams and milestones\n- Note infrastructure changes (review requirement, supervisor additions)\n\nISSUES CLOSED: #6975
Document the CLI-based lifecycle for removing, exporting, and importing named contexts, including JSON import limitations and scripting examples.
ISSUES CLOSED: #4409
Refresh timeline for Day 99 with updated gantt charts, status summary, and schedule adherence tables covering bug surge and milestone scope changes.
ISSUES CLOSED: #5780
- Fixed duplicate section number: two §2.4 -> renamed first to §2.3.1
- Verified all section cross-references valid
- Verified Appendix A model/mode data matches frontmatter (10 samples)
- Verified mkdocs.yml navigation entry
- Comprehensive stale-name sweep: zero hits across all files
- Added v1.36.0 revision entry with final statistics
- pr-reviewer.md: renamed "PR Self-Reviewer" to "PR Reviewer", rewrote
APPROVE and REQUEST_CHANGES templates to use curl with FORGEJO_REVIEWER_PAT
instead of denied MCP tools, corrected step ordering (formal review first,
backup comment second)
- pr-review-pool-supervisor.md: added all 3 reviewer credentials to stuck-PR
prompt which was missing them entirely
The Forgejo MCP tools authenticate with a single server-level token that
cannot be overridden per-call. The PR Reviewer must use curl with
FORGEJO_REVIEWER_PAT for write operations (reviews, comments) to
authenticate as the reviewer account.
- pr-reviewer.md: added curl allow, denied MCP write tools, added
curl-based review/comment API patterns with FORGEJO_REVIEWER_PAT
- pr-review-pool-supervisor.md: passes all 3 reviewer creds, documents
READ-via-MCP/WRITE-via-curl split
- product-builder.md: passes FORGEJO_REVIEWER_PASSWORD to review pool
- Added FORGEJO_REVIEWER_PASSWORD to Section 6.17 env table and Appendix C
- Purged all remaining "self-approval"/"shared bot account" language from spec
- Updated Sections 8.3.2 and 8.3.3 for dual-account architecture
- Added v1.31.0 revision entry
Solves the "shared bot account problem" by introducing a separate Forgejo
reviewer account (FORGEJO_REVIEWER_PAT / FORGEJO_REVIEWER_USERNAME).
- pr-reviewer.md: rewrote review protocol to use reviewer credentials,
formal APPROVED reviews are now the primary path (not a workaround)
- pr-review-pool-supervisor.md: passes reviewer credentials to dispatched reviewers
- pr-merge-pool-supervisor.md: updated approval detection to recognize
reviewer account as primary approver
- product-builder.md: passes reviewer creds when launching review pool
- shared/credential_security.md: added FORGEJO_REVIEWER_PAT and
FORGEJO_REVIEWER_USERNAME to required credentials
Per Subagent Specialization Principle: removed 17 duplicated rolling
average calculation blocks from all supervisors. The ATM now handles
interval calculation internally via --sleep-interval-default parameter.
- automation-tracking-manager.md: added sleep_interval_default to CREATE_TRACKING_ISSUE,
added CYCLE_ANNOUNCEMENT_REVIEW operation (#11)
- All 17 supervisor agents: replaced 7-line interval calc with --sleep-interval-default param
- shared/tracking_discovery_guide.md: updated to reference ATM-handled interval
Added the **Estimated Cycle Interval** field to the actual tracking body
template strings in all 14 agents that had inline body strings without it.
Fixed 2 non-standard body formats (project-owner had [HEALTH] header,
bug-hunt had no header). All 18 status-creating agents now produce tracking
issues with the standardized header including the interval field.
- Added v1.27.0 entry: all 17 agents fixed with correct READ-before-CREATE order
- All agents now include rolling average interval defaults and Estimated Cycle Interval requirement
All 17 supervisor/orchestrator agents had CREATE_TRACKING_ISSUE before
READ_TRACKING_STATE in their tracking operations reference. This wrong
ordering causes agents to destroy state before recovering it. Fixed all
to: READ (recover state) -> calculate rolling interval -> CREATE (new issue).
Each agent now includes:
- Startup recovery with READ_TRACKING_STATE as step 1
- Rolling average interval calculation with agent-specific defaults
- Note that tracking body MUST include Estimated Cycle Interval field
- automation-tracking-manager.md: added estimated_cycle_interval to READ_TRACKING_STATE return
- system-watchdog-pool-supervisor.md: replaced hardcoded interval lookup with parsing from
status issue body, changed staleness threshold from 1.2x to 2x
- backlog-grooming-pool-supervisor.md: added Pass 20 for duplicate status issue deduplication
- shared/tracking_discovery_guide.md: added rolling average calculation pattern
- automation-tracking-manager.md: enhanced READ_TRACKING_STATE to return full
comments, creation timestamp, and offline duration for crash recovery
- implementation-pool-supervisor.md: added state recovery as mandatory first
action (before PR analysis), with branch/PR target extraction and resume logic
- product-builder.md: replaced manual curl state detection with ATM
READ_TRACKING_STATE for consistent crash recovery
- shared/tracking_discovery_guide.md: added mandatory startup recovery protocol
documenting the correct read-then-delete-then-create sequence
HAL9000
clever-agent