2471 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	33672ce805	fix(lsp): restore secure ASCII decoding, top-level LspError import, printable-ASCII guard	2026-05-15 03:08:39 +00:00
HAL9000	dbc382f3d9	Fix TypeError in infer_resource_slots() when properties is null ... Fixed MCPToolAdapter.infer_resource_slots() to handle null values in JSON Schema by using instead of which returned None when the key exists with a null value. The @tdd_expected_fail tag was removed from TDD issue #10470 since the fix is now applied.	2026-05-15 02:41:37 +00:00
HAL9000	fa95c518d5	fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render ... Rename ActorSelectionOverlay._render() to _refresh_display() to avoid shadowing Textual's Widget._render(), fixing a crash in textual >=1.0 where get_content_height() would receive None and raise AttributeError. ISSUES CLOSED: #11039	2026-05-15 00:56:08 +00:00
HAL9000	ef6829b6f8	chore(lint): remove unused pathlib.Path import in llm_actors.py	2026-05-15 00:34:30 +00:00
HAL9000	a37b4e0ccb	fix(security): use relpath containment instead of startswith to prevent prefix-collision bypass	2026-05-14 23:59:01 +00:00
HAL9000	4fdfee6150	fix(security): fix file_tools.py validate_path startswith bypass #7478 ... Replace string-based startswith() path traversal guards with robust Path.relative_to() across three files to prevent prefix-collision bypass attacks. The old checks using str(target).startswith(str(root)) could be evaded by paths like /tmp/abc123-escape when root is /tmp/abc123. Files patched: - src/cleveragents/skills/builtins/file_ops.py (validate_sandbox_path) - src/cleveragents/resource/handlers/_base.py (_safe_resolve) - src/cleveragents/application/services/llm_actors.py (_write_to_sandbox) ISSUES CLOSED: #7478	2026-05-14 23:37:32 +00:00
CoreRasurae	b41f536da6	fix(automation): respect automation profile gates in lifecycle service and async jobs ... Add BDD regression tests for issue #4328 automation profile gates Tests verify that complete_strategize() and complete_execute() respect automation profile thresholds and do NOT unconditionally call auto_progress(). Covers 8 built-in profiles: manual, full-auto, supervised, auto, review_before_apply, ci, trusted ISSUES CLOSED: #4328	2026-05-14 22:57:11 +00:00
HAL9000	2f29f8352f	chore: resolve merge conflicts and apply cosmetic fixes ... - Resolve CHANGELOG.md conflict to include both entries, referencing issue #8164 instead of PR #11161 - Resolve CONTRIBUTORS.md conflict, fix leading space in new entry - Remove duplicate create_sequence_node function (dead code) Merges master into feat/structural-output-validation branch	2026-05-14 18:14:48 +00:00
hurui200320	cc8e013f9b	fix(actor): handle nested actor type and combined config.actor field in v3 YAML ... Two defects in ActorConfiguration._extract_v3_actor() prevented YAML files using the spec-canonical nested actors map format from being registered: Defect A: The method looked for the 'type' field inside the 'config:' block (config_block.get('type')) instead of at the actor-entry level (first_entry.get('type')). Because the spec places 'type' at actors.<name>.type — a sibling of 'config:', not a child of it — the v3 detection branch never fired for nested-actors-map YAMLs, causing _extract_v3_actor() to return (None, None, None, False) immediately. Defect B: Even if the type was found, the method only consulted separate config.provider and config.model keys; it never parsed the combined config.actor: 'provider/model' shorthand. Without the combined-field fallback, provider and model remained None for all spec-canonical YAMLs that use the shorthand, causing from_blob() to raise 'BadParameter: provider is required'. Both defects had to be fixed together because Defect A blocked the code from ever reaching the path where Defect B would otherwise have been encountered. The combined-format parser (config.actor split on first '/') is inserted after the explicit config.provider / config.model lookups so that explicit separate fields always take precedence over the shorthand when both are present. Parsing logic extracted into _parse_combined_actor_field() helper to eliminate DRY violation. Both provider and model halves validated consistently (empty provider half was previously silently inferred). Adds Behave scenarios covering: nested actors map + combined config.actor (success), explicit config.provider precedence over config.actor, explicit config.model precedence over config.actor, genuinely missing provider/model raising validation error, and malformed combined values (empty model half, empty provider half, missing delimiter). Adds a Robot integration test for the combined-actor YAML path with provider/model assertions via show. Restores accidentally deleted TOOL and GRAPH Robot integration tests. Mirrors provider/model extraction in step_run_actor_update for assertion step compatibility. ISSUES CLOSED: #11189	2026-05-14 08:10:58 +00:00
HAL9000	8c5dbf3f33	chore(contributors): add ACMS hot_max_tokens fix detail entry ... Adds contributor detail line for Hamza Khyari's ACMS execute-phase context assembler project-level budget override fix. ISSUES CLOSED: #11035	2026-05-14 07:13:24 +00:00
HAL9000	6d46baf552	fix: apply ruff format to step definitions file	2026-05-14 06:46:27 +00:00
HAL9000	ac81ea2ceb	fix: replace Scenario Outline with literal steps to fix Behave-parallel parameter substitution bug ... The Behevare-parallel runner in this project does not support inline parameter substitution for '{param}' or '<param>' markers within Scenario Outline Examples. All 4 original Scenario Outlines were failing because parameters were not being substituted, causing UndefinedStep and ValueError failures. Fix: Convert all Scenario Outline scenarios to regular Scenarios with explicit literal step definitions. Each unique Gherkin line gets its own @Given/@When/@Then step definition matching the exact string. Also fix pre-existing bugs identified in PR review #8719: - Fix undefined step by quoting {{seq}} in feature (line 46) - Fix ctx.decision_result → ctx.validation_result context variable (line 184) - Fix ctx.struct_result → ctx.validation_result context variable (line 210) - Replace # type: ignore[arg-type] with proper Callable[[Any], dict] type - Add missing literal step definitions for structured_output tests ISSUES CLOSED: #11161	2026-05-14 06:46:27 +00:00
freemo	80d27df9cc	fix(changelog): correct PR #11161 references in CHANGELOG.md and CONTRIBUTORS.md ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
freemo	b092ccac49	fix(ci): apply ruff formatting to validation.py and step definitions ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
freemo	cdafcf73cf	fix: detect duplicate sibling sequences in validate_plan_tree ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
freemo	b59b2508af	fix(ci): resolve remaining lint errors in __init__.py and step definitions ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
CleverAgents Bot	dce30e85a2	fix(ci): resolve lint and typecheck failures in structural validation module ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
HAL9000	f8e4f4a579	feat: implement structural component output validation ... Replace exact character matching with structural component checking for output validation. Implements three validators covering plan tree output, decision CLI dicts, and structured session snapshots. - validate_plan_tree: validates node dicts for required keys (decision_id, type, sequence, question, children), ULID format, correct types, and sibling ordering - validate_decision_dict: validates decision CLI output against Decision.as_cli_dict() schema with field presence, type, ULID, confidence range [0..1], bool fields - validate_structured_output: validates StructuredOutput envelope for command, session_id (ULID), status membership, exit_code, elements integrity - validate_structured_component_output: unified dispatcher by target_type BDD tests in features/structural_validation.feature. ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
HAL9000	c768e8c4f5	fix(lsp): cleanup subprocess on failed initialization in StdioTransport.start()	2026-05-14 06:40:27 +00:00
hurui200320	39f9903f1a	fix(tests): restore agent-evolution-pool-supervisor.md or remove its orphaned BDD scenarios ... Chose Option B (fallback): remove orphaned BDD scenarios for two retired agents. Commit 3c8cf601 deleted .opencode/agents/agent-evolution-pool-supervisor.md and .opencode/agents/implementation-pool-supervisor.md as part of a large-scale restructuring of agent definition files. However, their corresponding Behave feature files and step definitions were not cleaned up, causing nox -s unit_tests to fail with AssertionError on master. Removed files: - features/agent_evolution_pool_supervisor_metadata.feature (7 scenarios testing agent-evolution-pool-supervisor.md existence and content) - features/steps/agent_evolution_pool_supervisor_metadata_steps.py (382 lines of step definitions for the above feature) - features/pr_compliance_pool_supervisor.feature (10 scenarios testing implementation-pool-supervisor.md existence and content) - features/steps/pr_compliance_pool_supervisor_steps.py (219 lines of step definitions for the above feature) Both agent definition files were permanently retired by the restructuring commit and are not expected to return. Keeping orphaned tests that assert on deleted files is not valid; removal is the correct resolution per the project's handling of obsolete tests policy. Quality gates verified: - nox -s unit_tests: 694 features passed, 0 failed (was failing on master) - nox -s lint: all checks passed - nox -s typecheck: 0 errors, 3 warnings (pre-existing import warnings) - nox -s coverage_report: 96.5% (meets 96.5% threshold) - nox -s integration_tests: 1998 tests passed, 0 failed ISSUES CLOSED: #11208	2026-05-14 04:16:04 +00:00
Rebase Agent	a61a418b26	build: updated opencode.json	2026-05-13 21:41:15 -04:00
Rebase Agent	ecd0a94be4	build: got auto-agents to a working state with deterministic starting	2026-05-13 21:39:05 -04:00
Rebase Agent	3c8cf60110	build: got auto-agents to a working state with deterministic starting	2026-05-13 21:14:25 -04:00
brent.edwards	d31d9226f9	test(wf10_batch.robot): request that LLM not create files (#11133) ... Closes: #11007 ## Description Asks LLM to not create files. ## Type of Change - [ X ] Bug fix (non-breaking change which fixes an issue) - [ X ] Test improvements ## Quality Checklist - [ ] Code follows the project's coding standards (see CONTRIBUTING.md) - [ ] All public/protected methods have argument validation - [ ] Static typing is complete (no `Any` unless justified) - [ ] `nox -s typecheck` passes with no errors - [ ] `nox -s lint` passes with no errors - [ ] Unit tests written/updated (Behave scenarios in `features/`) - [ ] Integration tests written/updated (Robot suites in `robot/`) if applicable - [ ] Coverage remains above 85% (`nox -s coverage_report`) - [ ] No security issues introduced (`nox -s security_scan`) - [ ] No dead code introduced (`nox -s dead_code`) - [ ] Documentation updated if behavior changed ## Testing Running in git.cleverthis.com is the only real test possible. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues Closes #11007 Reviewed-on: #11133 Reviewed-by: Hamza Khyari <hamza.khyari@cleverthis.com>	2026-05-13 23:39:15 +00:00
HAL9000	f5761912db	fix(ci): make benchmark-regression resilient to missing S3 baselines ... Squash of two overlapping fixes that both addressed ASV benchmark-regression CI failures due to missing S3 baseline data:> 1. Make the job skip when no S3 baseline exists (e0239ef) > 2. Add baseline check logic with .benchmark-baseline file (2d628bd)> Combined approach detects S3 availability, creates baseline marker file, and gracefully skips regression when no baselines are available rather than failing. Also updates ASV config and noxfile to support this resilience ISSUES CLOSED: #10378	2026-05-13 12:24:33 +00:00
HAL9000	4099872acd	fix(events): restore exc_info=True in handler error logging ... The exc_info=True parameter was accidentally removed from the event_handler_failed logging block during a previous formatting cleanup. This restores it to include full exception tracebacks in warning logs, which is required by existing integration tests. Refs: #10378	2026-05-13 12:24:33 +00:00
HAL9000	3459f821c5	fix(events): add close() method to ReactiveEventBus to complete RxPY subject ... Add _closed flag and close() method to ReactiveEventBus to complete the RxPY Subject, preventing subscriber resource leaks. close() is idempotent and raises RuntimeError when called on a closed bus. Also adds: - emit() guard against post-close calls (RuntimeError) - __enter__/__exit__ context manager protocol for automatic cleanup - BDD scenarios in event_bus.feature and TDD tests in tdd_reactive_event_bus_close.feature ISSUES CLOSED: #10378	2026-05-13 12:24:33 +00:00
CoreRasurae	3fcfaee02d	feat(mcp): implement StdioMCPTransport for JSON-RPC 2.0 stdio communication ... Implements concrete StdioMCPTransport class that: - Spawns MCP server as subprocess and communicates via JSON-RPC 2.0 over stdio - Performs MCP handshake (initialize + notifications/initialized) - Supports tools/list and tools/call methods - Uses RLock for thread-safe concurrent access - Auto-selected when transport='stdio' in MCPServerConfig Adds BDD tests for stdio transport covering: - Connection lifecycle and error handling - Tool discovery and invocation - MCPToolAdapter integration ISSUES CLOSED: #4918	2026-05-13 07:13:34 +00:00
HAL9000	3368cba38f	refactor(a2a): execute ACP to A2A module rename and symbol standardization (#10583) ... Executes the systematic ACP -> A2A module rename per ADR-047. - Renamed all legacy ACP references to A2A throughout cleveragents.a2a module - Standardized all 22 exported symbols to A2A naming conventions - Added BDD test suite validating export completeness, zero ACP remnants, and documentation accuracy Closes #10583 Parent Epic: #8569 (A2A Standard Adoption)	2026-05-13 06:49:40 +00:00
HAL9000	09c79eab73	chore(deps): upgrade PyYAML to address known security vulnerability (#9244) ... - Add explicit `pyyaml>=6.0.3` constraint to pyproject.toml dependencies with a security comment - Add a `\#\#\# Security` section to CHANGELOG.md documenting this dependency constraint update - Verify no unsafe yaml.load() calls exist in the codebase Co-authored-by: HAL 9000 <hal9000@cleverthis.com> ISSUES CLOSED: #9055	2026-05-13 06:01:19 +00:00
brent.edwards	8ae754961a	test(noxfile.py): turn off bold and colors (#11172) ... ISSUES CLOSED: #11134 ## Description This turns off bold and colors in the terminal, making the output much easier to find substrings. ## Type of Change - [ X ] Bug fix (non-breaking change which fixes an issue) - [ X ] Test improvements ## Quality Checklist - [ ] Code follows the project's coding standards (see CONTRIBUTING.md) - [ ] All public/protected methods have argument validation - [ ] Static typing is complete (no `Any` unless justified) - [ ] `nox -s typecheck` passes with no errors - [ ] `nox -s lint` passes with no errors - [ ] Unit tests written/updated (Behave scenarios in `features/`) - [ ] Integration tests written/updated (Robot suites in `robot/`) if applicable - [ ] Coverage remains above 85% (`nox -s coverage_report`) - [ ] No security issues introduced (`nox -s security_scan`) - [ ] No dead code introduced (`nox -s dead_code`) - [ ] Documentation updated if behavior changed ## Testing I ran `nox -e unit_tests` locally, and I verified that the seven errors that had existed no longer exist. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues ISSUES CLOSED: #11134 ## Implementation Notes This change to the terminal had been done outside the program in git.cleverthis.com, so the problems never showed up there. Reviewed-on: #11172 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-05-12 21:06:23 +00:00
freemo	9cfa1dd1d7	fix(subplan): propagate invariant_enforced decisions to child plans on spawn ... SubplanService.spawn() now re-records all invariant_enforced decisions from the parent plan decision tree onto each child plan decision tree. This satisfies the spec requirement: 'recorded as invariant_enforced decisions that propagate to child plans.' (Glossary → Invariant) Previously, child plans started Strategize with a completely empty invariant set, violating the spec's propagation requirement. non_overridable global invariants enforced on the parent were not guaranteed to be enforced on child plans. The fix adds _propagate_invariant_decisions() to SubplanService which queries the parent plan's invariant_enforced decisions and re-records each one on the child plan using DecisionService.record_decision(). The DecisionService is already injected into SubplanService, so no new dependencies are required. BDD regression coverage added in features/tdd_invariant_propagation_subplan.feature with 4 scenarios covering: single invariant propagation, multiple invariant propagation, non_overridable invariant propagation, and clean spawn with no parent invariants. ISSUES CLOSED: #9131	2026-05-12 16:45:59 +00:00
CoreRasurae	3b83438e7d	test(actor): add regression test for issue 4321 nested config extraction ... Add BDD regression test for Forgejo issue 4321: ActorRegistry.add() fails to extract provider and model from nested actor config. The test verifies that when type is only at the nested actors map level (not at top level), provider and model are correctly extracted from the nested config block. This scenario is already handled correctly by the _extract_nested_v3_config() function added in commit 78be0887 (issue #4300). The test confirms the fix works as expected and prevents future regressions. Tags: @tdd_issue @tdd_issue_4321 ISSUES CLOSED: #4321	2026-05-12 13:02:59 +00:00
hamza.khyari	1e385b8f61	Merge pull request 'feat(agents): add review-started notification to pr-review-worker' (#11029) from feature/review-started-notification into master ... Reviewed-on: #11029 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-05-12 12:29:39 +00:00
hamza.khyari	f37bfa01fe	feat(agents): add review-started notification to pr-review-worker ... Add Step 0 to both first_review and re_review modes — posts a comment on the PR immediately after parameter validation, before any reading or cloning. Gives the PR author instant visibility that a review is in progress. CI flag mode is unchanged (too lightweight to warrant a notification). ISSUES CLOSED: #11028	2026-05-12 12:11:12 +00:00
hamza.khyari	d82f5de2eb	Merge pull request 'feat(agents): add work-started notification to task-implementor' (#11032) from feature/impl-started-notification into master ... Reviewed-on: #11032 Reviewed-by: Rui Hu <rui.hu@cleverthis.com>	2026-05-12 12:06:44 +00:00
CoreRasurae	39bbff0849	feat(agents): add work-started notification to task-implementor ... Add Step 2 (notification) to issue_impl and pr_fix procedures — posts a comment on the issue/PR after reading it but before cloning, giving authors instant visibility that implementation work has started. Also update CHANGELOG.md with entry for #11031. ISSUES CLOSED: #11031	2026-05-12 11:47:15 +00:00
hurui200320	52830971f2	fix(plan): guard cleanup_stale against execute/complete plans awaiting apply ... Bug #11121: _create_sandbox_for_plan() called GitWorktreeSandbox.cleanup_stale() unconditionally, destroying the cleveragents/plan-<id> git branch when agents plan execute was re-invoked on a plan already in execute/complete state (awaiting apply). This caused plan apply to find zero artifacts. Fix: Add a phase/state guard inside _create_sandbox_for_plan() that returns the flat fallback early when the plan is execute/complete, preserving the worktree branch intact for plan apply to merge. - TDD regression test from issue #11120 (without @tdd_expected_fail) - Verified sandbox lifecycle tests still pass ISSUES CLOSED: #11121	2026-05-12 10:17:39 +00:00
hurui200320	9fe69c468c	test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply ... Add two Behave scenarios tagged @tdd_issue, @tdd_issue_11121, and @tdd_expected_fail that capture bug #11121: _create_sandbox_for_plan() calls GitWorktreeSandbox.cleanup_stale() unconditionally on every execute invocation, including when the plan is already in execute/complete state awaiting apply. Scenario 1 asserts that the cleveragents/plan-<id> branch survives a second call to _create_sandbox_for_plan() on an execute/complete plan. This assertion fails because cleanup_stale deletes the branch regardless of plan state. Scenario 2 asserts that plan apply would find at least one artifact after a re-invoked execute on an execute/complete plan. This assertion fails because the branch (holding execute output) was destroyed by cleanup_stale. Both scenarios use @tdd_expected_fail so CI passes while the bug is unfixed. The @mock_only tag ensures no database is created for these git-only tests. The companion fix is tracked in issue #11121. Additional CI fixes bundled in this commit: - Fixed PlanGenerationGraph recursion bug: _should_retry() was mutating state in-place but LangGraph conditional edge functions cannot persist state mutations. Replaced with a proper _handle_retry() node that increments retry_count via state returns, resolving the GraphRecursionError that was crashing the integration tests. Updated the graph to include handle_retry as the 5th node, routing validate→should_retry→handle_retry→analyze. - Fixed TDD quality gate (scripts/tdd_quality_gate.py): Renamed @tdd_bug_N tags to @tdd_issue_N to match the CONTRIBUTING.md specification. Added _diff_is_tdd_issue_capture() detection so that TDD issue-capture PRs (which add @tdd_expected_fail rather than remove it) pass the quality gate correctly. Updated all related tests (Behave unit tests, Robot integration tests, and test helpers) to use the new tag naming. ISSUES CLOSED: #11120	2026-05-12 16:57:50 +08:00
hurui200320	d25a060c58	Revert "feat(ci): implement TDD bug tag quality gate for bug fix PRs" ... This reverts commit e8d2f76466.	2026-05-12 08:30:24 +00:00
freemo	d1328e562f	Fix validation bypass for code longer than 10 characters — the length fallback was overriding LLM-based FAIL verdicts and rendering validation ineffective	2026-05-12 02:16:48 +00:00
hurui200320	b4a514e0f4	fix(cli): add spec-required --data-dir, --config-path, and -v global options to main_callback ... Implements ADR-021 §Global CLI Flags and ADR-024 §Resolution Chain. All three global options were missing from main_callback(), causing any invocation with these flags to crash with 'No such option'. Changes: - src/cleveragents/cli/main.py * Add _VERBOSITY_LOG_LEVELS tuple mapping verbose count to log levels (0=CRITICAL/silent, 1=ERROR, 2=WARNING, 3=INFO, 4=DEBUG, 5+=DEBUG) * Add --data-dir PATH option: validates path is a directory if it exists, sets CLEVERAGENTS_DATA_DIR env var, resets Settings singleton * Add --config-path PATH option: validates file exists and is a file, sets CLEVERAGENTS_CONFIG_PATH env var for ConfigService to pick up * Add -v (count=True) option: wires verbose count to configure_structlog * Store all three values in ctx.obj for subcommand access * Update _print_basic_help() to include the three new global options so 'cleveragents --help' (fast path) also lists them * In the catch-all Exception handler, print the original exception type+message directly to err_console so actionable details remain visible even when log level is CRITICAL (e.g. 'No such option') - src/cleveragents/application/services/config_service.py * ConfigService.__init__ now checks CLEVERAGENTS_CONFIG_PATH env var when no explicit config_path is passed, completing the resolution chain for --config-path CLI override Tests (all passing): - features/cli_global_options.feature (21 Behave scenarios) - features/steps/cli_global_options_steps.py - robot/cli_global_options.robot (8 Robot Framework integration tests) - robot/helper_cli_global_options.py Quality gates: lint ✓ typecheck ✓ unit_tests ✓ integration_tests ✓ Coverage: 96.52% (threshold 96.5% ✓) ISSUES CLOSED: #6785	2026-05-12 01:05:10 +00:00
CoreRasurae	e8d2f76466	feat(ci): implement TDD bug tag quality gate for bug fix PRs ... Add an automated quality gate that enforces TDD bug fix workflow rules on pull requests. The gate parses PR descriptions for bug-closing keywords (Closes/Fixes/Resolves #N, ISSUES CLOSED: #N), searches the codebase for corresponding TDD tests tagged @tdd_bug_N, and verifies that @tdd_expected_fail tags have been removed. Key components: - scripts/tdd_quality_gate.py: Main quality gate script with PR description parsing, TDD test discovery, and tag removal verification. All public functions validate arguments fail-fast and are statically typed. - noxfile.py: New tdd_quality_gate session that reads PR_DESCRIPTION from the environment and runs the quality gate script. - .forgejo/workflows/ci.yml: New tdd_quality_gate CI job that runs only on pull_request events, passing the PR body as PR_DESCRIPTION. - features/tdd_quality_gate.feature: 46 Behave scenarios covering PR parsing, TDD test search, tag removal verification, full gate logic, robot diff handling, edge cases, argument validation, bool guards, co-located bug false-positive guard, and main() CLI entry point. - features/steps/tdd_quality_gate_steps.py: Step definitions for all Behave scenarios using temporary directories for isolation. - robot/tdd_quality_gate.robot: 15 Robot Framework integration tests exercising the gate end-to-end via a helper subprocess. - robot/helper_tdd_quality_gate.py: Helper script for Robot tests with sentinel-based sub-commands. Review-round fixes applied: - check_expected_fail_removed now uses _contains_tag_token for word-boundary matching (avoids false positives on partial tag names) - Diff expected-fail removal detection tracks flags at file level instead of per-hunk (fixes false negatives when tags span hunks) - parse_bug_refs filters out issue number zero - Redundant double error reporting eliminated (file-level check short-circuits the diff-level check) - run_quality_gate returns (errors, bug_refs) tuple to avoid redundant re-parsing in main() - Regex compilation cached via functools.lru_cache - Nox session no longer installs the full project (stdlib only) - CI checkout uses fetch-depth: 0 for reliable merge-base resolution Review-round 2 fixes applied: - _diff_has_expected_fail_removal_for_bug now requires the removed line to contain both the expected-fail tag and the specific bug tag (fixes false positives when two bugs share the same test file) - check_expected_fail_removed error messages use the correct tag prefix per file type (@tdd_bug_N for .feature, tdd_bug_N for .robot) - bool values rejected by bug-number validation guards in find_tdd_tests, check_expected_fail_removed, and _diff_has_expected_fail_removal_for_bug - File-read error handling catches UnicodeDecodeError alongside OSError (root-safe unreadable-file handling via invalid-UTF-8 test fixture) - Temp directory cleanup added to after_scenario hook in environment.py - 8 new Behave scenarios: bool type guards (2), co-located bug false-positive regression (1), run_quality_gate argument validation (3), and main() CLI entry point exit codes (2) Review-round 3 fixes applied: - Synthetic PR diff helper (_default_pr_diff_for_bug_refs) now auto-detects .robot vs .feature file type from the temp search tree and generates the matching diff format (fixes under-tested robot-format diff code path in multi-bug integration scenarios) - check_expected_fail_removed test step now filters files by bug tag via find_tdd_tests before checking (matches production path in run_quality_gate) - after_scenario temp directory cleanup no longer sets context.temp_dir = None (fixes cleanup conflict with cli_init_yes_flag_steps.py cleanup functions that run after hooks) - 2 new Behave scenarios: multi-line PR description parsing, and non-string pr_diff type guard for run_quality_gate ISSUES CLOSED: #629	2026-05-12 00:22:49 +01:00
clever-agent	dd763f50d9	build: moved e2e tests to master only yaml	2026-05-11 17:35:41 -04:00
clever-agent	81229422f2	Revert "ci(docker): Ensure CI uses CT docker proxy to workaround Docker ratelimit issues" ... This reverts commit 9c5f19854d.	2026-05-11 17:22:45 -04:00
HAL9000	b692894c88	fix(tests): remove AmbiguousStep conflict in security_pyyaml_dependency_steps ... Duplicate step definitions for 'the pyproject.toml file exists at', 'I read the project dependencies from pyproject.toml', 'I attempt to import the module', and 'the import should succeed without errors' were present in both security_pyyaml_dependency_steps.py and tdd_a2a_sdk_dependency_steps.py, causing a behave.AmbiguousStep error that failed the unit_tests CI gate. Removed the 4 duplicate step definitions from security_pyyaml_dependency_steps.py, keeping only the 3 PyYAML-specific step definitions. The shared steps are now exclusively provided by tdd_a2a_sdk_dependency_steps.py. Also resolved merge conflicts from master in CONTRIBUTORS.md: preserved all master additions (database resource types entry) alongside the existing PyYAML upgrade entry. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	2f01e7d625	fix(tests): resolve lint format failure and harden pyyaml BDD step path resolution ... - Move _flatten_toml_dict to module level: eliminates nested function definition that ruff format reformats unexpectedly; makes the helper independently testable and clearly documented. - Rename helper to _flatten_toml_dict (was _flatten) for unambiguous module-level identity and improved readability. - Add _PROJECT_ROOT constant computed from __file__ so pyproject.toml is always resolved via an absolute path regardless of the process working directory — fixes brittle relative-path lookup that fails when behave-parallel forks workers whose cwd differs from the repo root. - Fix ruff format violations: wrap long assert message, normalise decorator quote style, ensure trailing newline, fix import ordering (behave imports before packaging). - All quality gates pass: lint, format --check, security_scan, dead_code. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	63746b4d30	fix(pyyaml): address CI review feedback from PR #11012 ... - Fix ruff lint F541 error: remove unnecessary f-string prefix - Remove dead step_uv_lock_specifier step (never called by BDD scenarios) - Update CONTRIBUTORS.md to reference correct PR number (#11012 not #9244) ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	05acc26c40	chore(deps): upgrade PyYAML to address known security vulnerability ... - Added `pyyaml>=6.0.3` dependency constraint to pyproject.toml after aiohttp to prevent installation of vulnerable older versions with known YAML parsing security issues. - Updated uv.lock package dependencies and requires-dist to include pyyaml entry with specifier '>=6.0.3'. - Added changelog Security section entry under [Unreleased] documenting the upgrade for issue #9055. - Updated CONTRIBUTORS.md with contribution note (PR #9244). - Added BDD test scenario verifying PyYAML security dependency constraint. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	a1ea40d2e7	feat(plans): implement agents plan rollback command for checkpoint-based rollback ... Documents the agents plan rollback command (CLI entry at src/cleveragents/cli/commands/plan.py) that was integrated into master under Epic #8493. The command provides checkpoint-based plan state restoration, allowing plans to be restored to a previous checkpoint and resuming execution from that point. CHANGELOG.md entry added under [Unreleased] > ### Added section; CONTRIBUTORS.md updated with HAL 9000's contribution for this checkpoint-based rollback feature. ISSUES CLOSED: #8557 Epic: #8493	2026-05-11 06:54:32 +00:00