1913 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	155e5dd586	fix(tests): correct indentation in actor_loading.feature ... Fixed Gherkin syntax error where the 'LLM actor without tools' scenario had incorrect indentation (3 spaces instead of 2), which prevented the feature file from being parsed correctly by Behave. This was causing the concurrency test scenario to fail during test discovery. ISSUES CLOSED: #8588	2026-04-14 00:16:06 +00:00
HAL9000	6a9b0eb901	fix(actor): move namespace filter inside lock in ActorLoader.list_actors	2026-04-13 21:53:48 +00:00
clever-agent	c5afe1f3a7	Build: Made the prompts coming from the product builder to the async subagent more clear to avoid issues in the future	2026-04-13 16:14:24 -04:00
clever-agent	c5820266fd	Build: improced merge agent logic to ensure faster and more effective merging into master	2026-04-13 15:30:00 -04:00
clever-agent	5a9aaa79ed	Build: Reinforced label enforcement, and ensure implementation workers dont continue work on a mergable PR.	2026-04-13 13:54:43 -04:00
clever-agent	16883859b1	Build: some fixes to the automation tracking tickets ensuring they get cleaned up and handled more correctly, and announcements read in a more useful way	2026-04-13 13:00:23 -04:00
HAL9000	978849412d	docs(reference): align A2A facade API with implementation ... Fixes docs/reference/a2a.md Local Facade section. Issues #6620 and #6624. Fixes #6620 Fixes #6624 Automatically merged by PR Merge Pool Supervisor [AUTO-PRMRG-SUP] --- **Automated by CleverAgents Bot** Supervisor: PR Merge | Agent: pr-merge-pool-supervisor Co-authored-by: CleverThis <hal9000@cleverthis.com> Co-committed-by: CleverThis <hal9000@cleverthis.com>	2026-04-13 08:10:03 +00:00
hurui200320	2005b8ef82	feat(tests): replace all @skip tags with proper @tdd_expected_fail tags or remove them across the entire codebase (#7221) ... ## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-04-13 04:56:01 +00:00
clever-agent	96ff9d0ff8	build:added some excplict priorities	2026-04-12 23:45:01 -04:00
clever-agent	d5446081e3	build: improved the way the project rules are disseminated	2026-04-12 22:33:40 -04:00
clever-agent	56a430d31f	refactor(agents): rename backlog-grooming to grooming, fix tier selector dispatch ... Renamed backlog-grooming-pool-supervisor to grooming-pool-supervisor and backlog-grooming-worker to grooming-worker. The grooming agents now analyze all open issues AND pull requests (not just the backlog). Workers perform a full 10-point quality analysis on a single item instead of processing batches. PRs with unaddressed reviews are prioritized. PR labels are synced from linked issues. Workers post [GROOMED] markers for tracking. Fixed critical issue: implementation-pool-supervisor now correctly dispatches workers through tier selectors (tier-haiku/codex/sonnet/opus) instead of launching implementation-worker directly, ensuring the escalation model actually sets the correct model tier. Added implementation-worker to all four tier selector task permissions. Updated session tags from AUTO-BLOG to AUTO-GROOM. Updated specification sections 4.2.1, 5.5, 5.5.1, 9.7, and architecture diagram. ISSUES CLOSED: n/a	2026-04-12 22:33:40 -04:00
HAL9000	a3094dea2b	docs(spec): clarify path containment, datetime, and plugin security contracts ... Three implementation contracts clarified in response to security/correctness bugs surfaced by the bug hunt pool: 1. Path containment: Sandbox path validation MUST use Path.is_relative_to() not string prefix comparison. String prefix allows /tmp/sandboxmalicious to pass a /tmp/sandbox root check. Canonical implementation provided. 2. Datetime handling: All stored ISO timestamp comparisons MUST parse back to timezone-aware datetime objects before comparing. String comparison of ISO timestamps is incorrect when timezone offsets differ in format. Canonical parse_utc_ts() pattern provided. 3. Plugin protocol validation: Protocol compliance MUST be checked structurally via issubclass() — never by instantiating the plugin class. Instantiation runs __init__ side effects before the plugin is approved. These are minor clarifications (implementation contracts, not architectural changes) added to the existing Security and Extensibility sections. Refs: BUG-HUNT issues #7336 (path traversal), #7341 (datetime comparison), #7331 (plugin instantiation)	2026-04-13 00:44:44 +00:00
clever-agent	1ba4d1a0b3	build: improved the product verifier to make it a bit more effecient	2026-04-12 19:58:05 -04:00
clever-agent	8692bb46e5	build: Refactored agent definitions to be simpler and less contention	2026-04-12 19:24:50 -04:00
HAL9000	48532de1cd	docs: add context hydration and git worktree sandbox module docs ... - Add docs/modules/context-hydration.md: documents the ACMS context hydration pipeline (context_tier_hydrator) that fixes the empty ContextTierService bug (#1028). Covers hydrate_tiers_from_project, hydrate_tiers_for_plan, file listing strategies, limits, and fragment metadata. - Add docs/modules/git-worktree-sandbox.md: documents the GitWorktreeSandbox class that isolates plan apply changes in a dedicated git branch/worktree and merges back on commit (#4454). Covers full lifecycle, error types, branch naming, and fallback for non-git projects. - Update docs/architecture.md: add Git Worktree Sandbox Apply section and extend ACMS section with context hydration note. - Update mkdocs.yml: add both new module pages to the Modules nav. ISSUES CLOSED: #6841	2026-04-12 16:42:19 +00:00
HAL9000	8b7bdb5edf	Merge pull request 'docs(changelog): move ACMS fix to [Fixed] section and add sandbox root wiring' (#6052) from docs/changelog-acms-fix-4219 into master	2026-04-12 16:34:24 +00:00
HAL9000	c08187f336	docs(changelog): move ACMS fix to [Fixed] section and add sandbox root wiring ... Reclassify the ACMS context tier hydration entry as a bug fix and add the sandbox root wiring item so the changelog matches the behavior shipped in PR #4219 while preserving newer [Unreleased] additions. ISSUES CLOSED: #7628	2026-04-12 16:20:21 +00:00
HAL9000	8dceb2ad02	Merge pull request 'fix(data-integrity): guard validation gate for empty runs' (#7786) from fix/issue-7508-validation-apply-required-fields into master	2026-04-12 08:16:06 +00:00
HAL9000	251759c9b1	chore: add changelog entry and contributor for #7508 validation gate fix ... - Add CHANGELOG.md entry under [Unreleased] ### Fixed for the empty-run guard added to ApplyValidationSummary.all_required_passed - Add HAL 9000 to CONTRIBUTORS.md per CONTRIBUTING.md §PR Process Rule 8	2026-04-12 08:15:49 +00:00
HAL9000	8402279596	fix(data-integrity): fix validation_apply.py all_required_ fields #7508 ... ISSUES CLOSED: #7508	2026-04-12 08:15:49 +00:00
clever-agent	f20fed2173	fix(agents): always launch all 18 supervisors fresh, stop existing sessions first ... Previously the product-builder would adopt existing supervisor sessions from prior runs and skip launching those already running. This caused stale sessions to persist with outdated configuration and context. Now Phase C.0 discovers and gracefully stops all existing supervisor sessions before Phase C.2 unconditionally launches all 18 fresh.	2026-04-12 06:17:57 +00:00
clever-agent	ba416ba25d	build: force reviewers to not use forgejo mcp	2026-04-12 01:47:55 -04:00
clever-agent	27f3a57927	build: removed unused files	2026-04-12 01:29:15 -04:00
clever-agent	35ff97a641	fix(agents): force pr-reviewer to use curl exclusively, block all Forgejo MCP tools ... The pr-reviewer agent was falling back to Forgejo MCP tools for reads instead of using curl, causing actions to be attributed to the wrong user account. This change: - Blocks ALL Forgejo MCP tools (forgejo: '*': deny) instead of only specific write tools - Adds explicit curl-only mandate section with clear explanation - Adds tested curl command reference covering every API operation the reviewer needs (PR details, diffs, issues, CI status, reviews, file contents, posting reviews, posting comments, dismissals) - Adds robots.txt override instruction for our self-hosted instance - Updates all review process steps to reference curl instead of MCP	2026-04-12 04:59:51 +00:00
clever-agent	52c35c8182	fix: pass reviewer-only credentials through the PR review agent chain ... The product-builder now reads FORGEJO_REVIEWER_* env vars and passes them as the sole credentials to pr-review-pool-supervisor, which passes them through to pr-reviewer workers. No agent in the review chain receives the primary bot credentials, preventing accidental self-approvals. Simplifies the reviewer instructions to require formal PR reviews (not just comments) and removes contradictory references to denied MCP write tools.	2026-04-12 04:24:23 +00:00
HAL9000	ca2eaab02d	build: Made PR rule first more explicit for agents	2026-04-11 23:33:52 -04:00
clever-agent	b89b781881	docs(spec): add Section 22 — Division of Responsibilities and Redundancy Model ... Add comprehensive responsibility-first analysis of the entire agent system covering 144 named responsibilities (R-01 through R-144) organized into 8 categories with 29 sub-categories and complete bidirectional cross-references. Key additions: - Section 22.0: Categorized Responsibility Index with navigation guide - Section 7.9: Universal Supervisor Responsibilities (13 shared baseline) - Section 22.145: Redundancy Analysis Summary with depth distribution, highest-redundancy items, most cross-referenced agents, and 5 named redundancy patterns - 30 agent back-reference tables covering ~50 individual agents - Category introductions explaining scope and significance - 6th foundational principle (Defense-in-Depth) added to Section 1.1 Categories: A (Development Lifecycle, 50 items), B (Quality Assurance), C (Ticket Hygiene), D (Architecture), E (Operational Health), F (Human Interaction), G (Strategic Governance), H (Project Standards). ISSUES CLOSED: N/A	2026-04-11 23:03:56 -04:00
HAL9000	c62ae454a2	Merge pull request 'docs(timeline): update schedule adherence Day 100 (2026-04-10)' (#6893) from docs/timeline-day-100-2026-04-10 into master	2026-04-11 03:17:48 +00:00
HAL9000	157b0d6b8c	docs(timeline): update schedule adherence Day 100 (2026-04-10) ... Refresh Day 100 entries using Forgejo telemetry across both cycle snapshots to capture scope expansion, milestone progress, and active session data.\n\n- Update today marker and Gantt update log for Day 100\n- Capture scope expansion metrics and milestone completion percentages\n- Refresh risk register, status summary, and track/milestone forecasts\n- Append Day 100 cycle-2 schedule adherence tables for teams and milestones\n- Note infrastructure changes (review requirement, supervisor additions)\n\nISSUES CLOSED: #6975	2026-04-11 02:52:50 +00:00
HAL9000	fa44d2455d	Merge pull request 'docs: document automation-tracking-manager centralization and expand tracking system docs' (#5289) from docs/automation-tracking-manager-centralization into master	2026-04-11 01:07:34 +00:00
HAL9000	c76433f756	docs(tracking): document automation-tracking-manager centralization	2026-04-11 00:40:19 +00:00
HAL9000	28fcf7a02b	Merge pull request 'docs: add actor context management showcase (remove, export, import)' (#4220) from docs/add-example-actor-context-management into master	2026-04-11 00:16:40 +00:00
HAL9000	39b6fb3fa8	docs: harden backup script example	2026-04-10 23:37:56 +00:00
HAL9000	6523034cb0	docs: add actor context management showcase (remove, export, import) ... Document the CLI-based lifecycle for removing, exporting, and importing named contexts, including JSON import limitations and scripting examples. ISSUES CLOSED: #4409	2026-04-10 23:37:56 +00:00
HAL9000	a3d644ca52	Merge pull request 'docs(timeline): update schedule adherence Day 99 (2026-04-09)' (#5185) from timeline/day-99-2026-04-09 into master	2026-04-10 23:30:47 +00:00
HAL9000	59ce94cd27	docs(timeline): update schedule adherence Day 99 (2026-04-09) ... Refresh timeline for Day 99 with updated gantt charts, status summary, and schedule adherence tables covering bug surge and milestone scope changes. ISSUES CLOSED: #5780	2026-04-10 22:24:17 +00:00
clever-agent	7e66e57c21	docs(spec): final pass — structural integrity audit ... - Fixed duplicate section number: two §2.4 -> renamed first to §2.3.1 - Verified all section cross-references valid - Verified Appendix A model/mode data matches frontmatter (10 samples) - Verified mkdocs.yml navigation entry - Comprehensive stale-name sweep: zero hits across all files - Added v1.36.0 revision entry with final statistics	2026-04-10 21:07:30 +00:00
clever-agent	3a69aef505	docs(spec): twentieth pass achieving spec-wide dual-account coherence ... - Fixed Glossary: HAL9000 definition updated for dual-account architecture - Fixed Section 6.17.2: "two-step" -> "dual-account" in protocol text - Fixed Section 12.1.2: PR Reviewer table, description, and permissions rationale all updated for curl-based dual-account review protocol - Fixed Section 19.5: Security Model rewritten from "single bot account" to dual-account with separate permission scopes per account - Fixed 2 remaining "Two-Step Review Protocol" references - Added v1.35.0 revision entry	2026-04-10 20:59:08 +00:00
clever-agent	05e5b26f2a	docs(spec): nineteenth pass fixing diagram, MCP tool refs, and edit:deny count ... - Fixed Section 6.17.2 diagram: removed orphaned single-account nodes, updated to show curl with FORGEJO_REVIEWER_PAT - Fixed Section 6.17.2 step text: forgejo_create_pull_review -> curl - Fixed edit:deny count from 41 to 42 - Added missing separator after diagram - Added v1.34.0 revision entry	2026-04-10 20:51:37 +00:00
clever-agent	c558972933	fix(agents): fix stale PR Self-Reviewer references in pr-ci-test-fixer ... Renamed 3 "PR Self-Reviewer"/"self-reviewer" references to "PR Reviewer" and updated coordination section for dual-account architecture.	2026-04-10 20:51:28 +00:00
clever-agent	edbb3471b0	docs(spec): eighteenth pass fixing review template gaps and credential completeness ... - Updated Section 6.17 introduction to include FORGEJO_REVIEWER_PASSWORD - Updated Section 6.17 env table descriptions for clarity - Added v1.33.0 revision entry for template and credential fixes	2026-04-10 20:43:55 +00:00
clever-agent	858afa19d3	fix(agents): rewrite review templates to use curl, fix stuck-PR creds, rename title ... - pr-reviewer.md: renamed "PR Self-Reviewer" to "PR Reviewer", rewrote APPROVE and REQUEST_CHANGES templates to use curl with FORGEJO_REVIEWER_PAT instead of denied MCP tools, corrected step ordering (formal review first, backup comment second) - pr-review-pool-supervisor.md: added all 3 reviewer credentials to stuck-PR prompt which was missing them entirely	2026-04-10 20:43:44 +00:00
clever-agent	5dda3a2c43	docs(spec): seventeenth pass documenting MCP token limitation and curl workaround ... - Added Section 6.17.0: MCP Token Limitation — single server-level token, no per-call override, PR Reviewer must use curl for writes - Rewrote Section 21.22: "Total Bash Lockdown" -> "Restricted Bash with curl" - Added READ-via-MCP/WRITE-via-curl operation table - Added v1.32.0 revision entry	2026-04-10 20:37:33 +00:00
clever-agent	bdfd4dd042	fix(agents): implement curl-based reviewer auth for MCP token limitation ... The Forgejo MCP tools authenticate with a single server-level token that cannot be overridden per-call. The PR Reviewer must use curl with FORGEJO_REVIEWER_PAT for write operations (reviews, comments) to authenticate as the reviewer account. - pr-reviewer.md: added curl allow, denied MCP write tools, added curl-based review/comment API patterns with FORGEJO_REVIEWER_PAT - pr-review-pool-supervisor.md: passes all 3 reviewer creds, documents READ-via-MCP/WRITE-via-curl split - product-builder.md: passes FORGEJO_REVIEWER_PASSWORD to review pool	2026-04-10 20:37:21 +00:00
clever-agent	6baf921b52	docs(spec): sixteenth pass adding FORGEJO_REVIEWER_PASSWORD and purging stale language ... - Added FORGEJO_REVIEWER_PASSWORD to Section 6.17 env table and Appendix C - Purged all remaining "self-approval"/"shared bot account" language from spec - Updated Sections 8.3.2 and 8.3.3 for dual-account architecture - Added v1.31.0 revision entry	2026-04-10 20:31:25 +00:00
clever-agent	edd87d4847	fix(agents): add FORGEJO_REVIEWER_PASSWORD and purge stale self-approval language ... - shared/credential_security.md: added FORGEJO_REVIEWER_PASSWORD, fixed comment - shared/merge_safety.md: updated approval docstring + comment for dual-account - implementation-worker.md: updated 2 approval function docstrings - pr-merge-pool-supervisor.md: removed 2 stale self-approval references - pr-reviewer.md: removed stale self-approval error handling text - project-bootstrapper.md: updated branch protection notes for dual-account	2026-04-10 20:31:14 +00:00
clever-agent	fcff61e1b5	docs(spec): fifteenth pass introducing dual-account architecture ... - Rewrote Section 6.17: "Shared Bot Account Problem" -> "Dual-Account Architecture" - New env vars: FORGEJO_REVIEWER_PAT, FORGEJO_REVIEWER_USERNAME - Formal APPROVED reviews are now the primary approval path - Updated Section 6.17.2: "Two-Step" -> "Dual-Account Review Protocol" - Updated Appendix C environment variable table - Added v1.30.0 revision entry	2026-04-10 20:23:55 +00:00
clever-agent	17fbcbeb6e	feat(agents): introduce dual-account architecture for PR reviews ... Solves the "shared bot account problem" by introducing a separate Forgejo reviewer account (FORGEJO_REVIEWER_PAT / FORGEJO_REVIEWER_USERNAME). - pr-reviewer.md: rewrote review protocol to use reviewer credentials, formal APPROVED reviews are now the primary path (not a workaround) - pr-review-pool-supervisor.md: passes reviewer credentials to dispatched reviewers - pr-merge-pool-supervisor.md: updated approval detection to recognize reviewer account as primary approver - product-builder.md: passes reviewer creds when launching review pool - shared/credential_security.md: added FORGEJO_REVIEWER_PAT and FORGEJO_REVIEWER_USERNAME to required credentials	2026-04-10 20:23:43 +00:00
clever-agent	4029a3331a	docs(spec): fourteenth pass adding subagent specialization principle ... - Added Section 6.0: Subagent Specialization Principle (centralize, dont duplicate) - Updated Section 5.3.4: interval calculation now ATM-centralized - Updated Section 5.4: 11 operations (added CYCLE_ANNOUNCEMENT_REVIEW) - Added v1.29.0 revision entry: 17 duplicated blocks removed	2026-04-10 16:15:44 -04:00
clever-agent	cd49434c0d	fix(agents): centralize interval calculation in ATM, eliminate duplication ... Per Subagent Specialization Principle: removed 17 duplicated rolling average calculation blocks from all supervisors. The ATM now handles interval calculation internally via --sleep-interval-default parameter. - automation-tracking-manager.md: added sleep_interval_default to CREATE_TRACKING_ISSUE, added CYCLE_ANNOUNCEMENT_REVIEW operation (#11) - All 17 supervisor agents: replaced 7-line interval calc with --sleep-interval-default param - shared/tracking_discovery_guide.md: updated to reference ATM-handled interval	2026-04-10 16:15:44 -04:00