test(langgraph): capture content_not_contains edge condition regression (#95) #99
No reviewers
Labels
No labels
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs Feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
CI Blocker
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Automation
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Refactor
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Blocks
Reference
cleveragents/cleveractors-core!99
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "tdd/m1-pure-graph-content-not-contains"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Adds a failing-first Behave regression test proving issue #95:
PureLangGraph._evaluate_edge_condition()has no branch forcontent_not_contains(Actor Configuration Standard §5.4), so it falls into the "unknown condition type" catch-all and always returnsTrue. When a classifier node has siblingcontent_contains/content_not_containsedges (the classic if/else idiom), both fire whenever the configured text is present, so_get_next_nodes()returns two targets instead of one.The scenario is tagged
@tdd_issue,@tdd_issue_95, and@tdd_expected_failper the TDD issue-capture workflow.No runtime hook previously existed in this repo to make
@tdd_expected_failactually invert pass/fail, so this PR also addsTddExpectedFailPolicy(features/tdd_expected_fail.py) wired intofeatures/environment.py'safter_step/after_scenariohooks:@tdd_expected_failscenario'sAssertionErrorfailures to passing (proving the bug is still present).AssertionErrorfailures.The actual fix lands separately on
bugfix/m1-pure-graph-content-not-containsper issue #95.Test plan
nox -s lintgreennox -s format -- --checkgreennox -s typecheckgreennox -s security_scangreennox -s dead_codegreennox -s unit_testsgreen (2790 scenarios, including the new tagged scenario) — confirms the hook inverts the expected AssertionError failurenox -s coverage_report— 96.8% (>= 96.5% threshold)Closes #96
content_not_contains, causing mutually-exclusive branch conditions to both fireLGTM ✅ — self-approving per project policy (1 approval required, self-approval permitted). All quality gates verified locally:
nox -s lint,nox -s format -- --check,nox -s typecheck,nox -s security_scan,nox -s dead_code,nox -s unit_tests(2790/2790 scenarios green, including the new@tdd_issue_95/@tdd_expected_failregression scenario), andnox -s coverage_report(96.8%, above the 96.5% threshold) all pass. Forgejo CI is currently broken with systemic infra failures (install-step failures across unrelated commits/branches) unrelated to this change — proceeding per maintainer confirmation to disregard CI for this session.PR Review: !99 (Ticket #96)
Verdict: Request Changes
The TDD test and
@tdd_expected_failhook are well-implemented and follow the TDD tagging workflow, but the scenario asserts behavior that the current Actor Configuration Standard explicitly says pure-graph edges should not implement. Merging a test that contradicts the authoritative spec creates a spec/code inconsistency onmaster. This needs to be resolved before the PR can land.Critical Issues
None
Major Issues
features/pure_graph_content_not_contains.feature, lines 18–23content_not_containsedge evaluates based on message content. However,docs/index.md§5.4 listscontent_not_containsas honored only by "Stream router, conditional nodes, bridge router" — pure-graph edges are not included. §5.4.1 further states that for pure-graph edge conditions an unknown type defaults toTrue(with a warning), and §5.4.2 says a condition declared in a subsystem that does not honor it must follow that subsystem's default behavior. Under the current spec, the existing code insrc/cleveractors/langgraph/pure_graph.pyis therefore spec-compliant, and the test is asserting behavior the spec explicitly says should not exist.docs/index.md§5.4 to add pure-graph edges to the "Honored By" column forcontent_not_contains(and ensurecontent_containsalready covers them). Do this either in this PR or in the companionbugfix/m1-pure-graph-content-not-containsPR with a clear cross-reference. Until the spec is updated, the TDD test documents behavior that contradicts the source of truth.Minor Issues
features/tdd_expected_fail.py, lines 40–42 and 75–76CONTRIBUTING.md§1216–1223 states that the test-environment hooks enforce: (a) any scenario with@tdd_issue_<N>must also have@tdd_issue, and (b) any scenario with@tdd_expected_failmust also have@tdd_issueand at least one@tdd_issue_<N>. The current policy only checks for@tdd_expected_failand never validates the presence of the companion tags. A malformed tag combination would silently invert failures instead of failing CI with a clear tagging error.on_scenario(or a dedicated helper) that raisesAssertionErrorwhen@tdd_expected_failis present but@tdd_issueor@tdd_issue_<N>is missing.Nits
Unused context attribute
features/steps/pure_graph_content_not_contains_steps.py, line 22context.results = {}is assigned in the background step but never read. It can be removed or replaced with a comment explaining the reset.Import placement
features/environment.py, line 12from features.tdd_expected_fail import TddExpectedFailPolicyimport sits between the module docstring and thesys.setrecursionlimitcomment. Moving the comment above the imports (or grouping the import with the other imports) would improve readability.Summary
This PR correctly implements the TDD issue-capture mechanics: the scenario is tagged
@tdd_issue @tdd_issue_95 @tdd_expected_fail, it signals the bug viaAssertionError, and the newTddExpectedFailPolicyhook inverts expected failures while guarding against stale tags. The hook logic itself is sound (verified that raising inafter_scenariofails the scenario and thatcontext.scenariois available inafter_step).The blocker is specification alignment. Because the current spec says
content_not_containsis not honored by pure-graph edges, this regression test captures behavior that the spec currently defines as unsupported. Fix the spec first (or concurrently), then this PR is good to merge. The tag-validation gap in the hook should also be addressed so the new infrastructure fully enforces the TDD rules documented inCONTRIBUTING.md.(Note: CI failures are acknowledged as broken infrastructure and are excluded from this review per maintainer direction.)
7dab61942889fab68bf789fab68bf7d219e6943fPR Review: !99 (Ticket #96)
Verdict: Approve
The TDD-capture PR correctly implements the failing-first regression test for issue #95 and the
@tdd_expected_failinversion hook. The code is well-structured, type-safe, and aligned with the TDD workflow inCONTRIBUTING.md. All previously raised spec-compliance and tag-validation concerns have been addressed. No critical or major code issues remain.Critical Issues
None
Major Issues
None
Minor Issues
features/tdd_expected_fail.pyAssertionError), malformed tag-combination validation, and the rule that non-AssertionErrorfailures are never inverted. Only the happy-path inversion is exercised by the new@tdd_issue_95scenario. If any of these edge-case branches regress, the TDD workflow could silently break.AssertionErrorfailure in an@tdd_expected_failscenario still fails, and that removing@tdd_expected_failafter the bug is fixed causes the stale-tag assertion to fire.Nits
None
Summary
This PR delivers exactly what issue #96 asks for: a failing-first Behave regression test proving the
content_not_containsgap inPureLangGraph._evaluate_edge_condition(), with the correct@tdd_issue @tdd_issue_95 @tdd_expected_failtagging, and a reusableTddExpectedFailPolicyhook wired intofeatures/environment.py. The step definitions are fully implemented and signal the bug only viaAssertionError. The spec alignment work indocs/index.mdand the ADR resolve the earlier reviewer concern that the test contradicted the standard.The only remaining concern is the lack of direct tests for the hook's guard rails. Because those guard rails are what make the TDD workflow trustworthy, they merit a few targeted scenarios. Once those are added (here or as a fast-follow infrastructure test), this is ready to merge.
d219e6943f95f4ee1db395f4ee1db346bff0d451