test(langgraph): capture content_not_contains edge condition regression (#95) #99
Merged
CoreRasurae
merged 1 commits from 2026-08-04 10:07:51 +00:00
tdd/m1-pure-graph-content-not-contains into master
Labels
Clear labels
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Blocks
Reference: cleveragents/cleveractors-core#99
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "tdd/m1-pure-graph-content-not-contains"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Adds a failing-first Behave regression test proving issue #95:
PureLangGraph._evaluate_edge_condition()has no branch forcontent_not_contains(Actor Configuration Standard §5.4), so it falls into the "unknown condition type" catch-all and always returnsTrue. When a classifier node has siblingcontent_contains/content_not_containsedges (the classic if/else idiom), both fire whenever the configured text is present, so_get_next_nodes()returns two targets instead of one.The scenario is tagged
@tdd_issue,@tdd_issue_95, and@tdd_expected_failper the TDD issue-capture workflow.No runtime hook previously existed in this repo to make
@tdd_expected_failactually invert pass/fail, so this PR also addsTddExpectedFailPolicy(features/tdd_expected_fail.py) wired intofeatures/environment.py'safter_step/after_scenariohooks:@tdd_expected_failscenario'sAssertionErrorfailures to passing (proving the bug is still present).AssertionErrorfailures.The actual fix lands separately on
bugfix/m1-pure-graph-content-not-containsper issue #95.Test plan
nox -s lintgreennox -s format -- --checkgreennox -s typecheckgreennox -s security_scangreennox -s dead_codegreennox -s unit_testsgreen (2790 scenarios, including the new tagged scenario) — confirms the hook inverts the expected AssertionError failurenox -s coverage_report— 96.8% (>= 96.5% threshold)Closes #96
LGTM ✅ — self-approving per project policy (1 approval required, self-approval permitted). All quality gates verified locally:
nox -s lint,nox -s format -- --check,nox -s typecheck,nox -s security_scan,nox -s dead_code,nox -s unit_tests(2790/2790 scenarios green, including the new@tdd_issue_95/@tdd_expected_failregression scenario), andnox -s coverage_report(96.8%, above the 96.5% threshold) all pass. Forgejo CI is currently broken with systemic infra failures (install-step failures across unrelated commits/branches) unrelated to this change — proceeding per maintainer confirmation to disregard CI for this session.PR Review: !99 (Ticket #96)
Verdict: Request Changes
The TDD test and
@tdd_expected_failhook are well-implemented and follow the TDD tagging workflow, but the scenario asserts behavior that the current Actor Configuration Standard explicitly says pure-graph edges should not implement. Merging a test that contradicts the authoritative spec creates a spec/code inconsistency onmaster. This needs to be resolved before the PR can land.Critical Issues
None
Major Issues
features/pure_graph_content_not_contains.feature, lines 18–23content_not_containsedge evaluates based on message content. However,docs/index.md§5.4 listscontent_not_containsas honored only by "Stream router, conditional nodes, bridge router" — pure-graph edges are not included. §5.4.1 further states that for pure-graph edge conditions an unknown type defaults toTrue(with a warning), and §5.4.2 says a condition declared in a subsystem that does not honor it must follow that subsystem's default behavior. Under the current spec, the existing code insrc/cleveractors/langgraph/pure_graph.pyis therefore spec-compliant, and the test is asserting behavior the spec explicitly says should not exist.docs/index.md§5.4 to add pure-graph edges to the "Honored By" column forcontent_not_contains(and ensurecontent_containsalready covers them). Do this either in this PR or in the companionbugfix/m1-pure-graph-content-not-containsPR with a clear cross-reference. Until the spec is updated, the TDD test documents behavior that contradicts the source of truth.Minor Issues
features/tdd_expected_fail.py, lines 40–42 and 75–76CONTRIBUTING.md§1216–1223 states that the test-environment hooks enforce: (a) any scenario with@tdd_issue_<N>must also have@tdd_issue, and (b) any scenario with@tdd_expected_failmust also have@tdd_issueand at least one@tdd_issue_<N>. The current policy only checks for@tdd_expected_failand never validates the presence of the companion tags. A malformed tag combination would silently invert failures instead of failing CI with a clear tagging error.on_scenario(or a dedicated helper) that raisesAssertionErrorwhen@tdd_expected_failis present but@tdd_issueor@tdd_issue_<N>is missing.Nits
Unused context attribute
features/steps/pure_graph_content_not_contains_steps.py, line 22context.results = {}is assigned in the background step but never read. It can be removed or replaced with a comment explaining the reset.Import placement
features/environment.py, line 12from features.tdd_expected_fail import TddExpectedFailPolicyimport sits between the module docstring and thesys.setrecursionlimitcomment. Moving the comment above the imports (or grouping the import with the other imports) would improve readability.Summary
This PR correctly implements the TDD issue-capture mechanics: the scenario is tagged
@tdd_issue @tdd_issue_95 @tdd_expected_fail, it signals the bug viaAssertionError, and the newTddExpectedFailPolicyhook inverts expected failures while guarding against stale tags. The hook logic itself is sound (verified that raising inafter_scenariofails the scenario and thatcontext.scenariois available inafter_step).The blocker is specification alignment. Because the current spec says
content_not_containsis not honored by pure-graph edges, this regression test captures behavior that the spec currently defines as unsupported. Fix the spec first (or concurrently), then this PR is good to merge. The tag-validation gap in the hook should also be addressed so the new infrastructure fully enforces the TDD rules documented inCONTRIBUTING.md.(Note: CI failures are acknowledged as broken infrastructure and are excluded from this review per maintainer direction.)
7dab619428to89fab68bf789fab68bf7tod219e6943fPR Review: !99 (Ticket #96)
Verdict: Approve
The TDD-capture PR correctly implements the failing-first regression test for issue #95 and the
@tdd_expected_failinversion hook. The code is well-structured, type-safe, and aligned with the TDD workflow inCONTRIBUTING.md. All previously raised spec-compliance and tag-validation concerns have been addressed. No critical or major code issues remain.Critical Issues
None
Major Issues
None
Minor Issues
features/tdd_expected_fail.pyAssertionError), malformed tag-combination validation, and the rule that non-AssertionErrorfailures are never inverted. Only the happy-path inversion is exercised by the new@tdd_issue_95scenario. If any of these edge-case branches regress, the TDD workflow could silently break.AssertionErrorfailure in an@tdd_expected_failscenario still fails, and that removing@tdd_expected_failafter the bug is fixed causes the stale-tag assertion to fire.Nits
None
Summary
This PR delivers exactly what issue #96 asks for: a failing-first Behave regression test proving the
content_not_containsgap inPureLangGraph._evaluate_edge_condition(), with the correct@tdd_issue @tdd_issue_95 @tdd_expected_failtagging, and a reusableTddExpectedFailPolicyhook wired intofeatures/environment.py. The step definitions are fully implemented and signal the bug only viaAssertionError. The spec alignment work indocs/index.mdand the ADR resolve the earlier reviewer concern that the test contradicted the standard.The only remaining concern is the lack of direct tests for the hook's guard rails. Because those guard rails are what make the TDD workflow trustworthy, they merit a few targeted scenarios. Once those are added (here or as a fast-follow infrastructure test), this is ready to merge.
d219e6943fto95f4ee1db395f4ee1db3to46bff0d451