fix(langgraph): implement content_not_contains condition in pure graph edge evaluator #100

Merged

CoreRasurae merged 1 commits from bugfix/m1-pure-graph-content-not-contains into master 2026-08-04 12:39:02 +00:00

Conversation 3 Commits 1 Files Changed 6

+217 -3

CoreRasurae commented 2026-08-04 07:29:34 +00:00

Member

Copy Link

Copy Source

Summary

PureLangGraph._evaluate_edge_condition() had no branch for content_not_contains (Actor Configuration Standard §5.4), so it fell into the "unknown condition type" catch-all and always returned True. A classifier node with sibling content_contains/content_not_contains edges (the classic if/else idiom) would traverse both edges whenever the configured text was present, instead of the single edge intended.

• Adds a content_not_contains branch mirroring the existing correct implementations in nodes.py, bridge.py, and reactive/stream_router.py.
• Removes @tdd_expected_fail from the issue #95 regression scenario (kept @tdd_issue/@tdd_issue_95 forever as a regression guard), and adds direct content_not_contains true/false coverage plus a sibling-edge scenario for the text-absent direction.
• Adds a Robot integration test (robot/pure_graph_sibling_edges.robot, robot/PureGraphLib.py) that executes a real two-branch pure graph end-to-end and asserts exactly one branch node runs, for both directions.
• CHANGELOG entry added under ### Fixed.

Branch note: this branch is stacked on tdd/m1-pure-graph-content-not-contains (PR #99, not yet merged) since the fix builds on that regression test. Once #99 merges to master, this PR's diff will automatically shrink to just the bugfix commit.

Test plan

• nox -s lint green
• nox -s format -- --check green
• nox -s typecheck green
• nox -s security_scan green
• nox -s dead_code green
• nox -s unit_tests green — 2795/2795 scenarios, including the now-unconditionally-passing @tdd_issue_95 scenario and 5 new direct coverage scenarios
• nox -s integration_tests green — 321/321 tests, including the 2 new Robot tests
• nox -s coverage_report — 96.8% (>= 96.5% threshold)
• nox -s benchmark_regression -- --quick — flags 1.1-1.56x noise in unrelated registry/cache/local_store/token_budget benchmarks (none touch pure_graph.py; no benchmark exists for this code path); consistent with known --quick-mode measurement noise on a loaded runner, not a real regression from this change

Note: Forgejo CI is currently down (confirmed by maintainer) — all checks above were run and verified locally.

Closes #95

## Summary `PureLangGraph._evaluate_edge_condition()` had no branch for `content_not_contains` (Actor Configuration Standard §5.4), so it fell into the "unknown condition type" catch-all and always returned `True`. A classifier node with sibling `content_contains`/`content_not_contains` edges (the classic if/else idiom) would traverse both edges whenever the configured text was present, instead of the single edge intended. - Adds a `content_not_contains` branch mirroring the existing correct implementations in `nodes.py`, `bridge.py`, and `reactive/stream_router.py`. - Removes `@tdd_expected_fail` from the issue #95 regression scenario (kept `@tdd_issue`/`@tdd_issue_95` forever as a regression guard), and adds direct `content_not_contains` true/false coverage plus a sibling-edge scenario for the text-absent direction. - Adds a Robot integration test (`robot/pure_graph_sibling_edges.robot`, `robot/PureGraphLib.py`) that executes a real two-branch pure graph end-to-end and asserts exactly one branch node runs, for both directions. - CHANGELOG entry added under `### Fixed`. **Branch note:** this branch is stacked on `tdd/m1-pure-graph-content-not-contains` (PR #99, not yet merged) since the fix builds on that regression test. Once #99 merges to `master`, this PR's diff will automatically shrink to just the bugfix commit. ## Test plan - [x] `nox -s lint` green - [x] `nox -s format -- --check` green - [x] `nox -s typecheck` green - [x] `nox -s security_scan` green - [x] `nox -s dead_code` green - [x] `nox -s unit_tests` green — 2795/2795 scenarios, including the now-unconditionally-passing `@tdd_issue_95` scenario and 5 new direct coverage scenarios - [x] `nox -s integration_tests` green — 321/321 tests, including the 2 new Robot tests - [x] `nox -s coverage_report` — 96.8% (>= 96.5% threshold) - [x] `nox -s benchmark_regression -- --quick` — flags 1.1-1.56x noise in unrelated registry/cache/local_store/token_budget benchmarks (none touch `pure_graph.py`; no benchmark exists for this code path); consistent with known `--quick`-mode measurement noise on a loaded runner, not a real regression from this change Note: Forgejo CI is currently down (confirmed by maintainer) — all checks above were run and verified locally. Closes #95

CoreRasurae added this to the v2.1.0 milestone 2026-08-04 07:29:34 +00:00

CoreRasurae added a new dependency 2026-08-04 07:31:05 +00:00

#95 Pure-graph edge evaluator does not implement `content_not_contains`, causing mutually-exclusive branch conditions to both fire

CoreRasurae added the

Type

Bug

label 2026-08-04 07:31:07 +00:00

CoreRasurae commented 2026-08-04 07:31:32 +00:00

Author

Member

Copy Link

Copy Source

LGTM ✅ — self-approving per project policy (1 approval required, self-approval permitted). All quality gates verified locally: nox -s lint, nox -s format -- --check, nox -s typecheck, nox -s security_scan, nox -s dead_code, nox -s unit_tests (2795/2795 scenarios), nox -s integration_tests (321/321 tests), and nox -s coverage_report (96.8%) all pass. nox -s benchmark_regression -- --quick flags noise in unrelated registry/cache/local_store/token_budget benchmarks (not touched by this change, and no benchmark exists for pure_graph.py) — consistent with known --quick-mode measurement noise. Forgejo CI is currently down per maintainer confirmation; not blocking on it this session. Leaving merge to a maintainer/human.

LGTM ✅ — self-approving per project policy (1 approval required, self-approval permitted). All quality gates verified locally: `nox -s lint`, `nox -s format -- --check`, `nox -s typecheck`, `nox -s security_scan`, `nox -s dead_code`, `nox -s unit_tests` (2795/2795 scenarios), `nox -s integration_tests` (321/321 tests), and `nox -s coverage_report` (96.8%) all pass. `nox -s benchmark_regression -- --quick` flags noise in unrelated registry/cache/local_store/token_budget benchmarks (not touched by this change, and no benchmark exists for pure_graph.py) — consistent with known --quick-mode measurement noise. Forgejo CI is currently down per maintainer confirmation; not blocking on it this session. Leaving merge to a maintainer/human.

CoreRasurae force-pushed bugfix/m1-pure-graph-content-not-contains from 3f57ecf9fe to 7511c62c8c 2026-08-04 10:20:35 +00:00 Compare

hurui200320 approved these changes 2026-08-04 10:53:37 +00:00

hurui200320 left a comment

Member

Copy Link

Copy Source

PR Review: !100 (Ticket #95)

Verdict: Approve

The fix correctly implements content_not_contains in PureLangGraph._evaluate_edge_condition() per Actor Configuration Standard §5.4, and the test matrix (direct evaluator unit-style Behave scenarios plus an end-to-end Robot integration test) provides strong regression coverage for the mutually-exclusive sibling-edge idiom described in #95. I reviewed the changed code, related implementations (nodes.py, bridge.py, reactive/stream_router.py), the spec, and project quality gates. No critical or major correctness issues were found. The remaining items are minor process/documentation gaps.

Critical Issues

None

Major Issues

None

Minor Issues

1. Coverage falls below the documented 97% threshold.

   • The PR reports 96.8% coverage. CONTRIBUTING.md (and the coverage_report docstring) state that the enforced merge gate is 97%, while noxfile.py currently sets COVERAGE_THRESHOLD = 96.5. Because the actual tooling passes, this is not a blocker for this PR, but the project should reconcile the documented threshold with the configured threshold, or add coverage to reach 97%.

2. The non-string/non-dict fallback in content_not_contains is not exercised by tests.

   • File: src/cleveractors/langgraph/pure_graph.py, line 2054 (return True).
   • The implementation mirrors content_contains's existing fallback pattern, but the True branch for unknown message shapes has no direct test. Adding a Behave scenario (e.g., message is a list/object that does not contain the text) would improve confidence that the fallback behaves consistently with the semantics documented in the code comment.

Nits

1. Step-definition docstring is stale.
   • File: features/steps/pure_graph_content_not_contains_steps.py, lines 1–6.
   • The module docstring says it exercises PureLangGraph._get_next_nodes(), but the new scenarios also call _evaluate_edge_condition() directly. Update the docstring to mention both entry points.

Summary

This is a focused, well-tested bugfix. The core change is minimal and symmetric with the existing content_contains branch, and the added Behave/Robot scenarios directly cover the regression from #95. The only items worth addressing are minor: aligning the documented vs. configured coverage threshold and adding coverage for the final fallback branch. I am approving so the fix can land; the minor items can be handled in a fast-follow or as part of the ongoing coverage work.

## PR Review: !100 (Ticket #95) ### Verdict: Approve The fix correctly implements `content_not_contains` in `PureLangGraph._evaluate_edge_condition()` per Actor Configuration Standard §5.4, and the test matrix (direct evaluator unit-style Behave scenarios plus an end-to-end Robot integration test) provides strong regression coverage for the mutually-exclusive sibling-edge idiom described in #95. I reviewed the changed code, related implementations (`nodes.py`, `bridge.py`, `reactive/stream_router.py`), the spec, and project quality gates. No critical or major correctness issues were found. The remaining items are minor process/documentation gaps. ### Critical Issues None ### Major Issues None ### Minor Issues 1. **Coverage falls below the documented 97% threshold.** - The PR reports 96.8% coverage. `CONTRIBUTING.md` (and the `coverage_report` docstring) state that the enforced merge gate is **97%**, while `noxfile.py` currently sets `COVERAGE_THRESHOLD = 96.5`. Because the actual tooling passes, this is not a blocker for this PR, but the project should reconcile the documented threshold with the configured threshold, or add coverage to reach 97%. 2. **The non-string/non-dict fallback in `content_not_contains` is not exercised by tests.** - File: `src/cleveractors/langgraph/pure_graph.py`, line 2054 (`return True`). - The implementation mirrors `content_contains`'s existing fallback pattern, but the `True` branch for unknown message shapes has no direct test. Adding a Behave scenario (e.g., message is a list/object that does not contain the text) would improve confidence that the fallback behaves consistently with the semantics documented in the code comment. ### Nits 1. **Step-definition docstring is stale.** - File: `features/steps/pure_graph_content_not_contains_steps.py`, lines 1–6. - The module docstring says it exercises `PureLangGraph._get_next_nodes()`, but the new scenarios also call `_evaluate_edge_condition()` directly. Update the docstring to mention both entry points. ### Summary This is a focused, well-tested bugfix. The core change is minimal and symmetric with the existing `content_contains` branch, and the added Behave/Robot scenarios directly cover the regression from #95. The only items worth addressing are minor: aligning the documented vs. configured coverage threshold and adding coverage for the final fallback branch. I am approving so the fix can land; the minor items can be handled in a fast-follow or as part of the ongoing coverage work.

CoreRasurae commented 2026-08-04 11:31:49 +00:00

Author

Member

Copy Link

Copy Source

Minor issues number 1, is not relevant, we have a noxfile threshold at 96.5% while having a 97% in the specification, but the 97% is the rounded value, which is also obtainable from a 96.5% real coverage.

Minor issues number 1, is not relevant, we have a noxfile threshold at 96.5% while having a 97% in the specification, but the 97% is the rounded value, which is also obtainable from a 96.5% real coverage.

CoreRasurae added 1 commit 2026-08-04 12:15:48 +00:00

fix(langgraph): implement content_not_contains condition in pure graph edge evaluator ... a0c2119cc3

PureLangGraph._evaluate_edge_condition() had no branch for
content_not_contains (Actor Configuration Standard §5.4), so it fell
into the "unknown condition type" catch-all and always returned True.
A classifier node with sibling content_contains/content_not_contains
edges (the classic if/else idiom) would traverse both edges whenever
the configured text was present, instead of the single edge intended.

Adds a content_not_contains branch mirroring the existing correct
implementations in nodes.py, bridge.py, and reactive/stream_router.py:
true when the text is absent from the (stringified) message content,
for both string and dict messages; falls back to True (not found, so
not contained) for any other message shape, matching the sibling
content_not_contains implementations' "absent" fallback rather than
content_contains's False fallback.

Removes @tdd_expected_fail from the issue #95 regression scenario now
that the fix makes it pass unconditionally, and adds direct
content_not_contains true/false coverage plus a sibling-edge scenario
for the text-absent direction. Adds a Robot integration test
(robot/pure_graph_sibling_edges.robot, robot/PureGraphLib.py) that
executes a real two-branch pure graph end-to-end and asserts exactly
one branch node runs for each direction.

Per rui.hu's PR #100 review: adds direct coverage of the non-string/
non-dict message fallback branch (previously untested) and updates the
step-definitions module docstring, which was stale about which method
the scenarios exercise. The reviewer's coverage-threshold-reconciliation
note is a pre-existing, project-wide config/doc mismatch out of scope
for this issue and was already addressed in review comments.

Verified locally (Forgejo CI is currently down): nox -s lint, format
--check, typecheck, unit_tests (2905/2905 scenarios) are green, and the
new fallback scenario covers the previously-uncovered line in
pure_graph.py.

ISSUES CLOSED: #95
Refs: #96

CoreRasurae force-pushed bugfix/m1-pure-graph-content-not-contains from 7511c62c8c to a0c2119cc3 2026-08-04 12:15:48 +00:00 Compare

CoreRasurae referenced this issue from a commit 2026-08-04 12:15:48 +00:00

fix(langgraph): implement content_not_contains condition in pure graph edge evaluator

CoreRasurae merged commit a0c2119cc3 into master 2026-08-04 12:39:02 +00:00

CoreRasurae deleted branch bugfix/m1-pure-graph-content-not-contains 2026-08-04 12:39:14 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

hurui200320

Labels

Clear labels

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

auto/claimed-implementer

Currently being processed by an implementer worker.

auto/claimed-merge

Currently being processed by the merge driver.

auto/claimed-reviewer

Currently being processed by a reviewer worker.

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

auto/needs-implementer

Failing CI needs implementer attention.

auto/postmortem

Documenting a driver incident or rollback.

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

Points

1

1 man-hours worth of work for an expert with no learning curve.

Points

13

13 man-hours worth of work for an expert with no learning curve.

Points

2

2 man-hours worth of work for an expert with no learning curve.

Points

21

21 man-hours worth of work for an expert with no learning curve.

Points

3

3 man-hours worth of work for an expert with no learning curve.

Points

34

34 man-hours worth of work for an expert with no learning curve.

Points

5

5 man-hours worth of work for an expert with no learning curve.

Points

55

55 man-hours worth of work for an expert with no learning curve.

Points

8

8 man-hours worth of work for an expert with no learning curve.

Points

88

88 man-hours worth of work for an expert with no learning curve.

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

State

Duplicate

A ticket that represents the same content as an existing ticket.

State

In Progress

A ticket that is actively being developed.

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

Type

Automation

Any edits or discussion about the AI automated coding system.

Type

Bug

Something that doesnt work as intended.

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

Type

Documentation

An error or improvement needed in the documentation.

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

Type

Feature

Some new functionality not present.

Type

Legendary

A type of Epic which will contain other Epics.

Type

Refactor

A code change that restructures existing code without changing its external behavior.

Type

Support

Someone needs help using the project.

Type

Task

A generic task that doesnt fit into the other type categories.

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No Label

Type

Bug

Milestone

No items

No Milestone v2.1.0

Projects

Clear projects

No project

Assignees

Clear assignees

aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Blocks

#95 Pure-graph edge evaluator does not implement `content_not_contains`, causing mutually-exclusive branch conditions to both fire

cleveragents/cleveractors-core

Reference: cleveragents/cleveractors-core#100