fix(ci): make benchmark_regression job fast and correctly fail on regressions #87

Merged

CoreRasurae merged 1 commit from task/m2-quick-benchmark-regression-ci into master 2026-08-03 09:16:21 +00:00

Conversation 2 Commits 1 Files changed 3 +27 -5

CoreRasurae commented 2026-07-31 12:02:45 +00:00

Member

Copy link

Summary

Three compounding issues in the benchmark_regression CI check, found while investigating a 41m13s hang/timeout on PR #85's run (job 205876):

1. ASV calibration overhead: asv continuous ran with no speed-oriented flags, fully calibrating/repeating every one of 138 benchmark runs (69 benchmarks × 2 commits). noxfile.py's benchmark_regression session now forwards *session.posargs to asv continuous (its own default, full-accuracy behavior is unchanged when called without extra args); .gitea/workflows/ci.yml's benchmark job now invokes nox -s benchmark_regression -- --quick, scoping ASV's single-run mode to this informational job only.

2. Packaging bottleneck (surfaced once --quick was applied): asv.conf.json's build/install/uninstall commands used plain python -m build/pip, which silently spent ~11 minutes per run in pip's resolver (uncached, per-commit dependency install with no progress output). Switched to uv build/uv pip install/uv pip uninstall. Since ASV's find_executable only searches each managed venv's own bin/ (not $PATH), added uv to asv's matrix config so it gets pip-installed during venv bootstrap, and pass --python {env_dir}/bin/python explicitly to each command (standalone uv, unlike python -m pip, can't otherwise infer which of asv's several per-commit venvs to target). Also added --force-reinstall to the install command per ASV's own documented rationale.

3. Exit-code / success_codes mismatch: asv continuous returns the boolean worsened as its exit code (0 = no significant regression, 1 = a benchmark measurably worsened past --factor) — there is no exit code 2 in this ASV version. noxfile.py's success_codes=[0, 2] never matched the real "worsened" code, so the session failed unconditionally on any regression signal. Corrected to success_codes=[0], so the session (and CI job step) now fails specifically when ASV reports a real, significant regression — continue-on-error: true on the job is what keeps this from blocking the PR merge, not this success list.

This is a CI/tooling-only change — no business logic, no src/ changes.

Closes #86

Test plan

• python3 -m py_compile noxfile.py
• JSON/YAML validity checks on asv.conf.json / .gitea/workflows/ci.yml
• nox -s lint
• Verified locally end-to-end, repeatedly, with rm -rf .asv/env .asv/results between runs:
  • Completes in ~3-11 minutes (vs. the prior 40+ minute hang/timeout)
  • uv-based build/install/uninstall correctly targets each per-commit venv (no more ModuleNotFoundError)
  • Session correctly reports failed when asv continuous detects a significant regression between the compared commits (confirms the fix doesn't mask real regressions)
• Next CI run on this PR: confirm the benchmark job completes quickly and its pass/fail conclusion matches whether a real regression was detected

🤖 Generated with Claude Code

## Summary Three compounding issues in the `benchmark_regression` CI check, found while investigating a 41m13s hang/timeout on PR #85's run (job 205876): 1. **ASV calibration overhead**: `asv continuous` ran with no speed-oriented flags, fully calibrating/repeating every one of 138 benchmark runs (69 benchmarks × 2 commits). `noxfile.py`'s `benchmark_regression` session now forwards `*session.posargs` to `asv continuous` (its own default, full-accuracy behavior is unchanged when called without extra args); `.gitea/workflows/ci.yml`'s `benchmark` job now invokes `nox -s benchmark_regression -- --quick`, scoping ASV's single-run mode to this informational job only. 2. **Packaging bottleneck (surfaced once --quick was applied)**: `asv.conf.json`'s build/install/uninstall commands used plain `python -m build`/`pip`, which silently spent ~11 minutes per run in pip's resolver (uncached, per-commit dependency install with no progress output). Switched to `uv build`/`uv pip install`/`uv pip uninstall`. Since ASV's `find_executable` only searches each managed venv's own `bin/` (not `$PATH`), added `uv` to asv's `matrix` config so it gets pip-installed during venv bootstrap, and pass `--python {env_dir}/bin/python` explicitly to each command (standalone `uv`, unlike `python -m pip`, can't otherwise infer which of asv's several per-commit venvs to target). Also added `--force-reinstall` to the install command per ASV's own documented rationale. 3. **Exit-code / success_codes mismatch**: `asv continuous` returns the boolean `worsened` as its exit code (0 = no significant regression, 1 = a benchmark measurably worsened past `--factor`) — there is no exit code 2 in this ASV version. `noxfile.py`'s `success_codes=[0, 2]` never matched the real "worsened" code, so the session failed unconditionally on *any* regression signal. Corrected to `success_codes=[0]`, so the session (and CI job step) now fails specifically when ASV reports a real, significant regression — `continue-on-error: true` on the job is what keeps this from blocking the PR merge, not this success list. This is a CI/tooling-only change — no business logic, no `src/` changes. Closes #86 ## Test plan - [x] `python3 -m py_compile noxfile.py` - [x] JSON/YAML validity checks on `asv.conf.json` / `.gitea/workflows/ci.yml` - [x] `nox -s lint` - [x] Verified locally end-to-end, repeatedly, with `rm -rf .asv/env .asv/results` between runs: - Completes in ~3-11 minutes (vs. the prior 40+ minute hang/timeout) - `uv`-based build/install/uninstall correctly targets each per-commit venv (no more `ModuleNotFoundError`) - Session correctly reports `failed` when `asv continuous` detects a significant regression between the compared commits (confirms the fix doesn't mask real regressions) - [ ] Next CI run on this PR: confirm the `benchmark` job completes quickly and its pass/fail conclusion matches whether a real regression was detected 🤖 Generated with [Claude Code](https://claude.com/claude-code)

CoreRasurae added this to the v2.1.0 milestone 2026-07-31 12:02:45 +00:00

CoreRasurae added the

Type

Task

label 2026-07-31 12:02:46 +00:00

CoreRasurae added a new dependency 2026-07-31 12:24:31 +00:00

#86 fix(ci): benchmark_regression job intermittently hangs/times out and never signals real regressions correctly

CoreRasurae added 1 commit 2026-07-31 14:59:28 +00:00

fix(ci): make benchmark_regression job fast and correctly fail on regressions ... a1fd36932f

Three compounding issues in the benchmark_regression CI check, found
while investigating a 41m13s hang/timeout on PR #85's run (job 205876):

1. `asv continuous` ran with no speed-oriented flags, fully calibrating
   and repeating every one of 138 benchmark runs (69 benchmarks x 2
   commits). Per-benchmark ASV overhead (calibration + repeat + process
   averaging) cost 20-90s of wall clock per benchmark, dwarfing the
   actual measured microsecond-to-millisecond costs. `noxfile.py`'s
   `benchmark_regression` session now forwards *session.posargs to
   `asv continuous`, so its own default (full, accurate) behavior is
   unchanged when called without extra args; `.gitea/workflows/ci.yml`'s
   `benchmark` job now invokes `nox -s benchmark_regression -- --quick`,
   scoping ASV's single-run mode to this informational job only.

2. With --quick applied, a new bottleneck surfaced: asv.conf.json's
   build/install/uninstall commands used plain `python -m build`/`pip`,
   which silently spent ~11 minutes per run in pip's resolver (build
   isolation + a full, uncached dependency install per compared commit,
   no progress output during backtracking). Switched to `uv build`/
   `uv pip install`/`uv pip uninstall`. `uv` isn't installed inside each
   ASV-managed virtualenv by default (asv's find_executable only
   searches that venv's own bin/, not $PATH), so added `uv` to asv's
   `matrix` config to have it pip-installed during venv bootstrap
   (already-fast for a single small package), and pass `--python
   {env_dir}/bin/python` explicitly to each command since standalone
   `uv` (unlike `python -m pip`) has no unambiguous way to infer which
   of asv's several per-commit venvs to target otherwise. Also added
   `--force-reinstall` to the install command per asv's own documented
   rationale (compared commits may share the same package version).

3. `asv continuous` returns the boolean `worsened` as its process exit
   code (0 = no significant regression, 1 = a benchmark measurably
   worsened past --factor) -- there is no exit code 2 in this asv
   version. `noxfile.py`'s `success_codes=[0, 2]` therefore never
   actually matched the real "worsened" code, silently making this
   session fail on *any* regression signal regardless of significance.
   Corrected to `success_codes=[0]`, so the session (and CI job step)
   now fails specifically when asv reports a real, significant
   regression -- the CI job's existing `continue-on-error: true` is
   what keeps this from blocking the PR, not this success list.

Verified locally end-to-end (rm -rf .asv/env .asv/results between
runs): completes in ~3-11 minutes (vs. the prior 40+ minute
hang/timeout), and the session now correctly reports "failed" when
asv detects a significant regression between the compared commits.

ISSUES CLOSED: #86

CoreRasurae force-pushed task/m2-quick-benchmark-regression-ci from cc31d40aed to a1fd36932f 2026-07-31 14:59:28 +00:00 Compare

CoreRasurae changed title from fix(ci): scope asv --quick to the benchmark_regression CI job only to fix(ci): make benchmark_regression job fast and correctly fail on regressions 2026-07-31 14:59:50 +00:00

hurui200320 approved these changes 2026-08-01 07:21:21 +00:00

hurui200320 left a comment

Copy link

PR Review: !87 (Ticket #86)

Verdict: Approve

This PR correctly addresses the three compounding issues described in #86: ASV calibration overhead, pip packaging bottleneck, and the incorrect success_codes list. The changes are well-scoped, limited to CI/tooling files, and thoroughly documented with inline comments. No business logic is modified, so coverage and functional behavior are unaffected.

Critical Issues

None

Major Issues

None

Minor Issues

None

Nits

None

Summary

• noxfile.py: Forwarding *session.posargs to asv continuous is the right way to let CI opt into --quick without changing the session's default behavior. Correcting success_codes from [0, 2] to [0] aligns the session with ASV's actual exit-code semantics (0 = no regression, 1 = regression detected), so the job now fails specifically on real regressions rather than unconditionally.
• asv.conf.json: Switching build/install/uninstall commands to uv with explicit --python {env_dir}/bin/python and bootstrapping uv via the matrix config solves the per-commit pip resolver bottleneck while correctly targeting each ASV-managed venv.
• .gitea/workflows/ci.yml: Passing --quick only in the CI benchmark job keeps the fast, informational regression check scoped appropriately; the existing continue-on-error: true on the job remains the non-blocking mechanism.

The commit is atomic, the message matches the issue metadata, and the body explains the rationale clearly. This is ready to merge.

## PR Review: !87 (Ticket #86) ### Verdict: Approve This PR correctly addresses the three compounding issues described in #86: ASV calibration overhead, pip packaging bottleneck, and the incorrect `success_codes` list. The changes are well-scoped, limited to CI/tooling files, and thoroughly documented with inline comments. No business logic is modified, so coverage and functional behavior are unaffected. ### Critical Issues None ### Major Issues None ### Minor Issues None ### Nits None ### Summary - `noxfile.py`: Forwarding `*session.posargs` to `asv continuous` is the right way to let CI opt into `--quick` without changing the session's default behavior. Correcting `success_codes` from `[0, 2]` to `[0]` aligns the session with ASV's actual exit-code semantics (0 = no regression, 1 = regression detected), so the job now fails specifically on real regressions rather than unconditionally. - `asv.conf.json`: Switching build/install/uninstall commands to `uv` with explicit `--python {env_dir}/bin/python` and bootstrapping `uv` via the `matrix` config solves the per-commit pip resolver bottleneck while correctly targeting each ASV-managed venv. - `.gitea/workflows/ci.yml`: Passing `--quick` only in the CI benchmark job keeps the fast, informational regression check scoped appropriately; the existing `continue-on-error: true` on the job remains the non-blocking mechanism. The commit is atomic, the message matches the issue metadata, and the body explains the rationale clearly. This is ready to merge.

hurui200320 approved these changes 2026-08-02 13:22:03 +00:00

CoreRasurae merged commit a1fd36932f into master 2026-08-03 09:16:21 +00:00

CoreRasurae deleted branch task/m2-quick-benchmark-regression-ci 2026-08-03 09:16:27 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

hurui200320

Labels

Clear labels

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

v2.1.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#86 fix(ci): benchmark_regression job intermittently hangs/times out and never signals real regressions correctly

cleveragents/cleveractors-core

Reference

cleveragents/cleveractors-core!87

No description provided.