Various bug fixes #121

Merged

hurui200320 merged 9 commits from feat/118 into develop 2026-01-19 11:38:21 +00:00

Conversation 1 Commits 9 Files changed 22 +977 -2235

hurui200320 commented 2026-01-19 09:14:49 +00:00

Member

Copy link

This PR implemented ticket clevermicro/amq-adapter-python#118 and clevermicro/amq-adapter-python#120 with the following changes

• Tweak pipeline to remove -dev suffix when publishing lib for develop branch
• Remove RabbitMQ streaming (already removed in java clevermicro/amq-adapter-java#116 )
• Introduced a more robust way of handling typing resolution
• Remove FileHandler as a base class, merging it into S3FileHandler as it's the only implementation
• Fix the S3 object key generation, now it will follow the design doc and ensure the object keys are unique
• Allow env var S3_BUCKET to have s3:// prefix

After merge, this PR will build and release python library 0.3.1

This PR implemented ticket clevermicro/amq-adapter-python#118 and clevermicro/amq-adapter-python#120 with the following changes + Tweak pipeline to remove `-dev` suffix when publishing lib for develop branch + Remove RabbitMQ streaming (already removed in java clevermicro/amq-adapter-java#116 ) + Introduced a more robust way of handling typing resolution + Remove FileHandler as a base class, merging it into S3FileHandler as it's the only implementation + Fix the S3 object key generation, now it will follow the design doc and ensure the object keys are unique + Allow env var `S3_BUCKET` to have `s3://` prefix After merge, this PR will build and release python library 0.3.1

hurui200320 self-assigned this 2026-01-19 09:14:49 +00:00

hurui200320 added 8 commits 2026-01-19 09:14:49 +00:00

fix: use type to decide if the param is UploadFile, instead of using name 62de943fe9

feat: remove s3:// prefix for the S3_BUCKET env var 16038b8685

ci: tweak version handling on release library daaebc3cf2

test: fix broken test script ... 76df9d6d76

ISSUE CLOSED: clevermicro/amq-adapter-python#118

refactor: remove usage for StreamingFileHandler before removing it eb2c2e041e

feat: remove RabbitMQ streaming ee15353193

refactor: remove FileHandler base class, clean up code 9dabcf31c0

fix: generate s3 object key based on design fe51224dcc

hurui200320 added a new dependency 2026-01-19 09:16:59 +00:00

#118 Fix type handling to support union type

hurui200320 added a new dependency 2026-01-19 09:17:16 +00:00

#120 Remove RabbitMQ streaming impl and fix S3 object key generation

hurui200320 added 1 commit 2026-01-19 09:19:33 +00:00

ci: update cleverswarm-lite image tag for latest release f6694e097e

hurui200320 requested review from CoreRasurae 2026-01-19 09:56:15 +00:00

CoreRasurae approved these changes 2026-01-19 11:35:30 +00:00

CoreRasurae left a comment

Member

Copy link

I think it looks good, i'm approving the changes

I think it looks good, i'm approving the changes

hurui200320 merged commit c931d5e5b5 into develop 2026-01-19 11:38:21 +00:00

hurui200320 referenced this pull request from a commit 2026-01-19 11:38:21 +00:00

Various bug fixes (#121)

hurui200320 deleted branch feat/118 2026-01-19 11:38:21 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

CoreRasurae

Labels

Clear labels

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

hurui200320

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#118 Fix type handling to support union type

clevermicro/amq-adapter-python

#120 Remove RabbitMQ streaming impl and fix S3 object key generation

clevermicro/amq-adapter-python

Reference

clevermicro/amq-adapter-python!121

No description provided.