feat/#89: Implement File streaming protocol to support all addressing modes both on send and receive. Phase 1 that passes unit tests. #113
No reviewers
Labels
No labels
Blocked
Bounty
$100
Bounty
$1000
Bounty
$10000
Bounty
$20
Bounty
$2000
Bounty
$250
Bounty
$50
Bounty
$500
Bounty
$5000
Bounty
$750
MoSCoW
Could have
MoSCoW
Must have
MoSCoW
Should have
Needs feedback
Points
1
Points
13
Points
2
Points
21
Points
3
Points
34
Points
5
Points
55
Points
8
Points
88
Priority
Backlog
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
State
Completed
State
Duplicate
State
In Progress
State
In Review
State
Paused
State
Unverified
State
Verified
State
Wont Do
Type
Bug
Type
Discussion
Type
Documentation
Type
Epic
Type
Feature
Type
Legendary
Type
Support
Type
Task
Type
Testing
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
clevermicro/amq-adapter-python!113
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/89"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
For multipart upload, we defined
req-infoas the stream name for request itself, this allow us to send out a multi-stream message that contain both the request info and the uploaded content. However, the reverse path doesn't have similar things define. With the newly added pre-signed url feature, when downloading a file, instead of streaming the actual content, the microservice can give a presign url and the amq router will stream the content of that url to client.This ticket should first define a similar thing for response, like
resp-infoas the stream name to send an json object about the metadata of the downloaded file, then point to the actual file stream. When sending out the response, the caller should use addressing mode 4 to send the presign url, so the amq library can automatically use it and turns into an inputstream for amq router to use.WIP: feat/#89: Implement File streaming protocol to support all addressing modes both on send and receive. Phase 1 that passes unit tests.to feat/#89: Implement File streaming protocol to support all addressing modes both on send and receive. Phase 1 that passes unit tests.76874dd1f0d84a9f9fdeThe code looks good to me. Although the pipeline is failing, but Stan and I have already figured out the issue and fix for the pipeline. It's outside of this repo (the fix should be impl in cleverswarm-lite), so I will approve this PR. After Stan fixed the issue and update the pipeline and everything passes, this PR should be good to go.