feat: Initial version of CleverRDFLib #4

Merged
CoreRasurae merged 2 commits from feat/initial_version-#1 into master 2026-01-14 21:42:25 +00:00
Member

ISSUES CLOSED: #1

ISSUES CLOSED: #1
CoreRasurae 2025-12-09 13:24:08 +00:00
CoreRasurae force-pushed feat/initial_version-#1 from ef1b7b1760 to cbee72c78d
Some checks failed
CI / typecheck (pull_request) Failing after 4s
CI / lint (pull_request) Failing after 4s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.11) (pull_request) Failing after 4s
CI / behave (3.13) (pull_request) Failing after 3s
CI / build (pull_request) Failing after 6s
2025-12-09 13:30:30 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from cbee72c78d
Some checks failed
CI / typecheck (pull_request) Failing after 4s
CI / lint (pull_request) Failing after 4s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.11) (pull_request) Failing after 4s
CI / behave (3.13) (pull_request) Failing after 3s
CI / build (pull_request) Failing after 6s
to 33165418a1
Some checks failed
CI / lint (pull_request) Failing after 4s
CI / typecheck (pull_request) Failing after 4s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 4s
CI / build (pull_request) Failing after 4s
2025-12-09 13:34:15 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 33165418a1
Some checks failed
CI / lint (pull_request) Failing after 4s
CI / typecheck (pull_request) Failing after 4s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 4s
CI / build (pull_request) Failing after 4s
to b412bde0e9
Some checks failed
ci.yml / feat: Initial version of CleverRDFLib (push) Failing after 0s
ci.yml / feat: Initial version of CleverRDFLib (pull_request) Failing after 0s
2025-12-09 13:38:38 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from b412bde0e9
Some checks failed
ci.yml / feat: Initial version of CleverRDFLib (push) Failing after 0s
ci.yml / feat: Initial version of CleverRDFLib (pull_request) Failing after 0s
to 1be110eca9
Some checks failed
CI / lint (pull_request) Failing after 54s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 3s
CI / typecheck (pull_request) Failing after 1m27s
CI / build (pull_request) Failing after 55s
2025-12-09 13:41:35 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 1be110eca9
Some checks failed
CI / lint (pull_request) Failing after 54s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 3s
CI / typecheck (pull_request) Failing after 1m27s
CI / build (pull_request) Failing after 55s
to 969c51e3bf
Some checks failed
CI / lint (pull_request) Failing after 53s
CI / typecheck (pull_request) Failing after 5s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 2s
CI / behave (3.13) (pull_request) Failing after 3s
CI / build (pull_request) Failing after 55s
2025-12-09 13:44:14 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 969c51e3bf
Some checks failed
CI / lint (pull_request) Failing after 53s
CI / typecheck (pull_request) Failing after 5s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 2s
CI / behave (3.13) (pull_request) Failing after 3s
CI / build (pull_request) Failing after 55s
to 59650c3a0a
Some checks failed
CI / lint (pull_request) Failing after 3s
CI / typecheck (pull_request) Failing after 3s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 2s
CI / build (pull_request) Failing after 3s
2025-12-09 13:46:29 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 59650c3a0a
Some checks failed
CI / build (pull_request) Failing after 3s
CI / lint (pull_request) Failing after 3s
CI / typecheck (pull_request) Failing after 3s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 2s
to 23355ad08a
Some checks failed
CI / lint (pull_request) Failing after 1m29s
CI / typecheck (pull_request) Failing after 2s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 2s
CI / build (pull_request) Failing after 3s
2025-12-09 13:47:13 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 23355ad08a
Some checks failed
CI / lint (pull_request) Failing after 1m29s
CI / typecheck (pull_request) Failing after 2s
CI / behave (3.11) (pull_request) Failing after 3s
CI / behave (3.12) (pull_request) Failing after 3s
CI / behave (3.13) (pull_request) Failing after 2s
CI / build (pull_request) Failing after 3s
to c210884198
Some checks failed
CI / typecheck (pull_request) Failing after 5s
CI / lint (pull_request) Failing after 1m27s
CI / behave (3.11) (pull_request) Failing after 1m30s
CI / behave (3.12) (pull_request) Failing after 1m27s
CI / behave (3.13) (pull_request) Failing after 1m30s
CI / build (pull_request) Failing after 1m58s
2025-12-09 13:48:16 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from c210884198
Some checks failed
CI / typecheck (pull_request) Failing after 5s
CI / lint (pull_request) Failing after 1m27s
CI / behave (3.11) (pull_request) Failing after 1m30s
CI / behave (3.12) (pull_request) Failing after 1m27s
CI / behave (3.13) (pull_request) Failing after 1m30s
CI / build (pull_request) Failing after 1m58s
to cf2d24a160
Some checks failed
CI / lint (pull_request) Failing after 1m29s
CI / typecheck (pull_request) Failing after 1m26s
CI / behave (3.11) (pull_request) Failing after 1m26s
CI / behave (3.12) (pull_request) Failing after 1m28s
CI / behave (3.13) (pull_request) Failing after 1m29s
CI / build (pull_request) Failing after 1m28s
2025-12-09 13:49:11 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from cf2d24a160
Some checks failed
CI / lint (pull_request) Failing after 1m29s
CI / typecheck (pull_request) Failing after 1m26s
CI / behave (3.11) (pull_request) Failing after 1m26s
CI / behave (3.12) (pull_request) Failing after 1m28s
CI / behave (3.13) (pull_request) Failing after 1m29s
CI / build (pull_request) Failing after 1m28s
to e5517bc3ed
Some checks failed
CI / lint (pull_request) Failing after 1m58s
CI / typecheck (pull_request) Failing after 2m1s
CI / behave (3.11) (pull_request) Failing after 1m29s
CI / behave (3.12) (pull_request) Failing after 1m37s
CI / behave (3.13) (pull_request) Failing after 1m28s
CI / build (pull_request) Failing after 1m34s
2025-12-09 14:18:46 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from e5517bc3ed
Some checks failed
CI / lint (pull_request) Failing after 1m58s
CI / typecheck (pull_request) Failing after 2m1s
CI / behave (3.11) (pull_request) Failing after 1m29s
CI / behave (3.12) (pull_request) Failing after 1m37s
CI / behave (3.13) (pull_request) Failing after 1m28s
CI / build (pull_request) Failing after 1m34s
to cc86e5a93e
Some checks failed
CI / lint (pull_request) Failing after 1m26s
CI / typecheck (pull_request) Successful in 1m33s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m43s
CI / behave (3.13) (pull_request) Successful in 1m39s
CI / build (pull_request) Failing after 1m29s
2025-12-09 14:23:54 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from cc86e5a93e
Some checks failed
CI / lint (pull_request) Failing after 1m26s
CI / typecheck (pull_request) Successful in 1m33s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m43s
CI / behave (3.13) (pull_request) Successful in 1m39s
CI / build (pull_request) Failing after 1m29s
to 20c909ba0d
Some checks failed
CI / lint (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m41s
CI / build (pull_request) Failing after 1m26s
CI / behave (3.13) (pull_request) Successful in 1m43s
2025-12-09 15:01:04 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 20c909ba0d
Some checks failed
CI / lint (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m41s
CI / build (pull_request) Failing after 1m26s
CI / behave (3.13) (pull_request) Successful in 1m43s
to b0ac316167
Some checks failed
CI / lint (pull_request) Successful in 1m26s
CI / typecheck (pull_request) Successful in 2m4s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / behave (3.13) (pull_request) Successful in 1m39s
CI / build (pull_request) Failing after 1m28s
2025-12-09 15:03:37 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from b0ac316167
Some checks failed
CI / lint (pull_request) Successful in 1m26s
CI / typecheck (pull_request) Successful in 2m4s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / behave (3.13) (pull_request) Successful in 1m39s
CI / build (pull_request) Failing after 1m28s
to 477bd4e72c
Some checks failed
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 2m2s
CI / behave (3.11) (pull_request) Successful in 2m43s
CI / behave (3.12) (pull_request) Successful in 2m45s
CI / behave (3.13) (pull_request) Successful in 1m43s
CI / build (pull_request) Failing after 1m29s
2025-12-09 16:07:27 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 477bd4e72c
Some checks failed
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 2m2s
CI / behave (3.11) (pull_request) Successful in 2m43s
CI / behave (3.12) (pull_request) Successful in 2m45s
CI / behave (3.13) (pull_request) Successful in 1m43s
CI / build (pull_request) Failing after 1m29s
to eeadefa5b6
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m30s
CI / behave (3.11) (pull_request) Successful in 2m19s
CI / behave (3.12) (pull_request) Successful in 2m15s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 1m39s
2025-12-09 18:17:52 +00:00
Compare
aditya approved these changes 2025-12-10 14:45:26 +00:00
CoreRasurae force-pushed feat/initial_version-#1 from eeadefa5b6
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m30s
CI / behave (3.11) (pull_request) Successful in 2m19s
CI / behave (3.12) (pull_request) Successful in 2m15s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 1m39s
to 6536ff2a44
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m33s
CI / behave (3.11) (pull_request) Successful in 3m34s
CI / behave (3.12) (pull_request) Successful in 1m43s
CI / behave (3.13) (pull_request) Successful in 2m42s
CI / build (pull_request) Successful in 1m29s
2025-12-10 21:56:33 +00:00
Compare
@ -0,0 +155,4 @@
result = self.check_consistency()
return result.unsatisfiable_classes
def _check_unsatisfiable_classes(self) -> list[ConsistencyIssue]:
Member

just a question let's suppose that we have such classes that are equivalent or subclass of owl:nothing does this get flagged as error or just something to be reported

just a question let's suppose that we have such classes that are equivalent or subclass of `owl:nothing` does this get flagged as error or just something to be reported
Author
Member

this won't cause a failure, the application will resume processing but the potential issue gets reported

this won't cause a failure, the application will resume processing but the potential issue gets reported
CoreRasurae force-pushed feat/initial_version-#1 from 6536ff2a44
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m33s
CI / behave (3.11) (pull_request) Successful in 3m34s
CI / behave (3.12) (pull_request) Successful in 1m43s
CI / behave (3.13) (pull_request) Successful in 2m42s
CI / build (pull_request) Successful in 1m29s
to f3cfc42aaf
All checks were successful
CI / typecheck (pull_request) Successful in 1m32s
CI / lint (pull_request) Successful in 1m59s
CI / behave (3.11) (pull_request) Successful in 1m48s
CI / behave (3.12) (pull_request) Successful in 1m50s
CI / behave (3.13) (pull_request) Successful in 1m37s
CI / build (pull_request) Successful in 2m0s
2025-12-11 20:07:22 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from f3cfc42aaf
All checks were successful
CI / typecheck (pull_request) Successful in 1m32s
CI / lint (pull_request) Successful in 1m59s
CI / behave (3.11) (pull_request) Successful in 1m48s
CI / behave (3.12) (pull_request) Successful in 1m50s
CI / behave (3.13) (pull_request) Successful in 1m37s
CI / build (pull_request) Successful in 2m0s
to 4f33602813
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / behave (3.12) (pull_request) Successful in 1m45s
CI / behave (3.13) (pull_request) Successful in 2m12s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / build (pull_request) Successful in 1m27s
2025-12-11 21:01:09 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 4f33602813
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / behave (3.12) (pull_request) Successful in 1m45s
CI / behave (3.13) (pull_request) Successful in 2m12s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / build (pull_request) Successful in 1m27s
to 8b679b515b
All checks were successful
CI / lint (pull_request) Successful in 1m26s
CI / typecheck (pull_request) Successful in 1m29s
CI / behave (3.11) (pull_request) Successful in 1m37s
CI / behave (3.12) (pull_request) Successful in 1m59s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 2m8s
2025-12-11 21:28:17 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 8b679b515b
All checks were successful
CI / lint (pull_request) Successful in 1m26s
CI / typecheck (pull_request) Successful in 1m29s
CI / behave (3.11) (pull_request) Successful in 1m37s
CI / behave (3.12) (pull_request) Successful in 1m59s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 2m8s
to 235beb3727
Some checks failed
CI / lint (pull_request) Failing after 1m27s
CI / typecheck (pull_request) Successful in 2m0s
CI / behave (3.11) (pull_request) Successful in 1m44s
CI / behave (3.12) (pull_request) Successful in 2m10s
CI / behave (3.13) (pull_request) Successful in 1m47s
CI / build (pull_request) Successful in 1m29s
2025-12-12 22:27:38 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 235beb3727
Some checks failed
CI / lint (pull_request) Failing after 1m27s
CI / typecheck (pull_request) Successful in 2m0s
CI / behave (3.11) (pull_request) Successful in 1m44s
CI / behave (3.12) (pull_request) Successful in 2m10s
CI / behave (3.13) (pull_request) Successful in 1m47s
CI / build (pull_request) Successful in 1m29s
to 65f26ec777
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 2m32s
CI / behave (3.13) (pull_request) Successful in 2m22s
CI / build (pull_request) Successful in 1m29s
2025-12-13 22:11:24 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 65f26ec777
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m40s
CI / behave (3.12) (pull_request) Successful in 2m32s
CI / behave (3.13) (pull_request) Successful in 2m22s
CI / build (pull_request) Successful in 1m29s
to f93a81262c
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m30s
CI / behave (3.12) (pull_request) Successful in 1m41s
CI / behave (3.11) (pull_request) Successful in 2m10s
CI / behave (3.13) (pull_request) Successful in 1m50s
CI / build (pull_request) Successful in 1m30s
2025-12-15 18:07:20 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from f93a81262c
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m30s
CI / behave (3.12) (pull_request) Successful in 1m41s
CI / behave (3.11) (pull_request) Successful in 2m10s
CI / behave (3.13) (pull_request) Successful in 1m50s
CI / build (pull_request) Successful in 1m30s
to a43e7325d9
All checks were successful
CI / lint (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 1m31s
CI / behave (3.12) (pull_request) Successful in 1m38s
CI / behave (3.11) (pull_request) Successful in 1m47s
CI / build (pull_request) Successful in 1m30s
CI / behave (3.13) (pull_request) Successful in 1m39s
2025-12-15 20:51:50 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from a43e7325d9
All checks were successful
CI / lint (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 1m31s
CI / behave (3.12) (pull_request) Successful in 1m38s
CI / behave (3.11) (pull_request) Successful in 1m47s
CI / build (pull_request) Successful in 1m30s
CI / behave (3.13) (pull_request) Successful in 1m39s
to 742817f65b
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m29s
CI / behave (3.11) (pull_request) Successful in 1m42s
CI / behave (3.12) (pull_request) Successful in 1m40s
CI / build (pull_request) Successful in 1m28s
CI / behave (3.13) (pull_request) Successful in 1m41s
2025-12-15 22:32:38 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 742817f65b
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m29s
CI / behave (3.11) (pull_request) Successful in 1m42s
CI / behave (3.12) (pull_request) Successful in 1m40s
CI / build (pull_request) Successful in 1m28s
CI / behave (3.13) (pull_request) Successful in 1m41s
to 8196a35afc
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / behave (3.12) (pull_request) Successful in 2m22s
CI / behave (3.13) (pull_request) Successful in 1m46s
CI / build (pull_request) Successful in 1m28s
2025-12-15 22:59:41 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 8196a35afc
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m32s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / behave (3.12) (pull_request) Successful in 2m22s
CI / behave (3.13) (pull_request) Successful in 1m46s
CI / build (pull_request) Successful in 1m28s
to 4f20a23eae
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m31s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / build (pull_request) Successful in 1m27s
CI / behave (3.13) (pull_request) Successful in 1m36s
2025-12-16 21:54:01 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 4f20a23eae
All checks were successful
CI / lint (pull_request) Successful in 1m29s
CI / typecheck (pull_request) Successful in 1m31s
CI / behave (3.11) (pull_request) Successful in 1m38s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / build (pull_request) Successful in 1m27s
CI / behave (3.13) (pull_request) Successful in 1m36s
to 868084dc6b
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / typecheck (pull_request) Successful in 1m27s
CI / behave (3.12) (pull_request) Successful in 1m38s
CI / behave (3.11) (pull_request) Successful in 2m8s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 2m38s
2025-12-16 22:12:14 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 868084dc6b
All checks were successful
CI / lint (pull_request) Successful in 1m27s
CI / typecheck (pull_request) Successful in 1m27s
CI / behave (3.12) (pull_request) Successful in 1m38s
CI / behave (3.11) (pull_request) Successful in 2m8s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 2m38s
to 9fc69a1f56
All checks were successful
CI / typecheck (pull_request) Successful in 1m30s
CI / lint (pull_request) Successful in 1m30s
CI / behave (3.11) (pull_request) Successful in 1m37s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / build (pull_request) Successful in 1m28s
CI / behave (3.13) (pull_request) Successful in 1m34s
2025-12-18 13:51:07 +00:00
Compare
CoreRasurae force-pushed feat/initial_version-#1 from 9fc69a1f56
All checks were successful
CI / typecheck (pull_request) Successful in 1m30s
CI / lint (pull_request) Successful in 1m30s
CI / behave (3.11) (pull_request) Successful in 1m37s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / build (pull_request) Successful in 1m28s
CI / behave (3.13) (pull_request) Successful in 1m34s
to e828acf175
All checks were successful
CI / lint (push) Successful in 1m32s
CI / typecheck (push) Successful in 1m38s
CI / lint (pull_request) Successful in 1m30s
CI / typecheck (pull_request) Successful in 1m30s
CI / behave (3.11) (pull_request) Successful in 1m39s
CI / behave (3.12) (pull_request) Successful in 1m39s
CI / build (pull_request) Successful in 1m29s
CI / behave (3.13) (pull_request) Successful in 1m39s
CI / behave (3.11) (push) Successful in 1m39s
CI / behave (3.12) (push) Successful in 1m41s
CI / behave (3.13) (push) Successful in 1m37s
CI / build (push) Successful in 1m30s
2025-12-19 22:26:49 +00:00
Compare
@ -0,0 +112,4 @@
found = False
for prop_node in context.properties_list:
if prop_node.iri == iri:
found = True
Member

For this and functions like this, any(prop_node.iri == iri for prop_node in context.properties_list) might be a clearer way to express what you're doing

For this and functions like this, `any(prop_node.iri == iri for prop_node in context.properties_list)` might be a clearer way to express what you're doing
Author
Member

yes, i have been applying that for the production code, but the tests have more relaxed rules. Personally i think that condensing the logic in a single line does not make it any more readable, even if it written in a slightly different manner. i believe most people are used to those kinds of for loops like even if not from other languages.

yes, i have been applying that for the production code, but the tests have more relaxed rules. Personally i think that condensing the logic in a single line does not make it any more readable, even if it written in a slightly different manner. i believe most people are used to those kinds of for loops like even if not from other languages.
@ -0,0 +35,4 @@
# Note: We cannot use a context manager here because addinfourl takes ownership
# of the file object and will close it when the response is closed.
try:
file_obj = open(local_path, "rb") # noqa: SIM115
Member

If you're suppressing the warning, I think it's wise to finally: file_obj.close() after your exception handling

If you're suppressing the warning, I think it's wise to `finally: file_obj.close()` after your exception handling
@ -0,0 +271,4 @@
def _find_ontology_iris(self) -> set[URIRef]:
"""
Find all ontology IRI declarations in the graph.
Member

Where this is used in exctract_ontology_iri, the calling code just accesses the first ontology. Should an exception be raised, or a warning logged, when this returns a multi-element list? Otherwise you are silently dropping any subsequent IRIs.

Where this is used in exctract_ontology_iri, the calling code just accesses the first ontology. Should an exception be raised, or a warning logged, when this returns a multi-element list? Otherwise you are silently dropping any subsequent IRIs.
@ -0,0 +375,4 @@
# Check for direct circular references
for class_a, superclasses in subclass_relations.items():
for class_b in superclasses:
if class_b in subclass_relations and class_a in subclass_relations[class_b]:
Member

This looks like it catches non-trivial cycles, but it doesn't look like it catches trivial ones. E.g. you'd catch "a Foo is a subclass of Bar, and a Bar is a subclass of Foo" but I don't think it'd catch "a Foo is a subclass of Foo". Not 100% sure but I think that's the case.

This looks like it catches non-trivial cycles, but it doesn't look like it catches trivial ones. E.g. you'd catch "a Foo is a subclass of Bar, and a Bar is a subclass of Foo" but I don't think it'd catch "a Foo is a subclass of Foo". Not 100% sure but I think that's the case.
@ -0,0 +61,4 @@
Returns:
Tuple of (uri, depth) for the next item to process
"""
return self._stack.pop()
Member

In the breadth-first search you had to cast the equivalent call. If I were maintaining this, I'd find helpful a comment explaining why it's necessary there but not here.

In the breadth-first search you had to cast the equivalent call. If I were maintaining this, I'd find helpful a comment explaining why it's necessary there but not here.
khird approved these changes 2026-01-14 21:04:32 +00:00
khird left a comment
Member

Looks good. A handful of questions but given that I'm not an expert in the problem space, I'm approving anyway and just ask that you consider them.

Looks good. A handful of questions but given that I'm not an expert in the problem space, I'm approving anyway and just ask that you consider them.
Sign in to join this conversation.
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleverlibre/CleverRDFlib!4
No description provided.