unit-tests-google-tracker-sheet #48

Open
aditya wants to merge 2 commits from unit-tests-google-tracker-sheet into auto-excel-update
Member

This branch contains the behave bdd tests for google_sheets_tracker.py and also for upload_all_datasets.py

This branch contains the behave bdd tests for google_sheets_tracker.py and also for upload_all_datasets.py
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Please enter the commit message for your changes. Lines starting
upload_all_datasets.2.py
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Co-authored-by: aider (openrouter/anthropic/claude-sonnet-4) <aider@aider.chat>
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Co-authored-by: aider (openrouter/openai/o3-mini-high) <aider@aider.chat>
Reviewed-on: #41
Reviewed-by: Brent Edwards <brent.edwards@cleverthis.com>
Reviewed-on: #42
Reviewed-by: Brent Edwards <brent.edwards@cleverthis.com>
aditya changed target branch from master to auto-excel-update 2026-01-12 13:07:25 +00:00
aditya changed title from WIP: unit-tests-google-tracker-sheet to unit-tests-google-tracker-sheet 2026-01-12 13:07:48 +00:00
CoreRasurae left a comment
First-time contributor

I have one comment that i think might be relevant to address.

I have one comment that i think might be relevant to address.
@ -0,0 +143,4 @@
context.auth_result = context.tracker.authenticate()
except Exception as e:
context.auth_result = False
context.error = str(e)
First-time contributor

I am not sure if i am okay with steps like these that are so generic... i mean, it can silently hide the true failure reason as it tries so many different things depending on the context. i think this step should be split into more fine grained steps that do well defined things and easier to manually check when something fails.

I am not sure if i am okay with steps like these that are so generic... i mean, it can silently hide the true failure reason as it tries so many different things depending on the context. i think this step should be split into more fine grained steps that do well defined things and easier to manually check when something fails.
Author
Member

fixed !

fixed !
aditya force-pushed unit-tests-google-tracker-sheet from 6af250fc78 to 7f6594d99a 2026-01-19 11:57:35 +00:00 Compare
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin unit-tests-google-tracker-sheet:unit-tests-google-tracker-sheet
git switch unit-tests-google-tracker-sheet

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch auto-excel-update
git merge --no-ff unit-tests-google-tracker-sheet
git switch unit-tests-google-tracker-sheet
git rebase auto-excel-update
git switch auto-excel-update
git merge --ff-only unit-tests-google-tracker-sheet
git switch unit-tests-google-tracker-sheet
git rebase auto-excel-update
git switch auto-excel-update
git merge --no-ff unit-tests-google-tracker-sheet
git switch auto-excel-update
git merge --squash unit-tests-google-tracker-sheet
git switch auto-excel-update
git merge --ff-only unit-tests-google-tracker-sheet
git switch auto-excel-update
git merge unit-tests-google-tracker-sheet
git push origin auto-excel-update
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleverdatasets/dataset-uploader!48
No description provided.